[PATCH v2 1/1] net/mana: enable 32 bit build for mana driver

Wei Hu weh at microsoft.com
Tue Sep 19 04:44:43 CEST 2023


> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at amd.com>
> Sent: Tuesday, September 19, 2023 1:41 AM
> To: Wei Hu <weh at microsoft.com>; dev at dpdk.org; Long Li
> <longli at microsoft.com>
> Cc: stable at dpdk.org; Kevin Traynor <ktraynor at redhat.com>; Luca Boccassi
> <bluca at debian.org>
> Subject: Re: [PATCH v2 1/1] net/mana: enable 32 bit build for mana driver
> 
> On 9/13/2023 1:23 PM, Wei Hu wrote:
> > Enable 32 bit build on x86 Linux. Fixed build warnings and errors when
> > building in 32 bit.
> >
> > Cc: stable at dpdk.org
> >
> 
> This is not a fix, but adding 32bit support to the driver, so not sure about
> backporting. cc'ed Kevin & Luca for guidance.
> 
> I will drop the tag while merging unles otherwise suggested by LTS
> maintainers.

Hi Ferruh,

We have a customer who needs it to be on 22.11.x. That is why I put "Cc: stable at dpdk.org" in it.

> 
> > Signed-off-by: Wei Hu <weh at microsoft.com>
> >
> 
> Hi Wei,
> 
> Patch looks good, but it basically fixes the format specifiers that will cause
> build error for 32 bit.
> 
> Is there any other change required to make driver functional for 32 bit, or does
> it become functional with this change?
> And if it does can you please confirm explicityly that driver tested on
> 32 bit with this patch?

Another patch, " net/mana: add 32 bit short doorbell", is required to make mana fully
functional  with 32 bit applications. This patch is to fix some build time errors and warnings
when build in 32 bit.  These patches can be independently built and they are addressing
two different issues. So, I put them into two independent patches. 

I have tested it on 32 bit applications. They can run with this patch. Just mana would not
work as the applications still use 64 bit long door bells, which do not work for 32 bit apps.

Thanks,
Wei


More information about the stable mailing list