[PATCH] net/fm10k: fix cleanup during init failure

Patrick Robb probb at iol.unh.edu
Fri Apr 5 16:32:11 CEST 2024


Recheck-request: iol-intel-Functional

I see it's applied but I just want to clean up the record - checking
for lab infra failure

On Thu, Apr 4, 2024 at 6:39 AM Bruce Richardson
<bruce.richardson at intel.com> wrote:
>
> On Thu, Apr 04, 2024 at 11:18:16AM +0100, Bruce Richardson wrote:
> > On Wed, Apr 03, 2024 at 01:55:41PM +0200, Julien Meunier wrote:
> > > Cleanup was not done on this PMD if a error is seen during the init:
> > > - possible memory leak due to a missing free
> > > - interrupt handler was not disabled: if an IRQ is received after the
> > >   init, a SIGSEGV can be seen (private data stored in
> > >   rte_eth_devices[port_id] is pointing to NULL)
> > >
> > > Fixes: a6061d9e7075 ("fm10k: register PF driver")
> > > Fixes: 4c287332c39a ("fm10k: add PF and VF interrupt handling")
> > > Cc: stable at dpdk.org
> > >
> > > Signed-off-by: Julien Meunier <julien.meunier at nokia.com>
> >
> > Changes LGTM
> >
> > Reviewed-by: Bruce Richardson <bruce.richardson at intel.com>
>
> There are CI failures flagged in patchwork, but they appear unrelated to
> this patch itself.
>
> Patch applied to dpdk-next-net-intel.
> Thanks,
> /Bruce


More information about the stable mailing list