[PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h
Stephen Hemminger
stephen at networkplumber.org
Sun Apr 7 19:04:46 CEST 2024
On Sat, 6 Apr 2024 19:30:38 -0600
Ashish Sadanandan <ashish.sadanandan at gmail.com> wrote:
> On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon <thomas at monjalon.net> wrote:
>
> > 02/04/2024 18:03, Ashish Sadanandan:
> > > Hi everyone,
> > > I've made the updates as suggested. Could someone please review the
> > latest
> > > patchset? Not sure if I followed the new patchset instructions correctly,
> > > I've always had trouble with that part.
> >
> > I remember we were discussing about aligning all files.
> > I was waiting for a patch applying the rule we discussed.
> >
> > I missed the part where people were volunteering me for additional work :)
>
> The consensus seems to be that the extern "C" directives should only be in
> public headers, not private ones. Can you please tell me if there's an easy
> way to get a list of public headers?
The issue for private headers that Tyler mentioned is that MS has private
DPDK PMD's that are written in C++. Not sure if this needs to be considered
or supported.
More information about the stable
mailing list