patch 'net/nfp: fix getting firmware VNIC version' has been queued to stable release 23.11.1

Xueming Li xuemingl at nvidia.com
Sat Apr 13 14:49:21 CEST 2024


Hi,

FYI, your patch has been queued to stable release 23.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/15/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=bec3117648637d45e894bde55adea7c2be1a9851

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From bec3117648637d45e894bde55adea7c2be1a9851 Mon Sep 17 00:00:00 2001
From: Qin Ke <qin.ke at corigine.com>
Date: Mon, 11 Mar 2024 09:54:14 +0800
Subject: [PATCH] net/nfp: fix getting firmware VNIC version
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit e72d6053a945b71348f5874cca6cd0be89eed8e0 ]

When getting firmware VNIC version, the logic for representor
ports and other ports is inverse, fix it.

Fixes: c4de52eca76c ("net/nfp: remove redundancy for representor port")

Signed-off-by: Qin Ke <qin.ke at corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he at corigine.com>
Reviewed-by: Long Wu <long.wu at corigine.com>
Reviewed-by: Peng Zhang <peng.zhang at corigine.com>
---
 drivers/net/nfp/nfp_net_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index 46d0e07850..10732f459c 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -2073,7 +2073,7 @@ nfp_net_firmware_version_get(struct rte_eth_dev *dev,
 
 	hw = nfp_net_get_hw(dev);
 
-	if ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0) {
+	if ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) == 0) {
 		snprintf(vnic_version, FW_VER_LEN, "%d.%d.%d.%d",
 			hw->ver.extend, hw->ver.class,
 			hw->ver.major, hw->ver.minor);
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-04-13 20:43:07.484163284 +0800
+++ 0081-net-nfp-fix-getting-firmware-VNIC-version.patch	2024-04-13 20:43:05.037753879 +0800
@@ -1 +1 @@
-From e72d6053a945b71348f5874cca6cd0be89eed8e0 Mon Sep 17 00:00:00 2001
+From bec3117648637d45e894bde55adea7c2be1a9851 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit e72d6053a945b71348f5874cca6cd0be89eed8e0 ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -21 +23 @@
-index 20e628bfd1..bd43925960 100644
+index 46d0e07850..10732f459c 100644
@@ -24 +26 @@
-@@ -2155,7 +2155,7 @@ nfp_net_firmware_version_get(struct rte_eth_dev *dev,
+@@ -2073,7 +2073,7 @@ nfp_net_firmware_version_get(struct rte_eth_dev *dev,
@@ -28,2 +30,2 @@
--	if (rte_eth_dev_is_repr(dev)) {
-+	if (!rte_eth_dev_is_repr(dev)) {
+-	if ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0) {
++	if ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) == 0) {


More information about the stable mailing list