patch 'net/nfp: fix uninitialized variable' has been queued to stable release 23.11.1

Xueming Li xuemingl at nvidia.com
Sat Apr 13 14:49:52 CEST 2024


Hi,

FYI, your patch has been queued to stable release 23.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/15/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=4aa1a6420482dccab127369b01d51d1825fdd71d

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 4aa1a6420482dccab127369b01d51d1825fdd71d Mon Sep 17 00:00:00 2001
From: Chaoyong He <chaoyong.he at corigine.com>
Date: Tue, 19 Mar 2024 16:55:07 +0800
Subject: [PATCH] net/nfp: fix uninitialized variable
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 77cb47144932a52c34f1825d90a8804c2538817b ]

CI found in the logic of 'nfp_aesgcm_iv_update()', the variable
'cfg_iv' may be used uninitialized in some case.

Coverity issue: 415808
Fixes: 7e13f2dc603e ("net/nfp: fix IPsec data endianness")

Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
Reviewed-by: Long Wu <long.wu at corigine.com>
Reviewed-by: Peng Zhang <peng.zhang at corigine.com>
---
 drivers/net/nfp/nfp_ipsec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c
index aebdbb2f48..b10cda570b 100644
--- a/drivers/net/nfp/nfp_ipsec.c
+++ b/drivers/net/nfp/nfp_ipsec.c
@@ -523,7 +523,7 @@ nfp_aesgcm_iv_update(struct ipsec_add_sa *cfg,
 	char *iv_b;
 	char *iv_str;
 	const rte_be32_t *iv_value;
-	uint8_t cfg_iv[NFP_ESP_IV_LENGTH];
+	uint8_t cfg_iv[NFP_ESP_IV_LENGTH] = {};
 
 	iv_str = strdup(iv_string);
 	if (iv_str == NULL) {
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-04-13 20:43:08.445391928 +0800
+++ 0112-net-nfp-fix-uninitialized-variable.patch	2024-04-13 20:43:05.137753749 +0800
@@ -1 +1 @@
-From 77cb47144932a52c34f1825d90a8804c2538817b Mon Sep 17 00:00:00 2001
+From 4aa1a6420482dccab127369b01d51d1825fdd71d Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 77cb47144932a52c34f1825d90a8804c2538817b ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +23 @@
-index 205d1d594c..647bc2bb6d 100644
+index aebdbb2f48..b10cda570b 100644
@@ -24 +26 @@
-@@ -526,7 +526,7 @@ nfp_aesgcm_iv_update(struct ipsec_add_sa *cfg,
+@@ -523,7 +523,7 @@ nfp_aesgcm_iv_update(struct ipsec_add_sa *cfg,


More information about the stable mailing list