[PATCH 22.11] net/mlx5: fix incorrect counter cache dereference

Luca Boccassi bluca at debian.org
Sat Apr 20 00:21:40 CEST 2024


On Fri, 19 Apr 2024 at 14:10, Dariusz Sosnowski <dsosnowski at nvidia.com> wrote:
>
> When counter pool is prepopulated with preallocated counters,
> some counters were preloaded to per-queue caches.
> Per-queue counter cache can be disabled due to a change introduced in
> commit 244dbbf77871 ("net/mlx5: fix flow counter cache starvation").
> Aforementioned preload happened even if counter cache was disabled,
> which caused a segmentation fault on the attempt to access the cache.
>
> This patch adds a missing check for counter cache before preloading.
>
> Fixes: 244dbbf77871 ("net/mlx5: fix flow counter cache starvation")
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
> ---
>  drivers/net/mlx5/mlx5_hws_cnt.c | 38 ++++++++++++++++++---------------
>  1 file changed, 21 insertions(+), 17 deletions(-)

Applied and pushed.

Ali, is this the issue you mentioned on the validation report? If so
is it all green now after this is included?


More information about the stable mailing list