[PATCH 11/11] net/mlx5: remove unneeded device status checking
Dariusz Sosnowski
dsosnowski at nvidia.com
Wed Feb 28 18:00:46 CET 2024
From: Bing Zhao <bingz at nvidia.com>
The flow rule can be inserted even before the device started. The
only exception is for a queue or RSS action.
For the other interfaces of template API, the start status is not
checked. The checking would cause some cache miss or eviction since
the flag locates on some other cache line.
Fixes: f1fecffa88df ("net/mlx5: support Direct Rules action template API")
Cc: stable at dpdk.org
Signed-off-by: Bing Zhao <bingz at nvidia.com>
---
drivers/net/mlx5/mlx5_flow_hw.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c
index 4e4beb4428..8481a9b7f0 100644
--- a/drivers/net/mlx5/mlx5_flow_hw.c
+++ b/drivers/net/mlx5/mlx5_flow_hw.c
@@ -3501,11 +3501,6 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev,
uint32_t res_idx = 0;
int ret;
- if (unlikely((!dev->data->dev_started))) {
- rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
- "Port must be started before enqueueing flow operations");
- return NULL;
- }
flow = mlx5_ipool_malloc(table->flow, &flow_idx);
if (!flow)
goto error;
--
2.39.2
More information about the stable
mailing list