[PATCH v2] net/mlx5: fix jump action validation
Raslan Darawsheh
rasland at nvidia.com
Sun Jan 7 13:35:35 CET 2024
Hi,
> -----Original Message-----
> From: Michael Baum <michaelba at nvidia.com>
> Sent: Monday, November 27, 2023 2:43 PM
> To: dev at dpdk.org
> Cc: Matan Azrad <matan at nvidia.com>; Raslan Darawsheh
> <rasland at nvidia.com>; Slava Ovsiienko <viacheslavo at nvidia.com>; Ori Kam
> <orika at nvidia.com>; Suanming Mou <suanmingm at nvidia.com>;
> dekelp at mellanox.com; stable at dpdk.org
> Subject: [PATCH v2] net/mlx5: fix jump action validation
>
> Currently PMD doesn't allow to jump to the same group in order to
> avoid dead loop. But this also prevent experienced user to create
> flow with less Hops in order to have better performance.
>
> For example, rules in [1] should have better performance then [2].
>
> Furthermore, this protection will not really prevent dead loop, i.e
> [3]. So just remove this protection and user should take the
> responsibility to avoid dead loop.
>
> This patch enables jumping to the same group.
>
> [1]:
> flow create 0 group 1 priority 1 pattern eth / ipv4 / udp / gtp / end
> actions raw_decap / raw_encap / jump group 1 / end
> flow create 0 group 1 priority 0 pattern eth / ipv4 src is 1.0.0.1 / tcp
> / end actions queues index 1 / end
>
> [2]:
> flow create 0 group 1 priority 0 pattern eth / ipv4 / udp / gtp / end
> actions raw_decap / raw_encap / jump group 2 / end
> flow create 0 group 2 priority 0 pattern eth / ipv4 src is 1.0.0.1 / tcp
> / end actions queues index 1 / end
>
> [3]:
> flow create 0 group 1 pattern eth / end actions jump group 2 / end
> flow create 0 group 2 pattern eth / end actions jump group 1 / end
>
> Fixes: f78f747f41d0 ("net/mlx5: allow jump to group lower than current")
> Cc: dekelp at mellanox.com
> Cc: stable at dpdk.org
>
> Signed-off-by: Michael Baum <michaelba at nvidia.com>
> Acked-by: Matan Azrad <matan at nvidia.com>
> ---
>
> V2: change commit message to fix template.
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
More information about the stable
mailing list