[PATCH v2 6/8] common/mlx5: fix calloc parameters

Dariusz Sosnowski dsosnowski at nvidia.com
Fri Jan 26 11:12:23 CET 2024


> -----Original Message-----
> From: Morten Brørup <mb at smartsharesystems.com>
> Sent: Wednesday, January 24, 2024 20:01
> To: Ferruh Yigit <ferruh.yigit at amd.com>; Dariusz Sosnowski
> <dsosnowski at nvidia.com>; Slava Ovsiienko <viacheslavo at nvidia.com>; Ori
> Kam <orika at nvidia.com>; Suanming Mou <suanmingm at nvidia.com>; Matan
> Azrad <matan at nvidia.com>; Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> Cc: dev at dpdk.org; stable at dpdk.org; dkozlyuk at nvidia.com
> Subject: RE: [PATCH v2 6/8] common/mlx5: fix calloc parameters 
> 
> > From: Ferruh Yigit [mailto:ferruh.yigit at amd.com]
> > Sent: Wednesday, 24 January 2024 19.54
> >
> > gcc [1] generates warning [2] about calloc usage, because calloc
> > parameter order is wrong, fixing it by replacing parameters.
> >
> > [1]
> > gcc (GCC) 14.0.1 20240124 (experimental)
> >
> > [2]
> > Compiling C object .../common_mlx5_mlx5_common_mr.c.o
> > .../mlx5/mlx5_common_mr.c: In function ‘mlx5_mempool_get_chunks’:
> > .../common/mlx5/mlx5_common_mr.c:1384:29:
> >   warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier
> >   argument and not in the later argument [-Wcalloc-transposed-args]
> >  1384 |         *out = calloc(sizeof(**out), n);
> >       |                             ^
> >
> > Fixes: 7297d2cdecce ("common/mlx5: fix external memory pool
> > registration")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit at amd.com>
> > ---
> 
> Acked-by: Morten Brørup <mb at smartsharesystems.com>

Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>



More information about the stable mailing list