[PATCH] app/testpmd: fix async flow create failure handling

Ferruh Yigit ferruh.yigit at amd.com
Fri Mar 1 12:55:52 CET 2024


On 2/28/2024 6:57 PM, Dariusz Sosnowski wrote:
> In case of an error when an asynchronous flow create operation was
> enqueued, test-pmd attempted to enqueue a flow destroy operation
> of that flow rule.
> However, this was incorrect because:
> 
> - Flow rule index was used to enqueue a flow destroy operation.
>   This flow rule index was not yet initialized, so flow rule number 0
>   was always destroyed as a result.
> - Since rte_flow_async_create() does not return a handle on error,
>   then there is no flow rule to destroy.
> 
> test-pmd only needs to free internal memory allocated for
> storing a flow rule. Any flow destroy operation is not needed
> in this case.
> 
> Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
> Acked-by: Ori Kam <orika at nvidia.com>
>

Applied to dpdk-next-net/main, thanks.


More information about the stable mailing list