patch 'ci: update versions of actions in GHA' has been queued to stable release 23.11.1
Xueming Li
xuemingl at nvidia.com
Tue Mar 5 10:46:04 CET 2024
Hi,
FYI, your patch has been queued to stable release 23.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/31/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=a9e8fc49d9c537910ba78371b84766395004e2ef
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From a9e8fc49d9c537910ba78371b84766395004e2ef Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Wed, 31 Jan 2024 18:44:36 +0100
Subject: [PATCH] ci: update versions of actions in GHA
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 2ea7994ae39ff979b15899ec9eb9c68c944d4b11 ]
GitHub started deprecating GHA actions based on Node 16 [1].
For now, only warnings are raised, but we might as well switch to v4
versions of the common actions, now.
Link: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Aaron Conole <aconole at redhat.com>
---
.github/workflows/build.yml | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 272a6ffc7f..6b35c56da0 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -72,7 +72,7 @@ jobs:
steps:
- name: Checkout sources
- uses: actions/checkout at v3
+ uses: actions/checkout at v4
- name: Generate cache keys
id: get_ref_keys
run: |
@@ -80,7 +80,7 @@ jobs:
echo 'libabigail=libabigail-${{ env.LIBABIGAIL_VERSION }}-${{ matrix.config.os }}' >> $GITHUB_OUTPUT
echo 'abi=abi-${{ matrix.config.os }}-${{ matrix.config.compiler }}-${{ matrix.config.cross }}-${{ env.REF_GIT_TAG }}' >> $GITHUB_OUTPUT
- name: Retrieve ccache cache
- uses: actions/cache at v3
+ uses: actions/cache at v4
with:
path: ~/.ccache
key: ${{ steps.get_ref_keys.outputs.ccache }}-${{ github.ref }}
@@ -88,13 +88,13 @@ jobs:
${{ steps.get_ref_keys.outputs.ccache }}-refs/heads/main
- name: Retrieve libabigail cache
id: libabigail-cache
- uses: actions/cache at v3
+ uses: actions/cache at v4
if: env.ABI_CHECKS == 'true'
with:
path: libabigail
key: ${{ steps.get_ref_keys.outputs.libabigail }}
- name: Retrieve ABI reference cache
- uses: actions/cache at v3
+ uses: actions/cache at v4
if: env.ABI_CHECKS == 'true'
with:
path: reference
@@ -143,7 +143,7 @@ jobs:
run: .ci/linux-build.sh
- name: Upload logs on failure
if: failure()
- uses: actions/upload-artifact at v3
+ uses: actions/upload-artifact at v4
with:
name: meson-logs-${{ join(matrix.config.*, '-') }}
path: |
@@ -171,7 +171,7 @@ jobs:
echo 'image=image-${{ matrix.config.image }}-'$(date -u +%Y-%m-%d) >> $GITHUB_OUTPUT
- name: Retrieve image cache
id: image_cache
- uses: actions/cache at v3
+ uses: actions/cache at v4
with:
path: ~/.image
key: ${{ steps.get_keys.outputs.image }}
@@ -218,7 +218,7 @@ jobs:
steps:
- name: Checkout sources
- uses: actions/checkout at v3
+ uses: actions/checkout at v4
- name: Generate various keys
id: get_keys
run: |
@@ -226,7 +226,7 @@ jobs:
echo 'logs=meson-logs-${{ join(matrix.config.*, '-') }}' | tr -d ':' >> $GITHUB_OUTPUT
- name: Retrieve image cache
id: image_cache
- uses: actions/cache at v3
+ uses: actions/cache at v4
with:
path: ~/.image
key: ${{ needs.prepare-container-images.outputs.image }}
@@ -236,7 +236,7 @@ jobs:
echo 'Image ${{ matrix.config.image }} is not cached.'
false
- name: Retrieve ccache cache
- uses: actions/cache at v3
+ uses: actions/cache at v4
with:
path: ~/.ccache
key: ${{ steps.get_keys.outputs.ccache }}-${{ github.ref }}
@@ -276,7 +276,7 @@ jobs:
run: docker kill dpdk
- name: Upload logs on failure
if: failure()
- uses: actions/upload-artifact at v3
+ uses: actions/upload-artifact at v4
with:
name: ${{ steps.get_keys.outputs.logs }}
path: |
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-03-05 17:39:31.776755526 +0800
+++ 0023-ci-update-versions-of-actions-in-GHA.patch 2024-03-05 17:39:30.703566491 +0800
@@ -1 +1 @@
-From 2ea7994ae39ff979b15899ec9eb9c68c944d4b11 Mon Sep 17 00:00:00 2001
+From a9e8fc49d9c537910ba78371b84766395004e2ef Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 2ea7994ae39ff979b15899ec9eb9c68c944d4b11 ]
@@ -12,2 +14,0 @@
-Cc: stable at dpdk.org
-
@@ -21 +22 @@
-index 421207c241..776fbf6f30 100644
+index 272a6ffc7f..6b35c56da0 100644
More information about the stable
mailing list