patch 'net/af_xdp: fix memzone leak on config failure' has been queued to stable release 21.11.7

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 21.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/11/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/13696b1aa8c91c1b1659c6a7a60bc1ac59794950

Thanks.

Kevin

---
>From 13696b1aa8c91c1b1659c6a7a60bc1ac59794950 Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Tue, 5 Dec 2023 20:23:51 +0800
Subject: [PATCH] net/af_xdp: fix memzone leak on config failure

[ upstream commit 960775fc5b7d43cfbf9fa31e4c0b36c4da79615a ]

In xdp_umem_configure() allocated memzone for the 'umem', we should
free it when xsk_umem__create() call fails, otherwise it will lead to
memory zone leak. To fix it move 'umem->mz = mz;' assignment after
'mz == NULL' check.

Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")

Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Ciara Loftus <ciara.loftus at intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit at amd.com>
---
 drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 6bc7178fc5..dde4024267 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -1180,4 +1180,5 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
 		goto err;
 	}
+	umem->mz = mz;
 
 	ret = xsk_umem__create(&umem->umem, mz->addr,
@@ -1190,5 +1191,4 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
 		goto err;
 	}
-	umem->mz = mz;
 
 #endif
-- 
2.43.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-03-05 14:08:55.616074085 +0000
+++ 0040-net-af_xdp-fix-memzone-leak-on-config-failure.patch	2024-03-05 14:08:54.657520784 +0000
@@ -1 +1 @@
-From 960775fc5b7d43cfbf9fa31e4c0b36c4da79615a Mon Sep 17 00:00:00 2001
+From 13696b1aa8c91c1b1659c6a7a60bc1ac59794950 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 960775fc5b7d43cfbf9fa31e4c0b36c4da79615a ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 353c8688ec..2d151e45c7 100644
+index 6bc7178fc5..dde4024267 100644
@@ -25 +26 @@
-@@ -1235,4 +1235,5 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
+@@ -1180,4 +1180,5 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
@@ -31 +32 @@
-@@ -1245,5 +1246,4 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
+@@ -1190,5 +1191,4 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
@@ -36 +37 @@
- 	return umem;
+ #endif