patch 'net/vmxnet3: ignore Rx queue interrupt setup on FreeBSD' has been queued to stable release 22.11.5

luca.boccassi at gmail.com luca.boccassi at gmail.com
Mon Mar 25 13:08:18 CET 2024


Hi,

FYI, your patch has been queued to stable release 22.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/27/24. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/6409b2655024518d7c4f389c0afec41694a5c1c9

Thanks.

Luca Boccassi

---
>From 6409b2655024518d7c4f389c0afec41694a5c1c9 Mon Sep 17 00:00:00 2001
From: Tom Jones <thj at freebsd.org>
Date: Thu, 21 Mar 2024 10:31:33 +0000
Subject: [PATCH] net/vmxnet3: ignore Rx queue interrupt setup on FreeBSD

[ upstream commit 19fede459e0d22f5ac891366465dce07e68196bc ]

Interrupts disabled on FreeBSD for the vmxnet3 driver as they are not
supported. Rx queue interrupts were missed by this change, don't
attempt to enable them on FreeBSD.

Without this change applications enabling interrupts encounter an
immediate abort on FreeBSD.

Fixes: 40d5676ff1ea ("net/vmxnet3: fix initialization on FreeBSD")

Signed-off-by: Tom Jones <thj at freebsd.org>
Acked-by: Ferruh Yigit <ferruh.yigit at amd.com>
---
 .mailmap                             | 1 +
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/.mailmap b/.mailmap
index 2ad5489046..8979c462c7 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1388,6 +1388,7 @@ Tomasz Kulasek <tomaszx.kulasek at intel.com>
 Tomasz Zawadzki <tomasz.zawadzki at intel.com>
 Tom Barbette <barbette at kth.se> <tom.barbette at ulg.ac.be>
 Tom Crugnale <tcrugnale at sandvine.com>
+Tom Jones <thj at freebsd.org>
 Tom Millington <tmillington at solarflare.com>
 Tom Rix <trix at redhat.com>
 Tone Zhang <tone.zhang at arm.com>
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 9f9d8473e0..c1c7539fff 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1826,11 +1826,13 @@ done:
 static int
 vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
 {
+#ifndef RTE_EXEC_ENV_FREEBSD
 	struct vmxnet3_hw *hw = dev->data->dev_private;
 
 	vmxnet3_enable_intr(hw,
 			    rte_intr_vec_list_index_get(dev->intr_handle,
 							       queue_id));
+#endif
 
 	return 0;
 }
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2024-03-25 11:28:37.443985658 +0000
+++ 0003-net-vmxnet3-ignore-Rx-queue-interrupt-setup-on-FreeB.patch	2024-03-25 11:28:37.180388155 +0000
@@ -1 +1 @@
-From 19fede459e0d22f5ac891366465dce07e68196bc Mon Sep 17 00:00:00 2001
+From 6409b2655024518d7c4f389c0afec41694a5c1c9 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 19fede459e0d22f5ac891366465dce07e68196bc ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index a0b19832b5..491af1f6ff 100644
+index 2ad5489046..8979c462c7 100644
@@ -27 +28 @@
-@@ -1458,6 +1458,7 @@ Tomasz Kulasek <tomaszx.kulasek at intel.com>
+@@ -1388,6 +1388,7 @@ Tomasz Kulasek <tomaszx.kulasek at intel.com>
@@ -34 +35 @@
- Tomer Shmilovich <tshmilovich at nvidia.com>
+ Tone Zhang <tone.zhang at arm.com>
@@ -36 +37 @@
-index 2707b25148..ce7c347254 100644
+index 9f9d8473e0..c1c7539fff 100644
@@ -39 +40 @@
-@@ -1936,11 +1936,13 @@ done:
+@@ -1826,11 +1826,13 @@ done:


More information about the stable mailing list