[dpdk-test-report] [PatchWork]|ERROR| pw12197 Rate as a decimal number
sys_stv at intel.com
sys_stv at intel.com
Fri Apr 22 10:40:19 CEST 2016
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR
Patchwork ID: 12197
http://www.dpdk.org/dev/patchwork/patch/12197/
Submitter: "inaki.murillo" <inaki.murilloa at ehu.eus>
Date: Fri, 22 Apr 2016 10:07:24 +0200
DPDK git baseline: 7d619406f31ddf115714b32778c33f6dc0ead470
Check patch error:
12197:
ERROR: trailing whitespace
#65: FILE: app/cmd-functions.c:4704:
+cmdline_parse_float(cmdline_parse_token_hdr_t *tk, const char *srcbuf,
+$
WARNING: line over 80 characters
#78: FILE: app/cmd-functions.c:4717:
+ while (!cmdline_isendoftoken(srcbuf[token_len]) && token_len <
+(STR_TOKEN_SIZE-1)){
ERROR: space required before the open brace '{'
#78: FILE: app/cmd-functions.c:4717:
+ while (!cmdline_isendoftoken(srcbuf[token_len]) && token_len <
+(STR_TOKEN_SIZE-1)){
WARNING: braces {} are not necessary for single statement blocks
#78: FILE: app/cmd-functions.c:4717:
+ while (!cmdline_isendoftoken(srcbuf[token_len]) && token_len < (STR_TOKEN_SIZE-1)){
+ token_len++;
+ }
WARNING: line over 80 characters
#108: FILE: app/cmd-functions.c:4747:
+ memcpy(&nd, &((struct cmdline_token_float *)tk)->float_data,
+sizeof(nd));
WARNING: do not add new typedefs
#143: FILE: app/cmd-functions.h:95:
+typedef struct cmdline_token_float cmdline_parse_token_float_t;
ERROR: code indent should use tabs where possible
#189: FILE: app/pktgen-cmds.c:181:
+^I^I "# Port: %2d, Burst:%3d, Rate:%3f%%, Flags:%08x, TX Count:%s
",$
total: 3 errors, 4 warnings, 195 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
/home/patchWorkOrg/patches/dpdk-dev-v2-PKTGEN-Rate-as-a-decimal-number.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass
DPDK STV team
More information about the test-report
mailing list