[dpdk-test-report] [PatchWork]|ERROR|pw12222 eal: provide option to set vhost_user socket owner/permissions
sys_stv at intel.com
sys_stv at intel.com
Tue Apr 26 05:26:33 CEST 2016
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR
Patchwork ID: 12222
http://www.dpdk.org/dev/patchwork/patch/12222/
Submitter: Christian Ehrhardt <christian.ehrhardt at canonical.com>
Date: Mon, 25 Apr 2016 11:18:16 +0200
DPDK git baseline: cca231e048f634e13024aee5d80c4896a3c84fa8
Check patch error:
12222:
WARNING:LONG_LINE: line over 80 characters
#165: FILE: lib/librte_eal/linuxapp/eal/eal.c:349:
+ " --"OPT_VHOST_OWNER" Create vhost-user sockets with this owner:group
"
WARNING:LONG_LINE: line over 80 characters
#166: FILE: lib/librte_eal/linuxapp/eal/eal.c:350:
+ " --"OPT_VHOST_PERM" Create vhost-user sockets with these permissions
"
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: lib/librte_eal/linuxapp/eal/eal.c:957:
+ size_t newsize = *sizep * 2;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: lib/librte_eal/linuxapp/eal/eal.c:959:
+ if (newsize > *sizep) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#199: FILE: lib/librte_eal/linuxapp/eal/eal.c:960:
+ *buf = realloc(*buf, newsize);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: lib/librte_eal/linuxapp/eal/eal.c:960:
+ *buf = realloc(*buf, newsize);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#200: FILE: lib/librte_eal/linuxapp/eal/eal.c:961:
+ *sizep = newsize;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#200: FILE: lib/librte_eal/linuxapp/eal/eal.c:961:
+ *sizep = newsize;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#201: FILE: lib/librte_eal/linuxapp/eal/eal.c:962:
+ return 1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: lib/librte_eal/linuxapp/eal/eal.c:962:
+ return 1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#202: FILE: lib/librte_eal/linuxapp/eal/eal.c:963:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#204: FILE: lib/librte_eal/linuxapp/eal/eal.c:965:
+ return 0;$
WARNING:LONG_LINE: line over 80 characters
#226: FILE: lib/librte_eal/linuxapp/eal/eal.c:987:
+ while ((e = getpwnam_r(user_search, &pwd, buf, bufsize, &res)) == ERANGE) {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#227: FILE: lib/librte_eal/linuxapp/eal/eal.c:988:
+ if (!enlarge_buffer(&buf, &bufsize)) {
+ break;
+ }
WARNING:LONG_LINE: line over 80 characters
#233: FILE: lib/librte_eal/linuxapp/eal/eal.c:994:
+ RTE_LOG(ERR, EAL,"Failed to retrive user %s's uid (%s), aborting.",
ERROR:SPACING: space required after that ',' (ctx:VxV)
#233: FILE: lib/librte_eal/linuxapp/eal/eal.c:994:
+ RTE_LOG(ERR, EAL,"Failed to retrive user %s's uid (%s), aborting.",
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#238: FILE: lib/librte_eal/linuxapp/eal/eal.c:999:
+ RTE_LOG(ERR, EAL,"user %s not found, aborting.",
^
WARNING:LONG_LINE: line over 80 characters
#245: FILE: lib/librte_eal/linuxapp/eal/eal.c:1006:
+ while ((e = getpwuid_r(getuid(), &pwd, buf, bufsize, &res)) == ERANGE) {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#246: FILE: lib/librte_eal/linuxapp/eal/eal.c:1007:
+ if (!enlarge_buffer(&buf, &bufsize)) {
+ break;
+ }
ERROR:SPACING: space required after that ',' (ctx:VxV)
#252: FILE: lib/librte_eal/linuxapp/eal/eal.c:1013:
+ RTE_LOG(ERR, EAL,"Failed to retrive current user's uid "
^
WARNING:LONG_LINE: line over 80 characters
#274: FILE: lib/librte_eal/linuxapp/eal/eal.c:1035:
+ while ((e = getgrnam_r(grpstr, &grp, buf, bufsize, &res))
WARNING:BRACES: braces {} are not necessary for single statement blocks
#276: FILE: lib/librte_eal/linuxapp/eal/eal.c:1037:
+ if (!enlarge_buffer(&buf, &bufsize)) {
+ break;
+ }
WARNING:LONG_LINE: line over 80 characters
#282: FILE: lib/librte_eal/linuxapp/eal/eal.c:1043:
+ RTE_LOG(ERR, EAL,"Failed to get group entry for %s, "
ERROR:SPACING: space required after that ',' (ctx:VxV)
#282: FILE: lib/librte_eal/linuxapp/eal/eal.c:1043:
+ RTE_LOG(ERR, EAL,"Failed to get group entry for %s, "
^
WARNING:LONG_LINE: line over 80 characters
#288: FILE: lib/librte_eal/linuxapp/eal/eal.c:1049:
+ RTE_LOG(ERR, EAL,"Group %s not found, aborting.",
ERROR:SPACING: space required after that ',' (ctx:VxV)
#288: FILE: lib/librte_eal/linuxapp/eal/eal.c:1049:
+ RTE_LOG(ERR, EAL,"Group %s not found, aborting.",
^
WARNING:LONG_LINE: line over 80 characters
#308: FILE: lib/librte_eal/linuxapp/eal/eal.c:1069:
+ unsigned long int mode = strtoul(internal_config.vhost_sock_perm, NULL, 0);
ERROR:SPACING: space required after that ',' (ctx:VxV)
#311: FILE: lib/librte_eal/linuxapp/eal/eal.c:1072:
+ RTE_LOG(ERR, EAL,"vhost-user socket cannot set"
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#316: FILE: lib/librte_eal/linuxapp/eal/eal.c:1077:
+ RTE_LOG(INFO, EAL,"Socket %s changed permissions"
^
ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#324: FILE: lib/librte_eal/linuxapp/eal/eal.c:1085:
+ uid_t vhuid=0;
^
ERROR:SPACING: spaces required around that '=' (ctx:VxV)
#325: FILE: lib/librte_eal/linuxapp/eal/eal.c:1086:
+ gid_t vhgid=0;
^
WARNING:LONG_LINE: line over 80 characters
#327: FILE: lib/librte_eal/linuxapp/eal/eal.c:1088:
+ if (get_owners_from_str(internal_config.vhost_sock_owner, &vhuid, &vhgid)) {
ERROR:SPACING: space required after that ',' (ctx:VxV)
#328: FILE: lib/librte_eal/linuxapp/eal/eal.c:1089:
+ RTE_LOG(ERR, EAL,"vhost-user socket unable to get"
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#336: FILE: lib/librte_eal/linuxapp/eal/eal.c:1097:
+ RTE_LOG(ERR, EAL,"vhost-user socket unable to set"
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#342: FILE: lib/librte_eal/linuxapp/eal/eal.c:1103:
+ RTE_LOG(INFO, EAL,"Socket %s changed ownership"
^
WARNING:BRACES: braces {} are not necessary for single statement blocks
#350: FILE: lib/librte_eal/linuxapp/eal/eal.c:1111:
+ if (internal_config.vhost_sock_perm) {
+ vhost_set_permissions(path);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#354: FILE: lib/librte_eal/linuxapp/eal/eal.c:1115:
+ if (internal_config.vhost_sock_owner) {
+ vhost_set_ownership(path);
+ }
total: 15 errors, 22 warnings, 289 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
NOTE: Ignored message types: COMPARISON_TO_NULL FILE_PATH_CHANGES LINE_SPACING LINUX_VERSION_CODE NETWORKING_BLOCK_COMMENT_STYLE PARENTHESIS_ALIGNMENT PREFER_ALIGNED PREFER_KERNEL_TYPES PREFER_PACKED PREFER_PRINTF SPLIT_STRING VOLATILE
mbox has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass
DPDK STV team
More information about the test-report
mailing list