[dpdk-test-report] [PatchWork]|ERROR|pw12226-12232 examples/vhost: remove the non-working zero copy code

sys_stv at intel.com sys_stv at intel.com
Tue Apr 26 09:34:46 CEST 2016


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 12226-12232
http://www.dpdk.org/dev/patchwork/patch/12232/
Submitter: Yuanhan Liu <yuanhan.liu at linux.intel.com>
Date: Mon, 25 Apr 2016 21:45:45 -0700
DPDK git baseline: cca231e048f634e13024aee5d80c4896a3c84fa8

Check patch error:
12232: 
ERROR: do not initialise statics to 0 or NULL
#120: FILE: examples/vhost/main.c:1067:
+	static uint64_t prev_tsc = 0;

ERROR: space prohibited before that '++' (ctx:WxB)
#249: FILE: examples/vhost/main.c:1176:
+for (i = 0; i < rte_lcore_count(); i ++) {
                                     ^

 total: 2 errors, 0 warnings, 325 lines checked

 /home/patchWorkOrg/patches/dpdk-dev-7-7-examples-vhost-switch_worker-cleanup.patch has style problems, please review.

 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

 12226: 
 ERROR: do not initialise statics to 0 or NULL
 #141: FILE: examples/vhost/main.c:130:
 +static struct rte_mempool *mbuf_pool = NULL;

 total: 1 errors, 0 warnings, 1724 lines checked

 /home/patchWorkOrg/patches/dpdk-dev-1-7-examples-vhost-remove-the-non-working-zero-copy-code.patch has style problems, please review.

 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

 12228: 
 ERROR: "foo * bar" should be "foo *bar"
 #65: FILE: examples/vhost/main.c:746:
 +static inline struct vhost_dev * __attribute__((always_inline))

 WARNING: quoted string split across lines
 #182: FILE: examples/vhost/main.c:883:
 +		RTE_LOG(DEBUG, VHOST_DATA, "(%" PRIu64 ") "
 +			"Device is marked for removal
", fh);

 WARNING: line over 80 characters
 #301: FILE: examples/vhost/main.c:1124:
 +		if (lcore_info[lcore_id].dev_removal_flag == REQUEST_DEV_REMOVAL)

 WARNING: line over 80 characters
 #333: FILE: examples/vhost/main.c:1162:
 +							&dev_statistics[fh].rx_total_atomic,

 WARNING: line over 80 characters
 #337: FILE: examples/vhost/main.c:1165:
 +							&dev_statistics[fh].rx_atomic,

 WARNING: please, no space before tabs
 #758: FILE: examples/vhost/main.h:78:
 +^Iuint32_t ^I^Idevice_num;$

 WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
 #761: FILE: examples/vhost/main.h:81:
 +	volatile uint8_t	dev_removal_flag;

 total: 1 errors, 6 warnings, 714 lines checked

 /home/patchWorkOrg/patches/dpdk-dev-3-7-examples-vhost-use-tailq-to-link-vhost-devices.patch has style problems, please review.

 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


 patch file error:
 12232: 
 patching file examples/vhost/main.c
 Hunk #1 FAILED at 213.
 Hunk #2 succeeded at 1188 with fuzz 1 (offset 243 lines).
 Hunk #3 succeeded at 1238 (offset 229 lines).
 Hunk #4 FAILED at 1046.
 Hunk #5 FAILED at 1102.
 Hunk #6 FAILED at 1139.
 4 out of 6 hunks FAILED -- saving rejects to file examples/vhost/main.c.rej

 12226: 
 patching file doc/guides/sample_app_ug/vhost.rst
 patching file examples/vhost/main.c
 Hunk #14 FAILED at 755.
 Hunk #15 succeeded at 1128 (offset -5 lines).
 Hunk #16 FAILED at 1272.
 Hunk #17 FAILED at 2323.
 Hunk #18 succeeded at 2514 (offset -9 lines).
 Hunk #19 succeeded at 2524 (offset -9 lines).
 Hunk #20 FAILED at 2547.
 Hunk #21 succeeded at 2629 (offset -9 lines).
 Hunk #22 succeeded at 2689 (offset -9 lines).
 Hunk #23 FAILED at 2725.
 Hunk #24 succeeded at 2766 (offset -9 lines).
 Hunk #25 FAILED at 2823.
 Hunk #26 FAILED at 2916.
 7 out of 26 hunks FAILED -- saving rejects to file examples/vhost/main.c.rej patching file examples/vhost/main.h Hunk #1 succeeded at 51 (offset 12 lines).
 Hunk #2 succeeded at 59 (offset 12 lines).

 12228: 
 patching file examples/vhost/main.c
 Hunk #2 succeeded at 88 (offset 2 lines).
 Hunk #3 succeeded at 214 (offset 2 lines).
 Hunk #4 succeeded at 780 (offset 37 lines).
 Hunk #5 succeeded at 802 (offset 37 lines).
 Hunk #6 FAILED at 852.
 Hunk #7 FAILED at 916.
 Hunk #8 succeeded at 1147 (offset 56 lines).
 Hunk #9 succeeded at 1158 (offset 56 lines).
 Hunk #10 succeeded at 1196 (offset 54 lines).
 Hunk #11 succeeded at 1238 (offset 54 lines).
 Hunk #12 FAILED at 1213.
 Hunk #13 FAILED at 1385.
 Hunk #14 succeeded at 2520 (offset 1065 lines).
 Hunk #15 succeeded at 2533 (offset 1065 lines).
 Hunk #16 succeeded at 2617 (offset 1139 lines).
 Hunk #17 succeeded at 2633 (offset 1139 lines).
 Hunk #18 succeeded at 2657 (offset 1139 lines).
 Hunk #19 succeeded at 2672 (offset 1139 lines).
 Hunk #20 succeeded at 2697 (offset 1139 lines).
 Hunk #21 succeeded at 2774 (offset 1171 lines).
 Hunk #22 succeeded at 2874 (offset 1216 lines).
 4 out of 22 hunks FAILED -- saving rejects to file examples/vhost/main.c.rej patching file examples/vhost/main.h Hunk #2 succeeded at 46 with fuzz 2 (offset 12 lines).
 Hunk #3 succeeded at 73 (offset 12 lines).

 12230: 
 patching file examples/vhost/main.c
 Hunk #1 succeeded at 1041 (offset 208 lines).
 Hunk #2 succeeded at 1065 with fuzz 2 (offset 209 lines).
 Hunk #3 FAILED at 886.
 Hunk #4 succeeded at 1231 (offset 253 lines).
 Hunk #5 succeeded at 1257 with fuzz 2 (offset 252 lines).
 1 out of 5 hunks FAILED -- saving rejects to file examples/vhost/main.c.rej

 12231: 
 patching file examples/vhost/main.c
 Hunk #1 succeeded at 64 (offset 2 lines).
 Hunk #2 succeeded at 144 (offset 42 lines).
 Hunk #3 succeeded at 2991 (offset 1627 lines).
 Hunk #4 succeeded at 3078 (offset 1627 lines).
 Hunk #5 FAILED at 1468.
 1 out of 5 hunks FAILED -- saving rejects to file examples/vhost/main.c.rej


 DPDK STV team


More information about the test-report mailing list