[dpdk-test-report] [PatchWork]|ERROR| pw12259-12262 pmd: Modify PMD_REGISTER_DRIVER to emit a marker symbol

[sys_stv at intel.com]

Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 12259-12262
http://www.dpdk.org/dev/patchwork/patch/12262/
Submitter: Neil Horman <nhorman at tuxdriver.com>
Date: Tue, 26 Apr 2016 13:39:48 -0400
DPDK git baseline: d9ba0b2c5a0b91af4963a728833b77d096503198

Check patch error:
12259: 
ERROR: trailing whitespace
#68: FILE: lib/librte_eal/common/include/rte_dev.h:187:
+#ifdef RTE_BUILD_SHARED_LIB $

WARNING: please, no spaces at the start of a line
#72: FILE: lib/librte_eal/common/include/rte_dev.h:191:
+ __attribute__((alias(RTE_STR(src))))$

ERROR: space required after that close brace '}'
#79: FILE: lib/librte_eal/common/include/rte_dev.h:198:
+}
total: 2 errors, 1 warnings, 45 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

  /home/patchWorkOrg/patches/dpdk-dev-RFC-1-4-pmd-Modify-PMD_REGISTER_DRIVER-to-emit-a-marker-symbol.patch has style problems, please review.

  If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

  12261: 
  WARNING: externs should be avoided in .c files
  #128: FILE: drivers/net/e1000/em_ethdev.c:63:
  +int

  WARNING: externs should be avoided in .c files
  #169: FILE: drivers/net/e1000/igb_ethdev.c:89:
  +int

  WARNING: line over 80 characters
  #170: FILE: drivers/net/e1000/igb_ethdev.c:90:
  +rte_igb_pmd_init(const char *name __rte_unused, const char *params 
  +__rte_unused);

  WARNING: externs should be avoided in .c files
  #171: FILE: drivers/net/e1000/igb_ethdev.c:91:
  +int

  WARNING: line over 80 characters
  #172: FILE: drivers/net/e1000/igb_ethdev.c:92:
  +rte_igbvf_pmd_init(const char *name __rte_unused, const char *params 
  +__rte_unused);

  WARNING: line over 80 characters
  #246: FILE: drivers/net/e1000/pmds.c:6:
  +rte_igb_pmd_init(const char *name __rte_unused, const char *params 
  +__rte_unused);

  WARNING: externs should be avoided in .c files
  #247: FILE: drivers/net/e1000/pmds.c:7:
  +extern int

  WARNING: line over 80 characters
  #248: FILE: drivers/net/e1000/pmds.c:8:
  +rte_igbvf_pmd_init(const char *name __rte_unused, const char *params 
  +__rte_unused);

  WARNING: externs should be avoided in .c files
  #250: FILE: drivers/net/e1000/pmds.c:10:
  +extern const struct rte_pci_id pci_id_igb_map[];

  WARNING: externs should be avoided in .c files
  #251: FILE: drivers/net/e1000/pmds.c:11:
  +extern const struct rte_pci_id pci_id_igbvf_map[];

  ERROR: open brace '{' following function declarations go on the next line
  #253: FILE: drivers/net/e1000/pmds.c:13:
  +struct rte_driver __attribute__((used)) pmd_igb_drv = {

  ERROR: open brace '{' following function declarations go on the next line
  #260: FILE: drivers/net/e1000/pmds.c:20:
  +struct rte_driver __attribute__((used)) pmd_igbvf_drv = {

  WARNING: networking block comments don't use an empty /* line, use /* Comment...
  #276: FILE: drivers/net/e1000/pmds.c:36:
  +/*
  + *  * The set of PCI devices this driver supports

  WARNING: networking block comments put the trailing */ on a separate line
  #277: FILE: drivers/net/e1000/pmds.c:37:
  + *   */

  WARNING: externs should be avoided in .c files
  #278: FILE: drivers/net/e1000/pmds.c:38:
  +extern const struct rte_pci_id pci_id_em_map[];

  ERROR: open brace '{' following function declarations go on the next line
  #280: FILE: drivers/net/e1000/pmds.c:40:
  +static struct rte_driver __attribute__((used)) em_pmd_drv = {

  WARNING: externs should be avoided in .c files
  #336: FILE: drivers/net/i40e/i40e_ethdev.c:699:
  +extern int

  ERROR: code indent should use tabs where possible
  #338: FILE: drivers/net/i40e/i40e_ethdev.c:701:
  +                    const char *params __rte_unused);$

  WARNING: please, no spaces at the start of a line
  #338: FILE: drivers/net/i40e/i40e_ethdev.c:701:
  +                    const char *params __rte_unused);$

  WARNING: externs should be avoided in .c files
  #340: FILE: drivers/net/i40e/i40e_ethdev.c:703:
  +extern const struct rte_pci_id pci_id_i40evf_map[];

  WARNING: externs should be avoided in .c files
  #361: FILE: drivers/net/i40e/i40e_ethdev_vf.c:104:
  +int

  total: 4 errors, 17 warnings, 308 lines checked

  NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
        scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-RFC-3-4-pmd-Modify-drivers-to-export-appropriate-information.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

12262: 
ERROR: spaces required around that '=' (ctx:VxV)
#140: FILE: app/pmdinfo/pmdinfo.c:20:
+	for (i=0; driver->pci_table[i].vendor_id != 0; i++) {
      ^

  ERROR: trailing whitespace
  #196: FILE: app/pmdinfo/pmdinfo.c:76:
  +^I^I$

  ERROR: space required before the open parenthesis '('
  #207: FILE: app/pmdinfo/pmdinfo.c:87:
  +	} while(driver);

  total: 3 errors, 0 warnings, 157 lines checked

  NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
        scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-RFC-4-4-pmdinfo-Add-application-to-extract-pmd-driver-info.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team 


 DPDK STV team