[dpdk-test-report] [PatchWork]|ERROR| pw15068 Application framework vs. library

sys_stv at intel.com sys_stv at intel.com
Thu Aug 4 03:27:53 CEST 2016


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 15068
http://www.dpdk.org/dev/patchwork/patch/15068/
Submitter: Steffen.Bauch at rohde-schwarz.com
Date: Mon, 1 Aug 2016 11:22:44 +0200
DPDK git baseline: b0a1419a88efebac3a1d52987b7e634848f9c85e

Check patch error:
15068: 
WARNING: please, no spaces at the start of a line
#47: FILE: lib/librte_eal/linuxapp/eal/eal.c:696:
+       int fctret;$

WARNING: please, no spaces at the start of a line
#59: FILE: lib/librte_eal/linuxapp/eal/eal.c:700:
+       logid = NULL;$

WARNING: suspect code indent for conditional statements (7, 15)
#61: FILE: lib/librte_eal/linuxapp/eal/eal.c:702:
        if (rte_eal_log_early_init() < 0)
+               return -1;

ERROR: code indent should use tabs where possible
#63: FILE: lib/librte_eal/linuxapp/eal/eal.c:703:
+               return -1;$

WARNING: please, no spaces at the start of a line
#63: FILE: lib/librte_eal/linuxapp/eal/eal.c:703:
+               return -1;$

WARNING: suspect code indent for conditional statements (7, 15)
#65: FILE: lib/librte_eal/linuxapp/eal/eal.c:705:
        if (rte_eal_cpu_init() < 0)
+               return -1;

ERROR: code indent should use tabs where possible
#67: FILE: lib/librte_eal/linuxapp/eal/eal.c:706:
+               return -1;$

WARNING: please, no spaces at the start of a line
#67: FILE: lib/librte_eal/linuxapp/eal/eal.c:706:
+               return -1;$

ERROR: patch seems to be corrupt (line wrapped?)
#73: FILE: lib/librte_eal/linuxapp/eal/eal.c:716:
&&

ERROR: code indent should use tabs where possible
#77: FILE: lib/librte_eal/linuxapp/eal/eal.c:719:
+               return -1;$

WARNING: please, no spaces at the start of a line
#77: FILE: lib/librte_eal/linuxapp/eal/eal.c:719:
+               return -1;$

WARNING: suspect code indent for conditional statements (7, 15)
#85: FILE: lib/librte_eal/linuxapp/eal/eal.c:743:
        if (rte_eal_pci_init() < 0)
+               return -1;

ERROR: code indent should use tabs where possible
#87: FILE: lib/librte_eal/linuxapp/eal/eal.c:744:
+               return -1;$

WARNING: please, no spaces at the start of a line
#87: FILE: lib/librte_eal/linuxapp/eal/eal.c:744:
+               return -1;$

WARNING: suspect code indent for conditional statements (7, 15)
#90: FILE: lib/librte_eal/linuxapp/eal/eal.c:747:
        if (rte_eal_ivshmem_init() < 0)
+               return -1;

ERROR: code indent should use tabs where possible
#92: FILE: lib/librte_eal/linuxapp/eal/eal.c:748:
+               return -1;$

WARNING: please, no spaces at the start of a line
#92: FILE: lib/librte_eal/linuxapp/eal/eal.c:748:
+               return -1;$

WARNING: suspect code indent for conditional statements (7, 15)
#95: FILE: lib/librte_eal/linuxapp/eal/eal.c:751:
        if (rte_eal_memory_init() < 0)
+               return -1;

ERROR: code indent should use tabs where possible
#97: FILE: lib/librte_eal/linuxapp/eal/eal.c:752:
+               return -1;$

WARNING: please, no spaces at the start of a line
#97: FILE: lib/librte_eal/linuxapp/eal/eal.c:752:
+               return -1;$

WARNING: suspect code indent for conditional statements (7, 15)
#102: FILE: lib/librte_eal/linuxapp/eal/eal.c:757:
        if (rte_eal_memzone_init() < 0)
+               return -1;

ERROR: code indent should use tabs where possible
#104: FILE: lib/librte_eal/linuxapp/eal/eal.c:758:
+               return -1;$

WARNING: please, no spaces at the start of a line
#104: FILE: lib/librte_eal/linuxapp/eal/eal.c:758:
+               return -1;$

WARNING: suspect code indent for conditional statements (7, 15)
#106: FILE: lib/librte_eal/linuxapp/eal/eal.c:760:
        if (rte_eal_tailqs_init() < 0)
+               return -1;

ERROR: code indent should use tabs where possible
#108: FILE: lib/librte_eal/linuxapp/eal/eal.c:761:
+               return -1;$

WARNING: please, no spaces at the start of a line
#108: FILE: lib/librte_eal/linuxapp/eal/eal.c:761:
+               return -1;$

WARNING: suspect code indent for conditional statements (7, 15)
#111: FILE: lib/librte_eal/linuxapp/eal/eal.c:764:
        if (rte_eal_ivshmem_obj_init() < 0)
+               return -1;

ERROR: code indent should use tabs where possible
#113: FILE: lib/librte_eal/linuxapp/eal/eal.c:765:
+               return -1;$

WARNING: please, no spaces at the start of a line
#113: FILE: lib/librte_eal/linuxapp/eal/eal.c:765:
+               return -1;$

WARNING: suspect code indent for conditional statements (7, 15)
#116: FILE: lib/librte_eal/linuxapp/eal/eal.c:768:
        if (rte_eal_log_init(logid, internal_config.syslog_facility) < 0)
+               return -1;

ERROR: code indent should use tabs where possible
#118: FILE: lib/librte_eal/linuxapp/eal/eal.c:769:
+               return -1;$

WARNING: please, no spaces at the start of a line
#118: FILE: lib/librte_eal/linuxapp/eal/eal.c:769:
+               return -1;$

WARNING: suspect code indent for conditional statements (7, 15)
#120: FILE: lib/librte_eal/linuxapp/eal/eal.c:771:
        if (rte_eal_alarm_init() < 0)
+               return -1;

ERROR: code indent should use tabs where possible
#122: FILE: lib/librte_eal/linuxapp/eal/eal.c:772:
+               return -1;$

WARNING: please, no spaces at the start of a line
#122: FILE: lib/librte_eal/linuxapp/eal/eal.c:772:
+               return -1;$

ERROR: trailing whitespace
#124: FILE: lib/librte_eal/linuxapp/eal/eal.c:774:
+       /* interrupt handling will be initialized but the thread is $

ERROR: code indent should use tabs where possible
#128: FILE: lib/librte_eal/linuxapp/eal/eal.c:776:
+               return -1;$

ERROR: trailing whitespace
#130: FILE: lib/librte_eal/linuxapp/eal/eal.c:778:
+       /* timer stuff is initialized but hpet should be disabled in $

ERROR: code indent should use tabs where possible
#134: FILE: lib/librte_eal/linuxapp/eal/eal.c:780:
+               return -1;$

ERROR: code indent should use tabs where possible
#181: FILE: lib/librte_eal/linuxapp/eal/eal.c:794:
+               return -1;$

WARNING: please, no spaces at the start of a line
#181: FILE: lib/librte_eal/linuxapp/eal/eal.c:794:
+               return -1;$

WARNING: suspect code indent for conditional statements (7, 15)
#184: FILE: lib/librte_eal/linuxapp/eal/eal.c:797:
        if (rte_eal_pci_probe())
+               return -1;

ERROR: code indent should use tabs where possible
#186: FILE: lib/librte_eal/linuxapp/eal/eal.c:798:
+               return -1;$

WARNING: please, no spaces at the start of a line
#186: FILE: lib/librte_eal/linuxapp/eal/eal.c:798:
+               return -1;$

ERROR: trailing whitespace
#199: FILE: lib/librte_eal/linuxapp/eal/eal_interrupts.c:777:
+       /* we do not need the interrupt handling and do not want the 
+ extra $

ERROR: trailing whitespace
#216: FILE: lib/librte_eal/linuxapp/eal/eal_log.c:94:
+rte_eal_log_init(__attribute__((unused)) const char *id, $

ERROR: Missing Signed-off-by: line(s)

total: 21 errors, 26 warnings, 184 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-Application-framework-vs.-library.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team 


More information about the test-report mailing list