[dpdk-test-report] |WARNING| [PATCH] app/testpmd: unify help strings

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Dec 2 02:37:37 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17360

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#238: FILE: app/test-pmd/cmdline.c:2257:
+        .help_str = "port config <port-id> dcb vt on|off <num_tcs> pfc on|off",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#238: FILE: app/test-pmd/cmdline.c:2257:
+        .help_str = "port config <port-id> dcb vt on|off <num_tcs> pfc on|off",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#521: FILE: app/test-pmd/cmdline.c:3960:
+^I            "mode normal|bypass|isolate <port_id>: "$

ERROR:CODE_INDENT: code indent should use tabs where possible
#532: FILE: app/test-pmd/cmdline.c:4025:
+^I            "Set the NIC bypass watchdog timeout in seconds",$

WARNING:SIZEOF_PARENTHESIS: sizeof help should be sizeof(help)
#639: FILE: app/test-pmd/cmdline.c:4784:
+	snprintf(help, sizeof help, "set fwd %s: "

WARNING:LONG_LINE_STRING: line over 90 characters
#1316: FILE: app/test-pmd/cmdline.c:9285:
+	.help_str = "flow_director_mask ... : Set MAC VLAN mode flow director's mask on NIC",

WARNING:LONG_LINE_STRING: line over 90 characters
#1325: FILE: app/test-pmd/cmdline.c:9300:
+	.help_str = "flow_director_mask ... : Set tunnel mode flow director's mask on NIC",

WARNING:LONG_LINE_STRING: line over 90 characters
#1343: FILE: app/test-pmd/cmdline.c:9546:
+	.help_str = "flow_director_flexpayload ... : Set flow director's flex payload on NIC",

total: 3 errors, 5 warnings, 1360 lines checked


More information about the test-report mailing list