[dpdk-test-report] |WARNING| [PATCH 10/24] ethdev: parse ethertype filter

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Dec 2 05:14:14 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17371

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#210: FILE: lib/librte_ether/rte_flow_driver.h:179:
+#define PATTERN_SKIP_VOID(filter, filter_struct, error_type)		\
+	do {								\
+		if (!pattern) {						\
+			memset(filter, 0, sizeof(filter_struct));	\
+			error->type = error_type;                       \
+			return -EINVAL;					\
+		}							\
+		item = pattern + i;					\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {		\
+			i++;						\
+			item = pattern + i;				\
+		}							\
+	} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#224: FILE: lib/librte_ether/rte_flow_driver.h:193:
+#define ACTION_SKIP_VOID(filter, filter_struct, error_type)		\
+	do {								\
+		if (!actions) {						\
+			memset(filter, 0, sizeof(filter_struct));	\
+			error->type = error_type;			\
+			return -EINVAL;					\
+		}							\
+		act = actions + i;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {	\
+			i++;						\
+			act = actions + i;				\
+		}							\
+	} while (0)

total: 0 errors, 2 warnings, 179 lines checked


More information about the test-report mailing list