[dpdk-test-report] |WARNING| [PATCH 13/13] i40e: improve message grepability

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Dec 13 02:09:28 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17887

_coding style issues_


WARNING:LONG_LINE_STRING: line over 90 characters
#52: FILE: drivers/net/i40e/i40e_ethdev.c:766:
+		PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control frames from VSIs.");

WARNING:LONG_LINE: line over 90 characters
#115: FILE: drivers/net/i40e/i40e_ethdev.c:2718:
+		PMD_DRV_LOG(ERR, "Fail to debug read from I40E_GL_SWT_L2TAGCTRL[%d]", reg_id);

WARNING:LONG_LINE: line over 90 characters
#121: FILE: drivers/net/i40e/i40e_ethdev.c:2722:
+	PMD_DRV_LOG(DEBUG, "Debug read from I40E_GL_SWT_L2TAGCTRL[%d]: 0x%08"PRIx64"", reg_id, reg_r);

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#121: FILE: drivers/net/i40e/i40e_ethdev.c:2722:
+	PMD_DRV_LOG(DEBUG, "Debug read from I40E_GL_SWT_L2TAGCTRL[%d]: 0x%08"PRIx64"", reg_id, reg_r);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#121: FILE: drivers/net/i40e/i40e_ethdev.c:2722:
+	PMD_DRV_LOG(DEBUG, "Debug read from I40E_GL_SWT_L2TAGCTRL[%d]: 0x%08"PRIx64"", reg_id, reg_r);

WARNING:LONG_LINE: line over 90 characters
#131: FILE: drivers/net/i40e/i40e_ethdev.c:2736:
+		PMD_DRV_LOG(ERR, "Fail to debug write to I40E_GL_SWT_L2TAGCTRL[%d]", reg_id);

WARNING:LONG_LINE: line over 90 characters
#136: FILE: drivers/net/i40e/i40e_ethdev.c:2739:
+	PMD_DRV_LOG(DEBUG, "Debug write 0x%08"PRIx64" to I40E_GL_SWT_L2TAGCTRL[%d]", reg_w, reg_id);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#136: FILE: drivers/net/i40e/i40e_ethdev.c:2739:
+	PMD_DRV_LOG(DEBUG, "Debug write 0x%08"PRIx64" to I40E_GL_SWT_L2TAGCTRL[%d]", reg_w, reg_id);

WARNING:LONG_LINE: line over 90 characters
#146: FILE: drivers/net/i40e/i40e_ethdev.c:2883:
+		PMD_INIT_LOG(ERR, "Invalid high/low water setup value in KB, High_water must be <= %d.", max_high_water);

WARNING:LONG_LINE_STRING: line over 90 characters
#156: FILE: drivers/net/i40e/i40e_ethdev.c:3055:
+					PMD_DRV_LOG(ERR, "No VMDQ pool enabled/configured");

WARNING:LONG_LINE_STRING: line over 90 characters
#167: FILE: drivers/net/i40e/i40e_ethdev.c:3256:
+		PMD_DRV_LOG(ERR, "The size of hash lookup table configured (%d) doesn't match the number hardware can supported (%d)
",

WARNING:LONG_LINE_STRING: line over 90 characters
#179: FILE: drivers/net/i40e/i40e_ethdev.c:3296:
+		PMD_DRV_LOG(ERR, "The size of hash lookup table configured (%d) doesn't match the number hardware can supported (%d)
",

WARNING:LONG_LINE_STRING: line over 90 characters
#202: FILE: drivers/net/i40e/i40e_ethdev.c:3559:
+				PMD_DRV_LOG(DEBUG, "%u VMDQ VSIs, %u queues per VMDQ VSI, in total %u queues",

WARNING:LONG_LINE_STRING: line over 90 characters
#220: FILE: drivers/net/i40e/i40e_ethdev.c:3577:
+		PMD_DRV_LOG(ERR, "Failed to allocate %u queues, which exceeds the hardware maximum %u",

WARNING:LONG_LINE_STRING: line over 90 characters
#228: FILE: drivers/net/i40e/i40e_ethdev.c:3582:
+		PMD_DRV_LOG(ERR, "Failed to allocate %u VSIs, which exceeds the hardware maximum %u",

WARNING:LONG_LINE: line over 90 characters
#401: FILE: drivers/net/i40e/i40e_ethdev.c:6520:
+		PMD_DRV_LOG(ERR, "Maximum number of UDP ports reached, not adding port %d", port);

WARNING:LONG_LINE_STRING: line over 90 characters
#448: FILE: drivers/net/i40e/i40e_ethdev.c:7976:
+		PMD_DRV_LOG(ERR, "unsupported ether_type(0x%04x) in control packet filter.",

WARNING:LONG_LINE_STRING: line over 90 characters
#455: FILE: drivers/net/i40e/i40e_ethdev.c:7981:
+		PMD_DRV_LOG(WARNING, "filter vlan ether_type in first tag is not supported.");

WARNING:LONG_LINE: line over 90 characters
#466: FILE: drivers/net/i40e/i40e_ethdev.c:8308:
+			PMD_DRV_LOG(ERR, "Failed to write 0x%"PRIx64" to the address of 0x%"PRIx32,

CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#466: FILE: drivers/net/i40e/i40e_ethdev.c:8308:
+			PMD_DRV_LOG(ERR, "Failed to write 0x%"PRIx64" to the address of 0x%"PRIx32,

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#466: FILE: drivers/net/i40e/i40e_ethdev.c:8308:
+			PMD_DRV_LOG(ERR, "Failed to write 0x%"PRIx64" to the address of 0x%"PRIx32,

WARNING:LONG_LINE: line over 90 characters
#477: FILE: drivers/net/i40e/i40e_ethdev.c:8354:
+			PMD_DRV_LOG(ERR, "Failed to update VSI_L2TAGSTXVALID[%d]", vsi->vsi_id);

WARNING:LONG_LINE_STRING: line over 90 characters
#507: FILE: drivers/net/i40e/i40e_ethdev.c:8518:
+				PMD_DRV_LOG(ERR, "failed to remove mirror rule: ret = %d, aq_err = %d.",

WARNING:LONG_LINE_STRING: line over 90 characters
#527: FILE: drivers/net/i40e/i40e_ethdev.c:8661:
+			PMD_DRV_LOG(ERR, "failed to remove mirror rule: status = %d, aq_err = %d.",

WARNING:LONG_LINE_STRING: line over 90 characters
#537: FILE: drivers/net/i40e/i40e_ethdev.c:9094:
+		PMD_INIT_LOG(ERR, "AQ command Config switch_comp BW allocation per TC failed = %d",

WARNING:LONG_LINE: line over 90 characters
#547: FILE: drivers/net/i40e/i40e_ethdev.c:9103:
+		PMD_DRV_LOG(ERR, "Failed to get switch_comp ETS configuration %u", hw->aq.asq_last_status);

WARNING:LONG_LINE: line over 90 characters
#556: FILE: drivers/net/i40e/i40e_ethdev.c:9110:
+		PMD_DRV_LOG(ERR, "Failed to get switch_comp bandwidth configuration %u", hw->aq.asq_last_status);

WARNING:LONG_LINE_STRING: line over 90 characters
#566: FILE: drivers/net/i40e/i40e_ethdev.c:9175:
+		PMD_INIT_LOG(ERR, "AQ command Config VSI BW allocation per TC failed = %d",

WARNING:LONG_LINE: line over 90 characters
#596: FILE: drivers/net/i40e/i40e_ethdev.c:9376:
+				PMD_INIT_LOG(ERR, "default dcb config fails. err = %d, aq_err = %d.", ret,

WARNING:LONG_LINE: line over 90 characters
#603: FILE: drivers/net/i40e/i40e_ethdev.c:9381:
+			PMD_INIT_LOG(ERR, "DCB initialization in FW fails, err = %d, aq_err = %d.", ret,

WARNING:LONG_LINE: line over 90 characters
#619: FILE: drivers/net/i40e/i40e_ethdev.c:9397:
+			PMD_INIT_LOG(ERR, "DCBX configuration failed, err = %d, aq_err = %d.", ret,

total: 0 errors, 26 warnings, 5 checks, 529 lines checked


More information about the test-report mailing list