[dpdk-test-report] [PatchWork]|ERROR| pw14526-14541 vfio: fix include of eal_private.h to be local
sys_stv at intel.com
sys_stv at intel.com
Fri Jul 8 09:48:26 CEST 2016
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR
Patchwork ID: 14526-14541
http://www.dpdk.org/dev/patchwork/patch/14541/
Submitter: Jan Viktorin <viktorin at rehivetech.com>
Date: Mon, 4 Jul 2016 17:16:36 +0200
DPDK git baseline: 26622cbe1b91727f55dfb017c4df6f533407b3c6
Check patch error:
14536:
ERROR: do not use assignment in if condition
#342: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:326:
+ if ((ret = vfio_setup_device(pci_get_sysfs_path(), pci_addr,
WARNING: line over 80 characters
#449: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:73:
+ RTE_LOG(ERR, EAL, "Cannot open %s: %s
", filename,
WARNING: line over 80 characters
#460: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:84:
+ RTE_LOG(ERR, EAL, "Cannot open %s: %s
", filename,
WARNING: line over 80 characters
#471: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:95:
+ RTE_LOG(ERR, EAL, "Maximum number of VFIO groups reached!
");
WARNING: line over 80 characters
#475: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:99:
+ vfio_cfg.vfio_groups[vfio_cfg.vfio_group_idx].group_no =
+iommu_group_no;
WARNING: line over 80 characters
#476: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:100:
+ vfio_cfg.vfio_groups[vfio_cfg.vfio_group_idx].fd = vfio_group_fd;
WARNING: line over 80 characters
#488: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:112:
+ RTE_LOG(ERR, EAL, " cannot connect to primary process!
");
WARNING: line over 80 characters
#491: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:115:
+ if (vfio_mp_sync_send_request(socket_fd, SOCKET_REQ_GROUP) < 0) {
WARNING: line over 80 characters
#543: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:167:
+ RTE_LOG(WARNING, EAL, " %s not managed by VFIO driver, skipping
",
WARNING: line over 80 characters
#563: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:187:
+ RTE_LOG(WARNING, EAL, " %s not managed by VFIO driver, skipping
",
WARNING: line over 80 characters
#573: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:197:
+ * at this point, we know that this group is viable (meaning, all
+devices
WARNING: line over 80 characters
#581: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:205:
+ "error %i (%s)
", dev_addr, errno, strerror(errno));
WARNING: quoted string split across lines
#581: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:205:
+ RTE_LOG(ERR, EAL, " %s cannot get group status, "
+ "error %i (%s)
", dev_addr, errno, strerror(errno));
WARNING: line over 80 characters
#599: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:223:
+ RTE_LOG(ERR, EAL, " %s cannot add VFIO group to container, "
WARNING: line over 80 characters
#600: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:224:
+ "error %i (%s)
", dev_addr, errno, strerror(errno));
WARNING: quoted string split across lines
#600: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:224:
+ RTE_LOG(ERR, EAL, " %s cannot add VFIO group to container, "
+ "error %i (%s)
", dev_addr, errno, strerror(errno));
WARNING: line over 80 characters
#607: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:231:
+ * initialized, so we increment vfio_group_idx to indicate that we
+can
WARNING: line over 80 characters
#616: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:240:
+ * needs to be done only once, only when at least one group is
+assigned to
WARNING: line over 80 characters
#625: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:249:
+ RTE_LOG(ERR, EAL, " %s failed to select IOMMU type
", dev_addr);
WARNING: line over 80 characters
#631: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:255:
+ "error %i (%s)
", dev_addr, errno, strerror(errno));
WARNING: quoted string split across lines
#631: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:255:
+ RTE_LOG(ERR, EAL, " %s DMA remapping failed, "
+ "error %i (%s)
", dev_addr, errno, strerror(errno));
WARNING: line over 80 characters
#643: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:267:
+ RTE_LOG(WARNING, EAL, " %s not managed by VFIO driver, skipping
",
WARNING: line over 80 characters
#652: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:276:
+ "error %i (%s)
", dev_addr, errno, strerror(errno));
WARNING: quoted string split across lines
#652: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:276:
+ RTE_LOG(ERR, EAL, " %s cannot get device info, "
+ "error %i (%s)
", dev_addr, errno, strerror(errno));
WARNING: quoted string split across lines
#687: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:311:
+ RTE_LOG(DEBUG, EAL, "VFIO modules not loaded, "
+ "skipping VFIO support...
");
total: 1 errors, 24 warnings, 659 lines checked
/home/patchWorkOrg/patches/dpdk-dev-v3-11-16-vfio-move-global-vfio_cfg-to-eal_vfio.c.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
14535:
WARNING: line over 80 characters
#87: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:464:
+ * at this point, we know that this group is viable (meaning, all
+devices
WARNING: line over 80 characters
#145: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:564:
+ struct mapped_pci_res_list *vfio_res_list =
+RTE_TAILQ_CAST(rte_vfio_tailq.head, mapped_pci_res_list);
ERROR: do not use assignment in if condition
#159: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:578:
+ if ((ret = pci_vfio_setup_device(pci_addr, &vfio_dev_fd,
+&device_info)))
total: 1 errors, 2 warnings, 127 lines checked
/home/patchWorkOrg/patches/dpdk-dev-v3-10-16-vfio-extract-setup-logic-out-of-pci_vfio_map_resource.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass
DPDK STV team
More information about the test-report
mailing list