[dpdk-test-report] [PatchWork]|ERROR| pw13121-13127 pmdinfogen: Add buildtools and pmdinfogen utility

sys_stv at intel.com sys_stv at intel.com
Wed Jun 1 04:47:43 CEST 2016
Previous message: [dpdk-test-report] [PatchWork]|ERROR| pw13116-13120 app/test: categorize crypto AES test vectors into new file
Next message: [dpdk-test-report] [PatchWork]|SUCCESS| pw13132-13136 testpmd: add retry option
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13121-13127
http://www.dpdk.org/dev/patchwork/patch/13127/
Submitter: Neil Horman <nhorman at tuxdriver.com>
Date: Tue, 31 May 2016 09:57:42 -0400
DPDK git baseline: c8c33ad7f94c59d1c0676af0cfd61207b3e808db

Check patch error:
13121: 
ERROR: trailing whitespace
#174: FILE: buildtools/pmdinfogen/pmdinfogen.c:1:
+/* Postprocess pmd object files to export hw support $

ERROR: trailing whitespace
#242: FILE: buildtools/pmdinfogen/pmdinfogen.c:69:
+static Elf_Sym *find_sym_in_symtab(struct elf_info *info, $

ERROR: space required before the open parenthesis '('
#251: FILE: buildtools/pmdinfogen/pmdinfogen.c:78:
+for(; idx < info->symtab_stop; idx++) {

WARNING: line over 80 characters
#305: FILE: buildtools/pmdinfogen/pmdinfogen.c:132:
+fprintf(stderr, "section header offset=%lu in file '%s' is bigger than "

WARNING: quoted string split across lines
#306: FILE: buildtools/pmdinfogen/pmdinfogen.c:133:
+fprintf(stderr, "section header offset=%lu in file '%s' is bigger than "
+      "filesize=%lu
", (unsigned long)hdr->e_shoff,

ERROR: else should follow close brace '}'
#318: FILE: buildtools/pmdinfogen/pmdinfogen.c:145:
+}
+else {

WARNING: braces {} are not necessary for any arm of this statement
#321: FILE: buildtools/pmdinfogen/pmdinfogen.c:148:
+if (hdr->e_shstrndx == SHN_XINDEX) {
[...]
+else {
[...]

ERROR: else should follow close brace '}'
#324: FILE: buildtools/pmdinfogen/pmdinfogen.c:151:
+}
+else {

WARNING: line over 80 characters
#347: FILE: buildtools/pmdinfogen/pmdinfogen.c:174:
+fprintf(stderr, "%s is truncated. sechdrs[i].sh_offset=%lu > "

WARNING: quoted string split across lines
#348: FILE: buildtools/pmdinfogen/pmdinfogen.c:175:
+fprintf(stderr, "%s is truncated. sechdrs[i].sh_offset=%lu > "
+      "sizeof(*hrd)=%zu
", filename,

WARNING: line over 80 characters
#389: FILE: buildtools/pmdinfogen/pmdinfogen.c:216:
+fprintf(stderr, "%s: SYMTAB_SHNDX has bad sh_link: %u!=%u
",

ERROR: "foo* bar" should be "foo *bar"
#435: FILE: buildtools/pmdinfogen/pmdinfogen.c:262:
+const char* suffix;

ERROR: "foo* bar" should be "foo *bar"
#436: FILE: buildtools/pmdinfogen/pmdinfogen.c:263:
+const char* json_id;

ERROR: trailing whitespace
#449: FILE: buildtools/pmdinfogen/pmdinfogen.c:276:
+^I$

ERROR: spaces required around that '=' (ctx:VxV)
#453: FILE: buildtools/pmdinfogen/pmdinfogen.c:280:
+for (i=0; i<PMD_OPT_MAX; i++) {
      ^
  
  ERROR: spaces required around that '<' (ctx:VxV)
  #453: FILE: buildtools/pmdinfogen/pmdinfogen.c:280:
  +for (i=0; i<PMD_OPT_MAX; i++) {
           ^
   
   ERROR: code indent should use tabs where possible
   #469: FILE: buildtools/pmdinfogen/pmdinfogen.c:296:
   + ^I * If this returns NULL, then this is a PMD_VDEV, because$
   
   WARNING: please, no space before tabs
   #469: FILE: buildtools/pmdinfogen/pmdinfogen.c:296:
   + ^I * If this returns NULL, then this is a PMD_VDEV, because$
   
   ERROR: code indent should use tabs where possible
   #470: FILE: buildtools/pmdinfogen/pmdinfogen.c:297:
   + ^I * it has no pci table reference$
   
   WARNING: please, no space before tabs
   #470: FILE: buildtools/pmdinfogen/pmdinfogen.c:297:
   + ^I * it has no pci table reference$
   
   ERROR: code indent should use tabs where possible
   #471: FILE: buildtools/pmdinfogen/pmdinfogen.c:298:
   + ^I */$
   
   WARNING: please, no space before tabs
   #471: FILE: buildtools/pmdinfogen/pmdinfogen.c:298:
   + ^I */$
   
   WARNING: line over 80 characters
   #504: FILE: buildtools/pmdinfogen/pmdinfogen.c:331:
   +fprintf(stderr, "Failed to complete pmd entry
");
   
   WARNING: line over 80 characters
   #530: FILE: buildtools/pmdinfogen/pmdinfogen.c:357:
   +fprintf(ofd, "const char %s_pmd_info[] __attribute__((used)) = 
   +"PMD_INFO_STRING= {",
   
   ERROR: space required after that ',' (ctx:VxV)
   #532: FILE: buildtools/pmdinfogen/pmdinfogen.c:359:
   +fprintf(ofd,"\"name\" : \"%s\", ", drv->name);
           ^
   
   ERROR: spaces required around that '=' (ctx:VxV)
   #534: FILE: buildtools/pmdinfogen/pmdinfogen.c:361:
   +for(idx=0; idx<PMD_OPT_MAX; idx++) {
       ^
   
   ERROR: spaces required around that '<' (ctx:VxV)
   #534: FILE: buildtools/pmdinfogen/pmdinfogen.c:361:
   +for(idx=0; idx<PMD_OPT_MAX; idx++) {
              ^
  
  ERROR: space required before the open parenthesis '('
  #534: FILE: buildtools/pmdinfogen/pmdinfogen.c:361:
  +for(idx=0; idx<PMD_OPT_MAX; idx++) {
  
  WARNING: line over 80 characters
  #536: FILE: buildtools/pmdinfogen/pmdinfogen.c:363:
  +fprintf(ofd,"\"%s\" : \"%s\", ", opt_tags[idx].json_id,
  
  ERROR: space required after that ',' (ctx:VxV)
  #536: FILE: buildtools/pmdinfogen/pmdinfogen.c:363:
  +fprintf(ofd,"\"%s\" : \"%s\", ", opt_tags[idx].json_id,
           ^
   
   WARNING: line over 80 characters
   #567: FILE: buildtools/pmdinfogen/pmdinfogen.c:394:
   +fprintf(stderr, "usage: pmdinfo <object file> <c output file>
");
   
   WARNING: line over 80 characters
   #578: FILE: buildtools/pmdinfogen/pmdinfogen.c:405:
   +fprintf(stderr, "Hmm, Appears to be a driver but no drivers 
   +registered
");
   
   ERROR: "foo* bar" should be "foo *bar"
   #656: FILE: buildtools/pmdinfogen/pmdinfogen.h:67:
   +const char* opt_vals[PMD_OPT_MAX];
   
   total: 19 errors, 14 warnings, 753 lines checked
   
   NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
         scripts/cleanfile
 
 /home/patchWorkOrg/patches/dpdk-dev-PATCHv6-1-7-pmdinfogen-Add-buildtools-and-pmdinfogen-utility.patch has style problems, please review.
 
 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
 
 13122: 
 WARNING: Avoid line continuations in quoted strings
 #104: FILE: drivers/crypto/aesni_gcm/aesni_gcm_pmd.c:525:
 +DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs=<int>  
 WARNING: Avoid line continuations in quoted strings
 #116: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:720:
 +DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs=<int>  
 WARNING: Avoid line continuations in quoted strings
 #128: FILE: drivers/crypto/null/null_crypto_pmd.c:279:
 +DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs=<int>  
 WARNING: Avoid line continuations in quoted strings
 #152: FILE: drivers/crypto/snow3g/rte_snow3g_pmd.c:552:
 +DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs=<int>  
 WARNING: Avoid line continuations in quoted strings
 #164: FILE: drivers/net/af_packet/rte_eth_af_packet.c:882:
 +DRIVER_REGISTER_PARAM_STRING(eth_af_packet, "iface=<string>  
 WARNING: Avoid line continuations in quoted strings
 #191: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:2516:
 +DRIVER_REGISTER_PARAM_STRING(bonding, "slave=<ifc> primary=<ifc> 
 +mode=[0-4]  
 WARNING: Avoid line continuations in quoted strings
 #379: FILE: drivers/net/pcap/rte_eth_pcap.c:1094:
 +DRIVER_REGISTER_PARAM_STRING(pcap, "rx_pcap=<string> tx_pcap=<string>  
 ERROR: Macros with complex values should be enclosed in parenthesis
 #480: FILE: lib/librte_eal/common/include/rte_dev.h:181:
 +#define DRIVER_EXPORT_NAME_ARRAY(n, idx) n##idx[] __attribute__((used))
 
 ERROR: trailing whitespace
 #484: FILE: lib/librte_eal/common/include/rte_dev.h:185:
 + $
 
 WARNING: please, no spaces at the start of a line
 #484: FILE: lib/librte_eal/common/include/rte_dev.h:185:
 + $
 
 ERROR: code indent should use tabs where possible
 #492: FILE: lib/librte_eal/common/include/rte_dev.h:191:
 +        rte_eal_driver_register(&drv);\$
 
 WARNING: please, no spaces at the start of a line
 #492: FILE: lib/librte_eal/common/include/rte_dev.h:191:
 +        rte_eal_driver_register(&drv);\$
 
 ERROR: space required after that close brace '}'
 #493: FILE: lib/librte_eal/common/include/rte_dev.h:192:
 +} 
 WARNING: line over 80 characters
 #499: FILE: lib/librte_eal/common/include/rte_dev.h:198:
 +static const char DRV_EXP_TAG(name, pci_tbl_export)[] 
 +__attribute__((used)) = RTE_STR(table)
 
 WARNING: line over 80 characters
 #502: FILE: lib/librte_eal/common/include/rte_dev.h:201:
 +static const char DRV_EXP_TAG(name, param_string_export)[] 
 +__attribute__((used)) = str
 
 total: 4 errors, 11 warnings, 262 lines checked
 
 NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
       scripts/cleanfile
   
   /home/patchWorkOrg/patches/dpdk-dev-PATCHv6-2-7-drivers-Update-driver-registration-macro-usage.patch has style problems, please review.
   
   If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
   
   13123: 
   ERROR: trailing whitespace
   #47: FILE: lib/librte_eal/common/eal_common_options.c:119:
   + * Stringified version of solib path used by pmdinfo.py $
   
   WARNING: Avoid unnecessary line continuations
   #51: FILE: lib/librte_eal/common/eal_common_options.c:123:
   +static const char dpdk_solib_path[] __attribute__((used)) =    
   total: 1 errors, 1 warnings, 15 lines checked
   
   NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
         scripts/cleanfile
 
 /home/patchWorkOrg/patches/dpdk-dev-PATCHv6-3-7-eal-Add-an-export-symbol-to-expose-the-autoload-path-to-external-tools.patch has style problems, please review.
 
 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
 
 13127: 
 ERROR: trailing whitespace
 #49: FILE: doc/guides/prog_guide/dev_kit_build_system.rst:267:
 +*   rte.buildtools.mk: prerequisite tool to build dpdk $
 
 ERROR: trailing whitespace
 #70: FILE: doc/guides/prog_guide/dev_kit_build_system.rst:320:
 +.. code-block:: c $
 
 ERROR: trailing whitespace
 #77: FILE: doc/guides/prog_guide/dev_kit_build_system.rst:327:
 +.. code-block:: c $
 
 total: 3 errors, 0 warnings, 61 lines checked
 
 NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
       scripts/cleanfile
   
   /home/patchWorkOrg/patches/dpdk-dev-PATCHv6-7-7-doc-Add-prog_guide-section-documenting-pmdinfo-script.patch has style problems, please review.
   
   If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
   
   
   Compilation:
   OS: fedora
   Nic: niantic
   GCC: gcc_x86-64, 4.8.3
   ICC:16.0.2
   i686-native-linuxapp-icc: compile pass
   x86_64-native-linuxapp-gcc-combined: compile pass
   i686-native-linuxapp-gcc: compile pass
   x86_64-native-linuxapp-gcc: compile pass
   x86_64-native-linuxapp-icc: compile pass
   x86_64-native-linuxapp-gcc-debug: compile pass
   x86_64-native-linuxapp-gcc-shared: compile pass
   x86_64-native-linuxapp-clang: compile pass
   
   
   
   DPDK STV team
Previous message: [dpdk-test-report] [PatchWork]|ERROR| pw13116-13120 app/test: categorize crypto AES test vectors into new file
Next message: [dpdk-test-report] [PatchWork]|SUCCESS| pw13132-13136 testpmd: add retry option
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list