[dpdk-test-report] [PatchWork]|ERROR| pw13386-13388 lpm6 speed inmprovement on delete rule

sys_stv at intel.com sys_stv at intel.com
Sun Jun 12 05:03:52 CEST 2016


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13386-13388
http://www.dpdk.org/dev/patchwork/patch/13388/
Submitter: Nikita Kozlov <nikita at elyzion.net>
Date: Thu,  9 Jun 2016 02:53:52 +0200
DPDK git baseline: b3c64b7de8d5a40053c00625ddda4c02b8d12d94

Check patch error:
13386: 
ERROR: do not use C99 // comments
#193: FILE: app/test/test_lpm6.c:552:
+//use 13 tlb8

ERROR: do not use C99 // comments
#201: FILE: app/test/test_lpm6.c:560:
+//14

ERROR: do not use C99 // comments
#216: FILE: app/test/test_lpm6.c:575:
+//15

ERROR: do not use C99 // comments
#230: FILE: app/test/test_lpm6.c:589:
+//16

ERROR: do not use C99 // comments
#244: FILE: app/test/test_lpm6.c:603:
+//17

ERROR: do not use C99 // comments
#249: FILE: app/test/test_lpm6.c:608:
+//16

total: 6 errors, 0 warnings, 472 lines checked

/home/patchWorkOrg/patches/dpdk-dev-3-3-test_lpm6-make-test_lpm6-compatible-with-the-new-rte_lpm6.c-lib.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

13387: 
WARNING: line over 80 characters
#91: FILE: lib/librte_lpm/rte_lpm6.c:114:
+RB_HEAD(rte_lpm6_rules_tree, rte_lpm6_rule) rules[RTE_LPM6_MAX_DEPTH + 
+1];

ERROR: Macros with complex values should be enclosed in parenthesis
#114: FILE: lib/librte_lpm/rte_lpm6.c:136:
+#define __unused __attribute__ ((unused))

WARNING: line over 80 characters
#253: FILE: lib/librte_lpm/rte_lpm6.c:352:
+tbl8_entry = &tbl8[tbl8_gindex * RTE_LPM6_TBL8_GROUP_NUM_ENTRIES];

WARNING: braces {} are not necessary for single statement blocks
#398: FILE: lib/librte_lpm/rte_lpm6.c:527:
+if (tbl8_gindex < 0) {
return -ENOSPC;
+}

WARNING: braces {} are not necessary for single statement blocks
#456: FILE: lib/librte_lpm/rte_lpm6.c:601:
+if (rule == NULL) {
+return -EINVAL;
}

ERROR: "(foo*)" should be "(foo *)"
#506: FILE: lib/librte_lpm/rte_lpm6.c:672:
+return rte_lpm6_lookup_v1607(lpm, ip, (uint16_t*)next_hop);

WARNING: line over 80 characters
#514: FILE: lib/librte_lpm/rte_lpm6.c:679:
+rte_lpm6_lookup_v1607(const struct rte_lpm6 *lpm, uint8_t *ip, uint16_t 
+*next_hop)

WARNING: line over 80 characters
#531: FILE: lib/librte_lpm/rte_lpm6.c:715:
+return rte_lpm6_lookup_bulk_func_v1607(lpm, ips, (int32_t*)next_hops, 
+n);

ERROR: "(foo*)" should be "(foo *)"
#531: FILE: lib/librte_lpm/rte_lpm6.c:715:
+return rte_lpm6_lookup_bulk_func_v1607(lpm, ips, (int32_t*)next_hops, 
+n);

WARNING: line over 80 characters
#560: FILE: lib/librte_lpm/rte_lpm6.c:764:
+MAP_STATIC_SYMBOL(int rte_lpm6_lookup_bulk_func(const struct rte_lpm6 
+*lpm, uint8_t ips[][RTE_LPM6_IPV6_ADDR_SIZE],

WARNING: line over 80 characters
#561: FILE: lib/librte_lpm/rte_lpm6.c:765:
+int32_t *next_hops, unsigned n), rte_lpm6_lookup_bulk_func_v1607);

WARNING: line over 80 characters
#617: FILE: lib/librte_lpm/rte_lpm6.c:809:
+return rte_lpm6_is_rule_present_v1607(lpm, ip, depth, 
+(uint16_t*)next_hop);

ERROR: "(foo*)" should be "(foo *)"
#617: FILE: lib/librte_lpm/rte_lpm6.c:809:
+return rte_lpm6_is_rule_present_v1607(lpm, ip, depth, 
+(uint16_t*)next_hop);

WARNING: line over 80 characters
#658: FILE: lib/librte_lpm/rte_lpm6.c:843:
+MAP_STATIC_SYMBOL(int rte_lpm6_is_rule_present(struct rte_lpm6 *lpm, 
+uint8_t *ip,

WARNING: line over 80 characters
#659: FILE: lib/librte_lpm/rte_lpm6.c:844:
+uint8_t depth, uint16_t *next_hop), rte_lpm6_is_rule_present_v1607);

WARNING: line over 80 characters
#707: FILE: lib/librte_lpm/rte_lpm6.c:884:
+&& lpm->tbl8[j].depth == depth && lpm->tbl8[j].next_hop == 
+next_hop) {

WARNING: line over 80 characters
#715: FILE: lib/librte_lpm/rte_lpm6.c:892:
+delete_expand_step(lpm, tbl8_gindex_next, depth, next_hop);

WARNING: line over 80 characters
#726: FILE: lib/librte_lpm/rte_lpm6.c:903:
+uint8_t *ip, uint32_t tbl_group_start, struct rte_lpm6_rule 
+*sub_rule, uint8_t depth, uint8_t bits_covered, uint16_t next_hop)

WARNING: line over 80 characters
#739: FILE: lib/librte_lpm/rte_lpm6.c:916:
+/* recurse until we are at the last tbl8 that should have been deleted 
+for this rule without an expand */

WARNING: line over 80 characters
#746: FILE: lib/librte_lpm/rte_lpm6.c:923:
+tbl_group_next = tbl[tbl_index].lpm6_tbl8_gindex * 
+RTE_LPM6_TBL8_GROUP_NUM_ENTRIES;

WARNING: line over 80 characters
#747: FILE: lib/librte_lpm/rte_lpm6.c:924:
+delete_step(lpm, lpm->tbl8, ip, tbl_group_next, sub_rule, depth, 
+bits_covered + 8, next_hop);

WARNING: line over 80 characters
#752: FILE: lib/librte_lpm/rte_lpm6.c:929:
+/* last iteration, we may need to remove what we have done through 
+the expand */

WARNING: line over 80 characters
#758: FILE: lib/librte_lpm/rte_lpm6.c:935:
+delete_expand_step(lpm, tbl8_gindex, depth, next_hop);

WARNING: line over 80 characters
#764: FILE: lib/librte_lpm/rte_lpm6.c:941:
+tbl[i].next_hop = sub_rule->next_hop;

WARNING: line over 80 characters
#774: FILE: lib/librte_lpm/rte_lpm6.c:951:
+/* check if we can recycle the current tbl_entry because we have 
+cleaned all its childs  */

WARNING: line over 80 characters
#776: FILE: lib/librte_lpm/rte_lpm6.c:953:
+if (tbl8_is_free(lpm->tbl8, tbl[tbl_index].lpm6_tbl8_gindex * 
+RTE_LPM6_TBL8_GROUP_NUM_ENTRIES)) {

WARNING: braces {} are not necessary for single statement blocks
#776: FILE: lib/librte_lpm/rte_lpm6.c:953:
+if (tbl8_is_free(lpm->tbl8, tbl[tbl_index].lpm6_tbl8_gindex * RTE_LPM6_TBL8_GROUP_NUM_ENTRIES)) {
+tbl[tbl_index] = empty_tbl8_entry;
+}

WARNING: line over 80 characters
#781: FILE: lib/librte_lpm/rte_lpm6.c:958:
+/* we are recursing on the tbl24 so we don't need to check those cases 
+*/

WARNING: braces {} are not necessary for single statement blocks
#782: FILE: lib/librte_lpm/rte_lpm6.c:959:
+if (bits_covered == 24) {
+return;
+}

WARNING: line over 80 characters
#786: FILE: lib/librte_lpm/rte_lpm6.c:963:
+/* try to clean our current tbl group from tbl_group_start to 
+tbl_group_end */

WARNING: line over 80 characters
#787: FILE: lib/librte_lpm/rte_lpm6.c:964:
+for (i = tbl_group_start; i < tbl_group_start + 
+RTE_LPM6_TBL8_GROUP_NUM_ENTRIES; i++) {

WARNING: braces {} are not necessary for single statement blocks
#788: FILE: lib/librte_lpm/rte_lpm6.c:965:
+if (tbl[i].valid == 1) {
+break;
+}

WARNING: line over 80 characters
#804: FILE: lib/librte_lpm/rte_lpm6.c:981:
+rule_replace(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth, uint16_t 
+next_hop)

WARNING: line over 80 characters
#819: FILE: lib/librte_lpm/rte_lpm6.c:996:
+delete_step(lpm, lpm->tbl24, ip_masked, tbl_index, sub_rule, depth, 
+24, next_hop);

WARNING: space prohibited before semicolon
#983: FILE: lib/librte_lpm/rte_lpm6.c:1126:
+for (i = 0; i < lpm->number_tbl8s ; i++) {

WARNING: line over 80 characters
#1048: FILE: lib/librte_lpm/rte_lpm6.h:217:
+rte_lpm6_lookup_v1607(const struct rte_lpm6 *lpm, uint8_t *ip, uint16_t 
+*next_hop);

total: 4 errors, 32 warnings, 1008 lines checked

/home/patchWorkOrg/patches/dpdk-dev-1-3-lpm6-speed-inmprovement-on-delete-rule.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

13388: 
ERROR: Macros with complex values should be enclosed in parenthesis
#125: FILE: lib/librte_eal/common/include/sys/tree.h:80:
+#define SPLAY_LEFT(elm, field)(elm)->field.spe_left

ERROR: Macros with complex values should be enclosed in parenthesis
#126: FILE: lib/librte_eal/common/include/sys/tree.h:81:
+#define SPLAY_RIGHT(elm, field)(elm)->field.spe_right

ERROR: Macros with complex values should be enclosed in parenthesis
#127: FILE: lib/librte_eal/common/include/sys/tree.h:82:
+#define SPLAY_ROOT(head)(head)->sph_root

ERROR: trailing whitespace
#136: FILE: lib/librte_eal/common/include/sys/tree.h:91:
+^I$

WARNING: plain inline is preferred over __inline
#171: FILE: lib/librte_eal/common/include/sys/tree.h:126:
+static __inline struct type *
ERROR: return is not a function, parentheses are not required
#175: FILE: lib/librte_eal/common/include/sys/tree.h:130:
+return(NULL);
ERROR: return is not a function, parentheses are not required
#178: FILE: lib/librte_eal/common/include/sys/tree.h:133:
+return (head->sph_root);
ERROR: return is not a function, parentheses are not required
#179: FILE: lib/librte_eal/common/include/sys/tree.h:134:
+return (NULL);
WARNING: plain inline is preferred over __inline
#182: FILE: lib/librte_eal/common/include/sys/tree.h:137:
+static __inline struct type *
ERROR: return is not a function, parentheses are not required
#193: FILE: lib/librte_eal/common/include/sys/tree.h:148:
+return (elm);
WARNING: plain inline is preferred over __inline
#196: FILE: lib/librte_eal/common/include/sys/tree.h:151:
+static __inline struct type *
ERROR: code indent should use tabs where possible
#200: FILE: lib/librte_eal/common/include/sys/tree.h:155:
+        return (SPLAY_ROOT(head));^I^I^I^I^I\$

WARNING: please, no spaces at the start of a line
#200: FILE: lib/librte_eal/common/include/sys/tree.h:155:
+        return (SPLAY_ROOT(head));^I^I^I^I^I\$

ERROR: return is not a function, parentheses are not required
#200: FILE: lib/librte_eal/common/include/sys/tree.h:155:
+        return (SPLAY_ROOT(head));
WARNING: please, no spaces at the start of a line
#210: FILE: lib/librte_eal/common/include/sys/tree.h:165:
+    if (SPLAY_EMPTY(head)) {^I^I^I^I^I^I\$

WARNING: suspect code indent for conditional statements (4, 12)
#210: FILE: lib/librte_eal/common/include/sys/tree.h:165:
+    if (SPLAY_EMPTY(head)) {+    SPLAY_LEFT(elm, field) = SPLAY_RIGHT(elm, field) = NULL;
WARNING: please, no spaces at the start of a line
#212: FILE: lib/librte_eal/common/include/sys/tree.h:167:
+    } else {^I^I^I^I^I^I^I^I\$

WARNING: suspect code indent for conditional statements (12, 20)
#216: FILE: lib/librte_eal/common/include/sys/tree.h:171:
+    if(__comp < 0) {+    SPLAY_LEFT(elm, field) = SPLAY_LEFT((head)->sph_root, field);
ERROR: space required before the open parenthesis '('
#216: FILE: lib/librte_eal/common/include/sys/tree.h:171:
+    if(__comp < 0) {
WARNING: line over 80 characters
#217: FILE: lib/librte_eal/common/include/sys/tree.h:172:
+    SPLAY_LEFT(elm, field) = SPLAY_LEFT((head)->sph_root, field);
WARNING: suspect code indent for conditional statements (12, 20)
#220: FILE: lib/librte_eal/common/include/sys/tree.h:175:
+    } else if (__comp > 0) {+    SPLAY_RIGHT(elm, field) = SPLAY_RIGHT((head)->sph_root, field);
WARNING: line over 80 characters
#221: FILE: lib/librte_eal/common/include/sys/tree.h:176:
+    SPLAY_RIGHT(elm, field) = SPLAY_RIGHT((head)->sph_root, field);
ERROR: return is not a function, parentheses are not required
#225: FILE: lib/librte_eal/common/include/sys/tree.h:180:
+    return ((head)->sph_root);
WARNING: please, no spaces at the start of a line
#226: FILE: lib/librte_eal/common/include/sys/tree.h:181:
+    }^I^I^I^I^I^I^I^I^I\$

WARNING: please, no spaces at the start of a line
#227: FILE: lib/librte_eal/common/include/sys/tree.h:182:
+    (head)->sph_root = (elm);^I^I^I^I^I^I\$

WARNING: please, no spaces at the start of a line
#228: FILE: lib/librte_eal/common/include/sys/tree.h:183:
+    return (NULL);^I^I^I^I^I^I^I\$

ERROR: return is not a function, parentheses are not required
#228: FILE: lib/librte_eal/common/include/sys/tree.h:183:
+    return (NULL);
ERROR: return is not a function, parentheses are not required
#236: FILE: lib/librte_eal/common/include/sys/tree.h:191:
+return (NULL);
WARNING: line over 80 characters
#240: FILE: lib/librte_eal/common/include/sys/tree.h:195:
+(head)->sph_root = SPLAY_RIGHT((head)->sph_root, field);
ERROR: return is not a function, parentheses are not required
#247: FILE: lib/librte_eal/common/include/sys/tree.h:202:
+return (elm);
ERROR: return is not a function, parentheses are not required
#249: FILE: lib/librte_eal/common/include/sys/tree.h:204:
+return (NULL);
ERROR: space required before the open brace '{'
#266: FILE: lib/librte_eal/common/include/sys/tree.h:221:
+if ((cmp)(elm, __tmp) < 0){
WARNING: line over 80 characters
#268: FILE: lib/librte_eal/common/include/sys/tree.h:223:
+if (SPLAY_LEFT((head)->sph_root, field) == NULL)
ERROR: space required before the open brace '{'
#276: FILE: lib/librte_eal/common/include/sys/tree.h:231:
+if ((cmp)(elm, __tmp) > 0){
WARNING: line over 80 characters
#278: FILE: lib/librte_eal/common/include/sys/tree.h:233:
+if (SPLAY_RIGHT((head)->sph_root, field) == NULL)
WARNING: Avoid unnecessary line continuations
#289: FILE: lib/librte_eal/common/include/sys/tree.h:244:
+ */
ERROR: space required before the open brace '{'
#302: FILE: lib/librte_eal/common/include/sys/tree.h:257:
+if (__comp < 0){
WARNING: line over 80 characters
#304: FILE: lib/librte_eal/common/include/sys/tree.h:259:
+if (SPLAY_LEFT((head)->sph_root, field) == NULL)
WARNING: line over 80 characters
#314: FILE: lib/librte_eal/common/include/sys/tree.h:269:
+if (SPLAY_RIGHT((head)->sph_root, field) == NULL)
ERROR: Macros with complex values should be enclosed in parenthesis
#363: FILE: lib/librte_eal/common/include/sys/tree.h:318:
+#define RB_LEFT(elm, field)(elm)->field.rbe_left

ERROR: Macros with complex values should be enclosed in parenthesis
#364: FILE: lib/librte_eal/common/include/sys/tree.h:319:
+#define RB_RIGHT(elm, field)(elm)->field.rbe_right

ERROR: Macros with complex values should be enclosed in parenthesis
#365: FILE: lib/librte_eal/common/include/sys/tree.h:320:
+#define RB_PARENT(elm, field)(elm)->field.rbe_parent

ERROR: Macros with complex values should be enclosed in parenthesis
#366: FILE: lib/librte_eal/common/include/sys/tree.h:321:
+#define RB_COLOR(elm, field)(elm)->field.rbe_color

ERROR: Macros with complex values should be enclosed in parenthesis
#367: FILE: lib/librte_eal/common/include/sys/tree.h:322:
+#define RB_ROOT(head)(head)->rbh_root

ERROR: do not use assignment in if condition
#387: FILE: lib/librte_eal/common/include/sys/tree.h:342:
+if ((RB_RIGHT(elm, field) = RB_LEFT(tmp, field)) != NULL) {
ERROR: do not use assignment in if condition
#391: FILE: lib/librte_eal/common/include/sys/tree.h:346:
+if ((RB_PARENT(tmp, field) = RB_PARENT(elm, field)) != NULL) {
ERROR: do not use assignment in if condition
#407: FILE: lib/librte_eal/common/include/sys/tree.h:362:
+if ((RB_LEFT(elm, field) = RB_RIGHT(tmp, field)) != NULL) {
ERROR: do not use assignment in if condition
#411: FILE: lib/librte_eal/common/include/sys/tree.h:366:
+if ((RB_PARENT(tmp, field) = RB_PARENT(elm, field)) != NULL) {
ERROR: space required after that ',' (ctx:VxB)
#427: FILE: lib/librte_eal/common/include/sys/tree.h:382:
+RB_PROTOTYPE_INTERNAL(name, type, field, cmp,)
                                            ^

WARNING: storage class should be at the beginning of the declaration
#429: FILE: lib/librte_eal/common/include/sys/tree.h:384:
+RB_PROTOTYPE_INTERNAL(name, type, field, cmp, __unused static)

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#430: FILE: lib/librte_eal/common/include/sys/tree.h:385:
+#define RB_PROTOTYPE_INTERNAL(name, type, field, cmp, attr)+RB_PROTOTYPE_INSERT_COLOR(name, type, attr);+RB_PROTOTYPE_REMOVE_COLOR(name, type, attr);+RB_PROTOTYPE_INSERT(name, type, attr);+RB_PROTOTYPE_REMOVE(name, type, attr);+RB_PROTOTYPE_FIND(name, type, attr);+RB_PROTOTYPE_NFIND(name, type, attr);+RB_PROTOTYPE_NEXT(name, type, attr);+RB_PROTOTYPE_PREV(name, type, attr);+RB_PROTOTYPE_MINMAX(name, type, attr);

WARNING: line over 80 characters
#443: FILE: lib/librte_eal/common/include/sys/tree.h:398:
+attr void name##_RB_REMOVE_COLOR(struct name *, struct type *, struct 
+type *)

ERROR: space required after that ',' (ctx:VxB)
#463: FILE: lib/librte_eal/common/include/sys/tree.h:418:
+RB_GENERATE_INTERNAL(name, type, field, cmp,)
                                           ^
   
   WARNING: storage class should be at the beginning of the declaration
   #465: FILE: lib/librte_eal/common/include/sys/tree.h:420:
   +RB_GENERATE_INTERNAL(name, type, field, cmp, __unused static)
   
   ERROR: Macros with complex values should be enclosed in parenthesis
   #466: FILE: lib/librte_eal/common/include/sys/tree.h:421:
   +#define RB_GENERATE_INTERNAL(name, type, field, cmp, attr)   +RB_GENERATE_INSERT_COLOR(name, type, field, attr)   +RB_GENERATE_REMOVE_COLOR(name, type, field, attr)   +RB_GENERATE_INSERT(name, type, field, cmp, attr)   +RB_GENERATE_REMOVE(name, type, field, attr)   +RB_GENERATE_FIND(name, type, field, cmp, attr)   +RB_GENERATE_NFIND(name, type, field, cmp, attr)   +RB_GENERATE_NEXT(name, type, field, attr)   +RB_GENERATE_PREV(name, type, field, attr)   +RB_GENERATE_MINMAX(name, type, field, attr)
   
   WARNING: line over 80 characters
   #524: FILE: lib/librte_eal/common/include/sys/tree.h:479:
   +name##_RB_REMOVE_COLOR(struct name *head, struct type *parent, struct 
   +type *elm)    
   WARNING: line over 80 characters
   #537: FILE: lib/librte_eal/common/include/sys/tree.h:492:
   +    RB_COLOR(RB_LEFT(tmp, field), field) == RB_BLACK) &&   
   WARNING: line over 80 characters
   #539: FILE: lib/librte_eal/common/include/sys/tree.h:494:
   +    RB_COLOR(RB_RIGHT(tmp, field), field) == RB_BLACK)) {   
   WARNING: line over 80 characters
   #545: FILE: lib/librte_eal/common/include/sys/tree.h:500:
   +    RB_COLOR(RB_RIGHT(tmp, field), field) == RB_BLACK) {   
   ERROR: do not use assignment in if condition
   #547: FILE: lib/librte_eal/common/include/sys/tree.h:502:
   +if ((oleft = RB_LEFT(tmp, field))    
   WARNING: line over 80 characters
   #549: FILE: lib/librte_eal/common/include/sys/tree.h:504:
   +RB_COLOR(oleft, field) = RB_BLACK;   
   WARNING: line over 80 characters
   #551: FILE: lib/librte_eal/common/include/sys/tree.h:506:
   +RB_ROTATE_RIGHT(head, tmp, oleft, field);   
   WARNING: line over 80 characters
   #557: FILE: lib/librte_eal/common/include/sys/tree.h:512:
   +RB_COLOR(RB_RIGHT(tmp, field), field) = RB_BLACK;   
   WARNING: line over 80 characters
   #570: FILE: lib/librte_eal/common/include/sys/tree.h:525:
   +    RB_COLOR(RB_LEFT(tmp, field), field) == RB_BLACK) &&   
   WARNING: line over 80 characters
   #572: FILE: lib/librte_eal/common/include/sys/tree.h:527:
   +    RB_COLOR(RB_RIGHT(tmp, field), field) == RB_BLACK)) {   
   WARNING: line over 80 characters
   #578: FILE: lib/librte_eal/common/include/sys/tree.h:533:
   +    RB_COLOR(RB_LEFT(tmp, field), field) == RB_BLACK) {   
   ERROR: do not use assignment in if condition
   #580: FILE: lib/librte_eal/common/include/sys/tree.h:535:
   +if ((oright = RB_RIGHT(tmp, field))    
   WARNING: line over 80 characters
   #582: FILE: lib/librte_eal/common/include/sys/tree.h:537:
   +RB_COLOR(oright, field) = RB_BLACK;   
   WARNING: line over 80 characters
   #584: FILE: lib/librte_eal/common/include/sys/tree.h:539:
   +RB_ROTATE_LEFT(head, tmp, oright, field);   
   WARNING: line over 80 characters
   #590: FILE: lib/librte_eal/common/include/sys/tree.h:545:
   +RB_COLOR(RB_LEFT(tmp, field), field) = RB_BLACK;   
   ERROR: return is not a function, parentheses are not required
   #666: FILE: lib/librte_eal/common/include/sys/tree.h:621:
   +return (old);   
   ERROR: return is not a function, parentheses are not required
   #686: FILE: lib/librte_eal/common/include/sys/tree.h:641:
   +return (tmp);   
   ERROR: return is not a function, parentheses are not required
   #698: FILE: lib/librte_eal/common/include/sys/tree.h:653:
   +return (NULL);   
   ERROR: return is not a function, parentheses are not required
   #715: FILE: lib/librte_eal/common/include/sys/tree.h:670:
   +return (tmp);   
   ERROR: return is not a function, parentheses are not required
   #717: FILE: lib/librte_eal/common/include/sys/tree.h:672:
   +return (NULL);   
   ERROR: return is not a function, parentheses are not required
   #737: FILE: lib/librte_eal/common/include/sys/tree.h:692:
   +return (tmp);   
   ERROR: return is not a function, parentheses are not required
   #739: FILE: lib/librte_eal/common/include/sys/tree.h:694:
   +return (res);   
   ERROR: return is not a function, parentheses are not required
   #762: FILE: lib/librte_eal/common/include/sys/tree.h:717:
   +return (elm);   
   ERROR: return is not a function, parentheses are not required
   #785: FILE: lib/librte_eal/common/include/sys/tree.h:740:
   +return (elm);   
   ERROR: return is not a function, parentheses are not required
   #801: FILE: lib/librte_eal/common/include/sys/tree.h:756:
   +return (parent);   
   total: 44 errors, 36 warnings, 809 lines checked
   
   NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
         scripts/cleanfile
 
 /home/patchWorkOrg/patches/dpdk-dev-2-3-librte_eal-Import-FreeBSD-sys-tree.h-into-librte_eal-common.patch has style problems, please review.
 
 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
 
 
 Compilation:
 OS: fedora
 Nic: niantic
 GCC: gcc_x86-64, 4.8.3
 ICC:16.0.2
 i686-native-linuxapp-icc: compile pass
 x86_64-native-linuxapp-gcc-combined: compile pass
 i686-native-linuxapp-gcc: compile pass
 x86_64-native-linuxapp-gcc: compile pass
 x86_64-native-linuxapp-icc: compile pass
 x86_64-native-linuxapp-gcc-debug: compile pass
 x86_64-native-linuxapp-gcc-shared: compile pass
 x86_64-native-linuxapp-clang: compile pass
 
 
 
 DPDK STV team 
 


More information about the test-report mailing list