[dpdk-test-report] [PatchWork]|ERROR| pw12488-12519 eal: make enum rte_kernel_driver non-PCI specific

sys_stv at intel.com sys_stv at intel.com
Wed May 11 05:28:50 CEST 2016
Previous message: [dpdk-test-report] [PatchWork]|ERROR| pw12484-12487 test: add lpm routes as a linked resource
Next message: [dpdk-test-report] [PatchWork]|ERROR| pw12508-12511 kasumi: add new KASUMI PMD
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 12488-12519
http://www.dpdk.org/dev/patchwork/patch/12519/
Submitter: Jan Viktorin <viktorin at rehivetech.com>
Date: Fri,  6 May 2016 15:47:43 +0200
DPDK git baseline: 84c9b5a9fe926f1aa033dc5352be8d4a5e0b789d

Check patch error:
12512: 
ERROR: code indent should use tabs where possible
#85: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:57:
+^I         soc_get_sysfs_path(), dev->addr.name);$

total: 1 errors, 0 warnings, 51 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

  /home/patchWorkOrg/patches/dpdk-dev-v1-21-28-eal-soc-unbind-kernel-driver-on-probe.patch has style problems, please review.

  If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

  12513: 
  ERROR: do not use assignment in if condition
  #106: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:342:
  +if ((f = fopen(filename, "r")) == NULL) {

  WARNING: braces {} are not necessary for single statement blocks
  #106: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:342:
  +if ((f = fopen(filename, "r")) == NULL) {
  +return 0;
  +}

  ERROR: spaces required around that '?' (ctx:VxW)
  #123: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:396:
  +dev->is_dma_coherent? "coherent" : "non-coherent");
                    ^

total: 2 errors, 1 warnings, 71 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v1-22-28-eal-soc-detect-DMA-non-coherent-devices.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

12489: 
ERROR: else should follow close brace '}'
#103: FILE: lib/librte_eal/linuxapp/eal/eal.c:165:
}
+else if (ret < 0) {

total: 1 errors, 0 warnings, 74 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v1-02-28-eal-extract-function-eal_parse_sysfs_valuef.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

12490: 
ERROR: code indent should use tabs where possible
#72: FILE: lib/librte_eal/linuxapp/eal/eal.c:960:
+^I         "%s/driver/unbind", devpath);$

ERROR: code indent should use tabs where possible
#110: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:68:
+^I         SYSFS_PCI_DEVICES "/" PCI_PRI_FMT,$

total: 2 errors, 0 warnings, 95 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

  /home/patchWorkOrg/patches/dpdk-dev-v1-03-28-eal-linux-extract-function-rte_eal_unbind_kernel_driver.patch has style problems, please review.

  If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

  12493: 
  ERROR: code indent should use tabs where possible
  #311: FILE: lib/librte_eal/common/include/rte_soc.h:123:
  +                         const struct rte_soc_addr *a1)$

  WARNING: please, no spaces at the start of a line
  #311: FILE: lib/librte_eal/common/include/rte_soc.h:123:
  +                         const struct rte_soc_addr *a1)$

  total: 1 errors, 1 warnings, 258 lines checked

  NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
        scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-v1-06-28-eal-soc-introduce-very-essential-SoC-infra-definitions.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

12495: 
ERROR: spaces required around that '?' (ctx:VxW)
#149: FILE: lib/librte_eal/common/eal_common_soc.c:69:
+dev->addr.fdt_path? dev->addr.fdt_path : "(none)");
                  ^

  WARNING: line over 80 characters
  #299: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:78:
  +RTE_LOG(ERR, EAL, "Failed to alloc memory to read %s
", filename);

  ERROR: space required before the open parenthesis '('
  #349: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:128:
  +} while(p - uevent < (ptrdiff_t) total);

  ERROR: do not use assignment in if condition
  #436: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:215:
  +if ((ret = dev_parse_uevent(dev, uevent)))

  total: 3 errors, 1 warnings, 442 lines checked

  /home/patchWorkOrg/patches/dpdk-dev-v1-08-28-eal-soc-implement-SoC-device-discovery.patch has style problems, please review.

  If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

  12501: 
  WARNING: line over 80 characters
  #71: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:193:
  +RTE_LOG(ERR, EAL, "Fail to get kernel driver for %s
", dirname);

  WARNING: braces {} are not necessary for any arm of this statement
  #75: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:197:
  +if (!ret) {
  [...]
  +} else {
  [...]

  ERROR: do not use assignment in if condition
  #91: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:244:
  +if ((ret = dev_setup_associated_driver(dev, dirname)))

  total: 1 errors, 2 warnings, 60 lines checked

  /home/patchWorkOrg/patches/dpdk-dev-v1-14-28-eal-soc-detect-assigned-kernel-driver.patch has style problems, please review.

  If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

  12505: 
  ERROR: do not use assignment in if condition
  #95: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:309:
  +if ((f = fopen(filename, "r")) != NULL) {

  ERROR: do not use assignment in if condition
  #113: FILE: lib/librte_eal/linuxapp/eal/eal_soc.c:361:
  +if ((ret = dev_setup_numa_node(dev, dirname)) < 0)

  total: 2 errors, 0 warnings, 71 lines checked

  /home/patchWorkOrg/patches/dpdk-dev-v1-18-28-eal-soc-detect-numa_node-of-the-rte_soc_device.patch has style problems, please review.

  If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


  patch file error:
  12488: 
  patching file lib/librte_eal/common/include/rte_dev.h
  patching file lib/librte_eal/common/include/rte_pci.h
  Hunk #1 FAILED at 83.
  Hunk #2 succeeded at 143 (offset -2 lines).
  1 out of 2 hunks FAILED -- saving rejects to file lib/librte_eal/common/include/rte_pci.h.rej

  12494: 
  patching file app/test/test_soc.c
  patching file lib/librte_eal/bsdapp/eal/Makefile
  patching file lib/librte_eal/bsdapp/eal/rte_eal_version.map
  Hunk #1 FAILED at 158.
  1 out of 1 hunk FAILED -- saving rejects to file lib/librte_eal/bsdapp/eal/rte_eal_version.map.rej
  patching file lib/librte_eal/common/eal_common_soc.c
  patching file lib/librte_eal/common/include/rte_soc.h
  patching file lib/librte_eal/linuxapp/eal/Makefile
  patching file lib/librte_eal/linuxapp/eal/rte_eal_version.map
  Hunk #1 FAILED at 161.
  1 out of 1 hunk FAILED -- saving rejects to file lib/librte_eal/linuxapp/eal/rte_eal_version.map.rej

  12495: 
  patching file lib/librte_eal/bsdapp/eal/Makefile
  patching file lib/librte_eal/bsdapp/eal/eal_soc.c
  patching file lib/librte_eal/bsdapp/eal/rte_eal_version.map
  Hunk #1 FAILED at 158.
  1 out of 1 hunk FAILED -- saving rejects to file lib/librte_eal/bsdapp/eal/rte_eal_version.map.rej
  patching file lib/librte_eal/common/eal_common_soc.c
  can't find file to patch at input line 174 Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/lib/librte_eal/common/include/rte_soc.h 
  |b/lib/librte_eal/common/include/rte_soc.h
  |index 28c1798..6278295 100644
  |--- a/lib/librte_eal/common/include/rte_soc.h
  |+++ b/lib/librte_eal/common/include/rte_soc.h
  --------------------------
  File to patch: 
  Skip this patch? [y]
  Skipping patch.
  2 out of 2 hunks ignored
  patching file lib/librte_eal/linuxapp/eal/Makefile
  patching file lib/librte_eal/linuxapp/eal/eal_soc.c
  patching file lib/librte_eal/linuxapp/eal/rte_eal_version.map
  Hunk #1 FAILED at 162.
  1 out of 1 hunk FAILED -- saving rejects to file lib/librte_eal/linuxapp/eal/rte_eal_version.map.rej

  12498: 
  patching file lib/librte_eal/bsdapp/eal/rte_eal_version.map
  Hunk #1 FAILED at 163.
  1 out of 1 hunk FAILED -- saving rejects to file lib/librte_eal/bsdapp/eal/rte_eal_version.map.rej
  can't find file to patch at input line 46 Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/lib/librte_eal/common/eal_common_soc.c 
  |b/lib/librte_eal/common/eal_common_soc.c
  |index d8bb6d6..d8f0c00 100644
  |--- a/lib/librte_eal/common/eal_common_soc.c
  |+++ b/lib/librte_eal/common/eal_common_soc.c
  --------------------------
  File to patch: 
  Skip this patch? [y]
  Skipping patch.
  2 out of 2 hunks ignored
  can't find file to patch at input line 264 Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/lib/librte_eal/common/include/rte_soc.h 
  |b/lib/librte_eal/common/include/rte_soc.h
  |index 6278295..4117ffb 100644
  |--- a/lib/librte_eal/common/include/rte_soc.h
  |+++ b/lib/librte_eal/common/include/rte_soc.h
  --------------------------
  File to patch: 
  Skip this patch? [y]
  Skipping patch.
  1 out of 1 hunk ignored
  patching file lib/librte_eal/linuxapp/eal/eal.c Hunk #1 succeeded at 881 (offset -15 lines).
  patching file lib/librte_eal/linuxapp/eal/rte_eal_version.map
  Hunk #1 FAILED at 168.
  1 out of 1 hunk FAILED -- saving rejects to file lib/librte_eal/linuxapp/eal/rte_eal_version.map.rej

  12499: 
  patching file lib/librte_eal/common/eal_common_dev.c
  Hunk #1 FAILED at 154.
  Hunk #2 FAILED at 168.
  Hunk #3 FAILED at 175.
  Hunk #4 FAILED at 186.
  4 out of 4 hunks FAILED -- saving rejects to file lib/librte_eal/common/eal_common_dev.c.rej
  patching file lib/librte_eal/common/eal_common_devargs.c
  can't find file to patch at input line 120 Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/lib/librte_eal/common/eal_common_soc.c 
  |b/lib/librte_eal/common/eal_common_soc.c
  |index d8f0c00..3b885e8 100644
  |--- a/lib/librte_eal/common/eal_common_soc.c
  |+++ b/lib/librte_eal/common/eal_common_soc.c
  --------------------------
  File to patch: 
  Skip this patch? [y]
  Skipping patch.
  4 out of 4 hunks ignored
  patching file lib/librte_eal/common/include/rte_devargs.h
  can't find file to patch at input line 229 Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/lib/librte_eal/common/include/rte_soc.h 
  |b/lib/librte_eal/common/include/rte_soc.h
  |index 4117ffb..00fd0a6 100644
  |--- a/lib/librte_eal/common/include/rte_soc.h
  |+++ b/lib/librte_eal/common/include/rte_soc.h
  --------------------------
  File to patch: 
  Skip this patch? [y]
  Skipping patch.
  3 out of 3 hunks ignored

  12502: 
  can't find file to patch at input line 34 Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |From patchwork Fri May  6 13:47:57 2016
  |Content-Type: text/plain; charset="utf-8"
  |MIME-Version: 1.0
  |Content-Transfer-Encoding: 7bit
  |Subject: [dpdk-dev,v1,15/28] eal/soc: map/unmap resources
  |From: Jan Viktorin <viktorin at rehivetech.com>
  |X-Patchwork-Id: 12502
  |Message-Id: 
  |<1462542490-15556-16-git-send-email-viktorin at rehivetech.com>
  |To: dev at dpdk.org
  |Cc: Jan Viktorin <viktorin at rehivetech.com>,  David Marchand 
  |<david.marchand at 6wind.com>,  Thomas Monjalon 
  |<thomas.monjalon at 6wind.com>,  Bruce Richardson 
  |<bruce.richardson at intel.com>,  Declan Doherty 
  |<declan.doherty at intel.com>, jianbo.liu at linaro.org,  
  |jerin.jacob at caviumnetworks.com, Keith Wiles <keith.wiles at intel.com>,  
  |Stephen Hemminger <stephen at networkplumber.org>
  |Date: Fri,  6 May 2016 15:47:57 +0200
  |
  |Signed-off-by: Jan Viktorin <viktorin at rehivetech.com>
  |
  |---
  |lib/librte_eal/bsdapp/eal/eal_soc.c             | 12 ++++++
  | lib/librte_eal/bsdapp/eal/rte_eal_version.map   |  2 +
  | lib/librte_eal/common/eal_common_soc.c          | 13 +++++++
  | lib/librte_eal/common/include/rte_soc.h         | 50 +++++++++++++++++++++++++
  | lib/librte_eal/linuxapp/eal/eal_soc.c           | 30 +++++++++++++++
  | lib/librte_eal/linuxapp/eal/rte_eal_version.map |  2 +
  | 6 files changed, 109 insertions(+)
  |
  |diff --git a/lib/librte_eal/bsdapp/eal/eal_soc.c 
  |b/lib/librte_eal/bsdapp/eal/eal_soc.c
  |index f84aae9..687d37b 100644
  |--- a/lib/librte_eal/bsdapp/eal/eal_soc.c
  |+++ b/lib/librte_eal/bsdapp/eal/eal_soc.c
  --------------------------
  File to patch: 
  Skip this patch? [y]
  Skipping patch.
  1 out of 1 hunk ignored
  patching file lib/librte_eal/bsdapp/eal/rte_eal_version.map
  Hunk #1 FAILED at 166.
  1 out of 1 hunk FAILED -- saving rejects to file lib/librte_eal/bsdapp/eal/rte_eal_version.map.rej
  can't find file to patch at input line 72 Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/lib/librte_eal/common/eal_common_soc.c 
  |b/lib/librte_eal/common/eal_common_soc.c
  |index 75a7a97..d0e5351 100644
  |--- a/lib/librte_eal/common/eal_common_soc.c
  |+++ b/lib/librte_eal/common/eal_common_soc.c
  --------------------------
  File to patch: 
  Skip this patch? [y]
  Skipping patch.
  3 out of 3 hunks ignored
  can't find file to patch at input line 110 Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/lib/librte_eal/common/include/rte_soc.h 
  |b/lib/librte_eal/common/include/rte_soc.h
  |index 206244a..3192121 100644
  |--- a/lib/librte_eal/common/include/rte_soc.h
  |+++ b/lib/librte_eal/common/include/rte_soc.h
  --------------------------
  File to patch: 
  Skip this patch? [y]
  Skipping patch.
  5 out of 5 hunks ignored
  can't find file to patch at input line 199 Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/lib/librte_eal/linuxapp/eal/eal_soc.c 
  |b/lib/librte_eal/linuxapp/eal/eal_soc.c
  |index 4f9070e..f57486a 100644
  |--- a/lib/librte_eal/linuxapp/eal/eal_soc.c
  |+++ b/lib/librte_eal/linuxapp/eal/eal_soc.c
  --------------------------
  File to patch: 
  Skip this patch? [y]
  Skipping patch.
  2 out of 2 hunks ignored
  patching file lib/librte_eal/linuxapp/eal/rte_eal_version.map
  Hunk #1 FAILED at 171.
  1 out of 1 hunk FAILED -- saving rejects to file lib/librte_eal/linuxapp/eal/rte_eal_version.map.rej

  DPDK STV team
Previous message: [dpdk-test-report] [PatchWork]|ERROR| pw12484-12487 test: add lpm routes as a linked resource
Next message: [dpdk-test-report] [PatchWork]|ERROR| pw12508-12511 kasumi: add new KASUMI PMD
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list