[dpdk-test-report] [PatchWork]|ERROR| pw12528-12533 examples/ip_pipeline: add helper functions for parsing string

sys_stv at intel.com sys_stv at intel.com
Wed May 11 07:38:22 CEST 2016
Previous message: [dpdk-test-report] [PatchWork]|ERROR| pw12520-12527 snow3g: rename libsso reference due to library update
Next message: [dpdk-test-report] [PatchWork]|ERROR| pw12534 app/test: isolate lpm performance cases
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 12528-12533
http://www.dpdk.org/dev/patchwork/patch/12533/
Submitter: Michal Jastrzebski <michalx.k.jastrzebski at intel.com>
Date: Fri,  6 May 2016 17:57:25 +0200
DPDK git baseline: 84c9b5a9fe926f1aa033dc5352be8d4a5e0b789d

Check patch error:
12528: 
WARNING: space prohibited before semicolon
#424: FILE: examples/ip_pipeline/parser.c:106:
+	for ( ; isspace(*_p); _p++);		
ERROR: trailing statements should be on next line
#424: FILE: examples/ip_pipeline/parser.c:106:
+	for ( ; isspace(*_p); _p++);		
WARNING: space prohibited before semicolon
#642: FILE: examples/ip_pipeline/parser.c:324:
+	for ( ; (*string != ' '); ) {

ERROR: do not use assignment in if condition
#694: FILE: examples/ip_pipeline/parser.c:376:
+		if ((pch = strchr(digits, ch)) != NULL) {

ERROR: space prohibited after that '!' (ctx:BxW)
#699: FILE: examples/ip_pipeline/parser.c:381:
+			if (! saw_digit) {
    ^

ERROR: do not use assignment in if condition
#758: FILE: examples/ip_pipeline/parser.c:440:
+		if ((pch = strchr((xdigits = xdigits_l), ch)) == NULL)

WARNING: line over 80 characters
#808: FILE: examples/ip_pipeline/parser.c:490:
+		/* if we already have 8 double octets, having a colon means error */

ERROR: space prohibited after that '-' (ctx:BxW)
#820: FILE: examples/ip_pipeline/parser.c:502:
+			endp[- i] = colonp[n - i];
     ^

 WARNING: space prohibited between function name and open parenthesis '('
 #846: FILE: examples/ip_pipeline/parser.c:528:
 +	} while (++i != sizeof (o) / sizeof (o[0]) && end[0] != 0);

 WARNING: space prohibited between function name and open parenthesis '('
 #846: FILE: examples/ip_pipeline/parser.c:528:
 +	} while (++i != sizeof (o) / sizeof (o[0]) && end[0] != 0);

 WARNING: line over 80 characters
 #865: FILE: examples/ip_pipeline/parser.c:547:
 +			ether_addr.addr_bytes[i * 2 + 1] = (uint8_t)(o[i] & 0xff);

 total: 5 errors, 6 warnings, 1002 lines checked

 /home/patchWorkOrg/patches/dpdk-dev-1-6-examples-ip_pipeline-add-helper-functions-for-parsing-string.patch has style problems, please review.

 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

 12529: 
 WARNING: line over 80 characters
 #257: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:995:
 +	status = parse_tokenize_string(results->command_string, tokens, 
 +&n_tokens);

 WARNING: line over 80 characters
 #277: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1015:
 +			printf("Not enough arguments for "link <id> [config|up|down] ..." 
 +command
");

 WARNING: line over 80 characters
 #285: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1023:
 +				printf("Not enough arguments for "link config ..." command
");

 WARNING: line over 80 characters
 #290: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1028:
 +				printf("Incorrect format of IPv4 source address
");

 WARNING: line over 80 characters
 #300: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1038:
 +					rte_bswap32((uint32_t) ipaddr_ipv4.s_addr), depth);

 ERROR: else should follow close brace '}'
 #302: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1040:
 +		}
 +		else if (strcmp(tokens[1], "up") == 0)

 WARNING: line over 80 characters
 #309: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1047:
 +			printf("Incorrect link command: acceptable is link <id> 
 +[config|up|down]
");

 WARNING: line over 80 characters
 #318: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1056:
 +			APP_PARAM_FIND_BY_ID(app->link_params, "LINK", link_id, p);

 WARNING: line over 80 characters
 #334: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1072:
 +			APP_PARAM_FIND_BY_ID(app->link_params, "LINK", link_id, p);

 WARNING: line over 80 characters
 #341: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1079:
 +	printf("Incorrect link command: should be "link ls" or "link <id> 
 +[config|up|down] ..."
");

 WARNING: line over 80 characters
 #347: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1083:
 +		TOKEN_STRING_INITIALIZER(struct cmd_link_parsed_result, link_string,

 WARNING: line over 80 characters
 #353: FILE: examples/ip_pipeline/pipeline/pipeline_common_fe.c:1087:
 +		TOKEN_STRING_INITIALIZER(struct cmd_link_parsed_result, 
 +command_string,

 total: 1 errors, 11 warnings, 355 lines checked

 /home/patchWorkOrg/patches/dpdk-dev-2-6-examples-ip_pipeline-modifies-common-pipeline-CLI.patch has style problems, please review.

 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

 12530: 
 WARNING: quoted string split across lines
 #916: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:901:
 +			printf("Not enough parameters for "route add" or"
 +					""route add default".
");

 WARNING: line over 80 characters
 #929: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:911:
 +				printf("Not enough parameters for "route add".
");

 WARNING: quoted string split across lines
 #934: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:916:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is depth.
",

 WARNING: quoted string split across lines
 #940: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:922:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is word "port".
",

 WARNING: quoted string split across lines
 #946: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:928:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is port id.
",

 WARNING: quoted string split across lines
 #952: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:934:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is word "ether".
",

 ERROR: else should follow close brace '}'
 #960: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:942:
 +			}
 +			else if (0 == parse_ipv4_addr(tokens[6], &nh_ipv4)) {

 ERROR: else should follow close brace '}'
 #963: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:945:
 +			}
 +			else {

 WARNING: quoted string split across lines
 #965: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:947:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is MAC address or next hop IPv4"

 WARNING: line over 80 characters
 #978: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:960:
 +					if (parse_mpls_labels(tokens[8], mpls_labels, &n_labels)) {

 WARNING: line over 80 characters
 #979: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:961:
 +						printf("Incorrect parameter: "%s"."

 WARNING: quoted string split across lines
 #980: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:962:
 +						printf("Incorrect parameter: "%s"."
 +							" Expected parameter is mpls labels.
",

 WARNING: line over 80 characters
 #984: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:966:
 +					route_data.flags |= PIPELINE_ROUTING_ROUTE_MPLS;

 ERROR: else should follow close brace '}'
 #986: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:968:
 +				}
 +				else if (0 == strcmp(tokens[7], "qinq")) {

 WARNING: line over 80 characters
 #992: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:974:
 +					if (parser_read_uint32(&svlan, tokens[8])) {

 WARNING: line over 80 characters
 #993: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:975:
 +						printf("Incorrect parameter: "%s"."

 WARNING: quoted string split across lines
 #994: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:976:
 +						printf("Incorrect parameter: "%s"."
 +							" Expected parameter is svlan.
",

 WARNING: line over 80 characters
 #998: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:980:
 +					if (parser_read_uint32(&cvlan, tokens[9])) {

 WARNING: line over 80 characters
 #999: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:981:
 +						printf("Incorrect parameter: "%s"."

 WARNING: quoted string split across lines
 #1000: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:982:
 +						printf("Incorrect parameter: "%s"."
 +							" Expected parameter is cvlan.
",

 WARNING: line over 80 characters
 #1004: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:986:
 +					route_data.flags |= PIPELINE_ROUTING_ROUTE_QINQ;

 ERROR: else should follow close brace '}'
 #1006: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:988:
 +				}
 +				else {

 WARNING: quoted string split across lines
 #1008: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:990:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is word "mpls" or "qinq".
",

 WARNING: line over 80 characters
 #1017: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:999:
 +				/* route add <ipaddr> <depth> port <port ID> ether <macaddr> */

 WARNING: line over 80 characters
 #1022: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1004:
 +				/* route add (mpls = no, qinq = no, arp = yes) */

 WARNING: line over 80 characters
 #1023: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1005:
 +				/* route add <ipaddr> <depth> port <port ID> ether <ipaddr> */

 WARNING: line over 80 characters
 #1025: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1007:
 +				route_data.ethernet.ip = rte_bswap32((uint32_t) nh_ipv4.s_addr);

 WARNING: line over 80 characters
 #1028: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1010:
 +				/* route add (mpls = yes, qinq = no, arp = no) */

 WARNING: line over 80 characters
 #1029: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1011:
 +				/* route add <ipaddr> <depth> port <port ID> ether <macaddr>

 WARNING: line over 80 characters
 #1037: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1019:
 +					route_data.l2.mpls.labels[i] = mpls_labels[i];

 WARNING: line over 80 characters
 #1041: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1023:
 +			case PIPELINE_ROUTING_ROUTE_MPLS | PIPELINE_ROUTING_ROUTE_ARP:

 WARNING: line over 80 characters
 #1042: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1024:
 +				/* route add (mpls = yes, qinq = no, arp = yes) */

 WARNING: line over 80 characters
 #1043: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1025:
 +				/* route add <ipaddr> <depth> port <port ID> ether <ipaddr>

 WARNING: line over 80 characters
 #1049: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1031:
 +				route_data.ethernet.ip = rte_bswap32((uint32_t) nh_ipv4.s_addr);

 WARNING: line over 80 characters
 #1051: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1033:
 +					route_data.l2.mpls.labels[i] = mpls_labels[i];

 WARNING: line over 80 characters
 #1056: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1038:
 +				/* route add (mpls = no, qinq = yes, arp = no) */

 WARNING: line over 80 characters
 #1057: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1039:
 +				/* route add <ipaddr> <depth> port <port ID> ether <macaddr>

 WARNING: line over 80 characters
 #1064: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1046:
 +			case PIPELINE_ROUTING_ROUTE_QINQ | PIPELINE_ROUTING_ROUTE_ARP:

 WARNING: line over 80 characters
 #1065: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1047:
 +				/* route add (mpls = no, qinq = yes, arp = yes) */

 WARNING: line over 80 characters
 #1066: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1048:
 +				/* route add <ipaddr> <depth> port <port ID> ether <ipaddr>

 WARNING: line over 80 characters
 #1069: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1051:
 +				route_data.ethernet.ip = rte_bswap32((uint32_t) nh_ipv4.s_addr);

 WARNING: quoted string split across lines
 #1099: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1081:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is port id.
",

 WARNING: line over 80 characters
 #1108: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1090:
 +				printf("Command "route add default" failed.
");

 ERROR: else should follow close brace '}'
 #1112: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1094:
 +		}
 +		else {

 WARNING: quoted string split across lines
 #1114: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1096:
 +			printf("Incorrect parameter: "%s"."
 +				" Expected parameter is IPv4 address or word "default".
",

 WARNING: quoted string split across lines
 #1186: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1106:
 +			printf("Not enough parameters for "route del" or"
 +					""route del default".
");

 WARNING: quoted string split across lines
 #1204: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1121:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is depth.
",

 WARNING: line over 80 characters
 #1213: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1130:
 +			status = app_pipeline_routing_delete_route(app, params->p, &key);

 WARNING: line over 80 characters
 #1227: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1144:
 +			status = app_pipeline_routing_delete_default_route(app, params->p);

 WARNING: line over 80 characters
 #1229: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1146:
 +				printf("Command "route del default" failed.
");

 ERROR: else should follow close brace '}'
 #1233: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1150:
 +		}
 +		else {

 WARNING: quoted string split across lines
 #1235: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1152:
 +			printf("Incorrect parameter: "%s"."
 +				" Expected parameter is IPv4 or word "default".
",

 WARNING: line over 80 characters
 #1299: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1161:
 +			printf("Incorrect number of parameters for route ls.
");

 WARNING: quoted string split across lines
 #1382: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1173:
 +	printf("Command "route" failed."
 +		" Expected parameter is "add" or "del" or "ls".
");

 WARNING: line over 80 characters
 #1406: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1184:
 +	TOKEN_STRING_INITIALIZER(struct cmd_route_result, route_string, 
 +"route");

 WARNING: quoted string split across lines
 #1638: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1257:
 +			printf("Not enough parameters for "arp add" or"
 +					""arp add default".
");

 ERROR: space required before the open parenthesis '('
 #1654: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1270:
 +			if(parse_ipv4_addr(tokens[2], &ipv4)) {

 WARNING: quoted string split across lines
 #1656: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1272:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is IPv4.
",

 ERROR: space required before the open parenthesis '('
 #1660: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1276:
 +			if(parse_mac_addr(tokens[3], &mac_addr)) {

 WARNING: quoted string split across lines
 #1662: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1278:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is MAC address.
",

 WARNING: quoted string split across lines
 #1689: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1305:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is port id.
",

 ERROR: else should follow close brace '}'
 #1702: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1318:
 +		}
 +		else {

 WARNING: quoted string split across lines
 #1704: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1320:
 +			printf("Incorrect parameter: "%s"."
 +				" Expected parameter is port id or word "default".
",

 WARNING: quoted string split across lines
 #1747: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1330:
 +			printf("Not enough parameters for "arp del" or"
 +					""arp del default".
");

 WARNING: quoted string split across lines
 #1765: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1345:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is IPv4.
",

 WARNING: line over 80 characters
 #1790: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1370:
 +			status = app_pipeline_routing_delete_default_arp_entry(app,

 ERROR: else should follow close brace '}'
 #1797: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1377:
 +		}
 +		else {

 WARNING: quoted string split across lines
 #1799: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1379:
 +			printf("Incorrect parameter: "%s"."
 +				" Expected parameter is port id or word "default".
",

 WARNING: quoted string split across lines
 #1838: FILE: examples/ip_pipeline/pipeline/pipeline_routing.c:1400:
 +	printf("Command "arp" failed."
 +		" Expected parameter is "add" or "del" or "ls".
");

 total: 10 errors, 59 warnings, 1882 lines checked

 /home/patchWorkOrg/patches/dpdk-dev-3-6-examples-ip_pipeline-modifies-routing-commands.patch has style problems, please review.

 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

 12533: 
 WARNING: line over 80 characters
 #105: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:632:
 +			printf("not found file %s in the current working dir %s
",

 WARNING: line over 80 characters
 #112: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:639:
 +		if (file_buf[0] != ' ' && file_buf[0] != '
' && file_buf[0] != '#')

 WARNING: line over 80 characters
 #145: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:672:
 +			printf("there was a problem with the setting default value
");

 WARNING: line over 80 characters
 #153: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:680:
 +		uint8_t j, pos = 0, policer_count = 0, meter_count = 0, id_mask = 0;

 WARNING: line over 80 characters
 #161: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:688:
 +				printf("too many parameters at %d line
", line + 1);

 WARNING: line over 80 characters
 #163: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:690:
 +				printf("there was a problem with tokenize at %d line
",

 WARNING: line over 80 characters
 #182: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:709:
 +			printf("not found keyword 'flow' at line %d
", line + 1);

 WARNING: line over 80 characters
 #197: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:724:
 +		/* check the number of occurrences of keywords 'policer' and 'meter' 
 +*/

 WARNING: line over 80 characters
 #208: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:735:
 +			printf("incorrect amount of parameters at %d line for %d policers "

 WARNING: line over 80 characters
 #209: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:736:
 +					"and %d meters
", line + 1, policer_count, meter_count);

 WARNING: quoted string split across lines
 #209: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:736:
 +			printf("incorrect amount of parameters at %d line for %d policers "
 +					"and %d meters
", line + 1, policer_count, meter_count);

 WARNING: line over 80 characters
 #215: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:742:
 +			printf("the lack of any policers at line %d, required at least 1
",

 WARNING: line over 80 characters
 #220: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:747:
 +			printf("too much instances of policers at line %d
", line + 1);

 WARNING: line over 80 characters
 #226: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:753:
 +			printf("the lack of any meters at line %d, required at least 1
",

 WARNING: line over 80 characters
 #231: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:758:
 +			printf("too much instances of meters at line %d
", line + 1);

 WARNING: line over 80 characters
 #241: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:768:
 +				printf("not found keyword 'meter' at line %d.
", line + 1);

 WARNING: line over 80 characters
 #248: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:775:
 +				printf("conversion error meter id: '%s' at line %d
",

 WARNING: line over 80 characters
 #255: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:782:
 +				printf("meter id %d at line %d is not in the range <0,3>
",

 WARNING: line over 80 characters
 #262: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:789:
 +				printf("there were 2 the same ID for meters at line %d",

 WARNING: line over 80 characters
 #270: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:797:
 +			struct rte_meter_trtcm_params *m = &params->keys[i].m[num_value];

 WARNING: line over 80 characters
 #274: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:801:
 +				printf("conversion error cir: '%s' at line %d
",

 WARNING: line over 80 characters
 #284: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:811:
 +				printf("conversion error pir: '%s' at line %d
",

 WARNING: line over 80 characters
 #294: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:821:
 +				printf("conversion error cbs: '%s' at line %d
",

 WARNING: line over 80 characters
 #304: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:831:
 +				printf("conversion error pbs: '%s' at line %d
",

 WARNING: line over 80 characters
 #319: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:846:
 +				printf("not found keyword 'policer' at line %d.
", line + 1);

 WARNING: line over 80 characters
 #326: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:853:
 +				printf("conversion error policer id: '%s' at line %d
",

 WARNING: line over 80 characters
 #333: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:860:
 +				printf("policer id %d at line %d is not in the range <0,3>
",

 WARNING: line over 80 characters
 #340: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:867:
 +				printf("there were 2 the same ID for policers at line %d",

 WARNING: line over 80 characters
 #348: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:875:
 +												&params->keys[i].p[num_value];

 WARNING: line over 80 characters
 #355: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:882:
 +				struct pipeline_fa_policer_action *a = &p->action[k];

 WARNING: line over 80 characters
 #357: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:884:
 +				status = string_to_policer_action(tokens[pos], a);

 WARNING: line over 80 characters
 #360: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:887:
 +					printf("there was a problem with the set up"

 WARNING: quoted string split across lines
 #361: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:888:
 +					printf("there was a problem with the set up"
 +							" policer with id %d at line %d with action: %s
",

 WARNING: line over 80 characters
 #362: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:889:
 +							num_value, line + 1, tokens[pos]);

 WARNING: line over 80 characters
 #372: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:899:
 +			printf("not found keyword 'port' at line %d
", line + 1);

 WARNING: quoted string split across lines
 #1354: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1047:
 +			printf("Not enough parameters for "action flow" or"
 +					" "action flow bulk" or "action flow ls".
");

 WARNING: line over 80 characters
 #1364: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1054:
 +				printf("Not enough parameters for "action flow".
");

 WARNING: line over 80 characters
 #1374: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1061:
 +			 * p <pipeline ID> action flow <flow ID> meter <meter ID>

 WARNING: line over 80 characters
 #1384: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1068:
 +					printf("Incorrect number of parameters for action flow"

 WARNING: quoted string split across lines
 #1385: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1069:
 +					printf("Incorrect number of parameters for action flow"
 +						" meter configuration.
");

 WARNING: quoted string split across lines
 #1394: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1075:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is meter id.
",

 WARNING: quoted string split across lines
 #1400: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1081:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected meter id is less than %d.
",

 WARNING: line over 80 characters
 #1401: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1082:
 +						tokens[3], PIPELINE_FA_N_TC_MAX);

 WARNING: quoted string split across lines
 #1406: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1087:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is word "trtcm".
",

 WARNING: line over 80 characters
 #1410: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1091:
 +				if (parser_read_uint64(&flow_params.m[meter_id].cir,

 WARNING: quoted string split across lines
 #1413: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1094:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is cir.
",

 WARNING: line over 80 characters
 #1417: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1098:
 +				if (parser_read_uint64(&flow_params.m[meter_id].pir,

 WARNING: quoted string split across lines
 #1420: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1101:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is pir.
",

 WARNING: line over 80 characters
 #1424: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1105:
 +				if (parser_read_uint64(&flow_params.m[meter_id].cbs,

 WARNING: quoted string split across lines
 #1427: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1108:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is cbs.
",

 WARNING: line over 80 characters
 #1431: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1112:
 +				if (parser_read_uint64(&flow_params.m[meter_id].pbs,

 WARNING: quoted string split across lines
 #1434: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1115:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is pbs.
",

 WARNING: line over 80 characters
 #1450: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1128:
 +					printf("Command "action flow meter" failed.
");

 WARNING: line over 80 characters
 #1460: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1135:
 +			 * p <pipeline ID> action flow <flow ID> policer <policer ID>

 WARNING: line over 80 characters
 #1463: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1138:
 +			 * <action> = G (green) | Y (yellow) | R (red) | D (drop)

 WARNING: line over 80 characters
 #1513: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1144:
 +					printf("Incorrect number of parameters for action flow"

 WARNING: quoted string split across lines
 #1514: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1145:
 +					printf("Incorrect number of parameters for action flow"
 +						" policer configuration.
");

 WARNING: line over 80 characters
 #1521: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1149:
 +				if (parser_read_uint32(&policer_id, tokens[3])) {

 WARNING: quoted string split across lines
 #1523: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1151:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is policer id.
",

 WARNING: quoted string split across lines
 #1529: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1157:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected policer id is less than %d.
",

 WARNING: line over 80 characters
 #1530: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1158:
 +						tokens[3], PIPELINE_FA_N_TC_MAX);

 WARNING: quoted string split across lines
 #1535: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1163:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is word "g".
",

 WARNING: line over 80 characters
 #1540: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1168:
 +					&flow_params.p[policer_id].action[e_RTE_METER_GREEN])) {

 WARNING: quoted string split across lines
 #1542: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1170:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is policer green action.
",

 WARNING: quoted string split across lines
 #1548: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1176:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is word "y".
",

 WARNING: line over 80 characters
 #1553: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1181:
 +					&flow_params.p[policer_id].action[e_RTE_METER_YELLOW])) {

 WARNING: quoted string split across lines
 #1555: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1183:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is policer yellow action.
",

 WARNING: quoted string split across lines
 #1561: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1189:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is word "r".
",

 WARNING: line over 80 characters
 #1566: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1194:
 +					&flow_params.p[policer_id].action[e_RTE_METER_RED])) {

 WARNING: quoted string split across lines
 #1568: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1196:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is policer red action.
",

 WARNING: line over 80 characters
 #1584: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1209:
 +					printf("Command "action flow policer" failed.
");

 WARNING: line over 80 characters
 #1598: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1220:
 +					printf("Incorrect number of parameters for action flow"

 WARNING: quoted string split across lines
 #1599: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1221:
 +					printf("Incorrect number of parameters for action flow"
 +						" output port configuration.
");

 WARNING: line over 80 characters
 #1606: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1225:
 +				if (parser_read_uint32(&flow_params.port_id, tokens[3])) {

 WARNING: quoted string split across lines
 #1608: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1227:
 +					printf("Incorrect parameter: "%s"."
 +						" Expected parameter is port id.
",

 WARNING: line over 80 characters
 #1624: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1240:
 +					printf("Command "action flow port" failed.
");

 WARNING: line over 80 characters
 #1678: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1254:
 +					printf("Incorrect number of parameters for action flow"

 WARNING: quoted string split across lines
 #1679: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1255:
 +					printf("Incorrect number of parameters for action flow"
 +						" policer stats read.
");

 WARNING: line over 80 characters
 #1686: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1262:
 +					status = app_pipeline_fa_flow_policer_stats_read(app,

 WARNING: line over 80 characters
 #1693: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1269:
 +						printf("Command "action flow stats" for policer %"

 WARNING: line over 80 characters
 #1694: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1270:
 +							PRIu32 " failed.
", policer_id);

 WARNING: line over 80 characters
 #1706: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1282:
 +						stats.n_pkts[e_RTE_METER_YELLOW],

 ERROR: else should follow close brace '}'
 #1713: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1289:
 +			}
 +			else {

 WARNING: quoted string split across lines
 #1715: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1291:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is word "meter" or "policer" or"

 WARNING: line over 80 characters
 #1722: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1298:
 +		 * Flow meter, policer and output port configuration (multiple flows)

 WARNING: line over 80 characters
 #1741: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1317:
 +				printf("Command "action flow bulk" failed.
");

 WARNING: line over 80 characters
 #1756: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1332:
 +				printf("Command "action flow bulk" failed.
");

 WARNING: line over 80 characters
 #1769: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1345:
 +				printf("Incorrect number of parameters for action flow ls.
");

 WARNING: line over 80 characters
 #1773: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1349:
 +			status = app_pipeline_fa_flow_ls(app, params->pipeline_id);

 ERROR: else should follow close brace '}'
 #1779: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1355:
 +		}
 +		else {

 WARNING: quoted string split across lines
 #1781: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1357:
 +			printf("Incorrect parameter: "%s"."
 +				" Expected parameter is flow id or word "bulk" or"

 WARNING: quoted string split across lines
 #1794: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1370:
 +			printf("Not enough parameters for "action dscp" or"
 +					" "action dscp ls".
");

 WARNING: line over 80 characters
 #1799: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1375:
 +		 * Flow DiffServ Code Point (DSCP) translation table configuration

 WARNING: line over 80 characters
 #1801: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1377:
 +		 * p <pipeline ID> action dscp <DSCP ID> class <traffic class ID>

 WARNING: line over 80 characters
 #1811: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1387:
 +				printf("Incorrect number of parameters for action dscp.
");

 WARNING: quoted string split across lines
 #1817: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1393:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is word "class".
",

 WARNING: quoted string split across lines
 #1823: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1399:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is traffic class id.
",

 WARNING: quoted string split across lines
 #1829: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1405:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is word "color".
",

 WARNING: quoted string split across lines
 #1835: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1411:
 +				printf("Incorrect parameter: "%s"."
 +					" Expected parameter is color.
",

 WARNING: line over 80 characters
 #1857: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1433:
 +				printf("Incorrect number of parameters for action dscp ls.
");

 WARNING: line over 80 characters
 #1861: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1437:
 +			status = app_pipeline_fa_dscp_ls(app, params->pipeline_id);

 ERROR: else should follow close brace '}'
 #1867: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1443:
 +		}
 +		else {

 WARNING: quoted string split across lines
 #1869: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1445:
 +			printf("Incorrect parameter: "%s"."
 +				" Expected parameter is dscp id or word "ls".
",

 WARNING: quoted string split across lines
 #1876: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1452:
 +	printf("!Command "action" failed."
 +		" Expected parameter is "flow" or "dscp".
");

 WARNING: line over 80 characters
 #1896: FILE: examples/ip_pipeline/pipeline/pipeline_flow_actions.c:1463:
 +	TOKEN_STRING_INITIALIZER(struct cmd_action_result, action_string, 
 +"action");

 total: 3 errors, 102 warnings, 1908 lines checked

 /home/patchWorkOrg/patches/dpdk-dev-6-6-examples-ip_pipeline-modifies-flow-action-pipeline-CLI.patch has style problems, please review.

 If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


 Compilation:
 OS: fedora
 Nic: niantic
 GCC: gcc_x86-64, 4.8.3
 ICC:16.0.2
 i686-native-linuxapp-icc: compile pass
 x86_64-native-linuxapp-gcc-combined: compile pass
 i686-native-linuxapp-gcc: compile pass
 x86_64-native-linuxapp-gcc: compile pass
 x86_64-native-linuxapp-icc: compile pass
 x86_64-native-linuxapp-gcc-debug: compile pass
 x86_64-native-linuxapp-gcc-shared: compile pass
 x86_64-native-linuxapp-clang: compile pass



 DPDK STV team
Previous message: [dpdk-test-report] [PatchWork]|ERROR| pw12520-12527 snow3g: rename libsso reference due to library update
Next message: [dpdk-test-report] [PatchWork]|ERROR| pw12534 app/test: isolate lpm performance cases
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list