[dpdk-test-report] [PatchWork]|ERROR| pw13044 port: add KNI interface support 1. add KNI port type to the packet framework 2. add KNI support to the IP Pipeline sample Application

sys_stv at intel.com sys_stv at intel.com
Fri May 27 08:03:39 CEST 2016
Previous message: [dpdk-test-report] [PatchWork]|ERROR| pw13042-13043 bond mode 4: allow external state machine
Next message: [dpdk-test-report] [PatchWork]|SUCCESS| pw13045 i40e: fix vlan filter in promiscuous mode
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13044
http://www.dpdk.org/dev/patchwork/patch/13044/
Submitter: WeiJie Zhuang <zhuangwj at gmail.com>
Date: Fri, 27 May 2016 13:07:33 +0800
DPDK git baseline: c8c33ad7f94c59d1c0676af0cfd61207b3e808db

Check patch error:
13044: 
WARNING: line over 80 characters
#177: FILE: examples/ip_pipeline/app.h:768:
+								   RTE_DIM(app->pipeline_params));

WARNING: line over 80 characters
#210: FILE: examples/ip_pipeline/app.h:919:
+								   RTE_DIM(app->pipeline_params));

WARNING: line over 80 characters
#216: FILE: examples/ip_pipeline/app.h:925:
+									  RTE_DIM(p->pktq_out));

WARNING: line over 80 characters
#275: FILE: examples/ip_pipeline/config_check.c:444:
+			APP_LOG(app, LOW, "%s has more than one reader", p->name);

WARNING: line over 80 characters
#281: FILE: examples/ip_pipeline/config_check.c:450:
+			APP_LOG(app, LOW, "%s has more than one writer", p->name);

WARNING: line over 80 characters
#382: FILE: examples/ip_pipeline/config_parse.c:2515:
+									   "MEMPOOL", 1);

WARNING: line over 80 characters
#390: FILE: examples/ip_pipeline/config_parse.c:2523:
+								   section_name);

WARNING: line over 80 characters
#397: FILE: examples/ip_pipeline/config_parse.c:2530:
+											ent->value);

WARNING: line over 80 characters
#558: FILE: examples/ip_pipeline/init.c:1403:
+			out->params.kni.tx_burst_sz = app->kni_params[in->id].burst;

WARNING: line over 80 characters
#586: FILE: examples/ip_pipeline/init.c:1447:
+		conf.mbuf_size = app->mempool_params[p_kni->mempool_id].buffer_size;

WARNING: line over 80 characters
#592: FILE: examples/ip_pipeline/init.c:1453:
+		rte_eth_dev_info_get(app->link_params[port_id].pmd_id, &dev_info);

WARNING: line over 80 characters
#601: FILE: examples/ip_pipeline/init.c:1462:
+		app->kni[i] = rte_kni_alloc(app->mempool[p_kni->mempool_id], &conf, 
+&ops);

WARNING: please, no spaces at the start of a line
#639: FILE: examples/ip_pipeline/kni/kni.c:15:
+    int ret = 0;$

WARNING: please, no spaces at the start of a line
#641: FILE: examples/ip_pipeline/kni/kni.c:17:
+    if (port_id >= rte_eth_dev_count() || port_id >= RTE_MAX_ETHPORTS) 
+ {$

ERROR: code indent should use tabs where possible
#642: FILE: examples/ip_pipeline/kni/kni.c:18:
+        RTE_LOG(ERR, PORT, "%s: Invalid port id %d
", __func__, 
+ port_id);$

WARNING: please, no spaces at the start of a line
#642: FILE: examples/ip_pipeline/kni/kni.c:18:
+        RTE_LOG(ERR, PORT, "%s: Invalid port id %d
", __func__, 
+ port_id);$

ERROR: code indent should use tabs where possible
#643: FILE: examples/ip_pipeline/kni/kni.c:19:
+        return -EINVAL;$

WARNING: please, no spaces at the start of a line
#643: FILE: examples/ip_pipeline/kni/kni.c:19:
+        return -EINVAL;$

WARNING: please, no spaces at the start of a line
#644: FILE: examples/ip_pipeline/kni/kni.c:20:
+    }$

WARNING: please, no spaces at the start of a line
#646: FILE: examples/ip_pipeline/kni/kni.c:22:
+    RTE_LOG(INFO, PORT, "%s: Configure network interface of %d %s
",$

ERROR: code indent should use tabs where possible
#647: FILE: examples/ip_pipeline/kni/kni.c:23:
+            __func__, port_id, if_up ? "up" : "down");$

WARNING: please, no spaces at the start of a line
#647: FILE: examples/ip_pipeline/kni/kni.c:23:
+            __func__, port_id, if_up ? "up" : "down");$

WARNING: please, no spaces at the start of a line
#649: FILE: examples/ip_pipeline/kni/kni.c:25:
+    if (if_up != 0) { /* Configure network interface up */$

ERROR: code indent should use tabs where possible
#650: FILE: examples/ip_pipeline/kni/kni.c:26:
+        rte_eth_dev_stop(port_id);$

WARNING: please, no spaces at the start of a line
#650: FILE: examples/ip_pipeline/kni/kni.c:26:
+        rte_eth_dev_stop(port_id);$

ERROR: code indent should use tabs where possible
#651: FILE: examples/ip_pipeline/kni/kni.c:27:
+        ret = rte_eth_dev_start(port_id);$

WARNING: please, no spaces at the start of a line
#651: FILE: examples/ip_pipeline/kni/kni.c:27:
+        ret = rte_eth_dev_start(port_id);$

WARNING: please, no spaces at the start of a line
#652: FILE: examples/ip_pipeline/kni/kni.c:28:
+    } else /* Configure network interface down */$

ERROR: code indent should use tabs where possible
#653: FILE: examples/ip_pipeline/kni/kni.c:29:
+        rte_eth_dev_stop(port_id);$

WARNING: please, no spaces at the start of a line
#653: FILE: examples/ip_pipeline/kni/kni.c:29:
+        rte_eth_dev_stop(port_id);$

WARNING: please, no spaces at the start of a line
#655: FILE: examples/ip_pipeline/kni/kni.c:31:
+    if (ret < 0)$

ERROR: code indent should use tabs where possible
#656: FILE: examples/ip_pipeline/kni/kni.c:32:
+        RTE_LOG(ERR, PORT, "%s: Failed to start port %d
", __func__, 
+ port_id);$

WARNING: please, no spaces at the start of a line
#656: FILE: examples/ip_pipeline/kni/kni.c:32:
+        RTE_LOG(ERR, PORT, "%s: Failed to start port %d
", __func__, 
+ port_id);$

WARNING: please, no spaces at the start of a line
#658: FILE: examples/ip_pipeline/kni/kni.c:34:
+    return ret;$

WARNING: please, no spaces at the start of a line
#664: FILE: examples/ip_pipeline/kni/kni.c:40:
+    int ret;$

WARNING: please, no spaces at the start of a line
#666: FILE: examples/ip_pipeline/kni/kni.c:42:
+    if (port_id >= rte_eth_dev_count()) {$

ERROR: code indent should use tabs where possible
#667: FILE: examples/ip_pipeline/kni/kni.c:43:
+        RTE_LOG(ERR, PORT, "%s: Invalid port id %d
", __func__, 
+ port_id);$

WARNING: please, no spaces at the start of a line
#667: FILE: examples/ip_pipeline/kni/kni.c:43:
+        RTE_LOG(ERR, PORT, "%s: Invalid port id %d
", __func__, 
+ port_id);$

ERROR: code indent should use tabs where possible
#668: FILE: examples/ip_pipeline/kni/kni.c:44:
+        return -EINVAL;$

WARNING: please, no spaces at the start of a line
#668: FILE: examples/ip_pipeline/kni/kni.c:44:
+        return -EINVAL;$

WARNING: please, no spaces at the start of a line
#669: FILE: examples/ip_pipeline/kni/kni.c:45:
+    }$

WARNING: please, no spaces at the start of a line
#671: FILE: examples/ip_pipeline/kni/kni.c:47:
+    if (new_mtu > ETHER_MAX_LEN) {$

WARNING: line over 80 characters
#672: FILE: examples/ip_pipeline/kni/kni.c:48:
+        RTE_LOG(ERR, PORT, "%s: Fail to reconfigure port %d, the new 
+ MTU is too big
", __func__, port_id);

ERROR: code indent should use tabs where possible
#672: FILE: examples/ip_pipeline/kni/kni.c:48:
+        RTE_LOG(ERR, PORT, "%s: Fail to reconfigure port %d, the new 
+ MTU is too big
", __func__, port_id);$

WARNING: please, no spaces at the start of a line
#672: FILE: examples/ip_pipeline/kni/kni.c:48:
+        RTE_LOG(ERR, PORT, "%s: Fail to reconfigure port %d, the new 
+ MTU is too big
", __func__, port_id);$

ERROR: code indent should use tabs where possible
#673: FILE: examples/ip_pipeline/kni/kni.c:49:
+        return -EINVAL;$

WARNING: please, no spaces at the start of a line
#673: FILE: examples/ip_pipeline/kni/kni.c:49:
+        return -EINVAL;$

WARNING: please, no spaces at the start of a line
#674: FILE: examples/ip_pipeline/kni/kni.c:50:
+    }$

WARNING: line over 80 characters
#676: FILE: examples/ip_pipeline/kni/kni.c:52:
+    RTE_LOG(INFO, PORT, "%s: Change MTU of port %d to %u
", __func__, 
+ port_id, new_mtu);

WARNING: please, no spaces at the start of a line
#676: FILE: examples/ip_pipeline/kni/kni.c:52:
+    RTE_LOG(INFO, PORT, "%s: Change MTU of port %d to %u
", __func__, 
+ port_id, new_mtu);$

WARNING: please, no spaces at the start of a line
#679: FILE: examples/ip_pipeline/kni/kni.c:55:
+    rte_eth_dev_stop(port_id);$

WARNING: please, no spaces at the start of a line
#682: FILE: examples/ip_pipeline/kni/kni.c:58:
+    ret = rte_eth_dev_set_mtu(port_id, new_mtu);$

WARNING: please, no spaces at the start of a line
#683: FILE: examples/ip_pipeline/kni/kni.c:59:
+    if (ret < 0) {$

WARNING: line over 80 characters
#684: FILE: examples/ip_pipeline/kni/kni.c:60:
+        RTE_LOG(ERR, PORT, "%s: Fail to reconfigure port %d
", 
+ __func__, port_id);

ERROR: code indent should use tabs where possible
#684: FILE: examples/ip_pipeline/kni/kni.c:60:
+        RTE_LOG(ERR, PORT, "%s: Fail to reconfigure port %d
", 
+ __func__, port_id);$

WARNING: please, no spaces at the start of a line
#684: FILE: examples/ip_pipeline/kni/kni.c:60:
+        RTE_LOG(ERR, PORT, "%s: Fail to reconfigure port %d
", 
+ __func__, port_id);$

ERROR: code indent should use tabs where possible
#685: FILE: examples/ip_pipeline/kni/kni.c:61:
+        return ret;$

WARNING: please, no spaces at the start of a line
#685: FILE: examples/ip_pipeline/kni/kni.c:61:
+        return ret;$

WARNING: please, no spaces at the start of a line
#686: FILE: examples/ip_pipeline/kni/kni.c:62:
+    }$

WARNING: please, no spaces at the start of a line
#689: FILE: examples/ip_pipeline/kni/kni.c:65:
+    ret = rte_eth_dev_start(port_id);$

WARNING: please, no spaces at the start of a line
#690: FILE: examples/ip_pipeline/kni/kni.c:66:
+    if (ret < 0) {$

ERROR: code indent should use tabs where possible
#691: FILE: examples/ip_pipeline/kni/kni.c:67:
+        RTE_LOG(ERR, PORT, "%s: Fail to restart port %d
", __func__, 
+ port_id);$

WARNING: please, no spaces at the start of a line
#691: FILE: examples/ip_pipeline/kni/kni.c:67:
+        RTE_LOG(ERR, PORT, "%s: Fail to restart port %d
", __func__, 
+ port_id);$

ERROR: code indent should use tabs where possible
#692: FILE: examples/ip_pipeline/kni/kni.c:68:
+        return ret;$

WARNING: please, no spaces at the start of a line
#692: FILE: examples/ip_pipeline/kni/kni.c:68:
+        return ret;$

WARNING: please, no spaces at the start of a line
#693: FILE: examples/ip_pipeline/kni/kni.c:69:
+    }$

WARNING: please, no spaces at the start of a line
#695: FILE: examples/ip_pipeline/kni/kni.c:71:
+    return 0;$

WARNING: adding a line without newline at end of file
#718: FILE: examples/ip_pipeline/kni/kni.h:15:
+#endif

WARNING: line over 80 characters
#809: FILE: examples/ip_pipeline/thread.c:243:
+		if (core_id == (uint32_t)cpu_core_map_get_lcore_id(app->core_map,

ERROR: Macros with complex values should be enclosed in parenthesis
#901: FILE: lib/librte_port/rte_port_kni.c:46:
+#define RTE_PORT_KNI_READER_STATS_PKTS_IN_ADD(port, val) +	port->stats.n_pkts_in += val

ERROR: Macros with complex values should be enclosed in parenthesis
#903: FILE: lib/librte_port/rte_port_kni.c:48:
+#define RTE_PORT_KNI_READER_STATS_PKTS_DROP_ADD(port, val) +	port->stats.n_pkts_drop += val

WARNING: please, no spaces at the start of a line
#916: FILE: lib/librte_port/rte_port_kni.c:61:
+    struct rte_kni *kni;$

ERROR: Macros with complex values should be enclosed in parenthesis
#991: FILE: lib/librte_port/rte_port_kni.c:136:
+#define RTE_PORT_KNI_WRITER_STATS_PKTS_IN_ADD(port, val) +	port->stats.n_pkts_in += val

ERROR: Macros with complex values should be enclosed in parenthesis
#993: FILE: lib/librte_port/rte_port_kni.c:138:
+#define RTE_PORT_KNI_WRITER_STATS_PKTS_DROP_ADD(port, val) +	port->stats.n_pkts_drop += val

WARNING: space prohibited before semicolon
#1055: FILE: lib/librte_port/rte_port_kni.c:200:
+	for ( ; nb_tx < p->tx_buf_count; nb_tx++)

WARNING: space prohibited before semicolon
#1098: FILE: lib/librte_port/rte_port_kni.c:243:
+		for ( ; n_pkts_ok < n_pkts; n_pkts_ok++) {

WARNING: space prohibited before semicolon
#1104: FILE: lib/librte_port/rte_port_kni.c:249:
+		for ( ; pkts_mask; ) {

WARNING: please, no spaces at the start of a line
#1245: FILE: lib/librte_port/rte_port_kni.h:59:
+    struct rte_kni *kni;$

WARNING: please, no spaces at the start of a line
#1255: FILE: lib/librte_port/rte_port_kni.h:69:
+    struct rte_kni *kni;$

WARNING: please, no spaces at the start of a line
#1257: FILE: lib/librte_port/rte_port_kni.h:71:
+    uint32_t tx_burst_sz;$

total: 19 errors, 61 warnings, 1118 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile
	  
	  /home/patchWorkOrg/patches/dpdk-dev-port-add-KNI-interface-support-1.-add-KNI-port-type-to-the-packet-framework-2.-add-KNI-support-to-the-IP-Pipeline-sample-Application.patch has style problems, please review.
	  
	  If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
	  
	  
	  Compilation:
	  OS: fedora
	  Nic: niantic
	  GCC: gcc_x86-64, 4.8.3
	  ICC:16.0.2
	  i686-native-linuxapp-icc: compile pass
	  x86_64-native-linuxapp-gcc-combined: compile pass
	  i686-native-linuxapp-gcc: compile pass
	  x86_64-native-linuxapp-gcc: compile pass
	  x86_64-native-linuxapp-icc: compile pass
	  x86_64-native-linuxapp-gcc-debug: compile pass
	  x86_64-native-linuxapp-gcc-shared: compile pass
	  x86_64-native-linuxapp-clang: compile pass
	  
	  
	  
	  DPDK STV team
Previous message: [dpdk-test-report] [PatchWork]|ERROR| pw13042-13043 bond mode 4: allow external state machine
Next message: [dpdk-test-report] [PatchWork]|SUCCESS| pw13045 i40e: fix vlan filter in promiscuous mode
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list