[dpdk-test-report] [Patchwork]|ERROR| pw16887 E1000: fix for forced speed/duplex config

[sys_stv at intel.com]

Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 16887
http://www.dpdk.org/dev/patchwork/patch/16887/
Submitter: Ananda Sathyanarayana <ananda at versa-networks.com>
Date: Tue,  1 Nov 2016 15:47:04 -0700
DPDK git baseline: ca41215c051a1f4f6f96e947ccb671dab3509cbf

Check patch error:
16887: 
ERROR: code indent should use tabs where possible
#38: FILE: drivers/net/e1000/em_ethdev.c:642:
+                hw->mac.autoneg = 1;$

WARNING: please, no spaces at the start of a line
#38: FILE: drivers/net/e1000/em_ethdev.c:642:
+                hw->mac.autoneg = 1;$

WARNING: braces {} are not necessary for single statement blocks
#47: FILE: drivers/net/e1000/em_ethdev.c:676:
+		if (num_speeds == 0 || (!autoneg && (num_speeds > 1))) {
 			goto error_invalid_config;
+                }

ERROR: code indent should use tabs where possible
#50: FILE: drivers/net/e1000/em_ethdev.c:678:
+                }$

WARNING: please, no spaces at the start of a line
#50: FILE: drivers/net/e1000/em_ethdev.c:678:
+                }$

ERROR: code indent should use tabs where possible
#51: FILE: drivers/net/e1000/em_ethdev.c:679:
+                /*$

ERROR: code indent should use tabs where possible
#52: FILE: drivers/net/e1000/em_ethdev.c:680:
+                 * Set/reset the mac.autoneg based on the link speed,$

WARNING: networking block comments don't use an empty /* line, use /* Comment...
#52: FILE: drivers/net/e1000/em_ethdev.c:680:
+                /*
+                 * Set/reset the mac.autoneg based on the link speed,

ERROR: code indent should use tabs where possible
#53: FILE: drivers/net/e1000/em_ethdev.c:681:
+                 * fixed or not$

ERROR: code indent should use tabs where possible
#54: FILE: drivers/net/e1000/em_ethdev.c:682:
+                 */$

ERROR: code indent should use tabs where possible
#55: FILE: drivers/net/e1000/em_ethdev.c:683:
+                if (!autoneg) {$

WARNING: please, no spaces at the start of a line
#55: FILE: drivers/net/e1000/em_ethdev.c:683:
+                if (!autoneg) {$

ERROR: code indent should use tabs where possible
#56: FILE: drivers/net/e1000/em_ethdev.c:684:
+                        hw->mac.autoneg = 0;$

WARNING: please, no spaces at the start of a line
#56: FILE: drivers/net/e1000/em_ethdev.c:684:
+                        hw->mac.autoneg = 0;$

WARNING: line over 80 characters
#57: FILE: drivers/net/e1000/em_ethdev.c:685:
+                        hw->mac.forced_speed_duplex = hw->phy.autoneg_advertised;

ERROR: code indent should use tabs where possible
#57: FILE: drivers/net/e1000/em_ethdev.c:685:
+                        hw->mac.forced_speed_duplex = hw->phy.autoneg_advertised;$

WARNING: please, no spaces at the start of a line
#57: FILE: drivers/net/e1000/em_ethdev.c:685:
+                        hw->mac.forced_speed_duplex = hw->phy.autoneg_advertised;$

ERROR: code indent should use tabs where possible
#58: FILE: drivers/net/e1000/em_ethdev.c:686:
+                } else {$

WARNING: please, no spaces at the start of a line
#58: FILE: drivers/net/e1000/em_ethdev.c:686:
+                } else {$

ERROR: code indent should use tabs where possible
#59: FILE: drivers/net/e1000/em_ethdev.c:687:
+                        hw->mac.autoneg = 1;$

WARNING: please, no spaces at the start of a line
#59: FILE: drivers/net/e1000/em_ethdev.c:687:
+                        hw->mac.autoneg = 1;$

ERROR: code indent should use tabs where possible
#60: FILE: drivers/net/e1000/em_ethdev.c:688:
+                }$

WARNING: please, no spaces at the start of a line
#60: FILE: drivers/net/e1000/em_ethdev.c:688:
+                }$

ERROR: code indent should use tabs where possible
#61: FILE: drivers/net/e1000/em_ethdev.c:689:
+        }$

WARNING: please, no spaces at the start of a line
#61: FILE: drivers/net/e1000/em_ethdev.c:689:
+        }$

ERROR: code indent should use tabs where possible
#73: FILE: drivers/net/e1000/igb_ethdev.c:1330:
+                hw->mac.autoneg = 1;$

WARNING: please, no spaces at the start of a line
#73: FILE: drivers/net/e1000/igb_ethdev.c:1330:
+                hw->mac.autoneg = 1;$

WARNING: braces {} are not necessary for single statement blocks
#82: FILE: drivers/net/e1000/igb_ethdev.c:1364:
+		if (num_speeds == 0 || (!autoneg && (num_speeds > 1))) {
 			goto error_invalid_config;
+                }

ERROR: code indent should use tabs where possible
#85: FILE: drivers/net/e1000/igb_ethdev.c:1366:
+                }$

WARNING: please, no spaces at the start of a line
#85: FILE: drivers/net/e1000/igb_ethdev.c:1366:
+                }$

ERROR: code indent should use tabs where possible
#86: FILE: drivers/net/e1000/igb_ethdev.c:1367:
+                /*$

ERROR: code indent should use tabs where possible
#87: FILE: drivers/net/e1000/igb_ethdev.c:1368:
+                 * Set/reset the mac.autoneg based on the link speed,$

WARNING: networking block comments don't use an empty /* line, use /* Comment...
#87: FILE: drivers/net/e1000/igb_ethdev.c:1368:
+                /*
+                 * Set/reset the mac.autoneg based on the link speed,

ERROR: code indent should use tabs where possible
#88: FILE: drivers/net/e1000/igb_ethdev.c:1369:
+                 * fixed or not$

ERROR: code indent should use tabs where possible
#89: FILE: drivers/net/e1000/igb_ethdev.c:1370:
+                 */$

ERROR: code indent should use tabs where possible
#90: FILE: drivers/net/e1000/igb_ethdev.c:1371:
+                if (!autoneg) {$

WARNING: please, no spaces at the start of a line
#90: FILE: drivers/net/e1000/igb_ethdev.c:1371:
+                if (!autoneg) {$

ERROR: code indent should use tabs where possible
#91: FILE: drivers/net/e1000/igb_ethdev.c:1372:
+                        hw->mac.autoneg = 0;$

WARNING: please, no spaces at the start of a line
#91: FILE: drivers/net/e1000/igb_ethdev.c:1372:
+                        hw->mac.autoneg = 0;$

WARNING: line over 80 characters
#92: FILE: drivers/net/e1000/igb_ethdev.c:1373:
+                        hw->mac.forced_speed_duplex = hw->phy.autoneg_advertised;

ERROR: code indent should use tabs where possible
#92: FILE: drivers/net/e1000/igb_ethdev.c:1373:
+                        hw->mac.forced_speed_duplex = hw->phy.autoneg_advertised;$

WARNING: please, no spaces at the start of a line
#92: FILE: drivers/net/e1000/igb_ethdev.c:1373:
+                        hw->mac.forced_speed_duplex = hw->phy.autoneg_advertised;$

ERROR: code indent should use tabs where possible
#93: FILE: drivers/net/e1000/igb_ethdev.c:1374:
+                } else {$

WARNING: please, no spaces at the start of a line
#93: FILE: drivers/net/e1000/igb_ethdev.c:1374:
+                } else {$

ERROR: code indent should use tabs where possible
#94: FILE: drivers/net/e1000/igb_ethdev.c:1375:
+                        hw->mac.autoneg = 1;$

WARNING: please, no spaces at the start of a line
#94: FILE: drivers/net/e1000/igb_ethdev.c:1375:
+                        hw->mac.autoneg = 1;$

ERROR: code indent should use tabs where possible
#95: FILE: drivers/net/e1000/igb_ethdev.c:1376:
+                }$

WARNING: please, no spaces at the start of a line
#95: FILE: drivers/net/e1000/igb_ethdev.c:1376:
+                }$

ERROR: code indent should use tabs where possible
#96: FILE: drivers/net/e1000/igb_ethdev.c:1377:
+        }$

WARNING: please, no spaces at the start of a line
#96: FILE: drivers/net/e1000/igb_ethdev.c:1377:
+        }$

total: 26 errors, 24 warnings, 58 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-E1000-fix-for-forced-speed-duplex-config.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team