[dpdk-test-report] |WARNING| [PATCH 3/7] event/sw: software eventdev implementation

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Nov 16 19:01:27 CET 2016
Previous message: [dpdk-test-report] |SUCCESS| [PATCH 4/7] event/sw: makefiles and config
Next message: [dpdk-test-report] |WARNING| [PATCH 5/7] test/eventdev: unit and functional tests
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17049

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#56: 
This commit only adds the implementation, no existing DPDK files are modified.

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#206: FILE: drivers/event/sw/event_ring.h:56:
+#define force_inline inline __attribute__((always_inline))

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#209: FILE: drivers/event/sw/event_ring.h:59:
+static inline struct qe_ring * __attribute__((cold))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#210: FILE: drivers/event/sw/event_ring.h:60:
+qe_ring_create(const char *name, unsigned int size, unsigned socket_id)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#355: FILE: drivers/event/sw/iq_ring.h:57:
+#define force_inline inline __attribute__((always_inline))

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#358: FILE: drivers/event/sw/iq_ring.h:60:
+static inline struct iq_ring * __attribute__((cold))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#359: FILE: drivers/event/sw/iq_ring.h:61:
+iq_ring_create(const char *name, unsigned socket_id)

WARNING:BRACES: braces {} are not necessary for single statement blocks
#571: FILE: drivers/event/sw/sw_evdev.c:98:
+		if (qid >= sw->qid_count) {
+			break; /* error - invalid QIDs */
+		}

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#608: FILE: drivers/event/sw/sw_evdev.c:135:
+	static const char *q_type_strings[] = {"Ordered" , "Atomic",

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#608: FILE: drivers/event/sw/sw_evdev.c:135:
+	static const char *q_type_strings[] = {"Ordered" , "Atomic",
 	                                                 ^

ERROR:SPACING: space required before the open parenthesis '('
#657: FILE: drivers/event/sw/sw_evdev.c:184:
+		for(iq = 0; iq < SW_IQS_MAX; iq++) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#674: FILE: drivers/event/sw/sw_evdev.c:201:
+	unsigned i;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#755: FILE: drivers/event/sw/sw_evdev.c:282:
+	for (i = 0; i < SW_IQS_MAX; i++) {
+		iq_ring_destroy(qid->iq[i]);
+	}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#769: FILE: drivers/event/sw/sw_evdev.c:296:
+qid_init(struct sw_evdev *sw, unsigned idx, int type,

ERROR:SPACING: spaces prohibited around that '->' (ctx:WxV)
#881: FILE: drivers/event/sw/sw_evdev.c:408:
+			conf ->nb_atomic_order_sequences > 0)
 			     ^

ERROR:SPACING: spaces required around that '=' (ctx:VxW)
#926: FILE: drivers/event/sw/sw_evdev.c:453:
+	b= tmp;
 	 ^

ERROR:SPACING: space required before the open parenthesis '('
#975: FILE: drivers/event/sw/sw_evdev.c:502:
+	for(i = 0; i < sw->qid_count; i++) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#975: FILE: drivers/event/sw/sw_evdev.c:502:
+	for(i = 0; i < sw->qid_count; i++) {
+		qid_cleanup(sw, i);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#980: FILE: drivers/event/sw/sw_evdev.c:507:
+	for (i = 0; i < sw->port_count; i++) {
+		sw_port_cleanup(sw, i);
+	}

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#1013: FILE: drivers/event/sw/sw_evdev.c:540:
+	static const char *args[] = { NUMA_NODE_ARG, NULL };

ERROR:SPACING: space required after that ',' (ctx:VxV)
#1092: FILE: drivers/event/sw/sw_evdev.c:619:
+RTE_PMD_REGISTER_PARAM_STRING(evdev_sw,"numa_node=<int>");
                                       ^

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#1225: FILE: drivers/event/sw/sw_evdev.h:127:
+	int16_t num_ordered_qids; /** For loadbalanced we can optimise pulling
+			    packets from producers if there is no reordering

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1226: FILE: drivers/event/sw/sw_evdev.h:128:
+			    involved */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1264: FILE: drivers/event/sw/sw_evdev.h:166:
+	 * to identify the stage of processing. */

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1270: FILE: drivers/event/sw/sw_evdev.h:172:
+^Iuint32_t iq_pkt_mask; ^I/* A mask to indicate packets in an IQ */$

ERROR:SPACING: space required before the open parenthesis '('
#1395: FILE: drivers/event/sw/sw_evdev_scheduler.c:57:
+	if(count == 0)

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1399: FILE: drivers/event/sw/sw_evdev_scheduler.c:61:
+	 * used to identify the stage of processing in history lists etc */

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1430: FILE: drivers/event/sw/sw_evdev_scheduler.c:92:
+		/* If the destination CQ or its history list is full, move on
+		* to the next queue.

ERROR:SPACING: space required before the open parenthesis '('
#1443: FILE: drivers/event/sw/sw_evdev_scheduler.c:105:
+			if(sw->cq_ring_space[cq] == 0)

ERROR:SPACING: space prohibited after that '&' (ctx:WxW)
#1458: FILE: drivers/event/sw/sw_evdev_scheduler.c:120:
+		int head = (p->hist_head & (SW_PORT_HIST_LIST-1));
 		                         ^

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1479: FILE: drivers/event/sw/sw_evdev_scheduler.c:141:
+	 * used to identify the stage of processing in history lists etc */

ERROR:SPACING: space prohibited after that '&' (ctx:WxW)
#1515: FILE: drivers/event/sw/sw_evdev_scheduler.c:177:
+		const int head = (p->hist_head & (SW_PORT_HIST_LIST-1));
 		                               ^

ERROR:SPACING: space required before the open parenthesis '('
#1649: FILE: drivers/event/sw/sw_evdev_scheduler.c:311:
+				if(dest_qid >= sw->qid_count) {

WARNING:LONG_LINE: line over 90 characters
#1655: FILE: drivers/event/sw/sw_evdev_scheduler.c:317:
+				const struct iq_ring *dest_iq_ptr = dest_qid_ptr->iq[dest_iq];

ERROR:SPACING: space required before the open parenthesis '('
#1699: FILE: drivers/event/sw/sw_evdev_scheduler.c:361:
+	if(port->pp_buf_count == 0) {

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#1758: FILE: drivers/event/sw/sw_evdev_scheduler.c:420:
+			((struct reorder_buffer_entry*)rob_ptr)->ready =

WARNING:LONG_LINE_COMMENT: line over 90 characters
#1771: FILE: drivers/event/sw/sw_evdev_scheduler.c:433:
+				//TODO: How do we alert the user that they've exceeded max frags?

WARNING:LONG_LINE: line over 90 characters
#1775: FILE: drivers/event/sw/sw_evdev_scheduler.c:437:
+					rob_entry->fragments[rob_entry->num_fragments++] = *qe;

WARNING:INDENTED_LABEL: labels should not be indented
#1790: FILE: drivers/event/sw/sw_evdev_scheduler.c:452:
+		end_qe:

WARNING:INDENTED_LABEL: labels should not be indented
#1844: FILE: drivers/event/sw/sw_evdev_scheduler.c:506:
+		end_qe:

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1879: FILE: drivers/event/sw/sw_evdev_scheduler.c:541:
+		 * also be set so we can use xor */

ERROR:SPACING: space prohibited before that '--' (ctx:WxO)
#1913: FILE: drivers/event/sw/sw_evdev_scheduler.c:575:
+			port->inflights --;
 			                ^

ERROR:SPACING: space prohibited before that '++' (ctx:WxO)
#1914: FILE: drivers/event/sw/sw_evdev_scheduler.c:576:
+			port->hist_tail ++;
 			                ^

WARNING:LONG_LINE: line over 90 characters
#1963: FILE: drivers/event/sw/sw_evdev_scheduler.c:625:
+					in_pkts += sw_schedule_pull_port_no_reorder(sw, i);

ERROR:SPACING: space required before the open parenthesis '('
#1983: FILE: drivers/event/sw/sw_evdev_scheduler.c:645:
+	for(i = 0; i < sw->port_count; i++) {

ERROR:SPACING: space required before the open parenthesis '('
#2063: FILE: drivers/event/sw/sw_evdev_worker.c:59:
+	if(port_id >= sw->port_count)

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#2069: FILE: drivers/event/sw/sw_evdev_worker.c:65:
+	 * port_id check above */

ERROR:SPACING: space prohibited after that '&&' (ctx:WxW)
#2070: FILE: drivers/event/sw/sw_evdev_worker.c:66:
+	if(sw->overloaded && ev->operation == RTE_EVENT_OP_NEW)
 	                  ^

ERROR:SPACING: space required before the open parenthesis '('
#2070: FILE: drivers/event/sw/sw_evdev_worker.c:66:
+	if(sw->overloaded && ev->operation == RTE_EVENT_OP_NEW)

ERROR:SPACING: space required before the open parenthesis '('
#2079: FILE: drivers/event/sw/sw_evdev_worker.c:75:
+	if(invalid_qid) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2079: FILE: drivers/event/sw/sw_evdev_worker.c:75:
+	if(invalid_qid) {
+		p->stats.rx_dropped++;
+	}

ERROR:SPACING: space required before the open parenthesis '('
#2106: FILE: drivers/event/sw/sw_evdev_worker.c:102:
+	if(port_id >= sw->port_count)

ERROR:SPACING: space prohibited after that '&&' (ctx:WxW)
#2114: FILE: drivers/event/sw/sw_evdev_worker.c:110:
+		if(sw->overloaded && ev[i].operation == RTE_EVENT_OP_NEW)
 		                  ^

ERROR:SPACING: space required before the open parenthesis '('
#2114: FILE: drivers/event/sw/sw_evdev_worker.c:110:
+		if(sw->overloaded && ev[i].operation == RTE_EVENT_OP_NEW)

ERROR:SPACING: space required before the open parenthesis '('
#2122: FILE: drivers/event/sw/sw_evdev_worker.c:118:
+		if(invalid_qid) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2122: FILE: drivers/event/sw/sw_evdev_worker.c:118:
+		if(invalid_qid) {
+			p->stats.rx_dropped++;
+		}

ERROR:SPACING: space required before the open parenthesis '('
#2141: FILE: drivers/event/sw/sw_evdev_worker.c:137:
+	if(port_id >= sw->port_count)

ERROR:SPACING: space required before the open parenthesis '('
#2150: FILE: drivers/event/sw/sw_evdev_worker.c:146:
+	for(i = 0; i < out_rels; i++) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2150: FILE: drivers/event/sw/sw_evdev_worker.c:146:
+	for(i = 0; i < out_rels; i++) {
+		sw_event_release(dev, port_id, i);
+	}

ERROR:SPACING: space required before the open parenthesis '('
#2155: FILE: drivers/event/sw/sw_evdev_worker.c:151:
+	if(ev == 0)

ERROR:SPACING: space required before the open parenthesis '('
#2171: FILE: drivers/event/sw/sw_evdev_worker.c:167:
+	if(port_id >= sw->port_count)

ERROR:SPACING: space required before the open parenthesis '('
#2181: FILE: drivers/event/sw/sw_evdev_worker.c:177:
+		for(i = 0; i < out_rels; i++) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#2181: FILE: drivers/event/sw/sw_evdev_worker.c:177:
+		for(i = 0; i < out_rels; i++) {
+			sw_event_release(dev, port_id, i);
+		}

ERROR:SPACING: space required before the open parenthesis '('
#2187: FILE: drivers/event/sw/sw_evdev_worker.c:183:
+	if(ev == 0)

total: 34 errors, 30 warnings, 2095 lines checked
Previous message: [dpdk-test-report] |SUCCESS| [PATCH 4/7] event/sw: makefiles and config
Next message: [dpdk-test-report] |WARNING| [PATCH 5/7] test/eventdev: unit and functional tests
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list