[dpdk-test-report] [Patchwork]|ERROR| pw17054-17059 eal: define container macro

sys_stv at intel.com sys_stv at intel.com
Thu Nov 17 06:47:59 CET 2016


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 17054-17059
http://www.dpdk.org/dev/patchwork/patch/17059/
Submitter: Shreyansh Jain <shreyansh.jain at nxp.com>
Date: Thu, 17 Nov 2016 11:00:00 +0530
DPDK git baseline: 3549dd67152d26e46b136286ee0296a9aaa1923d

Check patch error:
17056: 
ERROR: space required after that ',' (ctx:VxV)
#266: FILE: bus/pci/linuxapp/pci_bus.c:93:
+	splitaddr.function = strchr(splitaddr.devid,'.');
 	                                           ^

ERROR: spaces required around that '<' (ctx:VxV)
#303: FILE: bus/pci/linuxapp/pci_bus.c:130:
+	for (i = 0; i<PCI_MAX_RESOURCE; i++) {
 	             ^

ERROR: space required after that ',' (ctx:VxV)
#331: FILE: bus/pci/linuxapp/pci_bus.c:158:
+pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,uint8_t devid,
                                                               ^

total: 3 errors, 0 warnings, 546 lines checked

/home/patchWorkOrg/patches/dpdk-dev-RFC-3-6-bus-add-bus-driver-layer.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

17057: 
WARNING: braces {} are not necessary for single statement blocks
#170: FILE: lib/librte_eal/common/eal_common_bus.c:112:
+	if (TAILQ_EMPTY(&rte_bus_list)) {
+		return 0;
+	}

WARNING: line over 80 characters
#381: FILE: lib/librte_eal/common/eal_common_pci.c:174:
+		RTE_LOG(INFO, EAL, "  Device is blacklisted, not initializing\n");

ERROR: spaces required around that '=' (ctx:VxW)
#470: FILE: lib/librte_eal/common/eal_common_pci.c:301:
+	struct rte_pci_driver *pci_drv= NULL;
 	                              ^

ERROR: space required after that ';' (ctx:VxV)
#592: FILE: lib/librte_eal/common/eal_common_pci.c:449:
+			ret = pci_probe_all_drivers(pci_dev);`
 			                                    ^

total: 2 errors, 2 warnings, 604 lines checked

/home/patchWorkOrg/patches/dpdk-dev-RFC-4-6-eal-common-handle-bus-abstraction-for-device-driver-objects.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

17059: 
ERROR: spaces required around that '=' (ctx:VxW)
#87: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1574:
+		.driver_init_t= eth_ixgbe_dev_init,
 		              ^

ERROR: spaces required around that '=' (ctx:VxW)
#88: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:1575:
+		.driver_uninit_t= eth_ixgbe_dev_uninit,
 		                ^

WARNING: line over 80 characters
#261: FILE: lib/librte_ether/rte_ethdev.c:2613:
+	/* TODO; Until intr_handle is available in rte_device, below is incorrect */

total: 2 errors, 1 warnings, 217 lines checked

/home/patchWorkOrg/patches/dpdk-dev-RFC-6-6-eal-removing-eth_driver.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

17055: 
WARNING: do not add new typedefs
#125: FILE: lib/librte_eal/common/include/rte_bus.h:78:
+typedef int (* bus_scan_t)(void);

ERROR: space prohibited after that '*' (ctx:BxW)
#125: FILE: lib/librte_eal/common/include/rte_bus.h:78:
+typedef int (* bus_scan_t)(void);
              ^

WARNING: do not add new typedefs
#143: FILE: lib/librte_eal/common/include/rte_bus.h:96:
+typedef int (* bus_match_t)(struct rte_driver *drv, struct rte_device *dev);

ERROR: space prohibited after that '*' (ctx:BxW)
#143: FILE: lib/librte_eal/common/include/rte_bus.h:96:
+typedef int (* bus_match_t)(struct rte_driver *drv, struct rte_device *dev);
              ^

WARNING: do not add new typedefs
#155: FILE: lib/librte_eal/common/include/rte_bus.h:108:
+typedef void (* bus_dump_t)(struct rte_bus *bus, FILE *f);

ERROR: space prohibited after that '*' (ctx:BxW)
#155: FILE: lib/librte_eal/common/include/rte_bus.h:108:
+typedef void (* bus_dump_t)(struct rte_bus *bus, FILE *f);
               ^

WARNING: do not add new typedefs
#167: FILE: lib/librte_eal/common/include/rte_bus.h:120:
+typedef struct rte_device * (* bus_device_get_t)(struct rte_device *dev);

ERROR: space prohibited after that '*' (ctx:BxW)
#167: FILE: lib/librte_eal/common/include/rte_bus.h:120:
+typedef struct rte_device * (* bus_device_get_t)(struct rte_device *dev);
                              ^

ERROR: "foo * bar" should be "foo *bar"
#257: FILE: lib/librte_eal/common/include/rte_bus.h:210:
+struct rte_bus * rte_eal_get_bus(const char *bus_name);

total: 5 errors, 4 warnings, 304 lines checked

/home/patchWorkOrg/patches/dpdk-dev-RFC-2-6-eal-introduce-bus-device-driver-structure.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


patch file error:
17057: 
patching file lib/librte_eal/common/eal_common_bus.c
patching file lib/librte_eal/common/eal_common_dev.c
patching file lib/librte_eal/common/eal_common_pci.c
Hunk #2 FAILED at 161.
Hunk #3 succeeded at 289 (offset 4 lines).
Hunk #4 succeeded at 299 (offset 4 lines).
Hunk #5 succeeded at 326 (offset 4 lines).
Hunk #6 succeeded at 358 (offset 4 lines).
Hunk #7 succeeded at 403 (offset 4 lines).
Hunk #8 succeeded at 447 (offset 4 lines).
Hunk #9 succeeded at 512 (offset 4 lines).
Hunk #10 succeeded at 532 (offset 4 lines).
Hunk #11 succeeded at 549 (offset 4 lines).
1 out of 11 hunks FAILED -- saving rejects to file lib/librte_eal/common/eal_common_pci.c.rej
patching file lib/librte_eal/common/include/rte_pci.h

17058: 
patching file lib/librte_eal/linuxapp/eal/Makefile
Hunk #1 FAILED at 77.
1 out of 1 hunk FAILED -- saving rejects to file lib/librte_eal/linuxapp/eal/Makefile.rej
patching file lib/librte_eal/linuxapp/eal/eal.c
Hunk #1 succeeded at 729 (offset -10 lines).
Hunk #2 succeeded at 827 with fuzz 2 (offset -13 lines).
patching file lib/librte_eal/linuxapp/eal/eal_pci.c
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file lib/librte_eal/linuxapp/eal/eal_pci.c.rej

17059: 
patching file drivers/net/ixgbe/ixgbe_ethdev.c
Hunk #1 succeeded at 1360 (offset -59 lines).
Hunk #2 succeeded at 1473 (offset -59 lines).
Hunk #3 FAILED at 1564.
Hunk #4 FAILED at 7594.
2 out of 4 hunks FAILED -- saving rejects to file drivers/net/ixgbe/ixgbe_ethdev.c.rej
patching file lib/librte_ether/rte_ethdev.c
Hunk #1 succeeded at 249 with fuzz 2 (offset 14 lines).
Hunk #2 succeeded at 267 (offset 15 lines).
Hunk #3 succeeded at 285 (offset 15 lines).
Hunk #4 succeeded at 302 with fuzz 2 (offset 15 lines).
Hunk #5 succeeded at 318 (offset 16 lines).
Hunk #6 succeeded at 333 (offset 16 lines).
Hunk #7 succeeded at 1736 (offset 180 lines).
Hunk #8 succeeded at 2713 (offset 176 lines).
Hunk #9 succeeded at 2721 (offset 176 lines).
Hunk #10 FAILED at 2577.
Hunk #11 succeeded at 2774 (offset 176 lines).
Hunk #12 succeeded at 2786 (offset 176 lines).
1 out of 12 hunks FAILED -- saving rejects to file lib/librte_ether/rte_ethdev.c.rej
patching file lib/librte_ether/rte_ethdev.h
Hunk #1 succeeded at 869 (offset -7 lines).
Hunk #2 succeeded at 1627 (offset 4 lines).

DPDK STV team 


More information about the test-report mailing list