[dpdk-test-report] |WARNING| [PATCH 04/56] net/sfc: import libefx filters support

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Nov 21 16:02:25 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17107

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#104: FILE: drivers/net/sfc/efx/base/efx.h:1057:
+						 * multiple queues */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#112: FILE: drivers/net/sfc/efx/base/efx.h:1065:
+						 * in its place. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#119: FILE: drivers/net/sfc/efx/base/efx.h:1072:
+						 * address */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#121: FILE: drivers/net/sfc/efx/base/efx.h:1074:
+						 * address */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#130: FILE: drivers/net/sfc/efx/base/efx.h:1083:
+						 * protocol */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#134: FILE: drivers/net/sfc/efx/base/efx.h:1087:
+						 * broadcast filters. */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#143: FILE: drivers/net/sfc/efx/base/efx.h:1096:
+					 * each NIC type. */

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#179: FILE: drivers/net/sfc/efx/base/efx.h:1132:
+extern	__checkReturn	efx_rc_t

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#323: FILE: drivers/net/sfc/efx/base/efx_filter.c:48:
+	return (efop->efo_add(enp, spec, B_FALSE));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#337: FILE: drivers/net/sfc/efx/base/efx_filter.c:62:
+	return (efop->efo_delete(enp, spec));

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#348: FILE: drivers/net/sfc/efx/base/efx_filter.c:73:
+	if ((rc = enp->en_efop->efo_restore(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#351: FILE: drivers/net/sfc/efx/base/efx_filter.c:76:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#356: FILE: drivers/net/sfc/efx/base/efx_filter.c:81:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#367: FILE: drivers/net/sfc/efx/base/efx_filter.c:92:
+	EFX_STATIC_ASSERT(sizeof (efx_filter_spec_t) == 64);

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#374: FILE: drivers/net/sfc/efx/base/efx_filter.c:99:
+	switch (enp->en_family) {
+

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#381: FILE: drivers/net/sfc/efx/base/efx_filter.c:106:
+	if ((rc = efop->efo_init(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#386: FILE: drivers/net/sfc/efx/base/efx_filter.c:111:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#395: FILE: drivers/net/sfc/efx/base/efx_filter.c:120:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#425: FILE: drivers/net/sfc/efx/base/efx_filter.c:150:
+	if ((rc = enp->en_efop->efo_supported_filters(enp, list, length)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#428: FILE: drivers/net/sfc/efx/base/efx_filter.c:153:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#433: FILE: drivers/net/sfc/efx/base/efx_filter.c:158:
+	return (rc);

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#444: FILE: drivers/net/sfc/efx/base/efx_filter.c:169:
+	__in_ecount(6*count)		uint8_t const *addrs,
 	             ^

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#454: FILE: drivers/net/sfc/efx/base/efx_filter.c:179:
+		if ((rc = enp->en_efop->efo_reconfigure(enp, mac_addr,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#461: FILE: drivers/net/sfc/efx/base/efx_filter.c:186:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#466: FILE: drivers/net/sfc/efx/base/efx_filter.c:191:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#481: FILE: drivers/net/sfc/efx/base/efx_filter.c:206:
+	memset(spec, 0, sizeof (*spec));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#496: FILE: drivers/net/sfc/efx/base/efx_filter.c:221:
+	memset(spec, 0, sizeof (*spec));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#522: FILE: drivers/net/sfc/efx/base/efx_filter.c:247:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#549: FILE: drivers/net/sfc/efx/base/efx_filter.c:274:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#565: FILE: drivers/net/sfc/efx/base/efx_filter.c:290:
+		return (EINVAL);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#565: FILE: drivers/net/sfc/efx/base/efx_filter.c:290:
+		return (EINVAL);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#575: FILE: drivers/net/sfc/efx/base/efx_filter.c:300:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#588: FILE: drivers/net/sfc/efx/base/efx_filter.c:313:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#602: FILE: drivers/net/sfc/efx/base/efx_filter.c:327:
+	return (0);

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#638: FILE: drivers/net/sfc/efx/base/efx_impl.h:186:
+	__in_ecount(6*count)		uint8_t const *addrs,
 	             ^

total: 20 errors, 11 warnings, 4 checks, 562 lines checked


More information about the test-report mailing list