[dpdk-test-report] |WARNING| [PATCH 28/56] net/sfc: import libefx bootrom configuration support

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17120

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#87: FILE: drivers/net/sfc/efx/base/efx.h:1427:
+extern	__checkReturn		efx_rc_t

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#238: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:107:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#246: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:115:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#263: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:132:
+	return (checksum);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#320: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:189:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#329: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:198:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#401: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:270:
+		(void) memset(data + used_bytes, 0, data_size - used_bytes);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#409: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:278:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#418: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:287:
+	return (rc);

CHECK:BRACES: braces {} should be used on all arms of this statement
#465: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:334:
+	if (sector_length > size) {
[...]
+	} else
[...]

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#474: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:343:
+	if ((rc = efx_nvram_rw_start(enp, EFX_NVRAM_BOOTROM_CFG, NULL)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#477: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:346:
+	if ((rc = efx_nvram_read_chunk(enp, EFX_NVRAM_BOOTROM_CFG,

CHECK:SPACING: No space is necessary after a cast
#479: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:348:
+		(void) efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#483: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:352:
+	if ((rc = efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG)) != 0)

CHECK:SPACING: No space is necessary after a cast
#529: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:398:
+		(void) memset(data + used_bytes, 0, size - used_bytes);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#537: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:406:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#558: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:427:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#601: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:470:
+	if ((rc = efx_bootcfg_verify(enp, data, size, &used_bytes)) != 0)

CHECK:SPACING: No space is necessary after a cast
#642: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:511:
+	(void) memset(partn_data + sector_offset, 0x0, sector_length);

CHECK:SPACING: No space is necessary after a cast
#643: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:512:
+	(void) memcpy(partn_data + sector_offset, data, used_bytes);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#648: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:517:
+	if ((rc = efx_nvram_erase(enp, EFX_NVRAM_BOOTROM_CFG)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#651: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:520:
+	if ((rc = efx_nvram_write_chunk(enp, EFX_NVRAM_BOOTROM_CFG,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#655: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:524:
+	if ((rc = efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#660: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:529:
+	return (0);

CHECK:SPACING: No space is necessary after a cast
#671: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:540:
+	(void) efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#691: FILE: drivers/net/sfc/efx/base/efx_bootcfg.c:560:
+	return (rc);

total: 18 errors, 0 warnings, 8 checks, 621 lines checked