[dpdk-test-report] |WARNING| [PATCH 21/56] net/sfc: import libefx RSS support

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17124

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#118: FILE: drivers/net/sfc/efx/base/ef10_impl.h:586:
+extern	__checkReturn	efx_rc_t

CHECK:SPACING: No space is necessary after a cast
#188: FILE: drivers/net/sfc/efx/base/ef10_rx.c:185:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#188: FILE: drivers/net/sfc/efx/base/ef10_rx.c:185:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#221: FILE: drivers/net/sfc/efx/base/ef10_rx.c:218:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#234: FILE: drivers/net/sfc/efx/base/ef10_rx.c:231:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#254: FILE: drivers/net/sfc/efx/base/ef10_rx.c:251:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#254: FILE: drivers/net/sfc/efx/base/ef10_rx.c:251:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#270: FILE: drivers/net/sfc/efx/base/ef10_rx.c:267:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#277: FILE: drivers/net/sfc/efx/base/ef10_rx.c:274:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#298: FILE: drivers/net/sfc/efx/base/ef10_rx.c:295:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#298: FILE: drivers/net/sfc/efx/base/ef10_rx.c:295:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#325: FILE: drivers/net/sfc/efx/base/ef10_rx.c:322:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#332: FILE: drivers/net/sfc/efx/base/ef10_rx.c:329:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#354: FILE: drivers/net/sfc/efx/base/ef10_rx.c:351:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#354: FILE: drivers/net/sfc/efx/base/ef10_rx.c:351:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#380: FILE: drivers/net/sfc/efx/base/ef10_rx.c:377:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#389: FILE: drivers/net/sfc/efx/base/ef10_rx.c:386:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#412: FILE: drivers/net/sfc/efx/base/ef10_rx.c:409:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#412: FILE: drivers/net/sfc/efx/base/ef10_rx.c:409:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#438: FILE: drivers/net/sfc/efx/base/ef10_rx.c:435:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#445: FILE: drivers/net/sfc/efx/base/ef10_rx.c:442:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#505: FILE: drivers/net/sfc/efx/base/ef10_rx.c:510:
+	if ((rc = efx_mcdi_rss_context_set_flags(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#509: FILE: drivers/net/sfc/efx/base/ef10_rx.c:514:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#518: FILE: drivers/net/sfc/efx/base/ef10_rx.c:523:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#536: FILE: drivers/net/sfc/efx/base/ef10_rx.c:541:
+	if ((rc = efx_mcdi_rss_context_set_key(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#540: FILE: drivers/net/sfc/efx/base/ef10_rx.c:545:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#547: FILE: drivers/net/sfc/efx/base/ef10_rx.c:552:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#565: FILE: drivers/net/sfc/efx/base/ef10_rx.c:570:
+	if ((rc = efx_mcdi_rss_context_set_table(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#569: FILE: drivers/net/sfc/efx/base/ef10_rx.c:574:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#576: FILE: drivers/net/sfc/efx/base/ef10_rx.c:581:
+	return (rc);

WARNING:MISSING_BREAK: Possible switch case/default not preceeded by break or fallthrough comment
#603: FILE: drivers/net/sfc/efx/base/ef10_rx.c:641:
+	default:

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#605: FILE: drivers/net/sfc/efx/base/ef10_rx.c:643:
+		return (0);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#618: FILE: drivers/net/sfc/efx/base/ef10_rx.c:841:
+	if (enp->en_rss_support != EFX_RX_SCALE_UNAVAILABLE) {
+		(void) efx_mcdi_rss_context_free(enp, enp->en_rss_context);
+	}

CHECK:SPACING: No space is necessary after a cast
#619: FILE: drivers/net/sfc/efx/base/ef10_rx.c:842:
+		(void) efx_mcdi_rss_context_free(enp, enp->en_rss_context);

WARNING:TYPO_SPELLING: 'psuedo' may be misspelled - perhaps 'pseudo'?
#697: FILE: drivers/net/sfc/efx/base/efx.h:1451:
+efx_psuedo_hdr_hash_get(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#889: FILE: drivers/net/sfc/efx/base/efx_rx.c:300:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#894: FILE: drivers/net/sfc/efx/base/efx_rx.c:305:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#915: FILE: drivers/net/sfc/efx/base/efx_rx.c:326:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#920: FILE: drivers/net/sfc/efx/base/efx_rx.c:331:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#937: FILE: drivers/net/sfc/efx/base/efx_rx.c:348:
+		if ((rc = erxop->erxo_scale_mode_set(enp, alg,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#942: FILE: drivers/net/sfc/efx/base/efx_rx.c:353:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#946: FILE: drivers/net/sfc/efx/base/efx_rx.c:357:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#963: FILE: drivers/net/sfc/efx/base/efx_rx.c:374:
+	if ((rc = erxop->erxo_scale_key_set(enp, key, n)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#966: FILE: drivers/net/sfc/efx/base/efx_rx.c:377:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#971: FILE: drivers/net/sfc/efx/base/efx_rx.c:382:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#988: FILE: drivers/net/sfc/efx/base/efx_rx.c:399:
+	if ((rc = erxop->erxo_scale_tbl_set(enp, table, n)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#991: FILE: drivers/net/sfc/efx/base/efx_rx.c:402:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#996: FILE: drivers/net/sfc/efx/base/efx_rx.c:407:
+	return (rc);

WARNING:TYPO_SPELLING: 'psuedo' may be misspelled - perhaps 'pseudo'?
#1009: FILE: drivers/net/sfc/efx/base/efx_rx.c:555:
+efx_psuedo_hdr_hash_get(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1020: FILE: drivers/net/sfc/efx/base/efx_rx.c:566:
+	return (erxop->erxo_prefix_hash(enp, func, buffer));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1081: FILE: drivers/net/sfc/efx/base/efx_rx.c:748:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1090: FILE: drivers/net/sfc/efx/base/efx_rx.c:757:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1204: FILE: drivers/net/sfc/efx/base/efx_rx.c:871:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1215: FILE: drivers/net/sfc/efx/base/efx_rx.c:882:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1270: FILE: drivers/net/sfc/efx/base/efx_rx.c:937:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1277: FILE: drivers/net/sfc/efx/base/efx_rx.c:944:
+	return (rc);

WARNING:MISSING_BREAK: Possible switch case/default not preceeded by break or fallthrough comment
#1304: FILE: drivers/net/sfc/efx/base/efx_rx.c:980:
+	case EFX_RX_HASHALG_LFSR:

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1309: FILE: drivers/net/sfc/efx/base/efx_rx.c:985:
+		return (0);

total: 41 errors, 10 warnings, 7 checks, 1181 lines checked