[dpdk-test-report] |WARNING| [PATCH 27/56] net/sfc: import libefx VPD support

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Nov 21 16:16:37 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17147

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#92: FILE: drivers/net/sfc/efx/base/ef10_impl.h:822:
+extern	__checkReturn		efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#242: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:81:
+		if ((rc = efx_vpd_hunk_verify(svpd, svpd_size, NULL)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#250: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:89:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#259: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:98:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#278: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:117:
+	if ((rc = efx_mcdi_nvram_info(enp, NVRAM_PARTITION_TYPE_DYNAMIC_CONFIG,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#282: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:121:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#287: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:126:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#312: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:151:
+	if ((rc = ef10_nvram_partn_read_tlv(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#328: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:167:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#337: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:176:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#363: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:202:
+	if ((rc = efx_vpd_hunk_verify(data, size, NULL)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#376: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:215:
+		if ((rc = efx_vpd_hunk_next(data, size, &dtag,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#392: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:231:
+			if ((rc = efx_vpd_hunk_next(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#408: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:247:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#419: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:258:
+	return (rc);

CHECK:BRACES: braces {} should be used on all arms of this statement
#434: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:273:
+	if (enp->en_arch.ef10.ena_svpd_length == 0)
[...]
+	else {
[...]

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#451: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:290:
+	if ((rc = efx_vpd_hunk_reinit(data, size, wantpid)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#454: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:293:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#461: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:300:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#480: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:319:
+		if ((rc = efx_vpd_hunk_get(enp->en_arch.ef10.ena_svpd,

CHECK:BRACES: braces {} should be used on all arms of this statement
#480: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:319:
+		if ((rc = efx_vpd_hunk_get(enp->en_arch.ef10.ena_svpd,
[...]
+		} else if (rc != ENOENT)
[...]

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#486: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:325:
+			return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#492: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:331:
+	if ((rc = efx_vpd_hunk_get(data, size, evvp->evv_tag,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#495: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:334:
+			return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#502: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:341:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#509: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:348:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#529: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:368:
+		if ((rc = efx_vpd_hunk_get(enp->en_arch.ef10.ena_svpd,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#537: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:376:
+	if ((rc = efx_vpd_hunk_set(data, size, evvp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#540: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:379:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#547: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:386:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#560: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:399:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#560: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:399:
+	return (ENOTSUP);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#585: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:424:
+	if ((rc = efx_vpd_hunk_length(data, size, &vpd_length)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#589: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:428:
+	if ((rc = ef10_nvram_partn_write_segment_tlv(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#595: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:434:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#603: FILE: drivers/net/sfc/efx/base/ef10_vpd.c:442:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#983: FILE: drivers/net/sfc/efx/base/efx_vpd.c:125:
+		if ((rc = evpdop->evpdo_init(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#990: FILE: drivers/net/sfc/efx/base/efx_vpd.c:132:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#997: FILE: drivers/net/sfc/efx/base/efx_vpd.c:139:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1011: FILE: drivers/net/sfc/efx/base/efx_vpd.c:153:
+	if ((rc = evpdop->evpdo_size(enp, sizep)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1014: FILE: drivers/net/sfc/efx/base/efx_vpd.c:156:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1019: FILE: drivers/net/sfc/efx/base/efx_vpd.c:161:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1034: FILE: drivers/net/sfc/efx/base/efx_vpd.c:176:
+	if ((rc = evpdop->evpdo_read(enp, data, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1037: FILE: drivers/net/sfc/efx/base/efx_vpd.c:179:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1042: FILE: drivers/net/sfc/efx/base/efx_vpd.c:184:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1057: FILE: drivers/net/sfc/efx/base/efx_vpd.c:199:
+	if ((rc = evpdop->evpdo_verify(enp, data, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1060: FILE: drivers/net/sfc/efx/base/efx_vpd.c:202:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1065: FILE: drivers/net/sfc/efx/base/efx_vpd.c:207:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1085: FILE: drivers/net/sfc/efx/base/efx_vpd.c:227:
+	if ((rc = evpdop->evpdo_reinit(enp, data, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1088: FILE: drivers/net/sfc/efx/base/efx_vpd.c:230:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1095: FILE: drivers/net/sfc/efx/base/efx_vpd.c:237:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1111: FILE: drivers/net/sfc/efx/base/efx_vpd.c:253:
+	if ((rc = evpdop->evpdo_get(enp, data, size, evvp)) != 0) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1113: FILE: drivers/net/sfc/efx/base/efx_vpd.c:255:
+			return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1118: FILE: drivers/net/sfc/efx/base/efx_vpd.c:260:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1123: FILE: drivers/net/sfc/efx/base/efx_vpd.c:265:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1139: FILE: drivers/net/sfc/efx/base/efx_vpd.c:281:
+	if ((rc = evpdop->evpdo_set(enp, data, size, evvp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1142: FILE: drivers/net/sfc/efx/base/efx_vpd.c:284:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1147: FILE: drivers/net/sfc/efx/base/efx_vpd.c:289:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1164: FILE: drivers/net/sfc/efx/base/efx_vpd.c:306:
+	if ((rc = evpdop->evpdo_next(enp, data, size, evvp, contp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1167: FILE: drivers/net/sfc/efx/base/efx_vpd.c:309:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1172: FILE: drivers/net/sfc/efx/base/efx_vpd.c:314:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1187: FILE: drivers/net/sfc/efx/base/efx_vpd.c:329:
+	if ((rc = evpdop->evpdo_write(enp, data, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1190: FILE: drivers/net/sfc/efx/base/efx_vpd.c:332:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1195: FILE: drivers/net/sfc/efx/base/efx_vpd.c:337:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1269: FILE: drivers/net/sfc/efx/base/efx_vpd.c:411:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1280: FILE: drivers/net/sfc/efx/base/efx_vpd.c:422:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1311: FILE: drivers/net/sfc/efx/base/efx_vpd.c:453:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1318: FILE: drivers/net/sfc/efx/base/efx_vpd.c:460:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1335: FILE: drivers/net/sfc/efx/base/efx_vpd.c:477:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1345: FILE: drivers/net/sfc/efx/base/efx_vpd.c:487:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1350: FILE: drivers/net/sfc/efx/base/efx_vpd.c:492:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1377: FILE: drivers/net/sfc/efx/base/efx_vpd.c:519:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1392: FILE: drivers/net/sfc/efx/base/efx_vpd.c:534:
+			if ((rc = efx_vpd_next_keyword(data + offset,

WARNING:INDENTED_LABEL: labels should not be indented
#1410: FILE: drivers/net/sfc/efx/base/efx_vpd.c:552:
+	done:

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1422: FILE: drivers/net/sfc/efx/base/efx_vpd.c:564:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1435: FILE: drivers/net/sfc/efx/base/efx_vpd.c:577:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1473: FILE: drivers/net/sfc/efx/base/efx_vpd.c:615:
+		    sizeof (__efx_vpd_blank_pid));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1474: FILE: drivers/net/sfc/efx/base/efx_vpd.c:616:
+		offset += sizeof (__efx_vpd_blank_pid);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1477: FILE: drivers/net/sfc/efx/base/efx_vpd.c:619:
+	memcpy(data + offset, __efx_vpd_blank_r, sizeof (__efx_vpd_blank_r));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1478: FILE: drivers/net/sfc/efx/base/efx_vpd.c:620:
+	offset += sizeof (__efx_vpd_blank_r);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1494: FILE: drivers/net/sfc/efx/base/efx_vpd.c:636:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1499: FILE: drivers/net/sfc/efx/base/efx_vpd.c:641:
+	return (rc);

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1522: FILE: drivers/net/sfc/efx/base/efx_vpd.c:664:
+	offset = index = 0;

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1525: FILE: drivers/net/sfc/efx/base/efx_vpd.c:667:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1546: FILE: drivers/net/sfc/efx/base/efx_vpd.c:688:
+				if ((rc = efx_vpd_next_keyword(data + offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1571: FILE: drivers/net/sfc/efx/base/efx_vpd.c:713:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1578: FILE: drivers/net/sfc/efx/base/efx_vpd.c:720:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1601: FILE: drivers/net/sfc/efx/base/efx_vpd.c:743:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1613: FILE: drivers/net/sfc/efx/base/efx_vpd.c:755:
+				return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1617: FILE: drivers/net/sfc/efx/base/efx_vpd.c:759:
+				if ((rc = efx_vpd_next_keyword(data + offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1624: FILE: drivers/net/sfc/efx/base/efx_vpd.c:766:
+					return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1633: FILE: drivers/net/sfc/efx/base/efx_vpd.c:775:
+	return (ENOENT);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOENT)
#1633: FILE: drivers/net/sfc/efx/base/efx_vpd.c:775:
+	return (ENOENT);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1640: FILE: drivers/net/sfc/efx/base/efx_vpd.c:782:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1691: FILE: drivers/net/sfc/efx/base/efx_vpd.c:833:
+	if ((rc = efx_vpd_hunk_length(data, size, &used)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1698: FILE: drivers/net/sfc/efx/base/efx_vpd.c:840:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

CHECK:BRACES: braces {} should be used on all arms of this statement
#1701: FILE: drivers/net/sfc/efx/base/efx_vpd.c:843:
+		if (tag == EFX_VPD_END)
[...]
+		else if (tag != evvp->evv_tag) {
[...]

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1726: FILE: drivers/net/sfc/efx/base/efx_vpd.c:868:
+		source = dest = 0;

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1728: FILE: drivers/net/sfc/efx/base/efx_vpd.c:870:
+			if ((rc = efx_vpd_next_keyword(data + offset,

WARNING:TYPO_SPELLING: 'existant' may be misspelled - perhaps 'existent'?
#1751: FILE: drivers/net/sfc/efx/base/efx_vpd.c:893:
+				 * user deleting a non-existant keyword then

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1755: FILE: drivers/net/sfc/efx/base/efx_vpd.c:897:
+					return (0);

WARNING:INDENTED_LABEL: labels should not be indented
#1764: FILE: drivers/net/sfc/efx/base/efx_vpd.c:906:
+	check_space:

CHECK:SPACING: No space is necessary after a cast
#1771: FILE: drivers/net/sfc/efx/base/efx_vpd.c:913:
+		(void) memmove(data + dest, data + source, used - source);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1806: FILE: drivers/net/sfc/efx/base/efx_vpd.c:948:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1813: FILE: drivers/net/sfc/efx/base/efx_vpd.c:955:
+				if ((rc = efx_vpd_next_keyword(data + offset,

CHECK:SPACING: No space is necessary after a cast
#1831: FILE: drivers/net/sfc/efx/base/efx_vpd.c:973:
+	(void) memset(data + offset + taglen, 0xff, size - offset - taglen);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1833: FILE: drivers/net/sfc/efx/base/efx_vpd.c:975:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1854: FILE: drivers/net/sfc/efx/base/efx_vpd.c:996:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2014: FILE: drivers/net/sfc/efx/base/siena_vpd.c:60:
+	if ((rc = siena_nvram_partn_size(enp, partn, &size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2023: FILE: drivers/net/sfc/efx/base/siena_vpd.c:69:
+	if ((rc = siena_nvram_partn_read(enp, partn, 0,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2051: FILE: drivers/net/sfc/efx/base/siena_vpd.c:97:
+		if ((rc = siena_nvram_partn_read(enp, partn, SIENA_NVRAM_CHUNK,

CHECK:BRACES: braces {} should be used on all arms of this statement
#2066: FILE: drivers/net/sfc/efx/base/siena_vpd.c:112:
+	if (vpd_length == 0)
[...]
+	else {
[...]

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2083: FILE: drivers/net/sfc/efx/base/siena_vpd.c:129:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2105: FILE: drivers/net/sfc/efx/base/siena_vpd.c:151:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#2112: FILE: drivers/net/sfc/efx/base/siena_vpd.c:158:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2129: FILE: drivers/net/sfc/efx/base/siena_vpd.c:175:
+	if ((rc = siena_vpd_get_static(enp, partn, &svpd, &size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2133: FILE: drivers/net/sfc/efx/base/siena_vpd.c:179:
+		if ((rc = efx_vpd_hunk_verify(svpd, size, NULL)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2140: FILE: drivers/net/sfc/efx/base/siena_vpd.c:186:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2149: FILE: drivers/net/sfc/efx/base/siena_vpd.c:195:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#2157: FILE: drivers/net/sfc/efx/base/siena_vpd.c:203:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2175: FILE: drivers/net/sfc/efx/base/siena_vpd.c:221:
+	if ((rc = siena_nvram_partn_size(enp, partn, sizep)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2178: FILE: drivers/net/sfc/efx/base/siena_vpd.c:224:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2183: FILE: drivers/net/sfc/efx/base/siena_vpd.c:229:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#2192: FILE: drivers/net/sfc/efx/base/siena_vpd.c:238:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2206: FILE: drivers/net/sfc/efx/base/siena_vpd.c:252:
+	if ((rc = siena_nvram_get_dynamic_cfg(enp, dcfg_partn,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2226: FILE: drivers/net/sfc/efx/base/siena_vpd.c:272:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2235: FILE: drivers/net/sfc/efx/base/siena_vpd.c:281:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2261: FILE: drivers/net/sfc/efx/base/siena_vpd.c:307:
+	if ((rc = efx_vpd_hunk_verify(data, size, NULL)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2274: FILE: drivers/net/sfc/efx/base/siena_vpd.c:320:
+		if ((rc = efx_vpd_hunk_next(data, size, &dtag,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2290: FILE: drivers/net/sfc/efx/base/siena_vpd.c:336:
+			if ((rc = efx_vpd_hunk_next(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2306: FILE: drivers/net/sfc/efx/base/siena_vpd.c:352:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2317: FILE: drivers/net/sfc/efx/base/siena_vpd.c:363:
+	return (rc);

CHECK:BRACES: braces {} should be used on all arms of this statement
#2332: FILE: drivers/net/sfc/efx/base/siena_vpd.c:378:
+	if (enp->en_u.siena.enu_svpd_length == 0)
[...]
+	else {
[...]

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2349: FILE: drivers/net/sfc/efx/base/siena_vpd.c:395:
+	if ((rc = efx_vpd_hunk_reinit(data, size, wantpid)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2352: FILE: drivers/net/sfc/efx/base/siena_vpd.c:398:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2359: FILE: drivers/net/sfc/efx/base/siena_vpd.c:405:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2377: FILE: drivers/net/sfc/efx/base/siena_vpd.c:423:
+		if ((rc = efx_vpd_hunk_get(enp->en_u.siena.enu_svpd,

CHECK:BRACES: braces {} should be used on all arms of this statement
#2377: FILE: drivers/net/sfc/efx/base/siena_vpd.c:423:
+		if ((rc = efx_vpd_hunk_get(enp->en_u.siena.enu_svpd,
[...]
+		} else if (rc != ENOENT)
[...]

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2383: FILE: drivers/net/sfc/efx/base/siena_vpd.c:429:
+			return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2389: FILE: drivers/net/sfc/efx/base/siena_vpd.c:435:
+	if ((rc = efx_vpd_hunk_get(data, size, evvp->evv_tag,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2392: FILE: drivers/net/sfc/efx/base/siena_vpd.c:438:
+			return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2400: FILE: drivers/net/sfc/efx/base/siena_vpd.c:446:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2407: FILE: drivers/net/sfc/efx/base/siena_vpd.c:453:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2426: FILE: drivers/net/sfc/efx/base/siena_vpd.c:472:
+		if ((rc = efx_vpd_hunk_get(enp->en_u.siena.enu_svpd,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2434: FILE: drivers/net/sfc/efx/base/siena_vpd.c:480:
+	if ((rc = efx_vpd_hunk_set(data, size, evvp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2437: FILE: drivers/net/sfc/efx/base/siena_vpd.c:483:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2444: FILE: drivers/net/sfc/efx/base/siena_vpd.c:490:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2457: FILE: drivers/net/sfc/efx/base/siena_vpd.c:503:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2457: FILE: drivers/net/sfc/efx/base/siena_vpd.c:503:
+	return (ENOTSUP);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#2466: FILE: drivers/net/sfc/efx/base/siena_vpd.c:512:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2480: FILE: drivers/net/sfc/efx/base/siena_vpd.c:526:
+	if ((rc = efx_vpd_hunk_length(data, size, &vpd_length)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2488: FILE: drivers/net/sfc/efx/base/siena_vpd.c:534:
+	if ((rc = siena_nvram_partn_size(enp, dcfg_partn, &partn_size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2491: FILE: drivers/net/sfc/efx/base/siena_vpd.c:537:
+	if ((rc = siena_nvram_partn_lock(enp, dcfg_partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2494: FILE: drivers/net/sfc/efx/base/siena_vpd.c:540:
+	if ((rc = siena_nvram_get_dynamic_cfg(enp, dcfg_partn,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2519: FILE: drivers/net/sfc/efx/base/siena_vpd.c:565:
+	if ((rc = siena_nvram_partn_erase(enp, dcfg_partn, 0, partn_size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2523: FILE: drivers/net/sfc/efx/base/siena_vpd.c:569:
+	if ((rc = siena_nvram_partn_write(enp, dcfg_partn, 0, (caddr_t)dcfg,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2531: FILE: drivers/net/sfc/efx/base/siena_vpd.c:577:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2552: FILE: drivers/net/sfc/efx/base/siena_vpd.c:598:
+	return (rc);

total: 133 errors, 10 warnings, 15 checks, 2444 lines checked


More information about the test-report mailing list