[dpdk-test-report] |WARNING| [PATCH v2 27/55] net/sfc: import libefx VPD support

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Nov 29 17:22:19 CET 2016
Previous message: [dpdk-test-report] |WARNING| [PATCH v2 29/55] net/sfc: import libefx licensing support
Next message: [dpdk-test-report] |SUCCESS| [PATCH v2 33/55] net/sfc: add device configuration checks
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17301

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#100: FILE: drivers/net/sfc/base/ef10_impl.h:822:
+extern	__checkReturn		efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#250: FILE: drivers/net/sfc/base/ef10_vpd.c:81:
+		if ((rc = efx_vpd_hunk_verify(svpd, svpd_size, NULL)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#258: FILE: drivers/net/sfc/base/ef10_vpd.c:89:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#267: FILE: drivers/net/sfc/base/ef10_vpd.c:98:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#286: FILE: drivers/net/sfc/base/ef10_vpd.c:117:
+	if ((rc = efx_mcdi_nvram_info(enp, NVRAM_PARTITION_TYPE_DYNAMIC_CONFIG,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#290: FILE: drivers/net/sfc/base/ef10_vpd.c:121:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#295: FILE: drivers/net/sfc/base/ef10_vpd.c:126:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#320: FILE: drivers/net/sfc/base/ef10_vpd.c:151:
+	if ((rc = ef10_nvram_partn_read_tlv(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#336: FILE: drivers/net/sfc/base/ef10_vpd.c:167:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#345: FILE: drivers/net/sfc/base/ef10_vpd.c:176:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#371: FILE: drivers/net/sfc/base/ef10_vpd.c:202:
+	if ((rc = efx_vpd_hunk_verify(data, size, NULL)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#384: FILE: drivers/net/sfc/base/ef10_vpd.c:215:
+		if ((rc = efx_vpd_hunk_next(data, size, &dtag,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#400: FILE: drivers/net/sfc/base/ef10_vpd.c:231:
+			if ((rc = efx_vpd_hunk_next(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#416: FILE: drivers/net/sfc/base/ef10_vpd.c:247:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#427: FILE: drivers/net/sfc/base/ef10_vpd.c:258:
+	return (rc);

CHECK:BRACES: braces {} should be used on all arms of this statement
#442: FILE: drivers/net/sfc/base/ef10_vpd.c:273:
+	if (enp->en_arch.ef10.ena_svpd_length == 0)
[...]
+	else {
[...]

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#459: FILE: drivers/net/sfc/base/ef10_vpd.c:290:
+	if ((rc = efx_vpd_hunk_reinit(data, size, wantpid)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#462: FILE: drivers/net/sfc/base/ef10_vpd.c:293:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#469: FILE: drivers/net/sfc/base/ef10_vpd.c:300:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#488: FILE: drivers/net/sfc/base/ef10_vpd.c:319:
+		if ((rc = efx_vpd_hunk_get(enp->en_arch.ef10.ena_svpd,

CHECK:BRACES: braces {} should be used on all arms of this statement
#488: FILE: drivers/net/sfc/base/ef10_vpd.c:319:
+		if ((rc = efx_vpd_hunk_get(enp->en_arch.ef10.ena_svpd,
[...]
+		} else if (rc != ENOENT)
[...]

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#494: FILE: drivers/net/sfc/base/ef10_vpd.c:325:
+			return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#500: FILE: drivers/net/sfc/base/ef10_vpd.c:331:
+	if ((rc = efx_vpd_hunk_get(data, size, evvp->evv_tag,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#503: FILE: drivers/net/sfc/base/ef10_vpd.c:334:
+			return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#510: FILE: drivers/net/sfc/base/ef10_vpd.c:341:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#517: FILE: drivers/net/sfc/base/ef10_vpd.c:348:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#537: FILE: drivers/net/sfc/base/ef10_vpd.c:368:
+		if ((rc = efx_vpd_hunk_get(enp->en_arch.ef10.ena_svpd,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#545: FILE: drivers/net/sfc/base/ef10_vpd.c:376:
+	if ((rc = efx_vpd_hunk_set(data, size, evvp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#548: FILE: drivers/net/sfc/base/ef10_vpd.c:379:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#555: FILE: drivers/net/sfc/base/ef10_vpd.c:386:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#568: FILE: drivers/net/sfc/base/ef10_vpd.c:399:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#568: FILE: drivers/net/sfc/base/ef10_vpd.c:399:
+	return (ENOTSUP);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#593: FILE: drivers/net/sfc/base/ef10_vpd.c:424:
+	if ((rc = efx_vpd_hunk_length(data, size, &vpd_length)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#597: FILE: drivers/net/sfc/base/ef10_vpd.c:428:
+	if ((rc = ef10_nvram_partn_write_segment_tlv(enp,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#603: FILE: drivers/net/sfc/base/ef10_vpd.c:434:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#611: FILE: drivers/net/sfc/base/ef10_vpd.c:442:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#991: FILE: drivers/net/sfc/base/efx_vpd.c:125:
+		if ((rc = evpdop->evpdo_init(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#998: FILE: drivers/net/sfc/base/efx_vpd.c:132:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1005: FILE: drivers/net/sfc/base/efx_vpd.c:139:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1019: FILE: drivers/net/sfc/base/efx_vpd.c:153:
+	if ((rc = evpdop->evpdo_size(enp, sizep)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1022: FILE: drivers/net/sfc/base/efx_vpd.c:156:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1027: FILE: drivers/net/sfc/base/efx_vpd.c:161:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1042: FILE: drivers/net/sfc/base/efx_vpd.c:176:
+	if ((rc = evpdop->evpdo_read(enp, data, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1045: FILE: drivers/net/sfc/base/efx_vpd.c:179:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1050: FILE: drivers/net/sfc/base/efx_vpd.c:184:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1065: FILE: drivers/net/sfc/base/efx_vpd.c:199:
+	if ((rc = evpdop->evpdo_verify(enp, data, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1068: FILE: drivers/net/sfc/base/efx_vpd.c:202:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1073: FILE: drivers/net/sfc/base/efx_vpd.c:207:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1093: FILE: drivers/net/sfc/base/efx_vpd.c:227:
+	if ((rc = evpdop->evpdo_reinit(enp, data, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1096: FILE: drivers/net/sfc/base/efx_vpd.c:230:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1103: FILE: drivers/net/sfc/base/efx_vpd.c:237:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1119: FILE: drivers/net/sfc/base/efx_vpd.c:253:
+	if ((rc = evpdop->evpdo_get(enp, data, size, evvp)) != 0) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1121: FILE: drivers/net/sfc/base/efx_vpd.c:255:
+			return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1126: FILE: drivers/net/sfc/base/efx_vpd.c:260:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1131: FILE: drivers/net/sfc/base/efx_vpd.c:265:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1147: FILE: drivers/net/sfc/base/efx_vpd.c:281:
+	if ((rc = evpdop->evpdo_set(enp, data, size, evvp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1150: FILE: drivers/net/sfc/base/efx_vpd.c:284:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1155: FILE: drivers/net/sfc/base/efx_vpd.c:289:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1172: FILE: drivers/net/sfc/base/efx_vpd.c:306:
+	if ((rc = evpdop->evpdo_next(enp, data, size, evvp, contp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1175: FILE: drivers/net/sfc/base/efx_vpd.c:309:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1180: FILE: drivers/net/sfc/base/efx_vpd.c:314:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1195: FILE: drivers/net/sfc/base/efx_vpd.c:329:
+	if ((rc = evpdop->evpdo_write(enp, data, size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1198: FILE: drivers/net/sfc/base/efx_vpd.c:332:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1203: FILE: drivers/net/sfc/base/efx_vpd.c:337:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1277: FILE: drivers/net/sfc/base/efx_vpd.c:411:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1288: FILE: drivers/net/sfc/base/efx_vpd.c:422:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1319: FILE: drivers/net/sfc/base/efx_vpd.c:453:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1326: FILE: drivers/net/sfc/base/efx_vpd.c:460:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1343: FILE: drivers/net/sfc/base/efx_vpd.c:477:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1353: FILE: drivers/net/sfc/base/efx_vpd.c:487:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1358: FILE: drivers/net/sfc/base/efx_vpd.c:492:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1385: FILE: drivers/net/sfc/base/efx_vpd.c:519:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1400: FILE: drivers/net/sfc/base/efx_vpd.c:534:
+			if ((rc = efx_vpd_next_keyword(data + offset,

WARNING:INDENTED_LABEL: labels should not be indented
#1418: FILE: drivers/net/sfc/base/efx_vpd.c:552:
+	done:

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1430: FILE: drivers/net/sfc/base/efx_vpd.c:564:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1443: FILE: drivers/net/sfc/base/efx_vpd.c:577:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1481: FILE: drivers/net/sfc/base/efx_vpd.c:615:
+		    sizeof (__efx_vpd_blank_pid));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1482: FILE: drivers/net/sfc/base/efx_vpd.c:616:
+		offset += sizeof (__efx_vpd_blank_pid);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1485: FILE: drivers/net/sfc/base/efx_vpd.c:619:
+	memcpy(data + offset, __efx_vpd_blank_r, sizeof (__efx_vpd_blank_r));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1486: FILE: drivers/net/sfc/base/efx_vpd.c:620:
+	offset += sizeof (__efx_vpd_blank_r);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1502: FILE: drivers/net/sfc/base/efx_vpd.c:636:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1507: FILE: drivers/net/sfc/base/efx_vpd.c:641:
+	return (rc);

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1530: FILE: drivers/net/sfc/base/efx_vpd.c:664:
+	offset = index = 0;

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1533: FILE: drivers/net/sfc/base/efx_vpd.c:667:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1554: FILE: drivers/net/sfc/base/efx_vpd.c:688:
+				if ((rc = efx_vpd_next_keyword(data + offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1579: FILE: drivers/net/sfc/base/efx_vpd.c:713:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1586: FILE: drivers/net/sfc/base/efx_vpd.c:720:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1609: FILE: drivers/net/sfc/base/efx_vpd.c:743:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1621: FILE: drivers/net/sfc/base/efx_vpd.c:755:
+				return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1625: FILE: drivers/net/sfc/base/efx_vpd.c:759:
+				if ((rc = efx_vpd_next_keyword(data + offset,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1632: FILE: drivers/net/sfc/base/efx_vpd.c:766:
+					return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1641: FILE: drivers/net/sfc/base/efx_vpd.c:775:
+	return (ENOENT);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOENT)
#1641: FILE: drivers/net/sfc/base/efx_vpd.c:775:
+	return (ENOENT);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1648: FILE: drivers/net/sfc/base/efx_vpd.c:782:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1699: FILE: drivers/net/sfc/base/efx_vpd.c:833:
+	if ((rc = efx_vpd_hunk_length(data, size, &used)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1706: FILE: drivers/net/sfc/base/efx_vpd.c:840:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

CHECK:BRACES: braces {} should be used on all arms of this statement
#1709: FILE: drivers/net/sfc/base/efx_vpd.c:843:
+		if (tag == EFX_VPD_END)
[...]
+		else if (tag != evvp->evv_tag) {
[...]

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1734: FILE: drivers/net/sfc/base/efx_vpd.c:868:
+		source = dest = 0;

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1736: FILE: drivers/net/sfc/base/efx_vpd.c:870:
+			if ((rc = efx_vpd_next_keyword(data + offset,

WARNING:TYPO_SPELLING: 'existant' may be misspelled - perhaps 'existent'?
#1759: FILE: drivers/net/sfc/base/efx_vpd.c:893:
+				 * user deleting a non-existant keyword then

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1763: FILE: drivers/net/sfc/base/efx_vpd.c:897:
+					return (0);

WARNING:INDENTED_LABEL: labels should not be indented
#1772: FILE: drivers/net/sfc/base/efx_vpd.c:906:
+	check_space:

CHECK:SPACING: No space is necessary after a cast
#1779: FILE: drivers/net/sfc/base/efx_vpd.c:913:
+		(void) memmove(data + dest, data + source, used - source);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1814: FILE: drivers/net/sfc/base/efx_vpd.c:948:
+		if ((rc = efx_vpd_next_tag(data, size, &offset,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1821: FILE: drivers/net/sfc/base/efx_vpd.c:955:
+				if ((rc = efx_vpd_next_keyword(data + offset,

CHECK:SPACING: No space is necessary after a cast
#1839: FILE: drivers/net/sfc/base/efx_vpd.c:973:
+	(void) memset(data + offset + taglen, 0xff, size - offset - taglen);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1841: FILE: drivers/net/sfc/base/efx_vpd.c:975:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1862: FILE: drivers/net/sfc/base/efx_vpd.c:996:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2022: FILE: drivers/net/sfc/base/siena_vpd.c:60:
+	if ((rc = siena_nvram_partn_size(enp, partn, &size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2031: FILE: drivers/net/sfc/base/siena_vpd.c:69:
+	if ((rc = siena_nvram_partn_read(enp, partn, 0,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2059: FILE: drivers/net/sfc/base/siena_vpd.c:97:
+		if ((rc = siena_nvram_partn_read(enp, partn, SIENA_NVRAM_CHUNK,

CHECK:BRACES: braces {} should be used on all arms of this statement
#2074: FILE: drivers/net/sfc/base/siena_vpd.c:112:
+	if (vpd_length == 0)
[...]
+	else {
[...]

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2091: FILE: drivers/net/sfc/base/siena_vpd.c:129:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2113: FILE: drivers/net/sfc/base/siena_vpd.c:151:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#2120: FILE: drivers/net/sfc/base/siena_vpd.c:158:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2137: FILE: drivers/net/sfc/base/siena_vpd.c:175:
+	if ((rc = siena_vpd_get_static(enp, partn, &svpd, &size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2141: FILE: drivers/net/sfc/base/siena_vpd.c:179:
+		if ((rc = efx_vpd_hunk_verify(svpd, size, NULL)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2148: FILE: drivers/net/sfc/base/siena_vpd.c:186:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2157: FILE: drivers/net/sfc/base/siena_vpd.c:195:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#2165: FILE: drivers/net/sfc/base/siena_vpd.c:203:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2183: FILE: drivers/net/sfc/base/siena_vpd.c:221:
+	if ((rc = siena_nvram_partn_size(enp, partn, sizep)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2186: FILE: drivers/net/sfc/base/siena_vpd.c:224:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2191: FILE: drivers/net/sfc/base/siena_vpd.c:229:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#2200: FILE: drivers/net/sfc/base/siena_vpd.c:238:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2214: FILE: drivers/net/sfc/base/siena_vpd.c:252:
+	if ((rc = siena_nvram_get_dynamic_cfg(enp, dcfg_partn,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2234: FILE: drivers/net/sfc/base/siena_vpd.c:272:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2243: FILE: drivers/net/sfc/base/siena_vpd.c:281:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2269: FILE: drivers/net/sfc/base/siena_vpd.c:307:
+	if ((rc = efx_vpd_hunk_verify(data, size, NULL)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2282: FILE: drivers/net/sfc/base/siena_vpd.c:320:
+		if ((rc = efx_vpd_hunk_next(data, size, &dtag,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2298: FILE: drivers/net/sfc/base/siena_vpd.c:336:
+			if ((rc = efx_vpd_hunk_next(

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2314: FILE: drivers/net/sfc/base/siena_vpd.c:352:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2325: FILE: drivers/net/sfc/base/siena_vpd.c:363:
+	return (rc);

CHECK:BRACES: braces {} should be used on all arms of this statement
#2340: FILE: drivers/net/sfc/base/siena_vpd.c:378:
+	if (enp->en_u.siena.enu_svpd_length == 0)
[...]
+	else {
[...]

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2357: FILE: drivers/net/sfc/base/siena_vpd.c:395:
+	if ((rc = efx_vpd_hunk_reinit(data, size, wantpid)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2360: FILE: drivers/net/sfc/base/siena_vpd.c:398:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2367: FILE: drivers/net/sfc/base/siena_vpd.c:405:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2385: FILE: drivers/net/sfc/base/siena_vpd.c:423:
+		if ((rc = efx_vpd_hunk_get(enp->en_u.siena.enu_svpd,

CHECK:BRACES: braces {} should be used on all arms of this statement
#2385: FILE: drivers/net/sfc/base/siena_vpd.c:423:
+		if ((rc = efx_vpd_hunk_get(enp->en_u.siena.enu_svpd,
[...]
+		} else if (rc != ENOENT)
[...]

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2391: FILE: drivers/net/sfc/base/siena_vpd.c:429:
+			return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2397: FILE: drivers/net/sfc/base/siena_vpd.c:435:
+	if ((rc = efx_vpd_hunk_get(data, size, evvp->evv_tag,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2400: FILE: drivers/net/sfc/base/siena_vpd.c:438:
+			return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2408: FILE: drivers/net/sfc/base/siena_vpd.c:446:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2415: FILE: drivers/net/sfc/base/siena_vpd.c:453:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2434: FILE: drivers/net/sfc/base/siena_vpd.c:472:
+		if ((rc = efx_vpd_hunk_get(enp->en_u.siena.enu_svpd,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2442: FILE: drivers/net/sfc/base/siena_vpd.c:480:
+	if ((rc = efx_vpd_hunk_set(data, size, evvp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2445: FILE: drivers/net/sfc/base/siena_vpd.c:483:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2452: FILE: drivers/net/sfc/base/siena_vpd.c:490:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2465: FILE: drivers/net/sfc/base/siena_vpd.c:503:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#2465: FILE: drivers/net/sfc/base/siena_vpd.c:503:
+	return (ENOTSUP);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#2474: FILE: drivers/net/sfc/base/siena_vpd.c:512:
+	efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2488: FILE: drivers/net/sfc/base/siena_vpd.c:526:
+	if ((rc = efx_vpd_hunk_length(data, size, &vpd_length)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2496: FILE: drivers/net/sfc/base/siena_vpd.c:534:
+	if ((rc = siena_nvram_partn_size(enp, dcfg_partn, &partn_size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2499: FILE: drivers/net/sfc/base/siena_vpd.c:537:
+	if ((rc = siena_nvram_partn_lock(enp, dcfg_partn)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2502: FILE: drivers/net/sfc/base/siena_vpd.c:540:
+	if ((rc = siena_nvram_get_dynamic_cfg(enp, dcfg_partn,

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2527: FILE: drivers/net/sfc/base/siena_vpd.c:565:
+	if ((rc = siena_nvram_partn_erase(enp, dcfg_partn, 0, partn_size)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#2531: FILE: drivers/net/sfc/base/siena_vpd.c:569:
+	if ((rc = siena_nvram_partn_write(enp, dcfg_partn, 0, (caddr_t)dcfg,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2539: FILE: drivers/net/sfc/base/siena_vpd.c:577:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#2560: FILE: drivers/net/sfc/base/siena_vpd.c:598:
+	return (rc);

total: 133 errors, 10 warnings, 15 checks, 2444 lines checked
Previous message: [dpdk-test-report] |WARNING| [PATCH v2 29/55] net/sfc: import libefx licensing support
Next message: [dpdk-test-report] |SUCCESS| [PATCH v2 33/55] net/sfc: add device configuration checks
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list