[dpdk-test-report] |WARNING| [PATCH v2 31/55] net/sfc: implement driver operation to init device on attach

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Nov 29 17:38:43 CET 2016


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17328

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#171: FILE: drivers/net/sfc/sfc.c:56:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#177: FILE: drivers/net/sfc/sfc.c:62:
+		return EFAULT;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#221: FILE: drivers/net/sfc/sfc.c:106:
+	return EFAULT;

CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#480: FILE: drivers/net/sfc/sfc_debug.h:51:
+		rte_panic("sfc " PCI_PRI_FMT " #%" PRIu8 ": " fmt "
",	\

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#677: FILE: drivers/net/sfc/sfc_mcdi.c:79:
+		RTE_BUILD_BUG_ON(SFC_MCDI_POLL_INTERVAL_MAX_US > UINT_MAX / 2);

total: 0 errors, 4 warnings, 1 checks, 664 lines checked


More information about the test-report mailing list