[dpdk-test-report] [PatchWork]|ERROR| pw15385 ntnic: add PMD driver
sys_stv at intel.com
sys_stv at intel.com
Fri Sep 2 08:31:28 CEST 2016
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR
Patchwork ID: 15385
http://www.dpdk.org/dev/patchwork/patch/15385/
Submitter: Finn Christensen <fc at napatech.com>
Date: Fri, 26 Aug 2016 13:44:01 +0000
DPDK git baseline: e22856313fff2db12d8e132dad446bbf74cf29a5
Check patch error:
15385:
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#397: FILE: drivers/net/ntnic/rte_eth_ntnic.c:56:
+/*
+ * hash = <value> (1..3)
WARNING: please, no spaces at the start of a line
#411: FILE: drivers/net/ntnic/rte_eth_ntnic.c:70:
+ uint32_t value[MAX_RX_QUEUES];$
WARNING: please, no spaces at the start of a line
#412: FILE: drivers/net/ntnic/rte_eth_ntnic.c:71:
+ int count;$
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#415: FILE: drivers/net/ntnic/rte_eth_ntnic.c:74:
+static volatile uint16_t port_locks[MAX_NTNIC_PORTS];
WARNING: please, no spaces at the start of a line
#418: FILE: drivers/net/ntnic/rte_eth_ntnic.c:77:
+ NtNetStreamRx_t pNetRx[MAX_RX_QUEUES]; /* NT Rx streams */$
WARNING: line over 80 characters
#419: FILE: drivers/net/ntnic/rte_eth_ntnic.c:78:
+ int curNetRx_idx; /* Current Rx stream index */
WARNING: please, no spaces at the start of a line
#419: FILE: drivers/net/ntnic/rte_eth_ntnic.c:78:
+ int curNetRx_idx; /* Current Rx stream index */$
WARNING: line over 80 characters
#420: FILE: drivers/net/ntnic/rte_eth_ntnic.c:79:
+ struct rte_mempool *mb_pool; /* mbuf memory pool */
WARNING: please, no spaces at the start of a line
#420: FILE: drivers/net/ntnic/rte_eth_ntnic.c:79:
+ struct rte_mempool *mb_pool; /* mbuf memory pool */$
WARNING: line over 80 characters
#421: FILE: drivers/net/ntnic/rte_eth_ntnic.c:80:
+ uint16_t buf_size; /* Size of data area in mbuf */
WARNING: please, no spaces at the start of a line
#421: FILE: drivers/net/ntnic/rte_eth_ntnic.c:80:
+ uint16_t buf_size; /* Size of data area in mbuf */$
WARNING: line over 80 characters
#422: FILE: drivers/net/ntnic/rte_eth_ntnic.c:81:
+ NtNetBuf_t pSeg; /* The current NT data segment we are working with */
WARNING: please, no spaces at the start of a line
#422: FILE: drivers/net/ntnic/rte_eth_ntnic.c:81:
+ NtNetBuf_t pSeg; /* The current NT data segment we are working with */$
WARNING: line over 80 characters
#423: FILE: drivers/net/ntnic/rte_eth_ntnic.c:82:
+ struct NtNetBuf_s pkt; /* The current packet */
WARNING: please, no spaces at the start of a line
#423: FILE: drivers/net/ntnic/rte_eth_ntnic.c:82:
+ struct NtNetBuf_s pkt; /* The current packet */$
WARNING: line over 80 characters
#424: FILE: drivers/net/ntnic/rte_eth_ntnic.c:83:
+ volatile unsigned long rx_pkts; /* Rx packet statistics */
WARNING: please, no spaces at the start of a line
#424: FILE: drivers/net/ntnic/rte_eth_ntnic.c:83:
+ volatile unsigned long rx_pkts; /* Rx packet statistics */$
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#424: FILE: drivers/net/ntnic/rte_eth_ntnic.c:83:
+ volatile unsigned long rx_pkts; /* Rx packet statistics */
WARNING: line over 80 characters
#425: FILE: drivers/net/ntnic/rte_eth_ntnic.c:84:
+ volatile unsigned long err_pkts; /* Rx error packet statistics */
WARNING: please, no spaces at the start of a line
#425: FILE: drivers/net/ntnic/rte_eth_ntnic.c:84:
+ volatile unsigned long err_pkts; /* Rx error packet statistics */$
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#425: FILE: drivers/net/ntnic/rte_eth_ntnic.c:84:
+ volatile unsigned long err_pkts; /* Rx error packet statistics */
WARNING: line over 80 characters
#426: FILE: drivers/net/ntnic/rte_eth_ntnic.c:85:
+ struct array_s astreamids; /* Array of NT streamids to read data from */
WARNING: please, no spaces at the start of a line
#426: FILE: drivers/net/ntnic/rte_eth_ntnic.c:85:
+ struct array_s astreamids; /* Array of NT streamids to read data from */$
WARNING: line over 80 characters
#427: FILE: drivers/net/ntnic/rte_eth_ntnic.c:86:
+ int enabled; /* Enabling/disabling of this queue */
WARNING: please, no spaces at the start of a line
#427: FILE: drivers/net/ntnic/rte_eth_ntnic.c:86:
+ int enabled; /* Enabling/disabling of this queue */$
WARNING: line over 80 characters
#431: FILE: drivers/net/ntnic/rte_eth_ntnic.c:90:
+ NtNetStreamTx_t pNetTx; /* NT Tx stream */
WARNING: please, no spaces at the start of a line
#431: FILE: drivers/net/ntnic/rte_eth_ntnic.c:90:
+ NtNetStreamTx_t pNetTx; /* NT Tx stream */$
WARNING: line over 80 characters
#432: FILE: drivers/net/ntnic/rte_eth_ntnic.c:91:
+ volatile unsigned long tx_pkts; /* Tx packet statistics */
WARNING: please, no spaces at the start of a line
#432: FILE: drivers/net/ntnic/rte_eth_ntnic.c:91:
+ volatile unsigned long tx_pkts; /* Tx packet statistics */$
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#432: FILE: drivers/net/ntnic/rte_eth_ntnic.c:91:
+ volatile unsigned long tx_pkts; /* Tx packet statistics */
WARNING: line over 80 characters
#433: FILE: drivers/net/ntnic/rte_eth_ntnic.c:92:
+ volatile unsigned long err_pkts; /* Tx error packet statistics */
WARNING: please, no spaces at the start of a line
#433: FILE: drivers/net/ntnic/rte_eth_ntnic.c:92:
+ volatile unsigned long err_pkts; /* Tx error packet statistics */$
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#433: FILE: drivers/net/ntnic/rte_eth_ntnic.c:92:
+ volatile unsigned long err_pkts; /* Tx error packet statistics */
WARNING: line over 80 characters
#434: FILE: drivers/net/ntnic/rte_eth_ntnic.c:93:
+ volatile uint16_t *plock; /* Per port transmit atomic lock */
WARNING: please, no spaces at the start of a line
#434: FILE: drivers/net/ntnic/rte_eth_ntnic.c:93:
+ volatile uint16_t *plock; /* Per port transmit atomic lock */$
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#434: FILE: drivers/net/ntnic/rte_eth_ntnic.c:93:
+ volatile uint16_t *plock; /* Per port transmit atomic lock */
WARNING: line over 80 characters
#435: FILE: drivers/net/ntnic/rte_eth_ntnic.c:94:
+ uint32_t port; /* Tx port for this queue */
WARNING: please, no spaces at the start of a line
#435: FILE: drivers/net/ntnic/rte_eth_ntnic.c:94:
+ uint32_t port; /* Tx port for this queue */$
WARNING: line over 80 characters
#436: FILE: drivers/net/ntnic/rte_eth_ntnic.c:95:
+ int enabled; /* Enabling/disabling of this queue */
WARNING: please, no spaces at the start of a line
#436: FILE: drivers/net/ntnic/rte_eth_ntnic.c:95:
+ int enabled; /* Enabling/disabling of this queue */$
WARNING: line over 80 characters
#437: FILE: drivers/net/ntnic/rte_eth_ntnic.c:96:
+ int fcs_add; /* If port HW needs added room for FCS */
WARNING: please, no spaces at the start of a line
#437: FILE: drivers/net/ntnic/rte_eth_ntnic.c:96:
+ int fcs_add; /* If port HW needs added room for FCS */$
WARNING: line over 80 characters
#441: FILE: drivers/net/ntnic/rte_eth_ntnic.c:100:
+ struct ntnic_rx_queue rxq[MAX_RX_QUEUES]; /* Array of Rx queues configured */
WARNING: please, no spaces at the start of a line
#441: FILE: drivers/net/ntnic/rte_eth_ntnic.c:100:
+ struct ntnic_rx_queue rxq[MAX_RX_QUEUES]; /* Array of Rx queues configured */$
WARNING: line over 80 characters
#442: FILE: drivers/net/ntnic/rte_eth_ntnic.c:101:
+ struct ntnic_tx_queue txq[MAX_TX_QUEUES]; /* Array of Tx queues configured */
WARNING: please, no spaces at the start of a line
#442: FILE: drivers/net/ntnic/rte_eth_ntnic.c:101:
+ struct ntnic_tx_queue txq[MAX_TX_QUEUES]; /* Array of Tx queues configured */$
WARNING: line over 80 characters
#443: FILE: drivers/net/ntnic/rte_eth_ntnic.c:102:
+ int if_index; /* Interface index always 0 - no bonding */
WARNING: please, no spaces at the start of a line
#443: FILE: drivers/net/ntnic/rte_eth_ntnic.c:102:
+ int if_index; /* Interface index always 0 - no bonding */$
WARNING: line over 80 characters
#444: FILE: drivers/net/ntnic/rte_eth_ntnic.c:103:
+ unsigned int nb_rx_queues; /* Number of Rx queues configured */
WARNING: please, no spaces at the start of a line
#444: FILE: drivers/net/ntnic/rte_eth_ntnic.c:103:
+ unsigned int nb_rx_queues; /* Number of Rx queues configured */$
WARNING: line over 80 characters
#445: FILE: drivers/net/ntnic/rte_eth_ntnic.c:104:
+ unsigned int nb_tx_queues; /* Number of Tx queues configured */
WARNING: please, no spaces at the start of a line
#445: FILE: drivers/net/ntnic/rte_eth_ntnic.c:104:
+ unsigned int nb_tx_queues; /* Number of Tx queues configured */$
WARNING: line over 80 characters
#446: FILE: drivers/net/ntnic/rte_eth_ntnic.c:105:
+ int MAC_50G; /* True if 50G ports */
WARNING: please, no spaces at the start of a line
#446: FILE: drivers/net/ntnic/rte_eth_ntnic.c:105:
+ int MAC_50G; /* True if 50G ports */$
WARNING: static const char * array should probably be static const char * const
#449: FILE: drivers/net/ntnic/rte_eth_ntnic.c:108:
+static const char *valid_arguments[] = {
WARNING: please, no spaces at the start of a line
#450: FILE: drivers/net/ntnic/rte_eth_ntnic.c:109:
+ ETH_NTNIC_PORT_ARG,$
WARNING: please, no spaces at the start of a line
#451: FILE: drivers/net/ntnic/rte_eth_ntnic.c:110:
+ ETH_NTNIC_PORTEND_ARG,$
WARNING: please, no spaces at the start of a line
#452: FILE: drivers/net/ntnic/rte_eth_ntnic.c:111:
+ ETH_NTNIC_RXQUEUES_ARG,$
WARNING: please, no spaces at the start of a line
#453: FILE: drivers/net/ntnic/rte_eth_ntnic.c:112:
+ ETH_NTNIC_TXQUEUES_ARG,$
WARNING: please, no spaces at the start of a line
#454: FILE: drivers/net/ntnic/rte_eth_ntnic.c:113:
+ ETH_NTNIC_STREAMID_ARG,$
WARNING: please, no spaces at the start of a line
#455: FILE: drivers/net/ntnic/rte_eth_ntnic.c:114:
+ ETH_NTNIC_HASH_ARG,$
WARNING: please, no spaces at the start of a line
#456: FILE: drivers/net/ntnic/rte_eth_ntnic.c:115:
+ NULL$
WARNING: please, no spaces at the start of a line
#464: FILE: drivers/net/ntnic/rte_eth_ntnic.c:123:
+ struct rte_mbuf *mbuf,$
WARNING: please, no spaces at the start of a line
#465: FILE: drivers/net/ntnic/rte_eth_ntnic.c:124:
+ const u_char *data,$
WARNING: please, no spaces at the start of a line
#466: FILE: drivers/net/ntnic/rte_eth_ntnic.c:125:
+ uint16_t data_len)$
WARNING: please, no spaces at the start of a line
#468: FILE: drivers/net/ntnic/rte_eth_ntnic.c:127:
+ struct rte_mbuf *m = mbuf;$
WARNING: please, no spaces at the start of a line
#471: FILE: drivers/net/ntnic/rte_eth_ntnic.c:130:
+ uint16_t len = rte_pktmbuf_tailroom(mbuf);$
WARNING: please, no spaces at the start of a line
#473: FILE: drivers/net/ntnic/rte_eth_ntnic.c:132:
+ rte_memcpy(rte_pktmbuf_append(mbuf, len), data, len);$
WARNING: please, no spaces at the start of a line
#474: FILE: drivers/net/ntnic/rte_eth_ntnic.c:133:
+ data_len -= len;$
WARNING: please, no spaces at the start of a line
#475: FILE: drivers/net/ntnic/rte_eth_ntnic.c:134:
+ data += len;$
WARNING: please, no spaces at the start of a line
#477: FILE: drivers/net/ntnic/rte_eth_ntnic.c:136:
+ while (data_len > 0) {$
WARNING: suspect code indent for conditional statements (7, 15)
#477: FILE: drivers/net/ntnic/rte_eth_ntnic.c:136:
+ while (data_len > 0) {
+ /* Allocate next mbuf and point to that. */
ERROR: code indent should use tabs where possible
#478: FILE: drivers/net/ntnic/rte_eth_ntnic.c:137:
+ /* Allocate next mbuf and point to that. */$
ERROR: code indent should use tabs where possible
#479: FILE: drivers/net/ntnic/rte_eth_ntnic.c:138:
+ m->next = rte_pktmbuf_alloc(mb_pool);$
WARNING: please, no spaces at the start of a line
#479: FILE: drivers/net/ntnic/rte_eth_ntnic.c:138:
+ m->next = rte_pktmbuf_alloc(mb_pool);$
ERROR: code indent should use tabs where possible
#481: FILE: drivers/net/ntnic/rte_eth_ntnic.c:140:
+ if (unlikely(!m->next))$
WARNING: please, no spaces at the start of a line
#481: FILE: drivers/net/ntnic/rte_eth_ntnic.c:140:
+ if (unlikely(!m->next))$
WARNING: suspect code indent for conditional statements (15, 23)
#481: FILE: drivers/net/ntnic/rte_eth_ntnic.c:140:
+ if (unlikely(!m->next))
+ return -1;
ERROR: code indent should use tabs where possible
#482: FILE: drivers/net/ntnic/rte_eth_ntnic.c:141:
+ return -1;$
WARNING: please, no spaces at the start of a line
#482: FILE: drivers/net/ntnic/rte_eth_ntnic.c:141:
+ return -1;$
ERROR: code indent should use tabs where possible
#484: FILE: drivers/net/ntnic/rte_eth_ntnic.c:143:
+ m = m->next;$
WARNING: please, no spaces at the start of a line
#484: FILE: drivers/net/ntnic/rte_eth_ntnic.c:143:
+ m = m->next;$
ERROR: code indent should use tabs where possible
#486: FILE: drivers/net/ntnic/rte_eth_ntnic.c:145:
+ /* Headroom is not needed in chained mbufs. */$
ERROR: code indent should use tabs where possible
#487: FILE: drivers/net/ntnic/rte_eth_ntnic.c:146:
+ rte_pktmbuf_prepend(m, rte_pktmbuf_headroom(m));$
WARNING: please, no spaces at the start of a line
#487: FILE: drivers/net/ntnic/rte_eth_ntnic.c:146:
+ rte_pktmbuf_prepend(m, rte_pktmbuf_headroom(m));$
ERROR: code indent should use tabs where possible
#488: FILE: drivers/net/ntnic/rte_eth_ntnic.c:147:
+ m->pkt_len = 0;$
WARNING: please, no spaces at the start of a line
#488: FILE: drivers/net/ntnic/rte_eth_ntnic.c:147:
+ m->pkt_len = 0;$
ERROR: code indent should use tabs where possible
#489: FILE: drivers/net/ntnic/rte_eth_ntnic.c:148:
+ m->data_len = 0;$
WARNING: please, no spaces at the start of a line
#489: FILE: drivers/net/ntnic/rte_eth_ntnic.c:148:
+ m->data_len = 0;$
ERROR: code indent should use tabs where possible
#491: FILE: drivers/net/ntnic/rte_eth_ntnic.c:150:
+ /* Copy next segment. */$
ERROR: code indent should use tabs where possible
#492: FILE: drivers/net/ntnic/rte_eth_ntnic.c:151:
+ len = RTE_MIN(rte_pktmbuf_tailroom(m), data_len);$
WARNING: please, no spaces at the start of a line
#492: FILE: drivers/net/ntnic/rte_eth_ntnic.c:151:
+ len = RTE_MIN(rte_pktmbuf_tailroom(m), data_len);$
ERROR: code indent should use tabs where possible
#493: FILE: drivers/net/ntnic/rte_eth_ntnic.c:152:
+ rte_memcpy(rte_pktmbuf_append(m, len), data, len);$
WARNING: please, no spaces at the start of a line
#493: FILE: drivers/net/ntnic/rte_eth_ntnic.c:152:
+ rte_memcpy(rte_pktmbuf_append(m, len), data, len);$
ERROR: code indent should use tabs where possible
#495: FILE: drivers/net/ntnic/rte_eth_ntnic.c:154:
+ mbuf->nb_segs++;$
WARNING: please, no spaces at the start of a line
#495: FILE: drivers/net/ntnic/rte_eth_ntnic.c:154:
+ mbuf->nb_segs++;$
ERROR: code indent should use tabs where possible
#496: FILE: drivers/net/ntnic/rte_eth_ntnic.c:155:
+ data_len -= len;$
WARNING: please, no spaces at the start of a line
#496: FILE: drivers/net/ntnic/rte_eth_ntnic.c:155:
+ data_len -= len;$
ERROR: code indent should use tabs where possible
#497: FILE: drivers/net/ntnic/rte_eth_ntnic.c:156:
+ data += len;$
WARNING: please, no spaces at the start of a line
#497: FILE: drivers/net/ntnic/rte_eth_ntnic.c:156:
+ data += len;$
WARNING: please, no spaces at the start of a line
#498: FILE: drivers/net/ntnic/rte_eth_ntnic.c:157:
+ }$
WARNING: please, no spaces at the start of a line
#500: FILE: drivers/net/ntnic/rte_eth_ntnic.c:159:
+ return mbuf->nb_segs;$
WARNING: please, no spaces at the start of a line
#507: FILE: drivers/net/ntnic/rte_eth_ntnic.c:166:
+ struct rte_mbuf **bufs,$
WARNING: please, no spaces at the start of a line
#508: FILE: drivers/net/ntnic/rte_eth_ntnic.c:167:
+ uint16_t nb_pkts)$
WARNING: please, no spaces at the start of a line
#510: FILE: drivers/net/ntnic/rte_eth_ntnic.c:169:
+ unsigned i;$
WARNING: please, no spaces at the start of a line
#511: FILE: drivers/net/ntnic/rte_eth_ntnic.c:170:
+ struct rte_mbuf *mbuf;$
WARNING: please, no spaces at the start of a line
#512: FILE: drivers/net/ntnic/rte_eth_ntnic.c:171:
+ struct ntnic_rx_queue *rx_q = queue;$
WARNING: please, no spaces at the start of a line
#513: FILE: drivers/net/ntnic/rte_eth_ntnic.c:172:
+ uint16_t num_rx = 0;$
WARNING: please, no spaces at the start of a line
#514: FILE: drivers/net/ntnic/rte_eth_ntnic.c:173:
+ uint16_t data_len;$
WARNING: please, no spaces at the start of a line
#516: FILE: drivers/net/ntnic/rte_eth_ntnic.c:175:
+ if (unlikely(rx_q->pNetRx[rx_q->curNetRx_idx] == NULL || nb_pkts == 0))$
WARNING: suspect code indent for conditional statements (7, 15)
#516: FILE: drivers/net/ntnic/rte_eth_ntnic.c:175:
+ if (unlikely(rx_q->pNetRx[rx_q->curNetRx_idx] == NULL || nb_pkts == 0))
+ return 0;
ERROR: code indent should use tabs where possible
#517: FILE: drivers/net/ntnic/rte_eth_ntnic.c:176:
+ return 0;$
WARNING: please, no spaces at the start of a line
#517: FILE: drivers/net/ntnic/rte_eth_ntnic.c:176:
+ return 0;$
WARNING: please, no spaces at the start of a line
#520: FILE: drivers/net/ntnic/rte_eth_ntnic.c:179:
+ if (rx_q->pSeg == NULL) {$
WARNING: suspect code indent for conditional statements (7, 15)
#520: FILE: drivers/net/ntnic/rte_eth_ntnic.c:179:
+ if (rx_q->pSeg == NULL) {
+ /* Next stream - if multiple streams are combined */
ERROR: code indent should use tabs where possible
#521: FILE: drivers/net/ntnic/rte_eth_ntnic.c:180:
+ /* Next stream - if multiple streams are combined */$
WARNING: line over 80 characters
#522: FILE: drivers/net/ntnic/rte_eth_ntnic.c:181:
+ rx_q->curNetRx_idx = (rx_q->curNetRx_idx < (rx_q->astreamids.count - 1)) ? rx_q->curNetRx_idx + 1 : 0;
ERROR: code indent should use tabs where possible
#522: FILE: drivers/net/ntnic/rte_eth_ntnic.c:181:
+ rx_q->curNetRx_idx = (rx_q->curNetRx_idx < (rx_q->astreamids.count - 1)) ? rx_q->curNetRx_idx + 1 : 0;$
WARNING: please, no spaces at the start of a line
#522: FILE: drivers/net/ntnic/rte_eth_ntnic.c:181:
+ rx_q->curNetRx_idx = (rx_q->curNetRx_idx < (rx_q->astreamids.count - 1)) ? rx_q->curNetRx_idx + 1 : 0;$
WARNING: line over 80 characters
#524: FILE: drivers/net/ntnic/rte_eth_ntnic.c:183:
+ if (NT_NetRxGet(rx_q->pNetRx[rx_q->curNetRx_idx], &rx_q->pSeg, 0) != NT_SUCCESS) {
ERROR: code indent should use tabs where possible
#524: FILE: drivers/net/ntnic/rte_eth_ntnic.c:183:
+ if (NT_NetRxGet(rx_q->pNetRx[rx_q->curNetRx_idx], &rx_q->pSeg, 0) != NT_SUCCESS) {$
WARNING: please, no spaces at the start of a line
#524: FILE: drivers/net/ntnic/rte_eth_ntnic.c:183:
+ if (NT_NetRxGet(rx_q->pNetRx[rx_q->curNetRx_idx], &rx_q->pSeg, 0) != NT_SUCCESS) {$
WARNING: suspect code indent for conditional statements (15, 23)
#524: FILE: drivers/net/ntnic/rte_eth_ntnic.c:183:
+ if (NT_NetRxGet(rx_q->pNetRx[rx_q->curNetRx_idx], &rx_q->pSeg, 0) != NT_SUCCESS) {
+ if (rx_q->pSeg != NULL) {
ERROR: code indent should use tabs where possible
#525: FILE: drivers/net/ntnic/rte_eth_ntnic.c:184:
+ if (rx_q->pSeg != NULL) {$
WARNING: please, no spaces at the start of a line
#525: FILE: drivers/net/ntnic/rte_eth_ntnic.c:184:
+ if (rx_q->pSeg != NULL) {$
WARNING: suspect code indent for conditional statements (23, 31)
#525: FILE: drivers/net/ntnic/rte_eth_ntnic.c:184:
+ if (rx_q->pSeg != NULL) {
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);
WARNING: line over 80 characters
#526: FILE: drivers/net/ntnic/rte_eth_ntnic.c:185:
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);
ERROR: code indent should use tabs where possible
#526: FILE: drivers/net/ntnic/rte_eth_ntnic.c:185:
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);$
WARNING: please, no spaces at the start of a line
#526: FILE: drivers/net/ntnic/rte_eth_ntnic.c:185:
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);$
ERROR: code indent should use tabs where possible
#527: FILE: drivers/net/ntnic/rte_eth_ntnic.c:186:
+ rx_q->pSeg = NULL;$
WARNING: please, no spaces at the start of a line
#527: FILE: drivers/net/ntnic/rte_eth_ntnic.c:186:
+ rx_q->pSeg = NULL;$
ERROR: code indent should use tabs where possible
#528: FILE: drivers/net/ntnic/rte_eth_ntnic.c:187:
+ }$
WARNING: please, no spaces at the start of a line
#528: FILE: drivers/net/ntnic/rte_eth_ntnic.c:187:
+ }$
ERROR: code indent should use tabs where possible
#529: FILE: drivers/net/ntnic/rte_eth_ntnic.c:188:
+ return 0;$
WARNING: please, no spaces at the start of a line
#529: FILE: drivers/net/ntnic/rte_eth_ntnic.c:188:
+ return 0;$
ERROR: code indent should use tabs where possible
#531: FILE: drivers/net/ntnic/rte_eth_ntnic.c:190:
+ }$
WARNING: please, no spaces at the start of a line
#531: FILE: drivers/net/ntnic/rte_eth_ntnic.c:190:
+ }$
ERROR: code indent should use tabs where possible
#532: FILE: drivers/net/ntnic/rte_eth_ntnic.c:191:
+ if (NT_NET_GET_SEGMENT_LENGTH(rx_q->pSeg)) {$
WARNING: please, no spaces at the start of a line
#532: FILE: drivers/net/ntnic/rte_eth_ntnic.c:191:
+ if (NT_NET_GET_SEGMENT_LENGTH(rx_q->pSeg)) {$
WARNING: suspect code indent for conditional statements (15, 23)
#532: FILE: drivers/net/ntnic/rte_eth_ntnic.c:191:
+ if (NT_NET_GET_SEGMENT_LENGTH(rx_q->pSeg)) {
+ /* Build a packet structure */
ERROR: code indent should use tabs where possible
#533: FILE: drivers/net/ntnic/rte_eth_ntnic.c:192:
+ /* Build a packet structure */$
ERROR: code indent should use tabs where possible
#534: FILE: drivers/net/ntnic/rte_eth_ntnic.c:193:
+ _nt_net_build_pkt_netbuf(rx_q->pSeg, &rx_q->pkt);$
WARNING: please, no spaces at the start of a line
#534: FILE: drivers/net/ntnic/rte_eth_ntnic.c:193:
+ _nt_net_build_pkt_netbuf(rx_q->pSeg, &rx_q->pkt);$
ERROR: code indent should use tabs where possible
#535: FILE: drivers/net/ntnic/rte_eth_ntnic.c:194:
+ } else {$
WARNING: please, no spaces at the start of a line
#535: FILE: drivers/net/ntnic/rte_eth_ntnic.c:194:
+ } else {$
WARNING: line over 80 characters
#536: FILE: drivers/net/ntnic/rte_eth_ntnic.c:195:
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);
ERROR: code indent should use tabs where possible
#536: FILE: drivers/net/ntnic/rte_eth_ntnic.c:195:
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);$
WARNING: please, no spaces at the start of a line
#536: FILE: drivers/net/ntnic/rte_eth_ntnic.c:195:
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);$
ERROR: code indent should use tabs where possible
#537: FILE: drivers/net/ntnic/rte_eth_ntnic.c:196:
+ rx_q->pSeg = NULL;$
WARNING: please, no spaces at the start of a line
#537: FILE: drivers/net/ntnic/rte_eth_ntnic.c:196:
+ rx_q->pSeg = NULL;$
ERROR: code indent should use tabs where possible
#538: FILE: drivers/net/ntnic/rte_eth_ntnic.c:197:
+ return 0;$
WARNING: please, no spaces at the start of a line
#538: FILE: drivers/net/ntnic/rte_eth_ntnic.c:197:
+ return 0;$
ERROR: code indent should use tabs where possible
#539: FILE: drivers/net/ntnic/rte_eth_ntnic.c:198:
+ }$
WARNING: please, no spaces at the start of a line
#539: FILE: drivers/net/ntnic/rte_eth_ntnic.c:198:
+ }$
WARNING: please, no spaces at the start of a line
#540: FILE: drivers/net/ntnic/rte_eth_ntnic.c:199:
+ }$
WARNING: please, no spaces at the start of a line
#542: FILE: drivers/net/ntnic/rte_eth_ntnic.c:201:
+ if (rte_mempool_get_bulk(rx_q->mb_pool, (void **)bufs, nb_pkts) != 0)$
WARNING: suspect code indent for conditional statements (7, 15)
#542: FILE: drivers/net/ntnic/rte_eth_ntnic.c:201:
+ if (rte_mempool_get_bulk(rx_q->mb_pool, (void **)bufs, nb_pkts) != 0)
+ return 0;
ERROR: code indent should use tabs where possible
#543: FILE: drivers/net/ntnic/rte_eth_ntnic.c:202:
+ return 0;$
WARNING: please, no spaces at the start of a line
#543: FILE: drivers/net/ntnic/rte_eth_ntnic.c:202:
+ return 0;$
WARNING: please, no spaces at the start of a line
#545: FILE: drivers/net/ntnic/rte_eth_ntnic.c:204:
+ for (i = 0; i < nb_pkts; i++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#545: FILE: drivers/net/ntnic/rte_eth_ntnic.c:204:
+ for (i = 0; i < nb_pkts; i++) {
+ mbuf = bufs[i];
ERROR: code indent should use tabs where possible
#546: FILE: drivers/net/ntnic/rte_eth_ntnic.c:205:
+ mbuf = bufs[i];$
WARNING: please, no spaces at the start of a line
#546: FILE: drivers/net/ntnic/rte_eth_ntnic.c:205:
+ mbuf = bufs[i];$
ERROR: code indent should use tabs where possible
#547: FILE: drivers/net/ntnic/rte_eth_ntnic.c:206:
+ rte_mbuf_refcnt_set(mbuf, 1);$
WARNING: please, no spaces at the start of a line
#547: FILE: drivers/net/ntnic/rte_eth_ntnic.c:206:
+ rte_mbuf_refcnt_set(mbuf, 1);$
ERROR: code indent should use tabs where possible
#548: FILE: drivers/net/ntnic/rte_eth_ntnic.c:207:
+ rte_pktmbuf_reset(mbuf);$
WARNING: please, no spaces at the start of a line
#548: FILE: drivers/net/ntnic/rte_eth_ntnic.c:207:
+ rte_pktmbuf_reset(mbuf);$
ERROR: code indent should use tabs where possible
#550: FILE: drivers/net/ntnic/rte_eth_ntnic.c:209:
+ /* HW slicing not supported */$
WARNING: line over 80 characters
#551: FILE: drivers/net/ntnic/rte_eth_ntnic.c:210:
+ data_len = (uint16_t)NT_NET_GET_PKT_WIRE_LENGTH((&rx_q->pkt)) - 4;
ERROR: code indent should use tabs where possible
#551: FILE: drivers/net/ntnic/rte_eth_ntnic.c:210:
+ data_len = (uint16_t)NT_NET_GET_PKT_WIRE_LENGTH((&rx_q->pkt)) - 4;$
WARNING: please, no spaces at the start of a line
#551: FILE: drivers/net/ntnic/rte_eth_ntnic.c:210:
+ data_len = (uint16_t)NT_NET_GET_PKT_WIRE_LENGTH((&rx_q->pkt)) - 4;$
ERROR: code indent should use tabs where possible
#552: FILE: drivers/net/ntnic/rte_eth_ntnic.c:211:
+ if (data_len <= rx_q->buf_size) {$
WARNING: please, no spaces at the start of a line
#552: FILE: drivers/net/ntnic/rte_eth_ntnic.c:211:
+ if (data_len <= rx_q->buf_size) {$
WARNING: suspect code indent for conditional statements (15, 23)
#552: FILE: drivers/net/ntnic/rte_eth_ntnic.c:211:
+ if (data_len <= rx_q->buf_size) {
+ /* Packet will fit in the mbuf, go ahead and copy */
ERROR: code indent should use tabs where possible
#553: FILE: drivers/net/ntnic/rte_eth_ntnic.c:212:
+ /* Packet will fit in the mbuf, go ahead and copy */$
ERROR: code indent should use tabs where possible
#554: FILE: drivers/net/ntnic/rte_eth_ntnic.c:213:
+ mbuf->pkt_len = mbuf->data_len = data_len;$
WARNING: please, no spaces at the start of a line
#554: FILE: drivers/net/ntnic/rte_eth_ntnic.c:213:
+ mbuf->pkt_len = mbuf->data_len = data_len;$
WARNING: line over 80 characters
#555: FILE: drivers/net/ntnic/rte_eth_ntnic.c:214:
+ rte_memcpy((u_char *)mbuf->buf_addr + RTE_PKTMBUF_HEADROOM, NT_NET_GET_PKT_L2_PTR((&rx_q->pkt)), mbuf->data_len);
ERROR: code indent should use tabs where possible
#555: FILE: drivers/net/ntnic/rte_eth_ntnic.c:214:
+ rte_memcpy((u_char *)mbuf->buf_addr + RTE_PKTMBUF_HEADROOM, NT_NET_GET_PKT_L2_PTR((&rx_q->pkt)), mbuf->data_len);$
WARNING: please, no spaces at the start of a line
#555: FILE: drivers/net/ntnic/rte_eth_ntnic.c:214:
+ rte_memcpy((u_char *)mbuf->buf_addr + RTE_PKTMBUF_HEADROOM, NT_NET_GET_PKT_L2_PTR((&rx_q->pkt)), mbuf->data_len);$
ERROR: code indent should use tabs where possible
#556: FILE: drivers/net/ntnic/rte_eth_ntnic.c:215:
+ } else {$
WARNING: please, no spaces at the start of a line
#556: FILE: drivers/net/ntnic/rte_eth_ntnic.c:215:
+ } else {$
ERROR: code indent should use tabs where possible
#557: FILE: drivers/net/ntnic/rte_eth_ntnic.c:216:
+ /* Try read jumbo frame into multi mbufs. */$
ERROR: code indent should use tabs where possible
#558: FILE: drivers/net/ntnic/rte_eth_ntnic.c:217:
+ if (unlikely(eth_ntnic_rx_jumbo(rx_q->mb_pool,$
WARNING: please, no spaces at the start of a line
#558: FILE: drivers/net/ntnic/rte_eth_ntnic.c:217:
+ if (unlikely(eth_ntnic_rx_jumbo(rx_q->mb_pool,$
WARNING: suspect code indent for conditional statements (23, 31)
#558: FILE: drivers/net/ntnic/rte_eth_ntnic.c:217:
+ if (unlikely(eth_ntnic_rx_jumbo(rx_q->mb_pool,
[...]
+ break;
ERROR: code indent should use tabs where possible
#559: FILE: drivers/net/ntnic/rte_eth_ntnic.c:218:
+ mbuf,$
WARNING: please, no spaces at the start of a line
#559: FILE: drivers/net/ntnic/rte_eth_ntnic.c:218:
+ mbuf,$
WARNING: line over 80 characters
#560: FILE: drivers/net/ntnic/rte_eth_ntnic.c:219:
+ NT_NET_GET_PKT_L2_PTR((&rx_q->pkt)),
ERROR: code indent should use tabs where possible
#560: FILE: drivers/net/ntnic/rte_eth_ntnic.c:219:
+ NT_NET_GET_PKT_L2_PTR((&rx_q->pkt)),$
WARNING: please, no spaces at the start of a line
#560: FILE: drivers/net/ntnic/rte_eth_ntnic.c:219:
+ NT_NET_GET_PKT_L2_PTR((&rx_q->pkt)),$
ERROR: code indent should use tabs where possible
#561: FILE: drivers/net/ntnic/rte_eth_ntnic.c:220:
+ data_len) == -1))$
WARNING: please, no spaces at the start of a line
#561: FILE: drivers/net/ntnic/rte_eth_ntnic.c:220:
+ data_len) == -1))$
ERROR: code indent should use tabs where possible
#562: FILE: drivers/net/ntnic/rte_eth_ntnic.c:221:
+ break;$
WARNING: please, no spaces at the start of a line
#562: FILE: drivers/net/ntnic/rte_eth_ntnic.c:221:
+ break;$
ERROR: code indent should use tabs where possible
#563: FILE: drivers/net/ntnic/rte_eth_ntnic.c:222:
+ }$
WARNING: please, no spaces at the start of a line
#563: FILE: drivers/net/ntnic/rte_eth_ntnic.c:222:
+ }$
ERROR: code indent should use tabs where possible
#565: FILE: drivers/net/ntnic/rte_eth_ntnic.c:224:
+ mbuf->port = NT_NET_GET_PKT_RXPORT((&rx_q->pkt));$
WARNING: please, no spaces at the start of a line
#565: FILE: drivers/net/ntnic/rte_eth_ntnic.c:224:
+ mbuf->port = NT_NET_GET_PKT_RXPORT((&rx_q->pkt));$
ERROR: code indent should use tabs where possible
#566: FILE: drivers/net/ntnic/rte_eth_ntnic.c:225:
+ num_rx++;$
WARNING: please, no spaces at the start of a line
#566: FILE: drivers/net/ntnic/rte_eth_ntnic.c:225:
+ num_rx++;$
ERROR: code indent should use tabs where possible
#568: FILE: drivers/net/ntnic/rte_eth_ntnic.c:227:
+ /* Get the next packet if any */$
ERROR: code indent should use tabs where possible
#569: FILE: drivers/net/ntnic/rte_eth_ntnic.c:228:
+ if (_nt_net_get_next_packet(rx_q->pSeg,$
WARNING: please, no spaces at the start of a line
#569: FILE: drivers/net/ntnic/rte_eth_ntnic.c:228:
+ if (_nt_net_get_next_packet(rx_q->pSeg,$
WARNING: suspect code indent for conditional statements (15, 23)
#569: FILE: drivers/net/ntnic/rte_eth_ntnic.c:228:
+ if (_nt_net_get_next_packet(rx_q->pSeg,
[...]
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);
ERROR: code indent should use tabs where possible
#570: FILE: drivers/net/ntnic/rte_eth_ntnic.c:229:
+ NT_NET_GET_SEGMENT_LENGTH(rx_q->pSeg),$
WARNING: please, no spaces at the start of a line
#570: FILE: drivers/net/ntnic/rte_eth_ntnic.c:229:
+ NT_NET_GET_SEGMENT_LENGTH(rx_q->pSeg),$
ERROR: code indent should use tabs where possible
#571: FILE: drivers/net/ntnic/rte_eth_ntnic.c:230:
+ &rx_q->pkt) == 0 ) {$
WARNING: please, no spaces at the start of a line
#571: FILE: drivers/net/ntnic/rte_eth_ntnic.c:230:
+ &rx_q->pkt) == 0 ) {$
ERROR: space prohibited before that close parenthesis ')'
#571: FILE: drivers/net/ntnic/rte_eth_ntnic.c:230:
+ &rx_q->pkt) == 0 ) {
WARNING: line over 80 characters
#572: FILE: drivers/net/ntnic/rte_eth_ntnic.c:231:
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);
ERROR: code indent should use tabs where possible
#572: FILE: drivers/net/ntnic/rte_eth_ntnic.c:231:
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);$
WARNING: please, no spaces at the start of a line
#572: FILE: drivers/net/ntnic/rte_eth_ntnic.c:231:
+ NT_NetRxRelease(rx_q->pNetRx[rx_q->curNetRx_idx], rx_q->pSeg);$
ERROR: code indent should use tabs where possible
#573: FILE: drivers/net/ntnic/rte_eth_ntnic.c:232:
+ rx_q->pSeg = NULL;$
WARNING: please, no spaces at the start of a line
#573: FILE: drivers/net/ntnic/rte_eth_ntnic.c:232:
+ rx_q->pSeg = NULL;$
ERROR: code indent should use tabs where possible
#574: FILE: drivers/net/ntnic/rte_eth_ntnic.c:233:
+ break;$
WARNING: please, no spaces at the start of a line
#574: FILE: drivers/net/ntnic/rte_eth_ntnic.c:233:
+ break;$
ERROR: code indent should use tabs where possible
#575: FILE: drivers/net/ntnic/rte_eth_ntnic.c:234:
+ }$
WARNING: please, no spaces at the start of a line
#575: FILE: drivers/net/ntnic/rte_eth_ntnic.c:234:
+ }$
ERROR: code indent should use tabs where possible
#577: FILE: drivers/net/ntnic/rte_eth_ntnic.c:236:
+ rx_q->rx_pkts++;$
WARNING: please, no spaces at the start of a line
#577: FILE: drivers/net/ntnic/rte_eth_ntnic.c:236:
+ rx_q->rx_pkts++;$
WARNING: please, no spaces at the start of a line
#578: FILE: drivers/net/ntnic/rte_eth_ntnic.c:237:
+ }$
WARNING: please, no spaces at the start of a line
#580: FILE: drivers/net/ntnic/rte_eth_ntnic.c:239:
+ if (num_rx < nb_pkts) {$
WARNING: suspect code indent for conditional statements (7, 9)
#580: FILE: drivers/net/ntnic/rte_eth_ntnic.c:239:
+ if (num_rx < nb_pkts) {
+ rte_mempool_put_bulk(rx_q->mb_pool, (void * const *)(bufs + num_rx), nb_pkts-num_rx);
WARNING: braces {} are not necessary for single statement blocks
#580: FILE: drivers/net/ntnic/rte_eth_ntnic.c:239:
+ if (num_rx < nb_pkts) {
+ rte_mempool_put_bulk(rx_q->mb_pool, (void * const *)(bufs + num_rx), nb_pkts-num_rx);
+ }
WARNING: line over 80 characters
#581: FILE: drivers/net/ntnic/rte_eth_ntnic.c:240:
+ rte_mempool_put_bulk(rx_q->mb_pool, (void * const *)(bufs + num_rx), nb_pkts-num_rx);
ERROR: code indent should use tabs where possible
#581: FILE: drivers/net/ntnic/rte_eth_ntnic.c:240:
+ rte_mempool_put_bulk(rx_q->mb_pool, (void * const *)(bufs + num_rx), nb_pkts-num_rx);$
WARNING: please, no spaces at the start of a line
#581: FILE: drivers/net/ntnic/rte_eth_ntnic.c:240:
+ rte_mempool_put_bulk(rx_q->mb_pool, (void * const *)(bufs + num_rx), nb_pkts-num_rx);$
WARNING: please, no spaces at the start of a line
#582: FILE: drivers/net/ntnic/rte_eth_ntnic.c:241:
+ }$
WARNING: please, no spaces at the start of a line
#583: FILE: drivers/net/ntnic/rte_eth_ntnic.c:242:
+ return num_rx;$
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#591: FILE: drivers/net/ntnic/rte_eth_ntnic.c:250:
+/*
+ * Callback to handle sending packets through a NT NIC.
WARNING: please, no spaces at the start of a line
#595: FILE: drivers/net/ntnic/rte_eth_ntnic.c:254:
+ struct rte_mbuf **bufs,$
WARNING: please, no spaces at the start of a line
#596: FILE: drivers/net/ntnic/rte_eth_ntnic.c:255:
+ uint16_t nb_pkts)$
WARNING: please, no spaces at the start of a line
#598: FILE: drivers/net/ntnic/rte_eth_ntnic.c:257:
+ unsigned i;$
WARNING: please, no spaces at the start of a line
#599: FILE: drivers/net/ntnic/rte_eth_ntnic.c:258:
+ struct ntnic_tx_queue *tx_q = queue;$
WARNING: please, no spaces at the start of a line
#600: FILE: drivers/net/ntnic/rte_eth_ntnic.c:259:
+ int retval;$
WARNING: please, no spaces at the start of a line
#601: FILE: drivers/net/ntnic/rte_eth_ntnic.c:260:
+ uint16_t old;$
WARNING: please, no spaces at the start of a line
#602: FILE: drivers/net/ntnic/rte_eth_ntnic.c:261:
+ uint16_t new_flag = 0;$
WARNING: please, no spaces at the start of a line
#605: FILE: drivers/net/ntnic/rte_eth_ntnic.c:264:
+ if (unlikely(tx_q == NULL || tx_q->pNetTx == NULL || nb_pkts == 0)) {$
WARNING: suspect code indent for conditional statements (7, 15)
#605: FILE: drivers/net/ntnic/rte_eth_ntnic.c:264:
+ if (unlikely(tx_q == NULL || tx_q->pNetTx == NULL || nb_pkts == 0)) {
+ return 0;
WARNING: braces {} are not necessary for single statement blocks
#605: FILE: drivers/net/ntnic/rte_eth_ntnic.c:264:
+ if (unlikely(tx_q == NULL || tx_q->pNetTx == NULL || nb_pkts == 0)) {
+ return 0;
+ }
ERROR: code indent should use tabs where possible
#606: FILE: drivers/net/ntnic/rte_eth_ntnic.c:265:
+ return 0;$
WARNING: please, no spaces at the start of a line
#606: FILE: drivers/net/ntnic/rte_eth_ntnic.c:265:
+ return 0;$
WARNING: please, no spaces at the start of a line
#607: FILE: drivers/net/ntnic/rte_eth_ntnic.c:266:
+ }$
WARNING: please, no spaces at the start of a line
#609: FILE: drivers/net/ntnic/rte_eth_ntnic.c:268:
+ do {$
WARNING: suspect code indent for conditional statements (7, 15)
#609: FILE: drivers/net/ntnic/rte_eth_ntnic.c:268:
+ do {
+ old = 0;
ERROR: code indent should use tabs where possible
#610: FILE: drivers/net/ntnic/rte_eth_ntnic.c:269:
+ old = 0;$
WARNING: please, no spaces at the start of a line
#610: FILE: drivers/net/ntnic/rte_eth_ntnic.c:269:
+ old = 0;$
ERROR: code indent should use tabs where possible
#611: FILE: drivers/net/ntnic/rte_eth_ntnic.c:270:
+ new_flag = 1;$
WARNING: please, no spaces at the start of a line
#611: FILE: drivers/net/ntnic/rte_eth_ntnic.c:270:
+ new_flag = 1;$
ERROR: code indent should use tabs where possible
#612: FILE: drivers/net/ntnic/rte_eth_ntnic.c:271:
+ retval = rte_atomic16_cmpset(tx_q->plock, old, new_flag);$
WARNING: please, no spaces at the start of a line
#612: FILE: drivers/net/ntnic/rte_eth_ntnic.c:271:
+ retval = rte_atomic16_cmpset(tx_q->plock, old, new_flag);$
WARNING: please, no spaces at the start of a line
#613: FILE: drivers/net/ntnic/rte_eth_ntnic.c:272:
+ } while (unlikely(retval == 0));$
WARNING: please, no spaces at the start of a line
#615: FILE: drivers/net/ntnic/rte_eth_ntnic.c:274:
+ for (i = 0; i < nb_pkts; i++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#615: FILE: drivers/net/ntnic/rte_eth_ntnic.c:274:
+ for (i = 0; i < nb_pkts; i++) {
+ /* Not allowed to TX less than 64 byte packets */
ERROR: code indent should use tabs where possible
#616: FILE: drivers/net/ntnic/rte_eth_ntnic.c:275:
+ /* Not allowed to TX less than 64 byte packets */$
ERROR: code indent should use tabs where possible
#617: FILE: drivers/net/ntnic/rte_eth_ntnic.c:276:
+ if (bufs[i]->pkt_len < 60) {$
WARNING: please, no spaces at the start of a line
#617: FILE: drivers/net/ntnic/rte_eth_ntnic.c:276:
+ if (bufs[i]->pkt_len < 60) {$
WARNING: suspect code indent for conditional statements (15, 23)
#617: FILE: drivers/net/ntnic/rte_eth_ntnic.c:276:
+ if (bufs[i]->pkt_len < 60) {
+ bufs[i]->pkt_len = 60;
WARNING: braces {} are not necessary for single statement blocks
#617: FILE: drivers/net/ntnic/rte_eth_ntnic.c:276:
+ if (bufs[i]->pkt_len < 60) {
+ bufs[i]->pkt_len = 60;
+ }
ERROR: code indent should use tabs where possible
#618: FILE: drivers/net/ntnic/rte_eth_ntnic.c:277:
+ bufs[i]->pkt_len = 60;$
WARNING: please, no spaces at the start of a line
#618: FILE: drivers/net/ntnic/rte_eth_ntnic.c:277:
+ bufs[i]->pkt_len = 60;$
ERROR: code indent should use tabs where possible
#619: FILE: drivers/net/ntnic/rte_eth_ntnic.c:278:
+ }$
WARNING: please, no spaces at the start of a line
#619: FILE: drivers/net/ntnic/rte_eth_ntnic.c:278:
+ }$
ERROR: code indent should use tabs where possible
#620: FILE: drivers/net/ntnic/rte_eth_ntnic.c:279:
+ /* transmit a single packet */$
WARNING: line over 80 characters
#621: FILE: drivers/net/ntnic/rte_eth_ntnic.c:280:
+ NT_NetTxRingbufferTransmitPacket(tx_q->pNetTx, rte_pktmbuf_mtod(bufs[i], uint8_t *), bufs[i]->pkt_len + 4 - tx_q->fcs_add);
ERROR: code indent should use tabs where possible
#621: FILE: drivers/net/ntnic/rte_eth_ntnic.c:280:
+ NT_NetTxRingbufferTransmitPacket(tx_q->pNetTx, rte_pktmbuf_mtod(bufs[i], uint8_t *), bufs[i]->pkt_len + 4 - tx_q->fcs_add);$
WARNING: please, no spaces at the start of a line
#621: FILE: drivers/net/ntnic/rte_eth_ntnic.c:280:
+ NT_NetTxRingbufferTransmitPacket(tx_q->pNetTx, rte_pktmbuf_mtod(bufs[i], uint8_t *), bufs[i]->pkt_len + 4 - tx_q->fcs_add);$
ERROR: code indent should use tabs where possible
#622: FILE: drivers/net/ntnic/rte_eth_ntnic.c:281:
+ rte_pktmbuf_free(bufs[i]);$
WARNING: please, no spaces at the start of a line
#622: FILE: drivers/net/ntnic/rte_eth_ntnic.c:281:
+ rte_pktmbuf_free(bufs[i]);$
WARNING: please, no spaces at the start of a line
#623: FILE: drivers/net/ntnic/rte_eth_ntnic.c:282:
+ }$
WARNING: please, no spaces at the start of a line
#624: FILE: drivers/net/ntnic/rte_eth_ntnic.c:283:
+ tx_q->tx_pkts += nb_pkts;$
WARNING: please, no spaces at the start of a line
#626: FILE: drivers/net/ntnic/rte_eth_ntnic.c:285:
+ *tx_q->plock = 0;$
WARNING: please, no spaces at the start of a line
#627: FILE: drivers/net/ntnic/rte_eth_ntnic.c:286:
+ return nb_pkts;$
WARNING: please, no spaces at the start of a line
#635: FILE: drivers/net/ntnic/rte_eth_ntnic.c:294:
+ struct pmd_internals *internals = dev->data->dev_private;$
WARNING: please, no spaces at the start of a line
#636: FILE: drivers/net/ntnic/rte_eth_ntnic.c:295:
+ struct ntnic_rx_queue *rx_q = internals->rxq;$
WARNING: please, no spaces at the start of a line
#637: FILE: drivers/net/ntnic/rte_eth_ntnic.c:296:
+ struct ntnic_tx_queue *tx_q = internals->txq;$
WARNING: please, no spaces at the start of a line
#638: FILE: drivers/net/ntnic/rte_eth_ntnic.c:297:
+ uint queue;$
WARNING: please, no spaces at the start of a line
#639: FILE: drivers/net/ntnic/rte_eth_ntnic.c:298:
+ int status, idx;$
WARNING: please, no spaces at the start of a line
#641: FILE: drivers/net/ntnic/rte_eth_ntnic.c:300:
+ RTE_LOG(INFO, PMD, "NTNIC: %s
", __func__);$
WARNING: please, no spaces at the start of a line
#643: FILE: drivers/net/ntnic/rte_eth_ntnic.c:302:
+ if ((internals->nb_tx_queues | internals->nb_rx_queues) == 0) {$
WARNING: suspect code indent for conditional statements (7, 15)
#643: FILE: drivers/net/ntnic/rte_eth_ntnic.c:302:
+ if ((internals->nb_tx_queues | internals->nb_rx_queues) == 0) {
+ return -1;
WARNING: braces {} are not necessary for single statement blocks
#643: FILE: drivers/net/ntnic/rte_eth_ntnic.c:302:
+ if ((internals->nb_tx_queues | internals->nb_rx_queues) == 0) {
+ return -1;
+ }
ERROR: code indent should use tabs where possible
#644: FILE: drivers/net/ntnic/rte_eth_ntnic.c:303:
+ return -1;$
WARNING: please, no spaces at the start of a line
#644: FILE: drivers/net/ntnic/rte_eth_ntnic.c:303:
+ return -1;$
WARNING: please, no spaces at the start of a line
#645: FILE: drivers/net/ntnic/rte_eth_ntnic.c:304:
+ }$
WARNING: please, no spaces at the start of a line
#647: FILE: drivers/net/ntnic/rte_eth_ntnic.c:306:
+ for (queue = 0; queue < internals->nb_rx_queues; queue++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#647: FILE: drivers/net/ntnic/rte_eth_ntnic.c:306:
+ for (queue = 0; queue < internals->nb_rx_queues; queue++) {
+ if (rx_q[queue].enabled) {
ERROR: code indent should use tabs where possible
#648: FILE: drivers/net/ntnic/rte_eth_ntnic.c:307:
+ if (rx_q[queue].enabled) {$
WARNING: please, no spaces at the start of a line
#648: FILE: drivers/net/ntnic/rte_eth_ntnic.c:307:
+ if (rx_q[queue].enabled) {$
WARNING: suspect code indent for conditional statements (15, 23)
#648: FILE: drivers/net/ntnic/rte_eth_ntnic.c:307:
+ if (rx_q[queue].enabled) {
+ char str[128], val[10];
ERROR: code indent should use tabs where possible
#649: FILE: drivers/net/ntnic/rte_eth_ntnic.c:308:
+ char str[128], val[10];$
WARNING: please, no spaces at the start of a line
#649: FILE: drivers/net/ntnic/rte_eth_ntnic.c:308:
+ char str[128], val[10];$
ERROR: code indent should use tabs where possible
#650: FILE: drivers/net/ntnic/rte_eth_ntnic.c:309:
+ str[0] = 0;$
WARNING: please, no spaces at the start of a line
#650: FILE: drivers/net/ntnic/rte_eth_ntnic.c:309:
+ str[0] = 0;$
ERROR: code indent should use tabs where possible
#651: FILE: drivers/net/ntnic/rte_eth_ntnic.c:310:
+ /* build list of streamids to log */$
WARNING: line over 80 characters
#652: FILE: drivers/net/ntnic/rte_eth_ntnic.c:311:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {
ERROR: code indent should use tabs where possible
#652: FILE: drivers/net/ntnic/rte_eth_ntnic.c:311:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {$
WARNING: please, no spaces at the start of a line
#652: FILE: drivers/net/ntnic/rte_eth_ntnic.c:311:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {$
WARNING: suspect code indent for conditional statements (23, 31)
#652: FILE: drivers/net/ntnic/rte_eth_ntnic.c:311:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {
+ if (idx) sprintf(val,",%d",rx_q[queue].astreamids.value[idx]);
WARNING: line over 80 characters
#653: FILE: drivers/net/ntnic/rte_eth_ntnic.c:312:
+ if (idx) sprintf(val,",%d",rx_q[queue].astreamids.value[idx]);
ERROR: code indent should use tabs where possible
#653: FILE: drivers/net/ntnic/rte_eth_ntnic.c:312:
+ if (idx) sprintf(val,",%d",rx_q[queue].astreamids.value[idx]);$
WARNING: please, no spaces at the start of a line
#653: FILE: drivers/net/ntnic/rte_eth_ntnic.c:312:
+ if (idx) sprintf(val,",%d",rx_q[queue].astreamids.value[idx]);$
ERROR: space required after that ',' (ctx:VxV)
#653: FILE: drivers/net/ntnic/rte_eth_ntnic.c:312:
+ if (idx) sprintf(val,",%d",rx_q[queue].astreamids.value[idx]);
^
ERROR: space required after that ',' (ctx:VxV)
#653: FILE: drivers/net/ntnic/rte_eth_ntnic.c:312:
+ if (idx) sprintf(val,",%d",rx_q[queue].astreamids.value[idx]);
^
ERROR: trailing statements should be on next line
#653: FILE: drivers/net/ntnic/rte_eth_ntnic.c:312:
+ if (idx) sprintf(val,",%d",rx_q[queue].astreamids.value[idx]);
WARNING: line over 80 characters
#654: FILE: drivers/net/ntnic/rte_eth_ntnic.c:313:
+ else sprintf(val, "%i",rx_q[queue].astreamids.value[idx]);
ERROR: code indent should use tabs where possible
#654: FILE: drivers/net/ntnic/rte_eth_ntnic.c:313:
+ else sprintf(val, "%i",rx_q[queue].astreamids.value[idx]);$
WARNING: please, no spaces at the start of a line
#654: FILE: drivers/net/ntnic/rte_eth_ntnic.c:313:
+ else sprintf(val, "%i",rx_q[queue].astreamids.value[idx]);$
ERROR: space required after that ',' (ctx:VxV)
#654: FILE: drivers/net/ntnic/rte_eth_ntnic.c:313:
+ else sprintf(val, "%i",rx_q[queue].astreamids.value[idx]);
^
ERROR: trailing statements should be on next line
#654: FILE: drivers/net/ntnic/rte_eth_ntnic.c:313:
+ else sprintf(val, "%i",rx_q[queue].astreamids.value[idx]);
ERROR: code indent should use tabs where possible
#655: FILE: drivers/net/ntnic/rte_eth_ntnic.c:314:
+ strcat(str, val);$
WARNING: please, no spaces at the start of a line
#655: FILE: drivers/net/ntnic/rte_eth_ntnic.c:314:
+ strcat(str, val);$
ERROR: code indent should use tabs where possible
#656: FILE: drivers/net/ntnic/rte_eth_ntnic.c:315:
+ }$
WARNING: please, no spaces at the start of a line
#656: FILE: drivers/net/ntnic/rte_eth_ntnic.c:315:
+ }$
WARNING: line over 80 characters
#658: FILE: drivers/net/ntnic/rte_eth_ntnic.c:317:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {
ERROR: code indent should use tabs where possible
#658: FILE: drivers/net/ntnic/rte_eth_ntnic.c:317:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {$
WARNING: please, no spaces at the start of a line
#658: FILE: drivers/net/ntnic/rte_eth_ntnic.c:317:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {$
WARNING: suspect code indent for conditional statements (23, 31)
#658: FILE: drivers/net/ntnic/rte_eth_ntnic.c:317:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {
+ if ((status = NT_NetRxOpen(&rx_q[queue].pNetRx[idx], "DPDK", NT_NET_INTERFACE_SEGMENT,
WARNING: line over 80 characters
#659: FILE: drivers/net/ntnic/rte_eth_ntnic.c:318:
+ if ((status = NT_NetRxOpen(&rx_q[queue].pNetRx[idx], "DPDK", NT_NET_INTERFACE_SEGMENT,
ERROR: code indent should use tabs where possible
#659: FILE: drivers/net/ntnic/rte_eth_ntnic.c:318:
+ if ((status = NT_NetRxOpen(&rx_q[queue].pNetRx[idx], "DPDK", NT_NET_INTERFACE_SEGMENT,$
WARNING: please, no spaces at the start of a line
#659: FILE: drivers/net/ntnic/rte_eth_ntnic.c:318:
+ if ((status = NT_NetRxOpen(&rx_q[queue].pNetRx[idx], "DPDK", NT_NET_INTERFACE_SEGMENT,$
WARNING: suspect code indent for conditional statements (31, 39)
#659: FILE: drivers/net/ntnic/rte_eth_ntnic.c:318:
+ if ((status = NT_NetRxOpen(&rx_q[queue].pNetRx[idx], "DPDK", NT_NET_INTERFACE_SEGMENT,
[...]
+ /* try packet interface instead */
ERROR: do not use assignment in if condition
#659: FILE: drivers/net/ntnic/rte_eth_ntnic.c:318:
+ if ((status = NT_NetRxOpen(&rx_q[queue].pNetRx[idx], "DPDK", NT_NET_INTERFACE_SEGMENT,
WARNING: line over 80 characters
#660: FILE: drivers/net/ntnic/rte_eth_ntnic.c:319:
+ rx_q[queue].astreamids.value[idx], -1)) != NT_SUCCESS) {
ERROR: code indent should use tabs where possible
#660: FILE: drivers/net/ntnic/rte_eth_ntnic.c:319:
+ rx_q[queue].astreamids.value[idx], -1)) != NT_SUCCESS) {$
WARNING: please, no spaces at the start of a line
#660: FILE: drivers/net/ntnic/rte_eth_ntnic.c:319:
+ rx_q[queue].astreamids.value[idx], -1)) != NT_SUCCESS) {$
ERROR: code indent should use tabs where possible
#661: FILE: drivers/net/ntnic/rte_eth_ntnic.c:320:
+ /* try packet interface instead */$
WARNING: line over 80 characters
#662: FILE: drivers/net/ntnic/rte_eth_ntnic.c:321:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));
ERROR: code indent should use tabs where possible
#662: FILE: drivers/net/ntnic/rte_eth_ntnic.c:321:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));$
WARNING: please, no spaces at the start of a line
#662: FILE: drivers/net/ntnic/rte_eth_ntnic.c:321:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));$
WARNING: line over 80 characters
#663: FILE: drivers/net/ntnic/rte_eth_ntnic.c:322:
+ RTE_LOG(ERR, PMD, "NT_NetRxOpen() failed: %s
", errorBuffer);
ERROR: code indent should use tabs where possible
#663: FILE: drivers/net/ntnic/rte_eth_ntnic.c:322:
+ RTE_LOG(ERR, PMD, "NT_NetRxOpen() failed: %s
", errorBuffer);$
WARNING: please, no spaces at the start of a line
#663: FILE: drivers/net/ntnic/rte_eth_ntnic.c:322:
+ RTE_LOG(ERR, PMD, "NT_NetRxOpen() failed: %s
", errorBuffer);$
ERROR: code indent should use tabs where possible
#664: FILE: drivers/net/ntnic/rte_eth_ntnic.c:323:
+ return -1;$
WARNING: please, no spaces at the start of a line
#664: FILE: drivers/net/ntnic/rte_eth_ntnic.c:323:
+ return -1;$
ERROR: code indent should use tabs where possible
#665: FILE: drivers/net/ntnic/rte_eth_ntnic.c:324:
+ }$
WARNING: please, no spaces at the start of a line
#665: FILE: drivers/net/ntnic/rte_eth_ntnic.c:324:
+ }$
ERROR: code indent should use tabs where possible
#666: FILE: drivers/net/ntnic/rte_eth_ntnic.c:325:
+ }$
WARNING: please, no spaces at the start of a line
#666: FILE: drivers/net/ntnic/rte_eth_ntnic.c:325:
+ }$
ERROR: code indent should use tabs where possible
#667: FILE: drivers/net/ntnic/rte_eth_ntnic.c:326:
+ }$
WARNING: please, no spaces at the start of a line
#667: FILE: drivers/net/ntnic/rte_eth_ntnic.c:326:
+ }$
WARNING: please, no spaces at the start of a line
#668: FILE: drivers/net/ntnic/rte_eth_ntnic.c:327:
+ }$
WARNING: please, no spaces at the start of a line
#670: FILE: drivers/net/ntnic/rte_eth_ntnic.c:329:
+ for (queue = 0; queue < internals->nb_tx_queues; queue++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#670: FILE: drivers/net/ntnic/rte_eth_ntnic.c:329:
+ for (queue = 0; queue < internals->nb_tx_queues; queue++) {
+ if (tx_q[queue].enabled) {
ERROR: code indent should use tabs where possible
#671: FILE: drivers/net/ntnic/rte_eth_ntnic.c:330:
+ if (tx_q[queue].enabled) {$
WARNING: please, no spaces at the start of a line
#671: FILE: drivers/net/ntnic/rte_eth_ntnic.c:330:
+ if (tx_q[queue].enabled) {$
WARNING: suspect code indent for conditional statements (15, 23)
#671: FILE: drivers/net/ntnic/rte_eth_ntnic.c:330:
+ if (tx_q[queue].enabled) {
+ RTE_LOG(INFO, PMD, "NTNIC: NT_NetTxOpen(%d)
", tx_q[queue].port);
WARNING: line over 80 characters
#672: FILE: drivers/net/ntnic/rte_eth_ntnic.c:331:
+ RTE_LOG(INFO, PMD, "NTNIC: NT_NetTxOpen(%d)
", tx_q[queue].port);
ERROR: code indent should use tabs where possible
#672: FILE: drivers/net/ntnic/rte_eth_ntnic.c:331:
+ RTE_LOG(INFO, PMD, "NTNIC: NT_NetTxOpen(%d)
", tx_q[queue].port);$
WARNING: please, no spaces at the start of a line
#672: FILE: drivers/net/ntnic/rte_eth_ntnic.c:331:
+ RTE_LOG(INFO, PMD, "NTNIC: NT_NetTxOpen(%d)
", tx_q[queue].port);$
WARNING: line over 80 characters
#673: FILE: drivers/net/ntnic/rte_eth_ntnic.c:332:
+ if ((status = NT_NetTxOpen(&tx_q[queue].pNetTx, "DPDK", 1 << tx_q[queue].port,
ERROR: code indent should use tabs where possible
#673: FILE: drivers/net/ntnic/rte_eth_ntnic.c:332:
+ if ((status = NT_NetTxOpen(&tx_q[queue].pNetTx, "DPDK", 1 << tx_q[queue].port,$
WARNING: please, no spaces at the start of a line
#673: FILE: drivers/net/ntnic/rte_eth_ntnic.c:332:
+ if ((status = NT_NetTxOpen(&tx_q[queue].pNetTx, "DPDK", 1 << tx_q[queue].port,$
WARNING: suspect code indent for conditional statements (23, 31)
#673: FILE: drivers/net/ntnic/rte_eth_ntnic.c:332:
+ if ((status = NT_NetTxOpen(&tx_q[queue].pNetTx, "DPDK", 1 << tx_q[queue].port,
[...]
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));
ERROR: do not use assignment in if condition
#673: FILE: drivers/net/ntnic/rte_eth_ntnic.c:332:
+ if ((status = NT_NetTxOpen(&tx_q[queue].pNetTx, "DPDK", 1 << tx_q[queue].port,
WARNING: line over 80 characters
#674: FILE: drivers/net/ntnic/rte_eth_ntnic.c:333:
+ dev->pci_dev->numa_node, 0)) != NT_SUCCESS) {
ERROR: code indent should use tabs where possible
#674: FILE: drivers/net/ntnic/rte_eth_ntnic.c:333:
+ dev->pci_dev->numa_node, 0)) != NT_SUCCESS) {$
WARNING: please, no spaces at the start of a line
#674: FILE: drivers/net/ntnic/rte_eth_ntnic.c:333:
+ dev->pci_dev->numa_node, 0)) != NT_SUCCESS) {$
WARNING: line over 80 characters
#675: FILE: drivers/net/ntnic/rte_eth_ntnic.c:334:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));
ERROR: code indent should use tabs where possible
#675: FILE: drivers/net/ntnic/rte_eth_ntnic.c:334:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));$
WARNING: please, no spaces at the start of a line
#675: FILE: drivers/net/ntnic/rte_eth_ntnic.c:334:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));$
WARNING: line over 80 characters
#676: FILE: drivers/net/ntnic/rte_eth_ntnic.c:335:
+ RTE_LOG(INFO, PMD, "NT_NetTxOpen(0x%X, %d, 0) failed: %s
", 1 << tx_q[queue].port,
ERROR: code indent should use tabs where possible
#676: FILE: drivers/net/ntnic/rte_eth_ntnic.c:335:
+ RTE_LOG(INFO, PMD, "NT_NetTxOpen(0x%X, %d, 0) failed: %s
", 1 << tx_q[queue].port,$
WARNING: please, no spaces at the start of a line
#676: FILE: drivers/net/ntnic/rte_eth_ntnic.c:335:
+ RTE_LOG(INFO, PMD, "NT_NetTxOpen(0x%X, %d, 0) failed: %s
", 1 << tx_q[queue].port,$
WARNING: line over 80 characters
#677: FILE: drivers/net/ntnic/rte_eth_ntnic.c:336:
+ dev->pci_dev->numa_node, errorBuffer);
ERROR: code indent should use tabs where possible
#677: FILE: drivers/net/ntnic/rte_eth_ntnic.c:336:
+ dev->pci_dev->numa_node, errorBuffer);$
WARNING: please, no spaces at the start of a line
#677: FILE: drivers/net/ntnic/rte_eth_ntnic.c:336:
+ dev->pci_dev->numa_node, errorBuffer);$
ERROR: code indent should use tabs where possible
#678: FILE: drivers/net/ntnic/rte_eth_ntnic.c:337:
+ return -1;$
WARNING: please, no spaces at the start of a line
#678: FILE: drivers/net/ntnic/rte_eth_ntnic.c:337:
+ return -1;$
ERROR: code indent should use tabs where possible
#679: FILE: drivers/net/ntnic/rte_eth_ntnic.c:338:
+ }$
WARNING: please, no spaces at the start of a line
#679: FILE: drivers/net/ntnic/rte_eth_ntnic.c:338:
+ }$
WARNING: line over 80 characters
#681: FILE: drivers/net/ntnic/rte_eth_ntnic.c:340:
+ /* Initialize and associate RTD Tx Ring buffer to Tx handler */
ERROR: code indent should use tabs where possible
#681: FILE: drivers/net/ntnic/rte_eth_ntnic.c:340:
+ /* Initialize and associate RTD Tx Ring buffer to Tx handler */$
WARNING: line over 80 characters
#682: FILE: drivers/net/ntnic/rte_eth_ntnic.c:341:
+ if ((status = NT_NetTxRingbufferInit(tx_q[queue].pNetTx, tx_q[queue].port)) != NT_SUCCESS) {
ERROR: code indent should use tabs where possible
#682: FILE: drivers/net/ntnic/rte_eth_ntnic.c:341:
+ if ((status = NT_NetTxRingbufferInit(tx_q[queue].pNetTx, tx_q[queue].port)) != NT_SUCCESS) {$
WARNING: please, no spaces at the start of a line
#682: FILE: drivers/net/ntnic/rte_eth_ntnic.c:341:
+ if ((status = NT_NetTxRingbufferInit(tx_q[queue].pNetTx, tx_q[queue].port)) != NT_SUCCESS) {$
WARNING: suspect code indent for conditional statements (23, 31)
#682: FILE: drivers/net/ntnic/rte_eth_ntnic.c:341:
+ if ((status = NT_NetTxRingbufferInit(tx_q[queue].pNetTx, tx_q[queue].port)) != NT_SUCCESS) {
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));
ERROR: do not use assignment in if condition
#682: FILE: drivers/net/ntnic/rte_eth_ntnic.c:341:
+ if ((status = NT_NetTxRingbufferInit(tx_q[queue].pNetTx, tx_q[queue].port)) != NT_SUCCESS) {
WARNING: line over 80 characters
#683: FILE: drivers/net/ntnic/rte_eth_ntnic.c:342:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));
ERROR: code indent should use tabs where possible
#683: FILE: drivers/net/ntnic/rte_eth_ntnic.c:342:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));$
WARNING: please, no spaces at the start of a line
#683: FILE: drivers/net/ntnic/rte_eth_ntnic.c:342:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer));$
WARNING: line over 80 characters
#684: FILE: drivers/net/ntnic/rte_eth_ntnic.c:343:
+ RTE_LOG(ERR, PMD, "NT_NetRxOpen() failed: %s
", errorBuffer);
ERROR: code indent should use tabs where possible
#684: FILE: drivers/net/ntnic/rte_eth_ntnic.c:343:
+ RTE_LOG(ERR, PMD, "NT_NetRxOpen() failed: %s
", errorBuffer);$
WARNING: please, no spaces at the start of a line
#684: FILE: drivers/net/ntnic/rte_eth_ntnic.c:343:
+ RTE_LOG(ERR, PMD, "NT_NetRxOpen() failed: %s
", errorBuffer);$
ERROR: code indent should use tabs where possible
#685: FILE: drivers/net/ntnic/rte_eth_ntnic.c:344:
+ return -1;$
WARNING: please, no spaces at the start of a line
#685: FILE: drivers/net/ntnic/rte_eth_ntnic.c:344:
+ return -1;$
ERROR: code indent should use tabs where possible
#686: FILE: drivers/net/ntnic/rte_eth_ntnic.c:345:
+ }$
WARNING: please, no spaces at the start of a line
#686: FILE: drivers/net/ntnic/rte_eth_ntnic.c:345:
+ }$
ERROR: code indent should use tabs where possible
#687: FILE: drivers/net/ntnic/rte_eth_ntnic.c:346:
+ }$
WARNING: please, no spaces at the start of a line
#687: FILE: drivers/net/ntnic/rte_eth_ntnic.c:346:
+ }$
ERROR: code indent should use tabs where possible
#688: FILE: drivers/net/ntnic/rte_eth_ntnic.c:347:
+ tx_q[queue].plock = &port_locks[tx_q[queue].port];$
WARNING: please, no spaces at the start of a line
#688: FILE: drivers/net/ntnic/rte_eth_ntnic.c:347:
+ tx_q[queue].plock = &port_locks[tx_q[queue].port];$
ERROR: code indent should use tabs where possible
#689: FILE: drivers/net/ntnic/rte_eth_ntnic.c:348:
+ tx_q[queue].fcs_add = (internals->MAC_50G)?4:0;$
WARNING: please, no spaces at the start of a line
#689: FILE: drivers/net/ntnic/rte_eth_ntnic.c:348:
+ tx_q[queue].fcs_add = (internals->MAC_50G)?4:0;$
ERROR: spaces required around that '?' (ctx:VxV)
#689: FILE: drivers/net/ntnic/rte_eth_ntnic.c:348:
+ tx_q[queue].fcs_add = (internals->MAC_50G)?4:0;
^
ERROR: spaces required around that ':' (ctx:VxV)
#689: FILE: drivers/net/ntnic/rte_eth_ntnic.c:348:
+ tx_q[queue].fcs_add = (internals->MAC_50G)?4:0;
^
WARNING: please, no spaces at the start of a line
#690: FILE: drivers/net/ntnic/rte_eth_ntnic.c:349:
+ }$
WARNING: please, no spaces at the start of a line
#692: FILE: drivers/net/ntnic/rte_eth_ntnic.c:351:
+ dev->data->dev_link.link_status = 1;$
WARNING: please, no spaces at the start of a line
#693: FILE: drivers/net/ntnic/rte_eth_ntnic.c:352:
+ return 0;$
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#697: FILE: drivers/net/ntnic/rte_eth_ntnic.c:356:
+/*
+ * This function gets called when the current port gets stopped.
WARNING: please, no spaces at the start of a line
#704: FILE: drivers/net/ntnic/rte_eth_ntnic.c:363:
+ struct pmd_internals *internals = dev->data->dev_private;$
WARNING: please, no spaces at the start of a line
#705: FILE: drivers/net/ntnic/rte_eth_ntnic.c:364:
+ struct ntnic_rx_queue *rx_q = internals->rxq;$
WARNING: please, no spaces at the start of a line
#706: FILE: drivers/net/ntnic/rte_eth_ntnic.c:365:
+ struct ntnic_tx_queue *tx_q = internals->txq;$
WARNING: please, no spaces at the start of a line
#707: FILE: drivers/net/ntnic/rte_eth_ntnic.c:366:
+ uint queue;$
WARNING: please, no spaces at the start of a line
#708: FILE: drivers/net/ntnic/rte_eth_ntnic.c:367:
+ int idx;$
WARNING: please, no spaces at the start of a line
#709: FILE: drivers/net/ntnic/rte_eth_ntnic.c:368:
+ RTE_LOG(INFO, PMD, "NTNIC: %s
", __func__);$
WARNING: please, no spaces at the start of a line
#711: FILE: drivers/net/ntnic/rte_eth_ntnic.c:370:
+ for (queue = 0; queue < internals->nb_rx_queues; queue++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#711: FILE: drivers/net/ntnic/rte_eth_ntnic.c:370:
+ for (queue = 0; queue < internals->nb_rx_queues; queue++) {
+ if (rx_q[queue].pSeg) {
ERROR: code indent should use tabs where possible
#712: FILE: drivers/net/ntnic/rte_eth_ntnic.c:371:
+ if (rx_q[queue].pSeg) {$
WARNING: please, no spaces at the start of a line
#712: FILE: drivers/net/ntnic/rte_eth_ntnic.c:371:
+ if (rx_q[queue].pSeg) {$
WARNING: suspect code indent for conditional statements (15, 23)
#712: FILE: drivers/net/ntnic/rte_eth_ntnic.c:371:
+ if (rx_q[queue].pSeg) {
+ NT_NetRxRelease(rx_q[queue].pNetRx[rx_q->curNetRx_idx], rx_q[queue].pSeg);
WARNING: line over 80 characters
#713: FILE: drivers/net/ntnic/rte_eth_ntnic.c:372:
+ NT_NetRxRelease(rx_q[queue].pNetRx[rx_q->curNetRx_idx], rx_q[queue].pSeg);
ERROR: code indent should use tabs where possible
#713: FILE: drivers/net/ntnic/rte_eth_ntnic.c:372:
+ NT_NetRxRelease(rx_q[queue].pNetRx[rx_q->curNetRx_idx], rx_q[queue].pSeg);$
WARNING: please, no spaces at the start of a line
#713: FILE: drivers/net/ntnic/rte_eth_ntnic.c:372:
+ NT_NetRxRelease(rx_q[queue].pNetRx[rx_q->curNetRx_idx], rx_q[queue].pSeg);$
ERROR: code indent should use tabs where possible
#714: FILE: drivers/net/ntnic/rte_eth_ntnic.c:373:
+ rx_q[queue].pSeg = NULL;$
WARNING: please, no spaces at the start of a line
#714: FILE: drivers/net/ntnic/rte_eth_ntnic.c:373:
+ rx_q[queue].pSeg = NULL;$
ERROR: code indent should use tabs where possible
#715: FILE: drivers/net/ntnic/rte_eth_ntnic.c:374:
+ }$
WARNING: please, no spaces at the start of a line
#715: FILE: drivers/net/ntnic/rte_eth_ntnic.c:374:
+ }$
ERROR: code indent should use tabs where possible
#716: FILE: drivers/net/ntnic/rte_eth_ntnic.c:375:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {$
WARNING: please, no spaces at the start of a line
#716: FILE: drivers/net/ntnic/rte_eth_ntnic.c:375:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {$
WARNING: suspect code indent for conditional statements (15, 23)
#716: FILE: drivers/net/ntnic/rte_eth_ntnic.c:375:
+ for (idx = 0; idx < rx_q[queue].astreamids.count; idx++) {
+ if (rx_q[queue].pNetRx[idx]) {
ERROR: code indent should use tabs where possible
#717: FILE: drivers/net/ntnic/rte_eth_ntnic.c:376:
+ if (rx_q[queue].pNetRx[idx]) {$
WARNING: please, no spaces at the start of a line
#717: FILE: drivers/net/ntnic/rte_eth_ntnic.c:376:
+ if (rx_q[queue].pNetRx[idx]) {$
WARNING: suspect code indent for conditional statements (23, 31)
#717: FILE: drivers/net/ntnic/rte_eth_ntnic.c:376:
+ if (rx_q[queue].pNetRx[idx]) {
+ (void)NT_NetRxClose(rx_q[queue].pNetRx[idx]);
WARNING: braces {} are not necessary for single statement blocks
#717: FILE: drivers/net/ntnic/rte_eth_ntnic.c:376:
+ if (rx_q[queue].pNetRx[idx]) {
+ (void)NT_NetRxClose(rx_q[queue].pNetRx[idx]);
+ }
ERROR: code indent should use tabs where possible
#718: FILE: drivers/net/ntnic/rte_eth_ntnic.c:377:
+ (void)NT_NetRxClose(rx_q[queue].pNetRx[idx]);$
WARNING: please, no spaces at the start of a line
#718: FILE: drivers/net/ntnic/rte_eth_ntnic.c:377:
+ (void)NT_NetRxClose(rx_q[queue].pNetRx[idx]);$
ERROR: code indent should use tabs where possible
#719: FILE: drivers/net/ntnic/rte_eth_ntnic.c:378:
+ }$
WARNING: please, no spaces at the start of a line
#719: FILE: drivers/net/ntnic/rte_eth_ntnic.c:378:
+ }$
ERROR: code indent should use tabs where possible
#720: FILE: drivers/net/ntnic/rte_eth_ntnic.c:379:
+ }$
WARNING: please, no spaces at the start of a line
#720: FILE: drivers/net/ntnic/rte_eth_ntnic.c:379:
+ }$
WARNING: please, no spaces at the start of a line
#721: FILE: drivers/net/ntnic/rte_eth_ntnic.c:380:
+ }$
WARNING: please, no spaces at the start of a line
#722: FILE: drivers/net/ntnic/rte_eth_ntnic.c:381:
+ for (queue = 0; queue < internals->nb_tx_queues; queue++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#722: FILE: drivers/net/ntnic/rte_eth_ntnic.c:381:
+ for (queue = 0; queue < internals->nb_tx_queues; queue++) {
+ if (tx_q[queue].pNetTx) {
ERROR: code indent should use tabs where possible
#723: FILE: drivers/net/ntnic/rte_eth_ntnic.c:382:
+ if (tx_q[queue].pNetTx) {$
WARNING: please, no spaces at the start of a line
#723: FILE: drivers/net/ntnic/rte_eth_ntnic.c:382:
+ if (tx_q[queue].pNetTx) {$
WARNING: suspect code indent for conditional statements (15, 23)
#723: FILE: drivers/net/ntnic/rte_eth_ntnic.c:382:
+ if (tx_q[queue].pNetTx) {
+ NT_NetTxRingbufferDone(tx_q[queue].pNetTx);
ERROR: code indent should use tabs where possible
#724: FILE: drivers/net/ntnic/rte_eth_ntnic.c:383:
+ NT_NetTxRingbufferDone(tx_q[queue].pNetTx);$
WARNING: please, no spaces at the start of a line
#724: FILE: drivers/net/ntnic/rte_eth_ntnic.c:383:
+ NT_NetTxRingbufferDone(tx_q[queue].pNetTx);$
ERROR: code indent should use tabs where possible
#725: FILE: drivers/net/ntnic/rte_eth_ntnic.c:384:
+ (void)NT_NetTxClose(tx_q[queue].pNetTx);$
WARNING: please, no spaces at the start of a line
#725: FILE: drivers/net/ntnic/rte_eth_ntnic.c:384:
+ (void)NT_NetTxClose(tx_q[queue].pNetTx);$
ERROR: code indent should use tabs where possible
#726: FILE: drivers/net/ntnic/rte_eth_ntnic.c:385:
+ }$
WARNING: please, no spaces at the start of a line
#726: FILE: drivers/net/ntnic/rte_eth_ntnic.c:385:
+ }$
WARNING: please, no spaces at the start of a line
#727: FILE: drivers/net/ntnic/rte_eth_ntnic.c:386:
+ }$
WARNING: please, no spaces at the start of a line
#728: FILE: drivers/net/ntnic/rte_eth_ntnic.c:387:
+ dev->data->dev_link.link_status = 0;$
WARNING: please, no spaces at the start of a line
#734: FILE: drivers/net/ntnic/rte_eth_ntnic.c:393:
+ RTE_LOG(INFO, PMD, "NTNIC: %s
", __func__);$
WARNING: please, no spaces at the start of a line
#735: FILE: drivers/net/ntnic/rte_eth_ntnic.c:394:
+ return 0;$
ERROR: code indent should use tabs where possible
#740: FILE: drivers/net/ntnic/rte_eth_ntnic.c:399:
+ struct rte_eth_dev_info *dev_info)$
WARNING: please, no spaces at the start of a line
#740: FILE: drivers/net/ntnic/rte_eth_ntnic.c:399:
+ struct rte_eth_dev_info *dev_info)$
WARNING: please, no spaces at the start of a line
#742: FILE: drivers/net/ntnic/rte_eth_ntnic.c:401:
+ struct pmd_internals *internals = dev->data->dev_private;$
WARNING: please, no spaces at the start of a line
#743: FILE: drivers/net/ntnic/rte_eth_ntnic.c:402:
+ dev_info->if_index = internals->if_index;$
WARNING: please, no spaces at the start of a line
#744: FILE: drivers/net/ntnic/rte_eth_ntnic.c:403:
+ dev_info->driver_name = drivername;$
WARNING: please, no spaces at the start of a line
#745: FILE: drivers/net/ntnic/rte_eth_ntnic.c:404:
+ dev_info->max_mac_addrs = 1;$
WARNING: please, no spaces at the start of a line
#746: FILE: drivers/net/ntnic/rte_eth_ntnic.c:405:
+ dev_info->max_rx_pktlen = HW_MTU;$
WARNING: please, no spaces at the start of a line
#747: FILE: drivers/net/ntnic/rte_eth_ntnic.c:406:
+ dev_info->max_rx_queues = (uint16_t)internals->nb_rx_queues;$
WARNING: please, no spaces at the start of a line
#748: FILE: drivers/net/ntnic/rte_eth_ntnic.c:407:
+ dev_info->max_tx_queues = (uint16_t)internals->nb_tx_queues;$
WARNING: please, no spaces at the start of a line
#749: FILE: drivers/net/ntnic/rte_eth_ntnic.c:408:
+ dev_info->min_rx_bufsize = 0;$
WARNING: please, no spaces at the start of a line
#750: FILE: drivers/net/ntnic/rte_eth_ntnic.c:409:
+ dev_info->pci_dev = NULL;$
WARNING: please, no spaces at the start of a line
#755: FILE: drivers/net/ntnic/rte_eth_ntnic.c:414:
+ struct rte_eth_stats *igb_stats)$
WARNING: please, no spaces at the start of a line
#757: FILE: drivers/net/ntnic/rte_eth_ntnic.c:416:
+ unsigned i;$
WARNING: please, no spaces at the start of a line
#758: FILE: drivers/net/ntnic/rte_eth_ntnic.c:417:
+ unsigned long rx_total = 0;$
WARNING: please, no spaces at the start of a line
#759: FILE: drivers/net/ntnic/rte_eth_ntnic.c:418:
+ unsigned long tx_total = 0;$
WARNING: please, no spaces at the start of a line
#760: FILE: drivers/net/ntnic/rte_eth_ntnic.c:419:
+ unsigned long tx_err_total = 0;$
WARNING: please, no spaces at the start of a line
#761: FILE: drivers/net/ntnic/rte_eth_ntnic.c:420:
+ const struct pmd_internals *internal = dev->data->dev_private;$
WARNING: please, no spaces at the start of a line
#763: FILE: drivers/net/ntnic/rte_eth_ntnic.c:422:
+ memset(igb_stats, 0, sizeof(*igb_stats));$
WARNING: line over 80 characters
#764: FILE: drivers/net/ntnic/rte_eth_ntnic.c:423:
+ for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS && i < internal->nb_rx_queues; i++) {
WARNING: please, no spaces at the start of a line
#764: FILE: drivers/net/ntnic/rte_eth_ntnic.c:423:
+ for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS && i < internal->nb_rx_queues; i++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#764: FILE: drivers/net/ntnic/rte_eth_ntnic.c:423:
+ for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS && i < internal->nb_rx_queues; i++) {
+ igb_stats->q_ipackets[i] = internal->rxq[i].rx_pkts;
ERROR: code indent should use tabs where possible
#765: FILE: drivers/net/ntnic/rte_eth_ntnic.c:424:
+ igb_stats->q_ipackets[i] = internal->rxq[i].rx_pkts;$
WARNING: please, no spaces at the start of a line
#765: FILE: drivers/net/ntnic/rte_eth_ntnic.c:424:
+ igb_stats->q_ipackets[i] = internal->rxq[i].rx_pkts;$
ERROR: code indent should use tabs where possible
#766: FILE: drivers/net/ntnic/rte_eth_ntnic.c:425:
+ rx_total += igb_stats->q_ipackets[i];$
WARNING: please, no spaces at the start of a line
#766: FILE: drivers/net/ntnic/rte_eth_ntnic.c:425:
+ rx_total += igb_stats->q_ipackets[i];$
WARNING: please, no spaces at the start of a line
#767: FILE: drivers/net/ntnic/rte_eth_ntnic.c:426:
+ }$
WARNING: line over 80 characters
#768: FILE: drivers/net/ntnic/rte_eth_ntnic.c:427:
+ for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS && i < internal->nb_tx_queues; i++) {
WARNING: please, no spaces at the start of a line
#768: FILE: drivers/net/ntnic/rte_eth_ntnic.c:427:
+ for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS && i < internal->nb_tx_queues; i++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#768: FILE: drivers/net/ntnic/rte_eth_ntnic.c:427:
+ for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS && i < internal->nb_tx_queues; i++) {
+ igb_stats->q_opackets[i] = internal->txq[i].tx_pkts;
ERROR: code indent should use tabs where possible
#769: FILE: drivers/net/ntnic/rte_eth_ntnic.c:428:
+ igb_stats->q_opackets[i] = internal->txq[i].tx_pkts;$
WARNING: please, no spaces at the start of a line
#769: FILE: drivers/net/ntnic/rte_eth_ntnic.c:428:
+ igb_stats->q_opackets[i] = internal->txq[i].tx_pkts;$
ERROR: code indent should use tabs where possible
#770: FILE: drivers/net/ntnic/rte_eth_ntnic.c:429:
+ igb_stats->q_errors[i] = internal->txq[i].err_pkts;$
WARNING: please, no spaces at the start of a line
#770: FILE: drivers/net/ntnic/rte_eth_ntnic.c:429:
+ igb_stats->q_errors[i] = internal->txq[i].err_pkts;$
ERROR: code indent should use tabs where possible
#771: FILE: drivers/net/ntnic/rte_eth_ntnic.c:430:
+ tx_total += igb_stats->q_opackets[i];$
WARNING: please, no spaces at the start of a line
#771: FILE: drivers/net/ntnic/rte_eth_ntnic.c:430:
+ tx_total += igb_stats->q_opackets[i];$
ERROR: code indent should use tabs where possible
#772: FILE: drivers/net/ntnic/rte_eth_ntnic.c:431:
+ tx_err_total += igb_stats->q_errors[i];$
WARNING: please, no spaces at the start of a line
#772: FILE: drivers/net/ntnic/rte_eth_ntnic.c:431:
+ tx_err_total += igb_stats->q_errors[i];$
WARNING: please, no spaces at the start of a line
#773: FILE: drivers/net/ntnic/rte_eth_ntnic.c:432:
+ }$
WARNING: please, no spaces at the start of a line
#775: FILE: drivers/net/ntnic/rte_eth_ntnic.c:434:
+ igb_stats->ipackets = rx_total;$
WARNING: please, no spaces at the start of a line
#776: FILE: drivers/net/ntnic/rte_eth_ntnic.c:435:
+ igb_stats->opackets = tx_total;$
WARNING: please, no spaces at the start of a line
#777: FILE: drivers/net/ntnic/rte_eth_ntnic.c:436:
+ igb_stats->oerrors = tx_err_total;$
WARNING: please, no spaces at the start of a line
#783: FILE: drivers/net/ntnic/rte_eth_ntnic.c:442:
+ unsigned i;$
WARNING: please, no spaces at the start of a line
#784: FILE: drivers/net/ntnic/rte_eth_ntnic.c:443:
+ struct pmd_internals *internal = dev->data->dev_private;$
WARNING: please, no spaces at the start of a line
#786: FILE: drivers/net/ntnic/rte_eth_ntnic.c:445:
+ for (i = 0; i < internal->nb_rx_queues; i++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#786: FILE: drivers/net/ntnic/rte_eth_ntnic.c:445:
+ for (i = 0; i < internal->nb_rx_queues; i++) {
+ internal->rxq[i].rx_pkts = 0;
WARNING: braces {} are not necessary for single statement blocks
#786: FILE: drivers/net/ntnic/rte_eth_ntnic.c:445:
+ for (i = 0; i < internal->nb_rx_queues; i++) {
+ internal->rxq[i].rx_pkts = 0;
+ }
ERROR: code indent should use tabs where possible
#787: FILE: drivers/net/ntnic/rte_eth_ntnic.c:446:
+ internal->rxq[i].rx_pkts = 0;$
WARNING: please, no spaces at the start of a line
#787: FILE: drivers/net/ntnic/rte_eth_ntnic.c:446:
+ internal->rxq[i].rx_pkts = 0;$
WARNING: please, no spaces at the start of a line
#788: FILE: drivers/net/ntnic/rte_eth_ntnic.c:447:
+ }$
WARNING: please, no spaces at the start of a line
#789: FILE: drivers/net/ntnic/rte_eth_ntnic.c:448:
+ for (i = 0; i < internal->nb_tx_queues; i++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#789: FILE: drivers/net/ntnic/rte_eth_ntnic.c:448:
+ for (i = 0; i < internal->nb_tx_queues; i++) {
+ internal->txq[i].tx_pkts = 0;
ERROR: code indent should use tabs where possible
#790: FILE: drivers/net/ntnic/rte_eth_ntnic.c:449:
+ internal->txq[i].tx_pkts = 0;$
WARNING: please, no spaces at the start of a line
#790: FILE: drivers/net/ntnic/rte_eth_ntnic.c:449:
+ internal->txq[i].tx_pkts = 0;$
ERROR: code indent should use tabs where possible
#791: FILE: drivers/net/ntnic/rte_eth_ntnic.c:450:
+ internal->txq[i].err_pkts = 0;$
WARNING: please, no spaces at the start of a line
#791: FILE: drivers/net/ntnic/rte_eth_ntnic.c:450:
+ internal->txq[i].err_pkts = 0;$
WARNING: please, no spaces at the start of a line
#792: FILE: drivers/net/ntnic/rte_eth_ntnic.c:451:
+ }$
WARNING: please, no spaces at the start of a line
#798: FILE: drivers/net/ntnic/rte_eth_ntnic.c:457:
+ RTE_LOG(INFO, PMD, "NTNIC: %s
", __func__);$
WARNING: please, no spaces at the start of a line
#804: FILE: drivers/net/ntnic/rte_eth_ntnic.c:463:
+ RTE_LOG(INFO, PMD, "NTNIC: %s
", __func__);$
WARNING: please, no spaces at the start of a line
#809: FILE: drivers/net/ntnic/rte_eth_ntnic.c:468:
+ int wait_to_complete __rte_unused)$
WARNING: please, no spaces at the start of a line
#811: FILE: drivers/net/ntnic/rte_eth_ntnic.c:470:
+ return 0;$
WARNING: please, no spaces at the start of a line
#816: FILE: drivers/net/ntnic/rte_eth_ntnic.c:475:
+ uint16_t rx_queue_id,$
WARNING: please, no spaces at the start of a line
#817: FILE: drivers/net/ntnic/rte_eth_ntnic.c:476:
+ uint16_t nb_rx_desc __rte_unused,$
WARNING: please, no spaces at the start of a line
#818: FILE: drivers/net/ntnic/rte_eth_ntnic.c:477:
+ unsigned int socket_id __rte_unused,$
WARNING: please, no spaces at the start of a line
#819: FILE: drivers/net/ntnic/rte_eth_ntnic.c:478:
+ const struct rte_eth_rxconf *rx_conf __rte_unused,$
WARNING: please, no spaces at the start of a line
#820: FILE: drivers/net/ntnic/rte_eth_ntnic.c:479:
+ struct rte_mempool *mb_pool)$
WARNING: please, no spaces at the start of a line
#822: FILE: drivers/net/ntnic/rte_eth_ntnic.c:481:
+ struct rte_pktmbuf_pool_private *mbp_priv;$
WARNING: please, no spaces at the start of a line
#823: FILE: drivers/net/ntnic/rte_eth_ntnic.c:482:
+ struct pmd_internals *internals = dev->data->dev_private;$
WARNING: please, no spaces at the start of a line
#824: FILE: drivers/net/ntnic/rte_eth_ntnic.c:483:
+ struct ntnic_rx_queue *rx_q = &internals->rxq[rx_queue_id];$
WARNING: please, no spaces at the start of a line
#826: FILE: drivers/net/ntnic/rte_eth_ntnic.c:485:
+ RTE_LOG(INFO, PMD, "NTNIC RX queue setup
");$
WARNING: please, no spaces at the start of a line
#827: FILE: drivers/net/ntnic/rte_eth_ntnic.c:486:
+ rx_q->mb_pool = mb_pool;$
WARNING: please, no spaces at the start of a line
#828: FILE: drivers/net/ntnic/rte_eth_ntnic.c:487:
+ dev->data->rx_queues[rx_queue_id] = rx_q;$
WARNING: please, no spaces at the start of a line
#830: FILE: drivers/net/ntnic/rte_eth_ntnic.c:489:
+ mbp_priv = rte_mempool_get_priv(rx_q->mb_pool);$
WARNING: line over 80 characters
#831: FILE: drivers/net/ntnic/rte_eth_ntnic.c:490:
+ rx_q->buf_size = (uint16_t) (mbp_priv->mbuf_data_room_size - RTE_PKTMBUF_HEADROOM);
WARNING: please, no spaces at the start of a line
#831: FILE: drivers/net/ntnic/rte_eth_ntnic.c:490:
+ rx_q->buf_size = (uint16_t) (mbp_priv->mbuf_data_room_size - RTE_PKTMBUF_HEADROOM);$
WARNING: please, no spaces at the start of a line
#832: FILE: drivers/net/ntnic/rte_eth_ntnic.c:491:
+ rx_q->enabled = 1;$
WARNING: please, no spaces at the start of a line
#833: FILE: drivers/net/ntnic/rte_eth_ntnic.c:492:
+ return 0;$
WARNING: please, no spaces at the start of a line
#838: FILE: drivers/net/ntnic/rte_eth_ntnic.c:497:
+ uint16_t tx_queue_id __rte_unused,$
WARNING: please, no spaces at the start of a line
#839: FILE: drivers/net/ntnic/rte_eth_ntnic.c:498:
+ uint16_t nb_tx_desc __rte_unused,$
WARNING: please, no spaces at the start of a line
#840: FILE: drivers/net/ntnic/rte_eth_ntnic.c:499:
+ unsigned int socket_id __rte_unused,$
WARNING: please, no spaces at the start of a line
#841: FILE: drivers/net/ntnic/rte_eth_ntnic.c:500:
+ const struct rte_eth_txconf *tx_conf __rte_unused)$
WARNING: please, no spaces at the start of a line
#843: FILE: drivers/net/ntnic/rte_eth_ntnic.c:502:
+ struct pmd_internals *internals = dev->data->dev_private;$
WARNING: please, no spaces at the start of a line
#844: FILE: drivers/net/ntnic/rte_eth_ntnic.c:503:
+ RTE_LOG(INFO, PMD, "NTNIC TX queue setup
");$
WARNING: please, no spaces at the start of a line
#845: FILE: drivers/net/ntnic/rte_eth_ntnic.c:504:
+ dev->data->tx_queues[tx_queue_id] = &internals->txq[tx_queue_id];$
WARNING: please, no spaces at the start of a line
#846: FILE: drivers/net/ntnic/rte_eth_ntnic.c:505:
+ internals->txq[tx_queue_id].enabled = 1;$
WARNING: please, no spaces at the start of a line
#847: FILE: drivers/net/ntnic/rte_eth_ntnic.c:506:
+ return 0;$
WARNING: please, no spaces at the start of a line
#852: FILE: drivers/net/ntnic/rte_eth_ntnic.c:511:
+ if (mtu < 46 || mtu > HW_MTU)$
WARNING: suspect code indent for conditional statements (7, 15)
#852: FILE: drivers/net/ntnic/rte_eth_ntnic.c:511:
+ if (mtu < 46 || mtu > HW_MTU)
+ return -EINVAL;
ERROR: code indent should use tabs where possible
#853: FILE: drivers/net/ntnic/rte_eth_ntnic.c:512:
+ return -EINVAL;$
WARNING: please, no spaces at the start of a line
#853: FILE: drivers/net/ntnic/rte_eth_ntnic.c:512:
+ return -EINVAL;$
WARNING: please, no spaces at the start of a line
#855: FILE: drivers/net/ntnic/rte_eth_ntnic.c:514:
+ return 0;$
ERROR: code indent should use tabs where possible
#859: FILE: drivers/net/ntnic/rte_eth_ntnic.c:518:
+ .dev_start = eth_dev_start,$
WARNING: please, no spaces at the start of a line
#859: FILE: drivers/net/ntnic/rte_eth_ntnic.c:518:
+ .dev_start = eth_dev_start,$
ERROR: code indent should use tabs where possible
#860: FILE: drivers/net/ntnic/rte_eth_ntnic.c:519:
+ .dev_stop = eth_dev_stop,$
WARNING: please, no spaces at the start of a line
#860: FILE: drivers/net/ntnic/rte_eth_ntnic.c:519:
+ .dev_stop = eth_dev_stop,$
ERROR: code indent should use tabs where possible
#861: FILE: drivers/net/ntnic/rte_eth_ntnic.c:520:
+ .dev_close = eth_dev_close,$
WARNING: please, no spaces at the start of a line
#861: FILE: drivers/net/ntnic/rte_eth_ntnic.c:520:
+ .dev_close = eth_dev_close,$
ERROR: code indent should use tabs where possible
#862: FILE: drivers/net/ntnic/rte_eth_ntnic.c:521:
+ .mtu_set = _dev_set_mtu,$
WARNING: please, no spaces at the start of a line
#862: FILE: drivers/net/ntnic/rte_eth_ntnic.c:521:
+ .mtu_set = _dev_set_mtu,$
ERROR: code indent should use tabs where possible
#863: FILE: drivers/net/ntnic/rte_eth_ntnic.c:522:
+ .dev_configure = eth_dev_configure,$
WARNING: please, no spaces at the start of a line
#863: FILE: drivers/net/ntnic/rte_eth_ntnic.c:522:
+ .dev_configure = eth_dev_configure,$
ERROR: code indent should use tabs where possible
#864: FILE: drivers/net/ntnic/rte_eth_ntnic.c:523:
+ .dev_infos_get = eth_dev_info,$
WARNING: please, no spaces at the start of a line
#864: FILE: drivers/net/ntnic/rte_eth_ntnic.c:523:
+ .dev_infos_get = eth_dev_info,$
ERROR: code indent should use tabs where possible
#865: FILE: drivers/net/ntnic/rte_eth_ntnic.c:524:
+ .rx_queue_setup = eth_rx_queue_setup,$
WARNING: please, no spaces at the start of a line
#865: FILE: drivers/net/ntnic/rte_eth_ntnic.c:524:
+ .rx_queue_setup = eth_rx_queue_setup,$
ERROR: code indent should use tabs where possible
#866: FILE: drivers/net/ntnic/rte_eth_ntnic.c:525:
+ .tx_queue_setup = eth_tx_queue_setup,$
WARNING: please, no spaces at the start of a line
#866: FILE: drivers/net/ntnic/rte_eth_ntnic.c:525:
+ .tx_queue_setup = eth_tx_queue_setup,$
ERROR: code indent should use tabs where possible
#867: FILE: drivers/net/ntnic/rte_eth_ntnic.c:526:
+ .rx_queue_release = eth_queue_release,$
WARNING: please, no spaces at the start of a line
#867: FILE: drivers/net/ntnic/rte_eth_ntnic.c:526:
+ .rx_queue_release = eth_queue_release,$
ERROR: code indent should use tabs where possible
#868: FILE: drivers/net/ntnic/rte_eth_ntnic.c:527:
+ .tx_queue_release = eth_queue_release,$
WARNING: please, no spaces at the start of a line
#868: FILE: drivers/net/ntnic/rte_eth_ntnic.c:527:
+ .tx_queue_release = eth_queue_release,$
ERROR: code indent should use tabs where possible
#869: FILE: drivers/net/ntnic/rte_eth_ntnic.c:528:
+ .link_update = eth_link_update,$
WARNING: please, no spaces at the start of a line
#869: FILE: drivers/net/ntnic/rte_eth_ntnic.c:528:
+ .link_update = eth_link_update,$
ERROR: code indent should use tabs where possible
#870: FILE: drivers/net/ntnic/rte_eth_ntnic.c:529:
+ .stats_get = eth_stats_get,$
WARNING: please, no spaces at the start of a line
#870: FILE: drivers/net/ntnic/rte_eth_ntnic.c:529:
+ .stats_get = eth_stats_get,$
ERROR: code indent should use tabs where possible
#871: FILE: drivers/net/ntnic/rte_eth_ntnic.c:530:
+ .stats_reset = eth_stats_reset,$
WARNING: please, no spaces at the start of a line
#871: FILE: drivers/net/ntnic/rte_eth_ntnic.c:530:
+ .stats_reset = eth_stats_reset,$
ERROR: code indent should use tabs where possible
#876: FILE: drivers/net/ntnic/rte_eth_ntnic.c:535:
+ const unsigned nb_rx_queues,$
WARNING: please, no spaces at the start of a line
#876: FILE: drivers/net/ntnic/rte_eth_ntnic.c:535:
+ const unsigned nb_rx_queues,$
ERROR: code indent should use tabs where possible
#877: FILE: drivers/net/ntnic/rte_eth_ntnic.c:536:
+ const unsigned nb_tx_queues,$
WARNING: please, no spaces at the start of a line
#877: FILE: drivers/net/ntnic/rte_eth_ntnic.c:536:
+ const unsigned nb_tx_queues,$
ERROR: code indent should use tabs where possible
#878: FILE: drivers/net/ntnic/rte_eth_ntnic.c:537:
+ const unsigned numa_node,$
WARNING: please, no spaces at the start of a line
#878: FILE: drivers/net/ntnic/rte_eth_ntnic.c:537:
+ const unsigned numa_node,$
ERROR: code indent should use tabs where possible
#879: FILE: drivers/net/ntnic/rte_eth_ntnic.c:538:
+ struct array_s *pastreamids,$
WARNING: please, no spaces at the start of a line
#879: FILE: drivers/net/ntnic/rte_eth_ntnic.c:538:
+ struct array_s *pastreamids,$
ERROR: code indent should use tabs where possible
#880: FILE: drivers/net/ntnic/rte_eth_ntnic.c:539:
+ const uint32_t port,$
WARNING: please, no spaces at the start of a line
#880: FILE: drivers/net/ntnic/rte_eth_ntnic.c:539:
+ const uint32_t port,$
ERROR: code indent should use tabs where possible
#881: FILE: drivers/net/ntnic/rte_eth_ntnic.c:540:
+ struct rte_eth_dev **eth_dev)$
WARNING: please, no spaces at the start of a line
#881: FILE: drivers/net/ntnic/rte_eth_ntnic.c:540:
+ struct rte_eth_dev **eth_dev)$
WARNING: please, no spaces at the start of a line
#883: FILE: drivers/net/ntnic/rte_eth_ntnic.c:542:
+ struct pmd_internals *internals = NULL;$
WARNING: please, no spaces at the start of a line
#884: FILE: drivers/net/ntnic/rte_eth_ntnic.c:543:
+ struct rte_eth_dev_data *data = NULL;$
WARNING: please, no spaces at the start of a line
#885: FILE: drivers/net/ntnic/rte_eth_ntnic.c:544:
+ struct rte_pci_device *pci_dev = NULL;$
WARNING: please, no spaces at the start of a line
#886: FILE: drivers/net/ntnic/rte_eth_ntnic.c:545:
+ uint i, status;$
WARNING: please, no spaces at the start of a line
#887: FILE: drivers/net/ntnic/rte_eth_ntnic.c:546:
+ char errBuf[NT_ERRBUF_SIZE];$
WARNING: please, no spaces at the start of a line
#888: FILE: drivers/net/ntnic/rte_eth_ntnic.c:547:
+ NtInfoStream_t hInfo;$
WARNING: please, no spaces at the start of a line
#889: FILE: drivers/net/ntnic/rte_eth_ntnic.c:548:
+ NtInfo_t infoPort;$
WARNING: please, no spaces at the start of a line
#890: FILE: drivers/net/ntnic/rte_eth_ntnic.c:549:
+ struct rte_eth_link pmd_link;$
WARNING: please, no spaces at the start of a line
#891: FILE: drivers/net/ntnic/rte_eth_ntnic.c:550:
+ assert(nb_rx_queues < MAX_RX_QUEUES);$
WARNING: please, no spaces at the start of a line
#892: FILE: drivers/net/ntnic/rte_eth_ntnic.c:551:
+ assert(nb_tx_queues < MAX_TX_QUEUES);$
WARNING: please, no spaces at the start of a line
#893: FILE: drivers/net/ntnic/rte_eth_ntnic.c:552:
+ assert(port < MAX_NTNIC_PORTS);$
WARNING: please, no spaces at the start of a line
#895: FILE: drivers/net/ntnic/rte_eth_ntnic.c:554:
+ RTE_LOG(INFO, PMD,$
WARNING: line over 80 characters
#896: FILE: drivers/net/ntnic/rte_eth_ntnic.c:555:
+ "Creating ntnic-backend ethdev on numa socket %u
", numa_node);
ERROR: code indent should use tabs where possible
#896: FILE: drivers/net/ntnic/rte_eth_ntnic.c:555:
+ "Creating ntnic-backend ethdev on numa socket %u
", numa_node);$
WARNING: please, no spaces at the start of a line
#896: FILE: drivers/net/ntnic/rte_eth_ntnic.c:555:
+ "Creating ntnic-backend ethdev on numa socket %u
", numa_node);$
ERROR: code indent should use tabs where possible
#899: FILE: drivers/net/ntnic/rte_eth_ntnic.c:558:
+ * and internal (private) data$
ERROR: code indent should use tabs where possible
#900: FILE: drivers/net/ntnic/rte_eth_ntnic.c:559:
+ */$
WARNING: please, no spaces at the start of a line
#901: FILE: drivers/net/ntnic/rte_eth_ntnic.c:560:
+ data = rte_zmalloc_socket(name, sizeof(*data), 0, numa_node);$
WARNING: please, no spaces at the start of a line
#902: FILE: drivers/net/ntnic/rte_eth_ntnic.c:561:
+ if (data == NULL)$
WARNING: suspect code indent for conditional statements (7, 15)
#902: FILE: drivers/net/ntnic/rte_eth_ntnic.c:561:
+ if (data == NULL)
+ goto error;
ERROR: code indent should use tabs where possible
#903: FILE: drivers/net/ntnic/rte_eth_ntnic.c:562:
+ goto error;$
WARNING: please, no spaces at the start of a line
#903: FILE: drivers/net/ntnic/rte_eth_ntnic.c:562:
+ goto error;$
WARNING: please, no spaces at the start of a line
#905: FILE: drivers/net/ntnic/rte_eth_ntnic.c:564:
+ pci_dev = rte_zmalloc_socket(name, sizeof(*pci_dev), 0, numa_node);$
WARNING: please, no spaces at the start of a line
#906: FILE: drivers/net/ntnic/rte_eth_ntnic.c:565:
+ if (pci_dev == NULL)$
WARNING: suspect code indent for conditional statements (7, 15)
#906: FILE: drivers/net/ntnic/rte_eth_ntnic.c:565:
+ if (pci_dev == NULL)
+ goto error;
ERROR: code indent should use tabs where possible
#907: FILE: drivers/net/ntnic/rte_eth_ntnic.c:566:
+ goto error;$
WARNING: please, no spaces at the start of a line
#907: FILE: drivers/net/ntnic/rte_eth_ntnic.c:566:
+ goto error;$
WARNING: please, no spaces at the start of a line
#909: FILE: drivers/net/ntnic/rte_eth_ntnic.c:568:
+ internals = rte_zmalloc_socket(name, sizeof(*internals), 0, numa_node);$
WARNING: please, no spaces at the start of a line
#910: FILE: drivers/net/ntnic/rte_eth_ntnic.c:569:
+ if (internals == NULL)$
WARNING: suspect code indent for conditional statements (7, 15)
#910: FILE: drivers/net/ntnic/rte_eth_ntnic.c:569:
+ if (internals == NULL)
+ goto error;
ERROR: code indent should use tabs where possible
#911: FILE: drivers/net/ntnic/rte_eth_ntnic.c:570:
+ goto error;$
WARNING: please, no spaces at the start of a line
#911: FILE: drivers/net/ntnic/rte_eth_ntnic.c:570:
+ goto error;$
WARNING: please, no spaces at the start of a line
#914: FILE: drivers/net/ntnic/rte_eth_ntnic.c:573:
+ *eth_dev = rte_eth_dev_allocate(name, RTE_ETH_DEV_VIRTUAL);$
WARNING: please, no spaces at the start of a line
#915: FILE: drivers/net/ntnic/rte_eth_ntnic.c:574:
+ if (*eth_dev == NULL)$
WARNING: suspect code indent for conditional statements (7, 15)
#915: FILE: drivers/net/ntnic/rte_eth_ntnic.c:574:
+ if (*eth_dev == NULL)
+ goto error;
ERROR: code indent should use tabs where possible
#916: FILE: drivers/net/ntnic/rte_eth_ntnic.c:575:
+ goto error;$
WARNING: please, no spaces at the start of a line
#916: FILE: drivers/net/ntnic/rte_eth_ntnic.c:575:
+ goto error;$
WARNING: please, no spaces at the start of a line
#919: FILE: drivers/net/ntnic/rte_eth_ntnic.c:578:
+ if ((status = NT_InfoOpen(&hInfo, "DPDK Info stream")) != NT_SUCCESS) {$
WARNING: suspect code indent for conditional statements (7, 15)
#919: FILE: drivers/net/ntnic/rte_eth_ntnic.c:578:
+ if ((status = NT_InfoOpen(&hInfo, "DPDK Info stream")) != NT_SUCCESS) {
+ NT_ExplainError(status, errBuf, sizeof(errBuf));
ERROR: do not use assignment in if condition
#919: FILE: drivers/net/ntnic/rte_eth_ntnic.c:578:
+ if ((status = NT_InfoOpen(&hInfo, "DPDK Info stream")) != NT_SUCCESS) {
ERROR: code indent should use tabs where possible
#920: FILE: drivers/net/ntnic/rte_eth_ntnic.c:579:
+ NT_ExplainError(status, errBuf, sizeof(errBuf));$
WARNING: please, no spaces at the start of a line
#920: FILE: drivers/net/ntnic/rte_eth_ntnic.c:579:
+ NT_ExplainError(status, errBuf, sizeof(errBuf));$
WARNING: line over 80 characters
#921: FILE: drivers/net/ntnic/rte_eth_ntnic.c:580:
+ RTE_LOG(ERR, PMD, ">>> Error: NT_InfoOpen failed. Code 0x%x = %s
", status, errBuf);
ERROR: code indent should use tabs where possible
#921: FILE: drivers/net/ntnic/rte_eth_ntnic.c:580:
+ RTE_LOG(ERR, PMD, ">>> Error: NT_InfoOpen failed. Code 0x%x = %s
", status, errBuf);$
WARNING: please, no spaces at the start of a line
#921: FILE: drivers/net/ntnic/rte_eth_ntnic.c:580:
+ RTE_LOG(ERR, PMD, ">>> Error: NT_InfoOpen failed. Code 0x%x = %s
", status, errBuf);$
ERROR: code indent should use tabs where possible
#922: FILE: drivers/net/ntnic/rte_eth_ntnic.c:581:
+ return status;$
WARNING: please, no spaces at the start of a line
#922: FILE: drivers/net/ntnic/rte_eth_ntnic.c:581:
+ return status;$
WARNING: please, no spaces at the start of a line
#923: FILE: drivers/net/ntnic/rte_eth_ntnic.c:582:
+ }$
WARNING: please, no spaces at the start of a line
#926: FILE: drivers/net/ntnic/rte_eth_ntnic.c:585:
+ infoPort.cmd = NT_INFO_CMD_READ_PORT_V7;$
WARNING: please, no spaces at the start of a line
#927: FILE: drivers/net/ntnic/rte_eth_ntnic.c:586:
+ infoPort.u.port_v7.portNo = (uint8_t)(port);$
WARNING: please, no spaces at the start of a line
#928: FILE: drivers/net/ntnic/rte_eth_ntnic.c:587:
+ if ((status = NT_InfoRead(hInfo, &infoPort)) != 0) {$
WARNING: suspect code indent for conditional statements (7, 15)
#928: FILE: drivers/net/ntnic/rte_eth_ntnic.c:587:
+ if ((status = NT_InfoRead(hInfo, &infoPort)) != 0) {
+ NT_ExplainError(status, errBuf, sizeof(errBuf));
ERROR: do not use assignment in if condition
#928: FILE: drivers/net/ntnic/rte_eth_ntnic.c:587:
+ if ((status = NT_InfoRead(hInfo, &infoPort)) != 0) {
ERROR: code indent should use tabs where possible
#929: FILE: drivers/net/ntnic/rte_eth_ntnic.c:588:
+ NT_ExplainError(status, errBuf, sizeof(errBuf));$
WARNING: please, no spaces at the start of a line
#929: FILE: drivers/net/ntnic/rte_eth_ntnic.c:588:
+ NT_ExplainError(status, errBuf, sizeof(errBuf));$
WARNING: line over 80 characters
#930: FILE: drivers/net/ntnic/rte_eth_ntnic.c:589:
+ RTE_LOG(ERR, PMD, "ERROR: NT_InfoRead failed. Code 0x%x = %s
", status, errBuf);
ERROR: code indent should use tabs where possible
#930: FILE: drivers/net/ntnic/rte_eth_ntnic.c:589:
+ RTE_LOG(ERR, PMD, "ERROR: NT_InfoRead failed. Code 0x%x = %s
", status, errBuf);$
WARNING: please, no spaces at the start of a line
#930: FILE: drivers/net/ntnic/rte_eth_ntnic.c:589:
+ RTE_LOG(ERR, PMD, "ERROR: NT_InfoRead failed. Code 0x%x = %s
", status, errBuf);$
ERROR: code indent should use tabs where possible
#931: FILE: drivers/net/ntnic/rte_eth_ntnic.c:590:
+ return status;$
WARNING: please, no spaces at the start of a line
#931: FILE: drivers/net/ntnic/rte_eth_ntnic.c:590:
+ return status;$
WARNING: please, no spaces at the start of a line
#932: FILE: drivers/net/ntnic/rte_eth_ntnic.c:591:
+ }$
WARNING: please, no spaces at the start of a line
#935: FILE: drivers/net/ntnic/rte_eth_ntnic.c:594:
+ if (infoPort.u.port_v7.data.adapterInfo.fpgaid.s.product == 9506 ||$
WARNING: suspect code indent for conditional statements (4, 7)
#935: FILE: drivers/net/ntnic/rte_eth_ntnic.c:594:
+ if (infoPort.u.port_v7.data.adapterInfo.fpgaid.s.product == 9506 ||
[...]
+ internals->MAC_50G = 1;
WARNING: please, no spaces at the start of a line
#936: FILE: drivers/net/ntnic/rte_eth_ntnic.c:595:
+ infoPort.u.port_v7.data.adapterInfo.fpgaid.s.product == 9509) {$
WARNING: please, no spaces at the start of a line
#937: FILE: drivers/net/ntnic/rte_eth_ntnic.c:596:
+ internals->MAC_50G = 1;$
WARNING: please, no spaces at the start of a line
#938: FILE: drivers/net/ntnic/rte_eth_ntnic.c:597:
+ } else {$
WARNING: please, no spaces at the start of a line
#939: FILE: drivers/net/ntnic/rte_eth_ntnic.c:598:
+ internals->MAC_50G = 0;$
ERROR: code indent should use tabs where possible
#941: FILE: drivers/net/ntnic/rte_eth_ntnic.c:600:
+ if (infoPort.u.port_v7.data.adapterInfo.fpgaid.s.product != 9507 &&$
WARNING: please, no spaces at the start of a line
#941: FILE: drivers/net/ntnic/rte_eth_ntnic.c:600:
+ if (infoPort.u.port_v7.data.adapterInfo.fpgaid.s.product != 9507 &&$
WARNING: suspect code indent for conditional statements (8, 15)
#941: FILE: drivers/net/ntnic/rte_eth_ntnic.c:600:
+ if (infoPort.u.port_v7.data.adapterInfo.fpgaid.s.product != 9507 &&
[...]
+ RTE_LOG(ERR, PMD, "ERROR: NTNIC PMD does not support the NT adapter - port %i
", port);
ERROR: code indent should use tabs where possible
#942: FILE: drivers/net/ntnic/rte_eth_ntnic.c:601:
+ infoPort.u.port_v7.data.adapterInfo.fpgaid.s.product != 9510) {$
WARNING: please, no spaces at the start of a line
#942: FILE: drivers/net/ntnic/rte_eth_ntnic.c:601:
+ infoPort.u.port_v7.data.adapterInfo.fpgaid.s.product != 9510) {$
WARNING: line over 80 characters
#943: FILE: drivers/net/ntnic/rte_eth_ntnic.c:602:
+ RTE_LOG(ERR, PMD, "ERROR: NTNIC PMD does not support the NT adapter - port %i
", port);
ERROR: code indent should use tabs where possible
#943: FILE: drivers/net/ntnic/rte_eth_ntnic.c:602:
+ RTE_LOG(ERR, PMD, "ERROR: NTNIC PMD does not support the NT adapter - port %i
", port);$
WARNING: please, no spaces at the start of a line
#943: FILE: drivers/net/ntnic/rte_eth_ntnic.c:602:
+ RTE_LOG(ERR, PMD, "ERROR: NTNIC PMD does not support the NT adapter - port %i
", port);$
ERROR: code indent should use tabs where possible
#944: FILE: drivers/net/ntnic/rte_eth_ntnic.c:603:
+ return -1;$
WARNING: please, no spaces at the start of a line
#944: FILE: drivers/net/ntnic/rte_eth_ntnic.c:603:
+ return -1;$
ERROR: code indent should use tabs where possible
#945: FILE: drivers/net/ntnic/rte_eth_ntnic.c:604:
+ }$
WARNING: please, no spaces at the start of a line
#945: FILE: drivers/net/ntnic/rte_eth_ntnic.c:604:
+ }$
WARNING: please, no spaces at the start of a line
#946: FILE: drivers/net/ntnic/rte_eth_ntnic.c:605:
+ }$
WARNING: please, no spaces at the start of a line
#948: FILE: drivers/net/ntnic/rte_eth_ntnic.c:607:
+ internals->nb_rx_queues = nb_rx_queues;$
WARNING: please, no spaces at the start of a line
#949: FILE: drivers/net/ntnic/rte_eth_ntnic.c:608:
+ internals->nb_tx_queues = nb_tx_queues;$
WARNING: please, no spaces at the start of a line
#950: FILE: drivers/net/ntnic/rte_eth_ntnic.c:609:
+ for (i=0; i < nb_rx_queues; i++) {$
WARNING: suspect code indent for conditional statements (7, 15)
#950: FILE: drivers/net/ntnic/rte_eth_ntnic.c:609:
+ for (i=0; i < nb_rx_queues; i++) {
+ int idx;
ERROR: spaces required around that '=' (ctx:VxV)
#950: FILE: drivers/net/ntnic/rte_eth_ntnic.c:609:
+ for (i=0; i < nb_rx_queues; i++) {
^
ERROR: code indent should use tabs where possible
#951: FILE: drivers/net/ntnic/rte_eth_ntnic.c:610:
+ int idx;$
WARNING: please, no spaces at the start of a line
#951: FILE: drivers/net/ntnic/rte_eth_ntnic.c:610:
+ int idx;$
ERROR: code indent should use tabs where possible
#952: FILE: drivers/net/ntnic/rte_eth_ntnic.c:611:
+ for (idx = 0; idx < pastreamids->count; idx++) {$
WARNING: please, no spaces at the start of a line
#952: FILE: drivers/net/ntnic/rte_eth_ntnic.c:611:
+ for (idx = 0; idx < pastreamids->count; idx++) {$
WARNING: suspect code indent for conditional statements (15, 23)
#952: FILE: drivers/net/ntnic/rte_eth_ntnic.c:611:
+ for (idx = 0; idx < pastreamids->count; idx++) {
+ internals->rxq[i].astreamids.value[idx] = pastreamids->value[idx] + i;
WARNING: braces {} are not necessary for single statement blocks
#952: FILE: drivers/net/ntnic/rte_eth_ntnic.c:611:
+ for (idx = 0; idx < pastreamids->count; idx++) {
+ internals->rxq[i].astreamids.value[idx] = pastreamids->value[idx] + i;
+ }
WARNING: line over 80 characters
#953: FILE: drivers/net/ntnic/rte_eth_ntnic.c:612:
+ internals->rxq[i].astreamids.value[idx] = pastreamids->value[idx] + i;
ERROR: code indent should use tabs where possible
#953: FILE: drivers/net/ntnic/rte_eth_ntnic.c:612:
+ internals->rxq[i].astreamids.value[idx] = pastreamids->value[idx] + i;$
WARNING: please, no spaces at the start of a line
#953: FILE: drivers/net/ntnic/rte_eth_ntnic.c:612:
+ internals->rxq[i].astreamids.value[idx] = pastreamids->value[idx] + i;$
ERROR: code indent should use tabs where possible
#954: FILE: drivers/net/ntnic/rte_eth_ntnic.c:613:
+ }$
WARNING: please, no spaces at the start of a line
#954: FILE: drivers/net/ntnic/rte_eth_ntnic.c:613:
+ }$
ERROR: code indent should use tabs where possible
#956: FILE: drivers/net/ntnic/rte_eth_ntnic.c:615:
+ internals->rxq[i].astreamids.count = pastreamids->count;$
WARNING: please, no spaces at the start of a line
#956: FILE: drivers/net/ntnic/rte_eth_ntnic.c:615:
+ internals->rxq[i].astreamids.count = pastreamids->count;$
ERROR: code indent should use tabs where possible
#958: FILE: drivers/net/ntnic/rte_eth_ntnic.c:617:
+ internals->rxq[i].pSeg = NULL;$
WARNING: please, no spaces at the start of a line
#958: FILE: drivers/net/ntnic/rte_eth_ntnic.c:617:
+ internals->rxq[i].pSeg = NULL;$
ERROR: code indent should use tabs where possible
#959: FILE: drivers/net/ntnic/rte_eth_ntnic.c:618:
+ internals->rxq[i].enabled = 0;$
WARNING: please, no spaces at the start of a line
#959: FILE: drivers/net/ntnic/rte_eth_ntnic.c:618:
+ internals->rxq[i].enabled = 0;$
WARNING: please, no spaces at the start of a line
#960: FILE: drivers/net/ntnic/rte_eth_ntnic.c:619:
+ }$
WARNING: please, no spaces at the start of a line
#962: FILE: drivers/net/ntnic/rte_eth_ntnic.c:621:
+ for (i = 0; i < nb_tx_queues; i++) {$
WARNING: suspect code indent for conditional statements (7, 7)
#962: FILE: drivers/net/ntnic/rte_eth_ntnic.c:621:
+ for (i = 0; i < nb_tx_queues; i++) {
+ if (port < infoPort.u.port_v7.data.adapterInfo.portOffset) {
WARNING: please, no spaces at the start of a line
#963: FILE: drivers/net/ntnic/rte_eth_ntnic.c:622:
+ if (port < infoPort.u.port_v7.data.adapterInfo.portOffset) {$
WARNING: suspect code indent for conditional statements (7, 15)
#963: FILE: drivers/net/ntnic/rte_eth_ntnic.c:622:
+ if (port < infoPort.u.port_v7.data.adapterInfo.portOffset) {
+ RTE_LOG(ERR, PMD, "Error wrong port specified
");
ERROR: code indent should use tabs where possible
#964: FILE: drivers/net/ntnic/rte_eth_ntnic.c:623:
+ RTE_LOG(ERR, PMD, "Error wrong port specified
");$
WARNING: please, no spaces at the start of a line
#964: FILE: drivers/net/ntnic/rte_eth_ntnic.c:623:
+ RTE_LOG(ERR, PMD, "Error wrong port specified
");$
ERROR: code indent should use tabs where possible
#965: FILE: drivers/net/ntnic/rte_eth_ntnic.c:624:
+ return -1;$
WARNING: please, no spaces at the start of a line
#965: FILE: drivers/net/ntnic/rte_eth_ntnic.c:624:
+ return -1;$
WARNING: please, no spaces at the start of a line
#966: FILE: drivers/net/ntnic/rte_eth_ntnic.c:625:
+ }$
ERROR: code indent should use tabs where possible
#967: FILE: drivers/net/ntnic/rte_eth_ntnic.c:626:
+ internals->txq[i].port = port;$
WARNING: please, no spaces at the start of a line
#967: FILE: drivers/net/ntnic/rte_eth_ntnic.c:626:
+ internals->txq[i].port = port;$
ERROR: code indent should use tabs where possible
#968: FILE: drivers/net/ntnic/rte_eth_ntnic.c:627:
+ internals->txq[i].enabled = 0;$
WARNING: please, no spaces at the start of a line
#968: FILE: drivers/net/ntnic/rte_eth_ntnic.c:627:
+ internals->txq[i].enabled = 0;$
WARNING: please, no spaces at the start of a line
#969: FILE: drivers/net/ntnic/rte_eth_ntnic.c:628:
+ }$
WARNING: please, no spaces at the start of a line
#971: FILE: drivers/net/ntnic/rte_eth_ntnic.c:630:
+ switch (infoPort.u.port_v7.data.speed) {$
WARNING: please, no spaces at the start of a line
#972: FILE: drivers/net/ntnic/rte_eth_ntnic.c:631:
+ case NT_LINK_SPEED_UNKNOWN:$
ERROR: code indent should use tabs where possible
#973: FILE: drivers/net/ntnic/rte_eth_ntnic.c:632:
+ pmd_link.link_speed = ETH_SPEED_NUM_1G;$
WARNING: please, no spaces at the start of a line
#973: FILE: drivers/net/ntnic/rte_eth_ntnic.c:632:
+ pmd_link.link_speed = ETH_SPEED_NUM_1G;$
ERROR: code indent should use tabs where possible
#974: FILE: drivers/net/ntnic/rte_eth_ntnic.c:633:
+ break;$
WARNING: please, no spaces at the start of a line
#974: FILE: drivers/net/ntnic/rte_eth_ntnic.c:633:
+ break;$
WARNING: please, no spaces at the start of a line
#975: FILE: drivers/net/ntnic/rte_eth_ntnic.c:634:
+ case NT_LINK_SPEED_10M:$
ERROR: code indent should use tabs where possible
#976: FILE: drivers/net/ntnic/rte_eth_ntnic.c:635:
+ pmd_link.link_speed = ETH_SPEED_NUM_10M;$
WARNING: please, no spaces at the start of a line
#976: FILE: drivers/net/ntnic/rte_eth_ntnic.c:635:
+ pmd_link.link_speed = ETH_SPEED_NUM_10M;$
ERROR: code indent should use tabs where possible
#977: FILE: drivers/net/ntnic/rte_eth_ntnic.c:636:
+ break;$
WARNING: please, no spaces at the start of a line
#977: FILE: drivers/net/ntnic/rte_eth_ntnic.c:636:
+ break;$
WARNING: please, no spaces at the start of a line
#978: FILE: drivers/net/ntnic/rte_eth_ntnic.c:637:
+ case NT_LINK_SPEED_100M:$
ERROR: code indent should use tabs where possible
#979: FILE: drivers/net/ntnic/rte_eth_ntnic.c:638:
+ pmd_link.link_speed = ETH_SPEED_NUM_100M;$
WARNING: please, no spaces at the start of a line
#979: FILE: drivers/net/ntnic/rte_eth_ntnic.c:638:
+ pmd_link.link_speed = ETH_SPEED_NUM_100M;$
ERROR: code indent should use tabs where possible
#980: FILE: drivers/net/ntnic/rte_eth_ntnic.c:639:
+ break;$
WARNING: please, no spaces at the start of a line
#980: FILE: drivers/net/ntnic/rte_eth_ntnic.c:639:
+ break;$
WARNING: please, no spaces at the start of a line
#981: FILE: drivers/net/ntnic/rte_eth_ntnic.c:640:
+ case NT_LINK_SPEED_1G:$
ERROR: code indent should use tabs where possible
#982: FILE: drivers/net/ntnic/rte_eth_ntnic.c:641:
+ pmd_link.link_speed = ETH_SPEED_NUM_1G;$
WARNING: please, no spaces at the start of a line
#982: FILE: drivers/net/ntnic/rte_eth_ntnic.c:641:
+ pmd_link.link_speed = ETH_SPEED_NUM_1G;$
ERROR: code indent should use tabs where possible
#983: FILE: drivers/net/ntnic/rte_eth_ntnic.c:642:
+ break;$
WARNING: please, no spaces at the start of a line
#983: FILE: drivers/net/ntnic/rte_eth_ntnic.c:642:
+ break;$
WARNING: please, no spaces at the start of a line
#984: FILE: drivers/net/ntnic/rte_eth_ntnic.c:643:
+ case NT_LINK_SPEED_10G:$
ERROR: code indent should use tabs where possible
#985: FILE: drivers/net/ntnic/rte_eth_ntnic.c:644:
+ pmd_link.link_speed = ETH_SPEED_NUM_10G;$
WARNING: please, no spaces at the start of a line
#985: FILE: drivers/net/ntnic/rte_eth_ntnic.c:644:
+ pmd_link.link_speed = ETH_SPEED_NUM_10G;$
ERROR: code indent should use tabs where possible
#986: FILE: drivers/net/ntnic/rte_eth_ntnic.c:645:
+ break;$
WARNING: please, no spaces at the start of a line
#986: FILE: drivers/net/ntnic/rte_eth_ntnic.c:645:
+ break;$
WARNING: please, no spaces at the start of a line
#987: FILE: drivers/net/ntnic/rte_eth_ntnic.c:646:
+ case NT_LINK_SPEED_40G:$
ERROR: code indent should use tabs where possible
#988: FILE: drivers/net/ntnic/rte_eth_ntnic.c:647:
+ pmd_link.link_speed = ETH_SPEED_NUM_40G;$
WARNING: please, no spaces at the start of a line
#988: FILE: drivers/net/ntnic/rte_eth_ntnic.c:647:
+ pmd_link.link_speed = ETH_SPEED_NUM_40G;$
ERROR: code indent should use tabs where possible
#989: FILE: drivers/net/ntnic/rte_eth_ntnic.c:648:
+ break;$
WARNING: please, no spaces at the start of a line
#989: FILE: drivers/net/ntnic/rte_eth_ntnic.c:648:
+ break;$
WARNING: please, no spaces at the start of a line
#990: FILE: drivers/net/ntnic/rte_eth_ntnic.c:649:
+ case NT_LINK_SPEED_50G:$
ERROR: code indent should use tabs where possible
#991: FILE: drivers/net/ntnic/rte_eth_ntnic.c:650:
+ pmd_link.link_speed = ETH_SPEED_NUM_50G;$
WARNING: please, no spaces at the start of a line
#991: FILE: drivers/net/ntnic/rte_eth_ntnic.c:650:
+ pmd_link.link_speed = ETH_SPEED_NUM_50G;$
ERROR: code indent should use tabs where possible
#992: FILE: drivers/net/ntnic/rte_eth_ntnic.c:651:
+ break;$
WARNING: please, no spaces at the start of a line
#992: FILE: drivers/net/ntnic/rte_eth_ntnic.c:651:
+ break;$
WARNING: please, no spaces at the start of a line
#993: FILE: drivers/net/ntnic/rte_eth_ntnic.c:652:
+ case NT_LINK_SPEED_100G:$
ERROR: code indent should use tabs where possible
#994: FILE: drivers/net/ntnic/rte_eth_ntnic.c:653:
+ pmd_link.link_speed = ETH_SPEED_NUM_100G;$
WARNING: please, no spaces at the start of a line
#994: FILE: drivers/net/ntnic/rte_eth_ntnic.c:653:
+ pmd_link.link_speed = ETH_SPEED_NUM_100G;$
ERROR: code indent should use tabs where possible
#995: FILE: drivers/net/ntnic/rte_eth_ntnic.c:654:
+ break;$
WARNING: please, no spaces at the start of a line
#995: FILE: drivers/net/ntnic/rte_eth_ntnic.c:654:
+ break;$
WARNING: please, no spaces at the start of a line
#996: FILE: drivers/net/ntnic/rte_eth_ntnic.c:655:
+ }$
WARNING: line over 80 characters
#998: FILE: drivers/net/ntnic/rte_eth_ntnic.c:657:
+ memcpy(ð_addr[port].addr_bytes, &infoPort.u.port_v7.data.macAddress, sizeof(eth_addr[port].addr_bytes));
WARNING: please, no spaces at the start of a line
#998: FILE: drivers/net/ntnic/rte_eth_ntnic.c:657:
+ memcpy(ð_addr[port].addr_bytes, &infoPort.u.port_v7.data.macAddress, sizeof(eth_addr[port].addr_bytes));$
WARNING: please, no spaces at the start of a line
#1000: FILE: drivers/net/ntnic/rte_eth_ntnic.c:659:
+ if ((status = NT_InfoClose(hInfo)) != NT_SUCCESS) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1000: FILE: drivers/net/ntnic/rte_eth_ntnic.c:659:
+ if ((status = NT_InfoClose(hInfo)) != NT_SUCCESS) {
+ NT_ExplainError(status, errBuf, sizeof(errBuf));
ERROR: do not use assignment in if condition
#1000: FILE: drivers/net/ntnic/rte_eth_ntnic.c:659:
+ if ((status = NT_InfoClose(hInfo)) != NT_SUCCESS) {
ERROR: code indent should use tabs where possible
#1001: FILE: drivers/net/ntnic/rte_eth_ntnic.c:660:
+ NT_ExplainError(status, errBuf, sizeof(errBuf));$
WARNING: please, no spaces at the start of a line
#1001: FILE: drivers/net/ntnic/rte_eth_ntnic.c:660:
+ NT_ExplainError(status, errBuf, sizeof(errBuf));$
WARNING: line over 80 characters
#1002: FILE: drivers/net/ntnic/rte_eth_ntnic.c:661:
+ RTE_LOG(ERR, PMD, ">>> Error: NT_InfoOpen failed. Code 0x%x = %s
", status, errBuf);
ERROR: code indent should use tabs where possible
#1002: FILE: drivers/net/ntnic/rte_eth_ntnic.c:661:
+ RTE_LOG(ERR, PMD, ">>> Error: NT_InfoOpen failed. Code 0x%x = %s
", status, errBuf);$
WARNING: please, no spaces at the start of a line
#1002: FILE: drivers/net/ntnic/rte_eth_ntnic.c:661:
+ RTE_LOG(ERR, PMD, ">>> Error: NT_InfoOpen failed. Code 0x%x = %s
", status, errBuf);$
ERROR: code indent should use tabs where possible
#1003: FILE: drivers/net/ntnic/rte_eth_ntnic.c:662:
+ return status;$
WARNING: please, no spaces at the start of a line
#1003: FILE: drivers/net/ntnic/rte_eth_ntnic.c:662:
+ return status;$
WARNING: please, no spaces at the start of a line
#1004: FILE: drivers/net/ntnic/rte_eth_ntnic.c:663:
+ }$
WARNING: please, no spaces at the start of a line
#1006: FILE: drivers/net/ntnic/rte_eth_ntnic.c:665:
+ pmd_link.link_duplex = ETH_LINK_FULL_DUPLEX;$
WARNING: please, no spaces at the start of a line
#1007: FILE: drivers/net/ntnic/rte_eth_ntnic.c:666:
+ pmd_link.link_status = 0;$
WARNING: please, no spaces at the start of a line
#1009: FILE: drivers/net/ntnic/rte_eth_ntnic.c:668:
+ internals->if_index = 0;$
WARNING: please, no spaces at the start of a line
#1011: FILE: drivers/net/ntnic/rte_eth_ntnic.c:670:
+ pci_dev->numa_node = numa_node;$
WARNING: please, no spaces at the start of a line
#1013: FILE: drivers/net/ntnic/rte_eth_ntnic.c:672:
+ data->dev_private = internals;$
WARNING: please, no spaces at the start of a line
#1014: FILE: drivers/net/ntnic/rte_eth_ntnic.c:673:
+ data->port_id = (*eth_dev)->data->port_id;$
WARNING: please, no spaces at the start of a line
#1015: FILE: drivers/net/ntnic/rte_eth_ntnic.c:674:
+ data->nb_rx_queues = (uint16_t)nb_rx_queues;$
WARNING: please, no spaces at the start of a line
#1016: FILE: drivers/net/ntnic/rte_eth_ntnic.c:675:
+ data->nb_tx_queues = (uint16_t)nb_tx_queues;$
WARNING: please, no spaces at the start of a line
#1017: FILE: drivers/net/ntnic/rte_eth_ntnic.c:676:
+ data->dev_link = pmd_link;$
WARNING: please, no spaces at the start of a line
#1018: FILE: drivers/net/ntnic/rte_eth_ntnic.c:677:
+ data->mac_addrs = ð_addr[port];$
WARNING: please, no spaces at the start of a line
#1019: FILE: drivers/net/ntnic/rte_eth_ntnic.c:678:
+ data->numa_node = numa_node;$
WARNING: please, no spaces at the start of a line
#1020: FILE: drivers/net/ntnic/rte_eth_ntnic.c:679:
+ data->drv_name = drivername;$
WARNING: please, no spaces at the start of a line
#1022: FILE: drivers/net/ntnic/rte_eth_ntnic.c:681:
+ (*eth_dev)->data = data;$
WARNING: please, no spaces at the start of a line
#1023: FILE: drivers/net/ntnic/rte_eth_ntnic.c:682:
+ (*eth_dev)->dev_ops = &ops;$
WARNING: please, no spaces at the start of a line
#1024: FILE: drivers/net/ntnic/rte_eth_ntnic.c:683:
+ (*eth_dev)->pci_dev = pci_dev;$
WARNING: please, no spaces at the start of a line
#1026: FILE: drivers/net/ntnic/rte_eth_ntnic.c:685:
+ return 0;$
WARNING: please, no spaces at the start of a line
#1029: FILE: drivers/net/ntnic/rte_eth_ntnic.c:688:
+ if (data)$
WARNING: suspect code indent for conditional statements (7, 15)
#1029: FILE: drivers/net/ntnic/rte_eth_ntnic.c:688:
+ if (data)
+ rte_free(data);
ERROR: code indent should use tabs where possible
#1030: FILE: drivers/net/ntnic/rte_eth_ntnic.c:689:
+ rte_free(data);$
WARNING: please, no spaces at the start of a line
#1030: FILE: drivers/net/ntnic/rte_eth_ntnic.c:689:
+ rte_free(data);$
WARNING: please, no spaces at the start of a line
#1031: FILE: drivers/net/ntnic/rte_eth_ntnic.c:690:
+ if (pci_dev)$
WARNING: suspect code indent for conditional statements (7, 15)
#1031: FILE: drivers/net/ntnic/rte_eth_ntnic.c:690:
+ if (pci_dev)
+ rte_free(pci_dev);
ERROR: code indent should use tabs where possible
#1032: FILE: drivers/net/ntnic/rte_eth_ntnic.c:691:
+ rte_free(pci_dev);$
WARNING: please, no spaces at the start of a line
#1032: FILE: drivers/net/ntnic/rte_eth_ntnic.c:691:
+ rte_free(pci_dev);$
WARNING: please, no spaces at the start of a line
#1033: FILE: drivers/net/ntnic/rte_eth_ntnic.c:692:
+ if (internals)$
WARNING: suspect code indent for conditional statements (7, 15)
#1033: FILE: drivers/net/ntnic/rte_eth_ntnic.c:692:
+ if (internals)
+ rte_free(internals);
ERROR: code indent should use tabs where possible
#1034: FILE: drivers/net/ntnic/rte_eth_ntnic.c:693:
+ rte_free(internals);$
WARNING: please, no spaces at the start of a line
#1034: FILE: drivers/net/ntnic/rte_eth_ntnic.c:693:
+ rte_free(internals);$
WARNING: please, no spaces at the start of a line
#1035: FILE: drivers/net/ntnic/rte_eth_ntnic.c:694:
+ return -1;$
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#1039: FILE: drivers/net/ntnic/rte_eth_ntnic.c:698:
+/*
+ * convert ascii to int
WARNING: line over 80 characters
#1042: FILE: drivers/net/ntnic/rte_eth_ntnic.c:701:
+ascii_to_u32(const char *key __rte_unused, const char *value, void *extra_args __rte_unused)
WARNING: please, no spaces at the start of a line
#1044: FILE: drivers/net/ntnic/rte_eth_ntnic.c:703:
+ *(uint32_t*)extra_args = atoi(value);$
ERROR: "(foo*)" should be "(foo *)"
#1044: FILE: drivers/net/ntnic/rte_eth_ntnic.c:703:
+ *(uint32_t*)extra_args = atoi(value);
WARNING: please, no spaces at the start of a line
#1045: FILE: drivers/net/ntnic/rte_eth_ntnic.c:704:
+ return 0;$
WARNING: line over 80 characters
#1049: FILE: drivers/net/ntnic/rte_eth_ntnic.c:708:
+ascii_to_u32_array(const char *key __rte_unused, const char *value, void *extra_args)
WARNING: please, no spaces at the start of a line
#1051: FILE: drivers/net/ntnic/rte_eth_ntnic.c:710:
+ struct array_s *pastreams = (struct array_s *)extra_args;$
WARNING: please, no spaces at the start of a line
#1052: FILE: drivers/net/ntnic/rte_eth_ntnic.c:711:
+ int sval, eval;$
WARNING: please, no spaces at the start of a line
#1053: FILE: drivers/net/ntnic/rte_eth_ntnic.c:712:
+ if (sscanf(value, "%d..%d", &sval, &eval) == 2) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1053: FILE: drivers/net/ntnic/rte_eth_ntnic.c:712:
+ if (sscanf(value, "%d..%d", &sval, &eval) == 2) {
+ int cnt;
ERROR: code indent should use tabs where possible
#1054: FILE: drivers/net/ntnic/rte_eth_ntnic.c:713:
+ int cnt;$
WARNING: please, no spaces at the start of a line
#1054: FILE: drivers/net/ntnic/rte_eth_ntnic.c:713:
+ int cnt;$
ERROR: code indent should use tabs where possible
#1055: FILE: drivers/net/ntnic/rte_eth_ntnic.c:714:
+ for (cnt = sval; cnt <= eval; cnt++)$
WARNING: please, no spaces at the start of a line
#1055: FILE: drivers/net/ntnic/rte_eth_ntnic.c:714:
+ for (cnt = sval; cnt <= eval; cnt++)$
WARNING: suspect code indent for conditional statements (15, 23)
#1055: FILE: drivers/net/ntnic/rte_eth_ntnic.c:714:
+ for (cnt = sval; cnt <= eval; cnt++)
+ pastreams->value[pastreams->count++] = cnt;
ERROR: code indent should use tabs where possible
#1056: FILE: drivers/net/ntnic/rte_eth_ntnic.c:715:
+ pastreams->value[pastreams->count++] = cnt;$
WARNING: please, no spaces at the start of a line
#1056: FILE: drivers/net/ntnic/rte_eth_ntnic.c:715:
+ pastreams->value[pastreams->count++] = cnt;$
WARNING: please, no spaces at the start of a line
#1057: FILE: drivers/net/ntnic/rte_eth_ntnic.c:716:
+ } else {$
ERROR: code indent should use tabs where possible
#1058: FILE: drivers/net/ntnic/rte_eth_ntnic.c:717:
+ pastreams->value[pastreams->count++] = atoi(value);$
WARNING: please, no spaces at the start of a line
#1058: FILE: drivers/net/ntnic/rte_eth_ntnic.c:717:
+ pastreams->value[pastreams->count++] = atoi(value);$
WARNING: please, no spaces at the start of a line
#1059: FILE: drivers/net/ntnic/rte_eth_ntnic.c:718:
+ }$
WARNING: please, no spaces at the start of a line
#1060: FILE: drivers/net/ntnic/rte_eth_ntnic.c:719:
+ return 0;$
WARNING: please, no spaces at the start of a line
#1069: FILE: drivers/net/ntnic/rte_eth_ntnic.c:728:
+ NtConfigStream_t hCfgStream;$
WARNING: please, no spaces at the start of a line
#1070: FILE: drivers/net/ntnic/rte_eth_ntnic.c:729:
+ NtNtplInfo_t ntplInfo;$
WARNING: please, no spaces at the start of a line
#1071: FILE: drivers/net/ntnic/rte_eth_ntnic.c:730:
+ int status;$
WARNING: please, no spaces at the start of a line
#1073: FILE: drivers/net/ntnic/rte_eth_ntnic.c:732:
+ if((status = NT_ConfigOpen(&hCfgStream, "capture")) != NT_SUCCESS) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1073: FILE: drivers/net/ntnic/rte_eth_ntnic.c:732:
+ if((status = NT_ConfigOpen(&hCfgStream, "capture")) != NT_SUCCESS) {
+ /* Get the status code as text */
ERROR: space required before the open parenthesis '('
#1073: FILE: drivers/net/ntnic/rte_eth_ntnic.c:732:
+ if((status = NT_ConfigOpen(&hCfgStream, "capture")) != NT_SUCCESS) {
ERROR: do not use assignment in if condition
#1073: FILE: drivers/net/ntnic/rte_eth_ntnic.c:732:
+ if((status = NT_ConfigOpen(&hCfgStream, "capture")) != NT_SUCCESS) {
ERROR: code indent should use tabs where possible
#1074: FILE: drivers/net/ntnic/rte_eth_ntnic.c:733:
+ /* Get the status code as text */$
ERROR: code indent should use tabs where possible
#1075: FILE: drivers/net/ntnic/rte_eth_ntnic.c:734:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer)-1);$
WARNING: please, no spaces at the start of a line
#1075: FILE: drivers/net/ntnic/rte_eth_ntnic.c:734:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer)-1);$
ERROR: code indent should use tabs where possible
#1076: FILE: drivers/net/ntnic/rte_eth_ntnic.c:735:
+ fprintf(stderr, "NT_ConfigOpen() failed: %s
", errorBuffer);$
WARNING: please, no spaces at the start of a line
#1076: FILE: drivers/net/ntnic/rte_eth_ntnic.c:735:
+ fprintf(stderr, "NT_ConfigOpen() failed: %s
", errorBuffer);$
ERROR: code indent should use tabs where possible
#1077: FILE: drivers/net/ntnic/rte_eth_ntnic.c:736:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1077: FILE: drivers/net/ntnic/rte_eth_ntnic.c:736:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1078: FILE: drivers/net/ntnic/rte_eth_ntnic.c:737:
+ }$
WARNING: please, no spaces at the start of a line
#1080: FILE: drivers/net/ntnic/rte_eth_ntnic.c:739:
+ RTE_LOG(INFO, PMD, "NTPL : %s
", ntplStr);$
WARNING: line over 80 characters
#1081: FILE: drivers/net/ntnic/rte_eth_ntnic.c:740:
+ if((status = NT_NTPL(hCfgStream, ntplStr, &ntplInfo, NT_NTPL_PARSER_VALIDATE_NORMAL)) != NT_SUCCESS) {
WARNING: please, no spaces at the start of a line
#1081: FILE: drivers/net/ntnic/rte_eth_ntnic.c:740:
+ if((status = NT_NTPL(hCfgStream, ntplStr, &ntplInfo, NT_NTPL_PARSER_VALIDATE_NORMAL)) != NT_SUCCESS) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1081: FILE: drivers/net/ntnic/rte_eth_ntnic.c:740:
+ if((status = NT_NTPL(hCfgStream, ntplStr, &ntplInfo, NT_NTPL_PARSER_VALIDATE_NORMAL)) != NT_SUCCESS) {
+ /* Get the status code as text */
ERROR: space required before the open parenthesis '('
#1081: FILE: drivers/net/ntnic/rte_eth_ntnic.c:740:
+ if((status = NT_NTPL(hCfgStream, ntplStr, &ntplInfo, NT_NTPL_PARSER_VALIDATE_NORMAL)) != NT_SUCCESS) {
ERROR: do not use assignment in if condition
#1081: FILE: drivers/net/ntnic/rte_eth_ntnic.c:740:
+ if((status = NT_NTPL(hCfgStream, ntplStr, &ntplInfo, NT_NTPL_PARSER_VALIDATE_NORMAL)) != NT_SUCCESS) {
ERROR: code indent should use tabs where possible
#1082: FILE: drivers/net/ntnic/rte_eth_ntnic.c:741:
+ /* Get the status code as text */$
ERROR: code indent should use tabs where possible
#1083: FILE: drivers/net/ntnic/rte_eth_ntnic.c:742:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer)-1);$
WARNING: please, no spaces at the start of a line
#1083: FILE: drivers/net/ntnic/rte_eth_ntnic.c:742:
+ NT_ExplainError(status, errorBuffer, sizeof(errorBuffer)-1);$
ERROR: code indent should use tabs where possible
#1084: FILE: drivers/net/ntnic/rte_eth_ntnic.c:743:
+ fprintf(stderr, "NT_NTPL() failed: %s
", errorBuffer);$
WARNING: please, no spaces at the start of a line
#1084: FILE: drivers/net/ntnic/rte_eth_ntnic.c:743:
+ fprintf(stderr, "NT_NTPL() failed: %s
", errorBuffer);$
WARNING: line over 80 characters
#1085: FILE: drivers/net/ntnic/rte_eth_ntnic.c:744:
+ fprintf(stderr, ">>> NTPL errorcode: %X
", ntplInfo.u.errorData.errCode);
ERROR: code indent should use tabs where possible
#1085: FILE: drivers/net/ntnic/rte_eth_ntnic.c:744:
+ fprintf(stderr, ">>> NTPL errorcode: %X
", ntplInfo.u.errorData.errCode);$
WARNING: please, no spaces at the start of a line
#1085: FILE: drivers/net/ntnic/rte_eth_ntnic.c:744:
+ fprintf(stderr, ">>> NTPL errorcode: %X
", ntplInfo.u.errorData.errCode);$
ERROR: code indent should use tabs where possible
#1086: FILE: drivers/net/ntnic/rte_eth_ntnic.c:745:
+ fprintf(stderr, ">>> %s
", ntplInfo.u.errorData.errBuffer[0]);$
WARNING: please, no spaces at the start of a line
#1086: FILE: drivers/net/ntnic/rte_eth_ntnic.c:745:
+ fprintf(stderr, ">>> %s
", ntplInfo.u.errorData.errBuffer[0]);$
ERROR: code indent should use tabs where possible
#1087: FILE: drivers/net/ntnic/rte_eth_ntnic.c:746:
+ fprintf(stderr, ">>> %s
", ntplInfo.u.errorData.errBuffer[1]);$
WARNING: please, no spaces at the start of a line
#1087: FILE: drivers/net/ntnic/rte_eth_ntnic.c:746:
+ fprintf(stderr, ">>> %s
", ntplInfo.u.errorData.errBuffer[1]);$
ERROR: code indent should use tabs where possible
#1088: FILE: drivers/net/ntnic/rte_eth_ntnic.c:747:
+ fprintf(stderr, ">>> %s
", ntplInfo.u.errorData.errBuffer[2]);$
WARNING: please, no spaces at the start of a line
#1088: FILE: drivers/net/ntnic/rte_eth_ntnic.c:747:
+ fprintf(stderr, ">>> %s
", ntplInfo.u.errorData.errBuffer[2]);$
ERROR: code indent should use tabs where possible
#1089: FILE: drivers/net/ntnic/rte_eth_ntnic.c:748:
+ NT_ConfigClose(hCfgStream);$
WARNING: please, no spaces at the start of a line
#1089: FILE: drivers/net/ntnic/rte_eth_ntnic.c:748:
+ NT_ConfigClose(hCfgStream);$
ERROR: code indent should use tabs where possible
#1090: FILE: drivers/net/ntnic/rte_eth_ntnic.c:749:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1090: FILE: drivers/net/ntnic/rte_eth_ntnic.c:749:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1091: FILE: drivers/net/ntnic/rte_eth_ntnic.c:750:
+ }$
WARNING: please, no spaces at the start of a line
#1092: FILE: drivers/net/ntnic/rte_eth_ntnic.c:751:
+ NT_ConfigClose(hCfgStream);$
WARNING: please, no spaces at the start of a line
#1093: FILE: drivers/net/ntnic/rte_eth_ntnic.c:752:
+ return 0;$
WARNING: please, no spaces at the start of a line
#1102: FILE: drivers/net/ntnic/rte_eth_ntnic.c:761:
+ unsigned numa_node;$
WARNING: please, no spaces at the start of a line
#1103: FILE: drivers/net/ntnic/rte_eth_ntnic.c:762:
+ int ret = 0;$
WARNING: please, no spaces at the start of a line
#1104: FILE: drivers/net/ntnic/rte_eth_ntnic.c:763:
+ struct rte_kvargs *kvlist;$
WARNING: please, no spaces at the start of a line
#1105: FILE: drivers/net/ntnic/rte_eth_ntnic.c:764:
+ struct rte_eth_dev *eth_dev;$
WARNING: please, no spaces at the start of a line
#1106: FILE: drivers/net/ntnic/rte_eth_ntnic.c:765:
+ unsigned int i;$
WARNING: please, no spaces at the start of a line
#1107: FILE: drivers/net/ntnic/rte_eth_ntnic.c:766:
+ uint32_t rxqueues = 0;$
WARNING: please, no spaces at the start of a line
#1108: FILE: drivers/net/ntnic/rte_eth_ntnic.c:767:
+ uint32_t txqueues = 0;$
WARNING: please, no spaces at the start of a line
#1109: FILE: drivers/net/ntnic/rte_eth_ntnic.c:768:
+ uint32_t port=0;$
ERROR: spaces required around that '=' (ctx:VxV)
#1109: FILE: drivers/net/ntnic/rte_eth_ntnic.c:768:
+ uint32_t port=0;
^
WARNING: please, no spaces at the start of a line
#1110: FILE: drivers/net/ntnic/rte_eth_ntnic.c:769:
+ uint32_t portend = (uint32_t)-1;$
WARNING: please, no spaces at the start of a line
#1111: FILE: drivers/net/ntnic/rte_eth_ntnic.c:770:
+ uint32_t hash = (uint32_t)-1;$
WARNING: please, no spaces at the start of a line
#1112: FILE: drivers/net/ntnic/rte_eth_ntnic.c:771:
+ struct array_s astreamids;$
WARNING: please, no spaces at the start of a line
#1114: FILE: drivers/net/ntnic/rte_eth_ntnic.c:773:
+ static int first = 1;$
WARNING: please, no spaces at the start of a line
#1115: FILE: drivers/net/ntnic/rte_eth_ntnic.c:774:
+ static int stream_id = 0;$
ERROR: do not initialise statics to 0 or NULL
#1115: FILE: drivers/net/ntnic/rte_eth_ntnic.c:774:
+ static int stream_id = 0;
WARNING: please, no spaces at the start of a line
#1116: FILE: drivers/net/ntnic/rte_eth_ntnic.c:775:
+ char ntplStr[512];$
WARNING: please, no spaces at the start of a line
#1118: FILE: drivers/net/ntnic/rte_eth_ntnic.c:777:
+ astreamids.count = 0;$
WARNING: please, no spaces at the start of a line
#1120: FILE: drivers/net/ntnic/rte_eth_ntnic.c:779:
+ RTE_LOG(INFO, PMD, "Initializing pmd_ntnic for %s
", name);$
WARNING: please, no spaces at the start of a line
#1122: FILE: drivers/net/ntnic/rte_eth_ntnic.c:781:
+ numa_node = rte_socket_id();$
WARNING: please, no spaces at the start of a line
#1124: FILE: drivers/net/ntnic/rte_eth_ntnic.c:783:
+ kvlist = rte_kvargs_parse(params, valid_arguments);$
WARNING: please, no spaces at the start of a line
#1125: FILE: drivers/net/ntnic/rte_eth_ntnic.c:784:
+ if (kvlist == NULL) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1125: FILE: drivers/net/ntnic/rte_eth_ntnic.c:784:
+ if (kvlist == NULL) {
+ return -1;
WARNING: braces {} are not necessary for single statement blocks
#1125: FILE: drivers/net/ntnic/rte_eth_ntnic.c:784:
+ if (kvlist == NULL) {
+ return -1;
+ }
ERROR: code indent should use tabs where possible
#1126: FILE: drivers/net/ntnic/rte_eth_ntnic.c:785:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1126: FILE: drivers/net/ntnic/rte_eth_ntnic.c:785:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1127: FILE: drivers/net/ntnic/rte_eth_ntnic.c:786:
+ }$
WARNING: please, no spaces at the start of a line
#1130: FILE: drivers/net/ntnic/rte_eth_ntnic.c:789:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_PORT_ARG))) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1130: FILE: drivers/net/ntnic/rte_eth_ntnic.c:789:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_PORT_ARG))) {
+ assert (i == 1);
ERROR: do not use assignment in if condition
#1130: FILE: drivers/net/ntnic/rte_eth_ntnic.c:789:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_PORT_ARG))) {
ERROR: code indent should use tabs where possible
#1131: FILE: drivers/net/ntnic/rte_eth_ntnic.c:790:
+ assert (i == 1);$
WARNING: please, no spaces at the start of a line
#1131: FILE: drivers/net/ntnic/rte_eth_ntnic.c:790:
+ assert (i == 1);$
WARNING: space prohibited between function name and open parenthesis '('
#1131: FILE: drivers/net/ntnic/rte_eth_ntnic.c:790:
+ assert (i == 1);
ERROR: code indent should use tabs where possible
#1132: FILE: drivers/net/ntnic/rte_eth_ntnic.c:791:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_PORT_ARG,$
WARNING: please, no spaces at the start of a line
#1132: FILE: drivers/net/ntnic/rte_eth_ntnic.c:791:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_PORT_ARG,$
ERROR: code indent should use tabs where possible
#1133: FILE: drivers/net/ntnic/rte_eth_ntnic.c:792:
+ &ascii_to_u32, &port);$
WARNING: please, no spaces at the start of a line
#1133: FILE: drivers/net/ntnic/rte_eth_ntnic.c:792:
+ &ascii_to_u32, &port);$
WARNING: please, no spaces at the start of a line
#1134: FILE: drivers/net/ntnic/rte_eth_ntnic.c:793:
+ }$
WARNING: please, no spaces at the start of a line
#1136: FILE: drivers/net/ntnic/rte_eth_ntnic.c:795:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_PORTEND_ARG))) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1136: FILE: drivers/net/ntnic/rte_eth_ntnic.c:795:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_PORTEND_ARG))) {
+ assert (i == 1);
ERROR: do not use assignment in if condition
#1136: FILE: drivers/net/ntnic/rte_eth_ntnic.c:795:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_PORTEND_ARG))) {
ERROR: code indent should use tabs where possible
#1137: FILE: drivers/net/ntnic/rte_eth_ntnic.c:796:
+ assert (i == 1);$
WARNING: please, no spaces at the start of a line
#1137: FILE: drivers/net/ntnic/rte_eth_ntnic.c:796:
+ assert (i == 1);$
WARNING: space prohibited between function name and open parenthesis '('
#1137: FILE: drivers/net/ntnic/rte_eth_ntnic.c:796:
+ assert (i == 1);
ERROR: code indent should use tabs where possible
#1138: FILE: drivers/net/ntnic/rte_eth_ntnic.c:797:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_PORTEND_ARG,$
WARNING: please, no spaces at the start of a line
#1138: FILE: drivers/net/ntnic/rte_eth_ntnic.c:797:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_PORTEND_ARG,$
WARNING: line over 80 characters
#1139: FILE: drivers/net/ntnic/rte_eth_ntnic.c:798:
+ &ascii_to_u32, &portend);
ERROR: code indent should use tabs where possible
#1139: FILE: drivers/net/ntnic/rte_eth_ntnic.c:798:
+ &ascii_to_u32, &portend);$
WARNING: please, no spaces at the start of a line
#1139: FILE: drivers/net/ntnic/rte_eth_ntnic.c:798:
+ &ascii_to_u32, &portend);$
WARNING: please, no spaces at the start of a line
#1140: FILE: drivers/net/ntnic/rte_eth_ntnic.c:799:
+ }$
WARNING: please, no spaces at the start of a line
#1143: FILE: drivers/net/ntnic/rte_eth_ntnic.c:802:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_RXQUEUES_ARG))) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1143: FILE: drivers/net/ntnic/rte_eth_ntnic.c:802:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_RXQUEUES_ARG))) {
+ assert (i == 1);
ERROR: do not use assignment in if condition
#1143: FILE: drivers/net/ntnic/rte_eth_ntnic.c:802:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_RXQUEUES_ARG))) {
ERROR: code indent should use tabs where possible
#1144: FILE: drivers/net/ntnic/rte_eth_ntnic.c:803:
+ assert (i == 1);$
WARNING: please, no spaces at the start of a line
#1144: FILE: drivers/net/ntnic/rte_eth_ntnic.c:803:
+ assert (i == 1);$
WARNING: space prohibited between function name and open parenthesis '('
#1144: FILE: drivers/net/ntnic/rte_eth_ntnic.c:803:
+ assert (i == 1);
ERROR: code indent should use tabs where possible
#1145: FILE: drivers/net/ntnic/rte_eth_ntnic.c:804:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_RXQUEUES_ARG,$
WARNING: please, no spaces at the start of a line
#1145: FILE: drivers/net/ntnic/rte_eth_ntnic.c:804:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_RXQUEUES_ARG,$
WARNING: line over 80 characters
#1146: FILE: drivers/net/ntnic/rte_eth_ntnic.c:805:
+ &ascii_to_u32, &rxqueues);
ERROR: code indent should use tabs where possible
#1146: FILE: drivers/net/ntnic/rte_eth_ntnic.c:805:
+ &ascii_to_u32, &rxqueues);$
WARNING: please, no spaces at the start of a line
#1146: FILE: drivers/net/ntnic/rte_eth_ntnic.c:805:
+ &ascii_to_u32, &rxqueues);$
WARNING: please, no spaces at the start of a line
#1147: FILE: drivers/net/ntnic/rte_eth_ntnic.c:806:
+ }$
WARNING: please, no spaces at the start of a line
#1149: FILE: drivers/net/ntnic/rte_eth_ntnic.c:808:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_TXQUEUES_ARG))) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1149: FILE: drivers/net/ntnic/rte_eth_ntnic.c:808:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_TXQUEUES_ARG))) {
+ assert (i == 1);
ERROR: do not use assignment in if condition
#1149: FILE: drivers/net/ntnic/rte_eth_ntnic.c:808:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_TXQUEUES_ARG))) {
ERROR: code indent should use tabs where possible
#1150: FILE: drivers/net/ntnic/rte_eth_ntnic.c:809:
+ assert (i == 1);$
WARNING: please, no spaces at the start of a line
#1150: FILE: drivers/net/ntnic/rte_eth_ntnic.c:809:
+ assert (i == 1);$
WARNING: space prohibited between function name and open parenthesis '('
#1150: FILE: drivers/net/ntnic/rte_eth_ntnic.c:809:
+ assert (i == 1);
ERROR: code indent should use tabs where possible
#1151: FILE: drivers/net/ntnic/rte_eth_ntnic.c:810:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_TXQUEUES_ARG,$
WARNING: please, no spaces at the start of a line
#1151: FILE: drivers/net/ntnic/rte_eth_ntnic.c:810:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_TXQUEUES_ARG,$
WARNING: line over 80 characters
#1152: FILE: drivers/net/ntnic/rte_eth_ntnic.c:811:
+ &ascii_to_u32, &txqueues);
ERROR: code indent should use tabs where possible
#1152: FILE: drivers/net/ntnic/rte_eth_ntnic.c:811:
+ &ascii_to_u32, &txqueues);$
WARNING: please, no spaces at the start of a line
#1152: FILE: drivers/net/ntnic/rte_eth_ntnic.c:811:
+ &ascii_to_u32, &txqueues);$
WARNING: please, no spaces at the start of a line
#1153: FILE: drivers/net/ntnic/rte_eth_ntnic.c:812:
+ }$
WARNING: please, no spaces at the start of a line
#1156: FILE: drivers/net/ntnic/rte_eth_ntnic.c:815:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_STREAMID_ARG))) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1156: FILE: drivers/net/ntnic/rte_eth_ntnic.c:815:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_STREAMID_ARG))) {
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_STREAMID_ARG,
ERROR: do not use assignment in if condition
#1156: FILE: drivers/net/ntnic/rte_eth_ntnic.c:815:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_STREAMID_ARG))) {
ERROR: code indent should use tabs where possible
#1157: FILE: drivers/net/ntnic/rte_eth_ntnic.c:816:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_STREAMID_ARG,$
WARNING: please, no spaces at the start of a line
#1157: FILE: drivers/net/ntnic/rte_eth_ntnic.c:816:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_STREAMID_ARG,$
WARNING: line over 80 characters
#1158: FILE: drivers/net/ntnic/rte_eth_ntnic.c:817:
+ &ascii_to_u32_array, &astreamids);
ERROR: code indent should use tabs where possible
#1158: FILE: drivers/net/ntnic/rte_eth_ntnic.c:817:
+ &ascii_to_u32_array, &astreamids);$
WARNING: please, no spaces at the start of a line
#1158: FILE: drivers/net/ntnic/rte_eth_ntnic.c:817:
+ &ascii_to_u32_array, &astreamids);$
WARNING: please, no spaces at the start of a line
#1159: FILE: drivers/net/ntnic/rte_eth_ntnic.c:818:
+ }$
WARNING: please, no spaces at the start of a line
#1162: FILE: drivers/net/ntnic/rte_eth_ntnic.c:821:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_HASH_ARG))) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1162: FILE: drivers/net/ntnic/rte_eth_ntnic.c:821:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_HASH_ARG))) {
+ assert (i == 1);
ERROR: do not use assignment in if condition
#1162: FILE: drivers/net/ntnic/rte_eth_ntnic.c:821:
+ if ((i = rte_kvargs_count(kvlist, ETH_NTNIC_HASH_ARG))) {
ERROR: code indent should use tabs where possible
#1163: FILE: drivers/net/ntnic/rte_eth_ntnic.c:822:
+ assert (i == 1);$
WARNING: please, no spaces at the start of a line
#1163: FILE: drivers/net/ntnic/rte_eth_ntnic.c:822:
+ assert (i == 1);$
WARNING: space prohibited between function name and open parenthesis '('
#1163: FILE: drivers/net/ntnic/rte_eth_ntnic.c:822:
+ assert (i == 1);
ERROR: code indent should use tabs where possible
#1164: FILE: drivers/net/ntnic/rte_eth_ntnic.c:823:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_HASH_ARG,$
WARNING: please, no spaces at the start of a line
#1164: FILE: drivers/net/ntnic/rte_eth_ntnic.c:823:
+ ret = rte_kvargs_process(kvlist, ETH_NTNIC_HASH_ARG,$
WARNING: line over 80 characters
#1165: FILE: drivers/net/ntnic/rte_eth_ntnic.c:824:
+ &ascii_to_u32, &hash);
ERROR: code indent should use tabs where possible
#1165: FILE: drivers/net/ntnic/rte_eth_ntnic.c:824:
+ &ascii_to_u32, &hash);$
WARNING: please, no spaces at the start of a line
#1165: FILE: drivers/net/ntnic/rte_eth_ntnic.c:824:
+ &ascii_to_u32, &hash);$
WARNING: please, no spaces at the start of a line
#1166: FILE: drivers/net/ntnic/rte_eth_ntnic.c:825:
+ }$
WARNING: please, no spaces at the start of a line
#1169: FILE: drivers/net/ntnic/rte_eth_ntnic.c:828:
+ if (portend != (uint32_t)-1 && astreamids.count) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1169: FILE: drivers/net/ntnic/rte_eth_ntnic.c:828:
+ if (portend != (uint32_t)-1 && astreamids.count) {
+ RTE_LOG(ERR, PMD, "Cannot specify portend when one or more streamid's are specified
");
WARNING: line over 80 characters
#1170: FILE: drivers/net/ntnic/rte_eth_ntnic.c:829:
+ RTE_LOG(ERR, PMD, "Cannot specify portend when one or more streamid's are specified
");
ERROR: code indent should use tabs where possible
#1170: FILE: drivers/net/ntnic/rte_eth_ntnic.c:829:
+ RTE_LOG(ERR, PMD, "Cannot specify portend when one or more streamid's are specified
");$
WARNING: please, no spaces at the start of a line
#1170: FILE: drivers/net/ntnic/rte_eth_ntnic.c:829:
+ RTE_LOG(ERR, PMD, "Cannot specify portend when one or more streamid's are specified
");$
ERROR: code indent should use tabs where possible
#1171: FILE: drivers/net/ntnic/rte_eth_ntnic.c:830:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1171: FILE: drivers/net/ntnic/rte_eth_ntnic.c:830:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1172: FILE: drivers/net/ntnic/rte_eth_ntnic.c:831:
+ }$
WARNING: please, no spaces at the start of a line
#1173: FILE: drivers/net/ntnic/rte_eth_ntnic.c:832:
+ rte_kvargs_free(kvlist);$
WARNING: please, no spaces at the start of a line
#1175: FILE: drivers/net/ntnic/rte_eth_ntnic.c:834:
+ if (ret < 0)$
WARNING: suspect code indent for conditional statements (7, 15)
#1175: FILE: drivers/net/ntnic/rte_eth_ntnic.c:834:
+ if (ret < 0)
+ return -1;
ERROR: code indent should use tabs where possible
#1176: FILE: drivers/net/ntnic/rte_eth_ntnic.c:835:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1176: FILE: drivers/net/ntnic/rte_eth_ntnic.c:835:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1178: FILE: drivers/net/ntnic/rte_eth_ntnic.c:837:
+ if (first)$
WARNING: suspect code indent for conditional statements (7, 15)
#1178: FILE: drivers/net/ntnic/rte_eth_ntnic.c:837:
+ if (first)
+ NT_Init(NTAPI_VERSION);
ERROR: code indent should use tabs where possible
#1179: FILE: drivers/net/ntnic/rte_eth_ntnic.c:838:
+ NT_Init(NTAPI_VERSION);$
WARNING: please, no spaces at the start of a line
#1179: FILE: drivers/net/ntnic/rte_eth_ntnic.c:838:
+ NT_Init(NTAPI_VERSION);$
WARNING: please, no spaces at the start of a line
#1181: FILE: drivers/net/ntnic/rte_eth_ntnic.c:840:
+ if (astreamids.count) {$
WARNING: suspect code indent for conditional statements (7, 15)
#1181: FILE: drivers/net/ntnic/rte_eth_ntnic.c:840:
+ if (astreamids.count) {
+ first = 0;
ERROR: code indent should use tabs where possible
#1182: FILE: drivers/net/ntnic/rte_eth_ntnic.c:841:
+ first = 0;$
WARNING: please, no spaces at the start of a line
#1182: FILE: drivers/net/ntnic/rte_eth_ntnic.c:841:
+ first = 0;$
WARNING: line over 80 characters
#1183: FILE: drivers/net/ntnic/rte_eth_ntnic.c:842:
+ /* specific streamid specified, use that - port defaults to Tx port only */
ERROR: code indent should use tabs where possible
#1183: FILE: drivers/net/ntnic/rte_eth_ntnic.c:842:
+ /* specific streamid specified, use that - port defaults to Tx port only */$
WARNING: line over 80 characters
#1184: FILE: drivers/net/ntnic/rte_eth_ntnic.c:843:
+ if (rte_pmd_init_internals(name, rxqueues, txqueues, numa_node, &astreamids, port, ð_dev) < 0)
ERROR: code indent should use tabs where possible
#1184: FILE: drivers/net/ntnic/rte_eth_ntnic.c:843:
+ if (rte_pmd_init_internals(name, rxqueues, txqueues, numa_node, &astreamids, port, ð_dev) < 0)$
WARNING: please, no spaces at the start of a line
#1184: FILE: drivers/net/ntnic/rte_eth_ntnic.c:843:
+ if (rte_pmd_init_internals(name, rxqueues, txqueues, numa_node, &astreamids, port, ð_dev) < 0)$
WARNING: suspect code indent for conditional statements (15, 23)
#1184: FILE: drivers/net/ntnic/rte_eth_ntnic.c:843:
+ if (rte_pmd_init_internals(name, rxqueues, txqueues, numa_node, &astreamids, port, ð_dev) < 0)
+ return -1;
ERROR: code indent should use tabs where possible
#1185: FILE: drivers/net/ntnic/rte_eth_ntnic.c:844:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1185: FILE: drivers/net/ntnic/rte_eth_ntnic.c:844:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1186: FILE: drivers/net/ntnic/rte_eth_ntnic.c:845:
+ } else {$
ERROR: code indent should use tabs where possible
#1187: FILE: drivers/net/ntnic/rte_eth_ntnic.c:846:
+ struct array_s astrids;$
WARNING: please, no spaces at the start of a line
#1187: FILE: drivers/net/ntnic/rte_eth_ntnic.c:846:
+ struct array_s astrids;$
ERROR: code indent should use tabs where possible
#1188: FILE: drivers/net/ntnic/rte_eth_ntnic.c:847:
+ if (first) {$
WARNING: please, no spaces at the start of a line
#1188: FILE: drivers/net/ntnic/rte_eth_ntnic.c:847:
+ if (first) {$
WARNING: suspect code indent for conditional statements (15, 23)
#1188: FILE: drivers/net/ntnic/rte_eth_ntnic.c:847:
+ if (first) {
+ /* Delete all NTPL */
ERROR: code indent should use tabs where possible
#1189: FILE: drivers/net/ntnic/rte_eth_ntnic.c:848:
+ /* Delete all NTPL */$
ERROR: code indent should use tabs where possible
#1190: FILE: drivers/net/ntnic/rte_eth_ntnic.c:849:
+ sprintf(ntplStr, "Delete=All");$
WARNING: please, no spaces at the start of a line
#1190: FILE: drivers/net/ntnic/rte_eth_ntnic.c:849:
+ sprintf(ntplStr, "Delete=All");$
ERROR: code indent should use tabs where possible
#1191: FILE: drivers/net/ntnic/rte_eth_ntnic.c:850:
+ if (DoNtpl(ntplStr) != 0) {$
WARNING: please, no spaces at the start of a line
#1191: FILE: drivers/net/ntnic/rte_eth_ntnic.c:850:
+ if (DoNtpl(ntplStr) != 0) {$
WARNING: suspect code indent for conditional statements (23, 31)
#1191: FILE: drivers/net/ntnic/rte_eth_ntnic.c:850:
+ if (DoNtpl(ntplStr) != 0) {
+ return -1;
WARNING: braces {} are not necessary for single statement blocks
#1191: FILE: drivers/net/ntnic/rte_eth_ntnic.c:850:
+ if (DoNtpl(ntplStr) != 0) {
+ return -1;
+ }
ERROR: code indent should use tabs where possible
#1192: FILE: drivers/net/ntnic/rte_eth_ntnic.c:851:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1192: FILE: drivers/net/ntnic/rte_eth_ntnic.c:851:
+ return -1;$
ERROR: code indent should use tabs where possible
#1193: FILE: drivers/net/ntnic/rte_eth_ntnic.c:852:
+ }$
WARNING: please, no spaces at the start of a line
#1193: FILE: drivers/net/ntnic/rte_eth_ntnic.c:852:
+ }$
ERROR: code indent should use tabs where possible
#1194: FILE: drivers/net/ntnic/rte_eth_ntnic.c:853:
+ first = 0;$
WARNING: please, no spaces at the start of a line
#1194: FILE: drivers/net/ntnic/rte_eth_ntnic.c:853:
+ first = 0;$
ERROR: code indent should use tabs where possible
#1195: FILE: drivers/net/ntnic/rte_eth_ntnic.c:854:
+ }$
WARNING: please, no spaces at the start of a line
#1195: FILE: drivers/net/ntnic/rte_eth_ntnic.c:854:
+ }$
ERROR: code indent should use tabs where possible
#1196: FILE: drivers/net/ntnic/rte_eth_ntnic.c:855:
+ astrids.count=1;$
WARNING: please, no spaces at the start of a line
#1196: FILE: drivers/net/ntnic/rte_eth_ntnic.c:855:
+ astrids.count=1;$
ERROR: spaces required around that '=' (ctx:VxV)
#1196: FILE: drivers/net/ntnic/rte_eth_ntnic.c:855:
+ astrids.count=1;
^
ERROR: code indent should use tabs where possible
#1197: FILE: drivers/net/ntnic/rte_eth_ntnic.c:856:
+ astrids.value[0] = stream_id;$
WARNING: please, no spaces at the start of a line
#1197: FILE: drivers/net/ntnic/rte_eth_ntnic.c:856:
+ astrids.value[0] = stream_id;$
WARNING: line over 80 characters
#1198: FILE: drivers/net/ntnic/rte_eth_ntnic.c:857:
+ if (rte_pmd_init_internals(name, rxqueues, txqueues, numa_node, &astrids, port, ð_dev) < 0)
ERROR: code indent should use tabs where possible
#1198: FILE: drivers/net/ntnic/rte_eth_ntnic.c:857:
+ if (rte_pmd_init_internals(name, rxqueues, txqueues, numa_node, &astrids, port, ð_dev) < 0)$
WARNING: please, no spaces at the start of a line
#1198: FILE: drivers/net/ntnic/rte_eth_ntnic.c:857:
+ if (rte_pmd_init_internals(name, rxqueues, txqueues, numa_node, &astrids, port, ð_dev) < 0)$
WARNING: suspect code indent for conditional statements (15, 23)
#1198: FILE: drivers/net/ntnic/rte_eth_ntnic.c:857:
+ if (rte_pmd_init_internals(name, rxqueues, txqueues, numa_node, &astrids, port, ð_dev) < 0)
+ return -1;
ERROR: code indent should use tabs where possible
#1199: FILE: drivers/net/ntnic/rte_eth_ntnic.c:858:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1199: FILE: drivers/net/ntnic/rte_eth_ntnic.c:858:
+ return -1;$
ERROR: code indent should use tabs where possible
#1201: FILE: drivers/net/ntnic/rte_eth_ntnic.c:860:
+ /* Assign the traffic */$
ERROR: code indent should use tabs where possible
#1202: FILE: drivers/net/ntnic/rte_eth_ntnic.c:861:
+ if (portend != (uint32_t)-1) {$
WARNING: please, no spaces at the start of a line
#1202: FILE: drivers/net/ntnic/rte_eth_ntnic.c:861:
+ if (portend != (uint32_t)-1) {$
WARNING: suspect code indent for conditional statements (15, 23)
#1202: FILE: drivers/net/ntnic/rte_eth_ntnic.c:861:
+ if (portend != (uint32_t)-1) {
+ sprintf(ntplStr, "Assign[streamid=(%d..%d);Descriptor=NT]=port==(%d..%d)", stream_id,
WARNING: line over 80 characters
#1203: FILE: drivers/net/ntnic/rte_eth_ntnic.c:862:
+ sprintf(ntplStr, "Assign[streamid=(%d..%d);Descriptor=NT]=port==(%d..%d)", stream_id,
ERROR: code indent should use tabs where possible
#1203: FILE: drivers/net/ntnic/rte_eth_ntnic.c:862:
+ sprintf(ntplStr, "Assign[streamid=(%d..%d);Descriptor=NT]=port==(%d..%d)", stream_id,$
WARNING: please, no spaces at the start of a line
#1203: FILE: drivers/net/ntnic/rte_eth_ntnic.c:862:
+ sprintf(ntplStr, "Assign[streamid=(%d..%d);Descriptor=NT]=port==(%d..%d)", stream_id,$
ERROR: code indent should use tabs where possible
#1204: FILE: drivers/net/ntnic/rte_eth_ntnic.c:863:
+ (stream_id+rxqueues-1), port, portend);$
WARNING: please, no spaces at the start of a line
#1204: FILE: drivers/net/ntnic/rte_eth_ntnic.c:863:
+ (stream_id+rxqueues-1), port, portend);$
ERROR: code indent should use tabs where possible
#1206: FILE: drivers/net/ntnic/rte_eth_ntnic.c:865:
+ } else {$
WARNING: please, no spaces at the start of a line
#1206: FILE: drivers/net/ntnic/rte_eth_ntnic.c:865:
+ } else {$
WARNING: line over 80 characters
#1207: FILE: drivers/net/ntnic/rte_eth_ntnic.c:866:
+ sprintf(ntplStr, "Assign[streamid=(%d..%d);Descriptor=NT]=port==%d", stream_id,
ERROR: code indent should use tabs where possible
#1207: FILE: drivers/net/ntnic/rte_eth_ntnic.c:866:
+ sprintf(ntplStr, "Assign[streamid=(%d..%d);Descriptor=NT]=port==%d", stream_id,$
WARNING: please, no spaces at the start of a line
#1207: FILE: drivers/net/ntnic/rte_eth_ntnic.c:866:
+ sprintf(ntplStr, "Assign[streamid=(%d..%d);Descriptor=NT]=port==%d", stream_id,$
ERROR: code indent should use tabs where possible
#1208: FILE: drivers/net/ntnic/rte_eth_ntnic.c:867:
+ (stream_id+rxqueues-1), port);$
WARNING: please, no spaces at the start of a line
#1208: FILE: drivers/net/ntnic/rte_eth_ntnic.c:867:
+ (stream_id+rxqueues-1), port);$
ERROR: code indent should use tabs where possible
#1209: FILE: drivers/net/ntnic/rte_eth_ntnic.c:868:
+ }$
WARNING: please, no spaces at the start of a line
#1209: FILE: drivers/net/ntnic/rte_eth_ntnic.c:868:
+ }$
ERROR: code indent should use tabs where possible
#1210: FILE: drivers/net/ntnic/rte_eth_ntnic.c:869:
+ if (DoNtpl(ntplStr) != 0) {$
WARNING: please, no spaces at the start of a line
#1210: FILE: drivers/net/ntnic/rte_eth_ntnic.c:869:
+ if (DoNtpl(ntplStr) != 0) {$
WARNING: suspect code indent for conditional statements (15, 23)
#1210: FILE: drivers/net/ntnic/rte_eth_ntnic.c:869:
+ if (DoNtpl(ntplStr) != 0) {
+ return -1;
WARNING: braces {} are not necessary for single statement blocks
#1210: FILE: drivers/net/ntnic/rte_eth_ntnic.c:869:
+ if (DoNtpl(ntplStr) != 0) {
+ return -1;
+ }
ERROR: code indent should use tabs where possible
#1211: FILE: drivers/net/ntnic/rte_eth_ntnic.c:870:
+ return -1;$
WARNING: please, no spaces at the start of a line
#1211: FILE: drivers/net/ntnic/rte_eth_ntnic.c:870:
+ return -1;$
ERROR: code indent should use tabs where possible
#1212: FILE: drivers/net/ntnic/rte_eth_ntnic.c:871:
+ }$
WARNING: please, no spaces at the start of a line
#1212: FILE: drivers/net/ntnic/rte_eth_ntnic.c:871:
+ }$
ERROR: code indent should use tabs where possible
#1214: FILE: drivers/net/ntnic/rte_eth_ntnic.c:873:
+ if (hash != (uint32_t)-1) {$
WARNING: please, no spaces at the start of a line
#1214: FILE: drivers/net/ntnic/rte_eth_ntnic.c:873:
+ if (hash != (uint32_t)-1) {$
WARNING: suspect code indent for conditional statements (15, 23)
#1214: FILE: drivers/net/ntnic/rte_eth_ntnic.c:873:
+ if (hash != (uint32_t)-1) {
+ switch (hash) {
ERROR: code indent should use tabs where possible
#1215: FILE: drivers/net/ntnic/rte_eth_ntnic.c:874:
+ switch (hash) {$
WARNING: please, no spaces at the start of a line
#1215: FILE: drivers/net/ntnic/rte_eth_ntnic.c:874:
+ switch (hash) {$
ERROR: code indent should use tabs where possible
#1216: FILE: drivers/net/ntnic/rte_eth_ntnic.c:875:
+ default:$
ERROR: code indent should use tabs where possible
#1217: FILE: drivers/net/ntnic/rte_eth_ntnic.c:876:
+ case 1:$
WARNING: please, no spaces at the start of a line
#1217: FILE: drivers/net/ntnic/rte_eth_ntnic.c:876:
+ case 1:$
ERROR: code indent should use tabs where possible
#1218: FILE: drivers/net/ntnic/rte_eth_ntnic.c:877:
+ DoNtpl("HashMode=HashRoundRobin");$
WARNING: please, no spaces at the start of a line
#1218: FILE: drivers/net/ntnic/rte_eth_ntnic.c:877:
+ DoNtpl("HashMode=HashRoundRobin");$
ERROR: code indent should use tabs where possible
#1219: FILE: drivers/net/ntnic/rte_eth_ntnic.c:878:
+ break;$
WARNING: please, no spaces at the start of a line
#1219: FILE: drivers/net/ntnic/rte_eth_ntnic.c:878:
+ break;$
ERROR: code indent should use tabs where possible
#1220: FILE: drivers/net/ntnic/rte_eth_ntnic.c:879:
+ case 2:$
WARNING: please, no spaces at the start of a line
#1220: FILE: drivers/net/ntnic/rte_eth_ntnic.c:879:
+ case 2:$
ERROR: code indent should use tabs where possible
#1221: FILE: drivers/net/ntnic/rte_eth_ntnic.c:880:
+ DoNtpl("HashMode=Hash2TupleSorted");$
WARNING: please, no spaces at the start of a line
#1221: FILE: drivers/net/ntnic/rte_eth_ntnic.c:880:
+ DoNtpl("HashMode=Hash2TupleSorted");$
ERROR: code indent should use tabs where possible
#1222: FILE: drivers/net/ntnic/rte_eth_ntnic.c:881:
+ break;$
WARNING: please, no spaces at the start of a line
#1222: FILE: drivers/net/ntnic/rte_eth_ntnic.c:881:
+ break;$
ERROR: code indent should use tabs where possible
#1223: FILE: drivers/net/ntnic/rte_eth_ntnic.c:882:
+ case 3:$
WARNING: please, no spaces at the start of a line
#1223: FILE: drivers/net/ntnic/rte_eth_ntnic.c:882:
+ case 3:$
ERROR: code indent should use tabs where possible
#1224: FILE: drivers/net/ntnic/rte_eth_ntnic.c:883:
+ DoNtpl("HashMode=Hash5TupleSorted");$
WARNING: please, no spaces at the start of a line
#1224: FILE: drivers/net/ntnic/rte_eth_ntnic.c:883:
+ DoNtpl("HashMode=Hash5TupleSorted");$
ERROR: code indent should use tabs where possible
#1225: FILE: drivers/net/ntnic/rte_eth_ntnic.c:884:
+ break;$
WARNING: please, no spaces at the start of a line
#1225: FILE: drivers/net/ntnic/rte_eth_ntnic.c:884:
+ break;$
ERROR: code indent should use tabs where possible
#1226: FILE: drivers/net/ntnic/rte_eth_ntnic.c:885:
+ }$
WARNING: please, no spaces at the start of a line
#1226: FILE: drivers/net/ntnic/rte_eth_ntnic.c:885:
+ }$
ERROR: code indent should use tabs where possible
#1227: FILE: drivers/net/ntnic/rte_eth_ntnic.c:886:
+ }$
WARNING: please, no spaces at the start of a line
#1227: FILE: drivers/net/ntnic/rte_eth_ntnic.c:886:
+ }$
ERROR: code indent should use tabs where possible
#1229: FILE: drivers/net/ntnic/rte_eth_ntnic.c:888:
+ stream_id += rxqueues;$
WARNING: please, no spaces at the start of a line
#1229: FILE: drivers/net/ntnic/rte_eth_ntnic.c:888:
+ stream_id += rxqueues;$
WARNING: please, no spaces at the start of a line
#1230: FILE: drivers/net/ntnic/rte_eth_ntnic.c:889:
+ }$
WARNING: please, no spaces at the start of a line
#1232: FILE: drivers/net/ntnic/rte_eth_ntnic.c:891:
+ eth_dev->rx_pkt_burst = eth_ntnic_rx;$
WARNING: please, no spaces at the start of a line
#1233: FILE: drivers/net/ntnic/rte_eth_ntnic.c:892:
+ eth_dev->tx_pkt_burst = eth_ntnic_tx_ringbuffer;$
WARNING: please, no spaces at the start of a line
#1235: FILE: drivers/net/ntnic/rte_eth_ntnic.c:894:
+ return 0;$
WARNING: please, no spaces at the start of a line
#1241: FILE: drivers/net/ntnic/rte_eth_ntnic.c:900:
+ .type = PMD_VDEV,$
WARNING: please, no spaces at the start of a line
#1242: FILE: drivers/net/ntnic/rte_eth_ntnic.c:901:
+ .init = rte_pmd_ntnic_devinit,$
WARNING: please, no spaces at the start of a line
#1247: FILE: drivers/net/ntnic/rte_eth_ntnic.c:906:
+ "port=<int> "$
WARNING: please, no spaces at the start of a line
#1248: FILE: drivers/net/ntnic/rte_eth_ntnic.c:907:
+ "rxqs=<int>"$
WARNING: please, no spaces at the start of a line
#1249: FILE: drivers/net/ntnic/rte_eth_ntnic.c:908:
+ "txqs=<int>"$
WARNING: please, no spaces at the start of a line
#1250: FILE: drivers/net/ntnic/rte_eth_ntnic.c:909:
+ "hash=<int>"$
WARNING: please, no spaces at the start of a line
#1251: FILE: drivers/net/ntnic/rte_eth_ntnic.c:910:
+ "streamids=<int..int>");$
total: 317 errors, 746 warnings, 1196 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
/home/patchWorkOrg/patches/dpdk-dev-ntnic-add-PMD-driver.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass
DPDK STV team
More information about the test-report
mailing list