[dpdk-test-report] [PatchWork]|ERROR| pw15445-15447 lib/librte_table: enabling cuckoo hash into table library

sys_stv at intel.com sys_stv at intel.com
Fri Sep 2 09:58:17 CEST 2016
Previous message: [dpdk-test-report] [PatchWork]|ERROR| pw15442-15444 hash: reorganize bucket structure
Next message: [dpdk-test-report] [PatchWork]|ERROR| pw15450-15505 qede/base: update base driver
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 15445
http://www.dpdk.org/dev/patchwork/patch/15445/
Submitter: "Chokkalingam, SankarX" <sankarx.chokkalingam at intel.com>
Date: Fri, 26 Aug 2016 17:01:16 -0700
DPDK git baseline: e22856313fff2db12d8e132dad446bbf74cf29a5

Check patch error:
15445: 
WARNING: please, no spaces at the start of a line
#83: FILE: lib/librte_table/rte_table_hash.h:369:
+    uint32_t key_size;$

WARNING: please, no spaces at the start of a line
#86: FILE: lib/librte_table/rte_table_hash.h:372:
+    uint32_t n_keys;$

WARNING: please, no spaces at the start of a line
#89: FILE: lib/librte_table/rte_table_hash.h:375:
+    rte_table_hash_op_hash f_hash;$

WARNING: please, no spaces at the start of a line
#92: FILE: lib/librte_table/rte_table_hash.h:378:
+    uint32_t seed;$

WARNING: please, no spaces at the start of a line
#97: FILE: lib/librte_table/rte_table_hash.h:383:
+    uint32_t signature_offset;$

WARNING: please, no spaces at the start of a line
#100: FILE: lib/librte_table/rte_table_hash.h:386:
+    uint32_t key_offset;$

WARNING: please, no spaces at the start of a line
#103: FILE: lib/librte_table/rte_table_hash.h:389:
+    const char *name;$

ERROR: Macros with complex values should be enclosed in parenthesis
#164: FILE: lib/librte_table/rte_table_hash_cuckoo.c:47:
+#define RTE_TABLE_HASH_CUCKOO_STATS_PKTS_IN_ADD(table, val) +	table->stats.n_pkts_in += val

ERROR: Macros with complex values should be enclosed in parenthesis
#166: FILE: lib/librte_table/rte_table_hash_cuckoo.c:49:
+#define RTE_TABLE_HASH_CUCKOO_STATS_PKTS_LOOKUP_MISS(table, val) +	table->stats.n_pkts_lookup_miss += val

WARNING: line over 80 characters
#199: FILE: lib/librte_table/rte_table_hash_cuckoo.c:82:
+check_params_create_hash_cuckoo(const struct 
+rte_table_hash_cuckoo_params *params)

ERROR: space required before the open brace '{'
#207: FILE: lib/librte_table/rte_table_hash_cuckoo.c:90:
+	if(params->key_size == 0){

ERROR: space required before the open parenthesis '('
#207: FILE: lib/librte_table/rte_table_hash_cuckoo.c:90:
+	if(params->key_size == 0){

ERROR: spaces required around that '==' (ctx:VxW)
#217: FILE: lib/librte_table/rte_table_hash_cuckoo.c:100:
+	if (params->f_hash== NULL) {
 	                  ^

ERROR: "foo * bar" should be "foo *bar"
#231: FILE: lib/librte_table/rte_table_hash_cuckoo.c:114:
+rte_table_hash_cuckoo_create(void * params,

ERROR: space required before the open parenthesis '('
#243: FILE: lib/librte_table/rte_table_hash_cuckoo.c:126:
+	if(check_params_create_hash_cuckoo(params))

ERROR: space prohibited after that open parenthesis '('
#274: FILE: lib/librte_table/rte_table_hash_cuckoo.c:157:
+		if( NULL == rte_hash_handle) {

ERROR: space required before the open parenthesis '('
#274: FILE: lib/librte_table/rte_table_hash_cuckoo.c:157:
+		if( NULL == rte_hash_handle) {

ERROR: space required before the open parenthesis '('
#303: FILE: lib/librte_table/rte_table_hash_cuckoo.c:186:
+	if(table == NULL) {

ERROR: "(foo*)" should be "(foo *)"
#308: FILE: lib/librte_table/rte_table_hash_cuckoo.c:191:
+	struct rte_table_hash *t = (struct rte_table_hash*)table;

ERROR: code indent should use tabs where possible
#318: FILE: lib/librte_table/rte_table_hash_cuckoo.c:201:
+        int *key_found, void **entry_ptr)$

WARNING: please, no spaces at the start of a line
#318: FILE: lib/librte_table/rte_table_hash_cuckoo.c:201:
+        int *key_found, void **entry_ptr)$

ERROR: space required before the open parenthesis '('
#322: FILE: lib/librte_table/rte_table_hash_cuckoo.c:205:
+	if(table == NULL) {

ERROR: space required before the open parenthesis '('
#327: FILE: lib/librte_table/rte_table_hash_cuckoo.c:210:
+	if(key == NULL) {

ERROR: space required before the open parenthesis '('
#332: FILE: lib/librte_table/rte_table_hash_cuckoo.c:215:
+	if(entry == NULL) {

ERROR: "(foo*)" should be "(foo *)"
#337: FILE: lib/librte_table/rte_table_hash_cuckoo.c:220:
+	struct rte_table_hash *t = (struct rte_table_hash*)table;

ERROR: do not use C99 // comments
#339: FILE: lib/librte_table/rte_table_hash_cuckoo.c:222:
+	// Find Existing entries

WARNING: suspect code indent for conditional statements (8, 8)
#350: FILE: lib/librte_table/rte_table_hash_cuckoo.c:233:
+	} else if (pos == -ENOENT) {
+	// Entry not found. Adding new entry

ERROR: do not use C99 // comments
#351: FILE: lib/librte_table/rte_table_hash_cuckoo.c:234:
+	// Entry not found. Adding new entry

ERROR: trailing whitespace
#373: FILE: lib/librte_table/rte_table_hash_cuckoo.c:256:
+rte_table_hash_cuckoo_entry_delete(void *table, void *key, $

ERROR: code indent should use tabs where possible
#374: FILE: lib/librte_table/rte_table_hash_cuckoo.c:257:
+        int *key_found, __rte_unused void *entry)$

WARNING: please, no spaces at the start of a line
#374: FILE: lib/librte_table/rte_table_hash_cuckoo.c:257:
+        int *key_found, __rte_unused void *entry)$

ERROR: space required before the open parenthesis '('
#378: FILE: lib/librte_table/rte_table_hash_cuckoo.c:261:
+	if(table == NULL) {

ERROR: space required before the open parenthesis '('
#383: FILE: lib/librte_table/rte_table_hash_cuckoo.c:266:
+	if(key == NULL) {

ERROR: "(foo*)" should be "(foo *)"
#388: FILE: lib/librte_table/rte_table_hash_cuckoo.c:271:
+	struct rte_table_hash *t = (struct rte_table_hash*)table;

ERROR: trailing whitespace
#399: FILE: lib/librte_table/rte_table_hash_cuckoo.c:282:
+rte_table_hash_cuckoo_lookup_bulk_dosig(void *table, $

ERROR: code indent should use tabs where possible
#400: FILE: lib/librte_table/rte_table_hash_cuckoo.c:283:
+        struct rte_mbuf **pkts,$

WARNING: please, no spaces at the start of a line
#400: FILE: lib/librte_table/rte_table_hash_cuckoo.c:283:
+        struct rte_mbuf **pkts,$

ERROR: code indent should use tabs where possible
#401: FILE: lib/librte_table/rte_table_hash_cuckoo.c:284:
+        uint64_t pkts_mask,$

WARNING: please, no spaces at the start of a line
#401: FILE: lib/librte_table/rte_table_hash_cuckoo.c:284:
+        uint64_t pkts_mask,$

ERROR: code indent should use tabs where possible
#402: FILE: lib/librte_table/rte_table_hash_cuckoo.c:285:
+        uint64_t *lookup_hit_mask,$

WARNING: please, no spaces at the start of a line
#402: FILE: lib/librte_table/rte_table_hash_cuckoo.c:285:
+        uint64_t *lookup_hit_mask,$

ERROR: code indent should use tabs where possible
#403: FILE: lib/librte_table/rte_table_hash_cuckoo.c:286:
+        void **entries)$

WARNING: please, no spaces at the start of a line
#403: FILE: lib/librte_table/rte_table_hash_cuckoo.c:286:
+        void **entries)$

ERROR: "(foo*)" should be "(foo *)"
#410: FILE: lib/librte_table/rte_table_hash_cuckoo.c:293:
+	struct rte_table_hash *t = (struct rte_table_hash*)table;

ERROR: trailing whitespace
#413: FILE: lib/librte_table/rte_table_hash_cuckoo.c:296:
+^I$

WARNING: braces {} are not necessary for single statement blocks
#415: FILE: lib/librte_table/rte_table_hash_cuckoo.c:298:
+	for (i = 0; i < n_pkts_in; i++) {
+		keys[i] = RTE_MBUF_METADATA_UINT8_PTR(pkts[i], t->key_offset);
+	}

ERROR: trailing whitespace
#442: FILE: lib/librte_table/rte_table_hash_cuckoo.c:325:
+rte_table_hash_cuckoo_lookup_dosig(void *table, $

ERROR: code indent should use tabs where possible
#443: FILE: lib/librte_table/rte_table_hash_cuckoo.c:326:
+        struct rte_mbuf **pkts,$

WARNING: please, no spaces at the start of a line
#443: FILE: lib/librte_table/rte_table_hash_cuckoo.c:326:
+        struct rte_mbuf **pkts,$

ERROR: code indent should use tabs where possible
#444: FILE: lib/librte_table/rte_table_hash_cuckoo.c:327:
+        uint64_t pkts_mask,$

WARNING: please, no spaces at the start of a line
#444: FILE: lib/librte_table/rte_table_hash_cuckoo.c:327:
+        uint64_t pkts_mask,$

ERROR: code indent should use tabs where possible
#445: FILE: lib/librte_table/rte_table_hash_cuckoo.c:328:
+        uint64_t *lookup_hit_mask,$

WARNING: please, no spaces at the start of a line
#445: FILE: lib/librte_table/rte_table_hash_cuckoo.c:328:
+        uint64_t *lookup_hit_mask,$

ERROR: code indent should use tabs where possible
#446: FILE: lib/librte_table/rte_table_hash_cuckoo.c:329:
+        void **entries)$

WARNING: please, no spaces at the start of a line
#446: FILE: lib/librte_table/rte_table_hash_cuckoo.c:329:
+        void **entries)$

ERROR: space required before the open parenthesis '('
#452: FILE: lib/librte_table/rte_table_hash_cuckoo.c:335:
+	if(table == NULL) {

ERROR: space required before the open parenthesis '('
#457: FILE: lib/librte_table/rte_table_hash_cuckoo.c:340:
+	if(pkts == NULL) {

ERROR: "(foo*)" should be "(foo *)"
#462: FILE: lib/librte_table/rte_table_hash_cuckoo.c:345:
+	struct rte_table_hash *t = (struct rte_table_hash*)table;

ERROR: trailing whitespace
#467: FILE: lib/librte_table/rte_table_hash_cuckoo.c:350:
+^I^Ireturn(rte_table_hash_cuckoo_lookup_bulk_dosig(table, $

ERROR: return is not a function, parentheses are not required
#467: FILE: lib/librte_table/rte_table_hash_cuckoo.c:350:
+		return(rte_table_hash_cuckoo_lookup_bulk_dosig(table,

ERROR: space prohibited after that open parenthesis '('
#478: FILE: lib/librte_table/rte_table_hash_cuckoo.c:361:
+	for ( i = 0; pkts_mask; i++) {

ERROR: trailing whitespace
#489: FILE: lib/librte_table/rte_table_hash_cuckoo.c:372:
+^I^I^I^I__func__, i); $

ERROR: trailing whitespace
#503: FILE: lib/librte_table/rte_table_hash_cuckoo.c:386:
+static int                                                                  $

ERROR: trailing whitespace
#504: FILE: lib/librte_table/rte_table_hash_cuckoo.c:387:
+rte_table_hash_cuckoo_stats_read(void *table, struct rte_table_stats 
+*stats, $

ERROR: code indent should use tabs where possible
#505: FILE: lib/librte_table/rte_table_hash_cuckoo.c:388:
+        int clear)$

WARNING: please, no spaces at the start of a line
#505: FILE: lib/librte_table/rte_table_hash_cuckoo.c:388:
+        int clear)$

ERROR: space required before the open parenthesis '('
#507: FILE: lib/librte_table/rte_table_hash_cuckoo.c:390:
+	if(table == NULL) {

ERROR: trailing whitespace
#532: FILE: lib/librte_table/rte_table_hash_cuckoo.c:415:
+};         $

total: 47 errors, 21 warnings, 490 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-1-3-lib-librte_table-enabling-cuckoo-hash-into-table-library.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

15446:
ERROR: code indent should use tabs where possible
#48: FILE: app/test-pipeline/config.c:143:
+        {"hash-cuckoo-8", e_APP_PIPELINE_HASH_CUCKOO_KEY8},$

WARNING: please, no spaces at the start of a line
#48: FILE: app/test-pipeline/config.c:143:
+        {"hash-cuckoo-8", e_APP_PIPELINE_HASH_CUCKOO_KEY8},$

ERROR: code indent should use tabs where possible
#49: FILE: app/test-pipeline/config.c:144:
+        {"hash-cuckoo-16", e_APP_PIPELINE_HASH_CUCKOO_KEY16},$

WARNING: please, no spaces at the start of a line
#49: FILE: app/test-pipeline/config.c:144:
+        {"hash-cuckoo-16", e_APP_PIPELINE_HASH_CUCKOO_KEY16},$

ERROR: code indent should use tabs where possible
#50: FILE: app/test-pipeline/config.c:145:
+        {"hash-cuckoo-32", e_APP_PIPELINE_HASH_CUCKOO_KEY32},$

WARNING: please, no spaces at the start of a line
#50: FILE: app/test-pipeline/config.c:145:
+        {"hash-cuckoo-32", e_APP_PIPELINE_HASH_CUCKOO_KEY32},$

ERROR: code indent should use tabs where possible
#51: FILE: app/test-pipeline/config.c:146:
+        {"hash-cuckoo-48", e_APP_PIPELINE_HASH_CUCKOO_KEY48},$

WARNING: please, no spaces at the start of a line
#51: FILE: app/test-pipeline/config.c:146:
+        {"hash-cuckoo-48", e_APP_PIPELINE_HASH_CUCKOO_KEY48},$

ERROR: code indent should use tabs where possible
#52: FILE: app/test-pipeline/config.c:147:
+        {"hash-cuckoo-64", e_APP_PIPELINE_HASH_CUCKOO_KEY64},$

WARNING: please, no spaces at the start of a line
#52: FILE: app/test-pipeline/config.c:147:
+        {"hash-cuckoo-64", e_APP_PIPELINE_HASH_CUCKOO_KEY64},$

ERROR: code indent should use tabs where possible
#53: FILE: app/test-pipeline/config.c:148:
+        {"hash-cuckoo-80", e_APP_PIPELINE_HASH_CUCKOO_KEY80},$

WARNING: please, no spaces at the start of a line
#53: FILE: app/test-pipeline/config.c:148:
+        {"hash-cuckoo-80", e_APP_PIPELINE_HASH_CUCKOO_KEY80},$

ERROR: code indent should use tabs where possible
#54: FILE: app/test-pipeline/config.c:149:
+        {"hash-cuckoo-96", e_APP_PIPELINE_HASH_CUCKOO_KEY96},$

WARNING: please, no spaces at the start of a line
#54: FILE: app/test-pipeline/config.c:149:
+        {"hash-cuckoo-96", e_APP_PIPELINE_HASH_CUCKOO_KEY96},$

ERROR: code indent should use tabs where possible
#55: FILE: app/test-pipeline/config.c:150:
+        {"hash-cuckoo-112", e_APP_PIPELINE_HASH_CUCKOO_KEY112},$

WARNING: please, no spaces at the start of a line
#55: FILE: app/test-pipeline/config.c:150:
+        {"hash-cuckoo-112", e_APP_PIPELINE_HASH_CUCKOO_KEY112},$

ERROR: code indent should use tabs where possible
#56: FILE: app/test-pipeline/config.c:151:
+        {"hash-cuckoo-128", e_APP_PIPELINE_HASH_CUCKOO_KEY128},$

WARNING: please, no spaces at the start of a line
#56: FILE: app/test-pipeline/config.c:151:
+        {"hash-cuckoo-128", e_APP_PIPELINE_HASH_CUCKOO_KEY128},$

ERROR: space required after that ',' (ctx:VxV)
#189: FILE: app/test-pipeline/pipeline_hash.c:394:
+		snprintf(hash_name, sizeof(hash_name),"RTE_TH_CUCKOO_%d",
 		                                     ^

total: 10 errors, 9 warnings, 162 lines checked


15447:
WARNING: line over 80 characters
#200: FILE: app/test/test_table_tables.c:978:
+	table = rte_table_hash_cuckoo_dosig_ops.f_create(&cuckoo_params, 0, entry_size);

WARNING: line over 80 characters
#207: FILE: app/test/test_table_tables.c:985:
+	table = rte_table_hash_cuckoo_dosig_ops.f_create(&cuckoo_params, 0, entry_size);

WARNING: line over 80 characters
#214: FILE: app/test/test_table_tables.c:992:
+	table = rte_table_hash_cuckoo_dosig_ops.f_create(&cuckoo_params, 0, entry_size);

ERROR: spaces required around that '=' (ctx:VxW)
#219: FILE: app/test/test_table_tables.c:997:
+	cuckoo_params.name= NULL;
 	                  ^

WARNING: line over 80 characters
#221: FILE: app/test/test_table_tables.c:999:
+	table = rte_table_hash_cuckoo_dosig_ops.f_create(&cuckoo_params, 0, entry_size);

ERROR: spaces required around that '=' (ctx:VxW)
#225: FILE: app/test/test_table_tables.c:1003:
+	cuckoo_params.name= "CUCKOO";
 	                  ^

WARNING: line over 80 characters
#227: FILE: app/test/test_table_tables.c:1005:
+	table = rte_table_hash_cuckoo_dosig_ops.f_create(&cuckoo_params, 0, entry_size);

WARNING: line over 80 characters
#252: FILE: app/test/test_table_tables.c:1030:
+	status = rte_table_hash_cuckoo_dosig_ops.f_add(NULL, &key_cuckoo, &entry, &key_found,

WARNING: line over 80 characters
#257: FILE: app/test/test_table_tables.c:1035:
+	status = rte_table_hash_cuckoo_dosig_ops.f_add(table, NULL, &entry, &key_found,

WARNING: line over 80 characters
#262: FILE: app/test/test_table_tables.c:1040:
+	status = rte_table_hash_cuckoo_dosig_ops.f_add(table, &key_cuckoo, NULL, &key_found,

WARNING: line over 80 characters
#267: FILE: app/test/test_table_tables.c:1045:
+	status = rte_table_hash_cuckoo_dosig_ops.f_add(table, &key_cuckoo, &entry, &key_found,

WARNING: line over 80 characters
#272: FILE: app/test/test_table_tables.c:1050:
+	status = rte_table_hash_cuckoo_dosig_ops.f_add(table, &key_cuckoo, &entry, &key_found,

WARNING: line over 80 characters
#278: FILE: app/test/test_table_tables.c:1056:
+	status = rte_table_hash_cuckoo_dosig_ops.f_delete(NULL, &key_cuckoo, &key_found, NULL);

WARNING: line over 80 characters
#282: FILE: app/test/test_table_tables.c:1060:
+	status = rte_table_hash_cuckoo_dosig_ops.f_delete(table, NULL, &key_found, NULL);

WARNING: line over 80 characters
#286: FILE: app/test/test_table_tables.c:1064:
+	status = rte_table_hash_cuckoo_dosig_ops.f_delete(table, &key_cuckoo, &key_found, NULL);

WARNING: line over 80 characters
#290: FILE: app/test/test_table_tables.c:1068:
+	status = rte_table_hash_cuckoo_dosig_ops.f_delete(table, &key_cuckoo, &key_found, NULL);

WARNING: line over 80 characters
#296: FILE: app/test/test_table_tables.c:1074:
+	status = rte_table_hash_cuckoo_dosig_ops.f_add(table, &key_cuckoo, &entry, &key_found,

total: 2 errors, 15 warnings, 289 lines checked

/home/patchWorkOrg/patches/dpdk-dev-3-3-app-test-adding-cuckoo-hash-table-for-testing.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team
Previous message: [dpdk-test-report] [PatchWork]|ERROR| pw15442-15444 hash: reorganize bucket structure
Next message: [dpdk-test-report] [PatchWork]|ERROR| pw15450-15505 qede/base: update base driver
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list