[dpdk-test-report] |WARNING| pw23633 [PATCH] Proposal of mbuf Race Condition Detection

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Apr 13 23:00:11 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23633

_coding style issues_


ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#50: 
@@ -492,8 +495,10 @@ send_packets_multi(struct lcore_conf *qconf, struct

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#141: 
> > Besides, race condition is very difficult to reproduce. Usually we get a

ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#279: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:298:
**pkts_burst,

ERROR:CODE_INDENT: code indent should use tabs where possible
#283: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:302:
+            RTE_MBUF_LOCK(pkts_burst[j]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#283: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:302:
+            RTE_MBUF_LOCK(pkts_burst[j]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#284: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:303:
+            RTE_MBUF_LOCK(pkts_burst[j+1]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#284: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:303:
+            RTE_MBUF_LOCK(pkts_burst[j+1]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#285: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:304:
+            RTE_MBUF_LOCK(pkts_burst[j+2]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#285: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:304:
+            RTE_MBUF_LOCK(pkts_burst[j+2]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#286: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:305:
+            RTE_MBUF_LOCK(pkts_burst[j+3]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#286: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:305:
+            RTE_MBUF_LOCK(pkts_burst[j+3]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#287: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:306:
+            RTE_MBUF_LOCK(pkts_burst[j+4]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#287: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:306:
+            RTE_MBUF_LOCK(pkts_burst[j+4]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#288: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:307:
+            RTE_MBUF_LOCK(pkts_burst[j+5]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#288: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:307:
+            RTE_MBUF_LOCK(pkts_burst[j+5]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#289: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:308:
+            RTE_MBUF_LOCK(pkts_burst[j+6]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#289: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:308:
+            RTE_MBUF_LOCK(pkts_burst[j+6]);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#290: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:309:
+            RTE_MBUF_LOCK(pkts_burst[j+7]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#290: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:309:
+            RTE_MBUF_LOCK(pkts_burst[j+7]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#301: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:345:
+      for (; j < nb_rx; j++) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (6, 14)
#301: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:345:
+      for (; j < nb_rx; j++) {
+              RTE_MBUF_LOCK(pkts_burst[j]);

ERROR:CODE_INDENT: code indent should use tabs where possible
#302: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:346:
+              RTE_MBUF_LOCK(pkts_burst[j]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:346:
+              RTE_MBUF_LOCK(pkts_burst[j]);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#304: FILE: examples/l3fwd/l3fwd_em_hlm_sse.h:348:
+      }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#317: FILE: examples/l3fwd/l3fwd_sse.h:325:
+      for (j = 0; j < num; ++j)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (6, 12)
#317: FILE: examples/l3fwd/l3fwd_sse.h:325:
+      for (j = 0; j < num; ++j)
+            RTE_MBUF_UNLOCK(m);

ERROR:CODE_INDENT: code indent should use tabs where possible
#318: FILE: examples/l3fwd/l3fwd_sse.h:326:
+            RTE_MBUF_UNLOCK(m);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#318: FILE: examples/l3fwd/l3fwd_sse.h:326:
+            RTE_MBUF_UNLOCK(m);$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 13 errors, 16 warnings, 37 lines checked


More information about the test-report mailing list