[dpdk-test-report] |WARNING| pw27380 [PATCH v1 14/21] net/mlx5: add Hash Rx queue object

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Aug 2 16:12:15 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27380

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#33: FILE: drivers/net/mlx5/mlx5.c:187:
+		WARN("%p: some Hash Rx queue still remain", (void*)priv);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#323: FILE: drivers/net/mlx5/mlx5_rxq.c:1755:
+	DEBUG("%p: Hash Rx queue %p: refcnt %d", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#324: FILE: drivers/net/mlx5/mlx5_rxq.c:1756:
+	      (void*)hrxq, rte_atomic32_read(&hrxq->refcnt));

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#363: FILE: drivers/net/mlx5/mlx5_rxq.c:1795:
+		DEBUG("%p: Hash Rx queue %p: refcnt %d", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#364: FILE: drivers/net/mlx5/mlx5_rxq.c:1796:
+		      (void*)hrxq, rte_atomic32_read(&hrxq->refcnt));

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#384: FILE: drivers/net/mlx5/mlx5_rxq.c:1816:
+	DEBUG("%p: Hash Rx queue %p: refcnt %d", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#385: FILE: drivers/net/mlx5/mlx5_rxq.c:1817:
+	      (void*)hrxq, rte_atomic32_read(&hrxq->refcnt));

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#392: FILE: drivers/net/mlx5/mlx5_rxq.c:1824:
+		return 0;
+	} else {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#396: FILE: drivers/net/mlx5/mlx5_rxq.c:1828:
+	return EBUSY;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#415: FILE: drivers/net/mlx5/mlx5_rxq.c:1847:
+		      (void*)priv, (void*)hrxq);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#415: FILE: drivers/net/mlx5/mlx5_rxq.c:1847:
+		      (void*)priv, (void*)hrxq);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#446: FILE: drivers/net/mlx5/mlx5_rxtx.h:377:
+struct mlx5_hrxq* mlx5_priv_hrxq_new(struct priv *priv, uint8_t *rss_key,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#449: FILE: drivers/net/mlx5/mlx5_rxtx.h:380:
+struct mlx5_hrxq* mlx5_priv_hrxq_get(struct priv *priv, uint8_t *rss_key,

total: 11 errors, 2 warnings, 0 checks, 403 lines checked


More information about the test-report mailing list