[dpdk-test-report] |WARNING| pw27399 [PATCH 1/2] net/mlx4: get back RX flow functionality

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Aug 3 10:51:17 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27399

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#119: FILE: drivers/net/mlx4/mlx4_prm.h:56:
+#define MLX4_TRANSPOSE(val, from, to) \
+	(((from) >= (to)) ? \
+	 (((val) & (from)) / ((from) / (to))) : \
+	 (((val) & (from)) * ((to) / (from))))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'from' - possible side-effects?
#119: FILE: drivers/net/mlx4/mlx4_prm.h:56:
+#define MLX4_TRANSPOSE(val, from, to) \
+	(((from) >= (to)) ? \
+	 (((val) & (from)) / ((from) / (to))) : \
+	 (((val) & (from)) * ((to) / (from))))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'to' - possible side-effects?
#119: FILE: drivers/net/mlx4/mlx4_prm.h:56:
+#define MLX4_TRANSPOSE(val, from, to) \
+	(((from) >= (to)) ? \
+	 (((val) & (from)) / ((from) / (to))) : \
+	 (((val) & (from)) * ((to) / (from))))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#334: FILE: drivers/net/mlx4/mlx4_prm.h:271:
+	unsigned         max_post;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#336: FILE: drivers/net/mlx4/mlx4_prm.h:273:
+	unsigned         head;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#337: FILE: drivers/net/mlx4/mlx4_prm.h:274:
+	unsigned         tail;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#340: FILE: drivers/net/mlx4/mlx4_prm.h:277:
+	unsigned         head_en_index;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#341: FILE: drivers/net/mlx4/mlx4_prm.h:278:
+	unsigned         head_en_count;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#373: FILE: drivers/net/mlx4/mlx4_prm.h:310:
+	unsigned              last_db_head;

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'xxx' may be better as '(xxx)' to avoid precedence issues
#448: FILE: drivers/net/mlx4/mlx4_prm.h:385:
+#define to_mxxx(xxx, type) \
+	((struct mlx4_##type *)	\
+	 ((uint8_t *)ib##xxx - offsetof(struct mlx4_##type, ibv_##xxx)))

CHECK:BRACES: Unbalanced braces around else statement
#512: FILE: drivers/net/mlx4/mlx4_rxq.c:104:
+		} else

total: 0 errors, 6 warnings, 5 checks, 1079 lines checked


More information about the test-report mailing list