[dpdk-test-report] |WARNING| pw27524 [PATCH] kni: fix SLE version detection

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Aug 11 18:33:51 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27524

_coding style issues_


WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#36: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:700:
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 57))

ERROR:SPACING: space required after that ',' (ctx:VxV)
#39: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:703:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#39: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:703:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
                                                  ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#39: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:703:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )

ERROR:SPACING: space prohibited before that close parenthesis ')'
#39: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:703:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#39: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:703:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )

ERROR:SPACING: space required after that ',' (ctx:VxV)
#41: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:705:
+#define SLE_VERSION_CODE SLE_VERSION(12,0,0)
                                        ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#41: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:705:
+#define SLE_VERSION_CODE SLE_VERSION(12,0,0)
                                          ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#52: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:710:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )
                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#52: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:710:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )
                                                 ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#52: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:710:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )

ERROR:SPACING: space prohibited before that close parenthesis ')'
#52: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:710:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#52: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:710:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )

ERROR:SPACING: space required after that ',' (ctx:VxV)
#54: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:712:
+#define SLE_VERSION_CODE SLE_VERSION(11,1,0)
                                        ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#54: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:712:
+#define SLE_VERSION_CODE SLE_VERSION(11,1,0)
                                          ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#55: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:713:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )
                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#55: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:713:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )
                                                 ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#55: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:713:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )

ERROR:SPACING: space prohibited before that close parenthesis ')'
#55: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:713:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#55: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:713:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )

ERROR:SPACING: space required after that ',' (ctx:VxV)
#57: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:715:
+#define SLE_VERSION_CODE SLE_VERSION(11,0,0)
                                        ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#57: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:715:
+#define SLE_VERSION_CODE SLE_VERSION(11,0,0)
                                          ^

total: 18 errors, 4 warnings, 34 lines checked


More information about the test-report mailing list