[dpdk-test-report] |WARNING| pw27683 [PATCH RFC] net/mlx5: support count flow action
checkpatch at dpdk.org
checkpatch at dpdk.org
Mon Aug 21 14:37:06 CEST 2017
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27683
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18:
driver. As soon as the features will be implemented on the verbs driver this
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#121: FILE: drivers/net/mlx5/mlx5_flow.c:1167:
+ * ^I Counter id.$
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#129: FILE: drivers/net/mlx5/mlx5_flow.c:1175:
+{
+
ERROR:SPACING: space required after that ',' (ctx:VxV)
#134: FILE: drivers/net/mlx5/mlx5_flow.c:1180:
+ counter = ibv_create_counter_set(priv->ctx,0);
^
WARNING:BRACES: braces {} are not necessary for single statement blocks
#135: FILE: drivers/net/mlx5/mlx5_flow.c:1181:
+ if (!counter) {
+ return NULL;
+ }
ERROR:SPACING: space required after that ',' (ctx:VxO)
#171: FILE: drivers/net/mlx5/mlx5_flow.c:1263:
+ counter = priv_flow_create_counter(priv,&flow,0);
^
ERROR:SPACING: space required before that '&' (ctx:OxV)
#171: FILE: drivers/net/mlx5/mlx5_flow.c:1263:
+ counter = priv_flow_create_counter(priv,&flow,0);
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#171: FILE: drivers/net/mlx5/mlx5_flow.c:1263:
+ counter = priv_flow_create_counter(priv,&flow,0);
^
ERROR:SPACING: space required before the open parenthesis '('
#172: FILE: drivers/net/mlx5/mlx5_flow.c:1264:
+ if(!counter)
ERROR:SPACING: space required after that ',' (ctx:VxV)
#235: FILE: drivers/net/mlx5/mlx5_flow.c:1704:
+ res_value = ibv_query_counter_set(attr,counters);
^
ERROR:SPACING: space required before the open parenthesis '('
#236: FILE: drivers/net/mlx5/mlx5_flow.c:1705:
+ if(res_value < 0) {
ERROR:SPACING: space required after that ',' (ctx:VxV)
#244: FILE: drivers/net/mlx5/mlx5_flow.c:1713:
+ res_value = ibv_query_counter_set(attr,res->hits);
^
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#262: FILE: drivers/net/mlx5/mlx5_flow.c:1731:
+{
+
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#264: FILE: drivers/net/mlx5/mlx5_flow.c:1733:
+ switch (type){
+ case RTE_FLOW_ACTION_TYPE_COUNT:
ERROR:SPACING: space required before the open brace '{'
#264: FILE: drivers/net/mlx5/mlx5_flow.c:1733:
+ switch (type){
WARNING:LONG_LINE: line over 90 characters
#268: FILE: drivers/net/mlx5/mlx5_flow.c:1737:
+ RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
WARNING:LONG_LINE: line over 90 characters
#274: FILE: drivers/net/mlx5/mlx5_flow.c:1743:
+ res_value = priv_flow_query_counter(mlx5_get_priv(dev), flow->counter,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#275: FILE: drivers/net/mlx5/mlx5_flow.c:1744:
+ (struct rte_flow_query_count*)res,
total: 11 errors, 5 warnings, 2 checks, 246 lines checked
More information about the test-report
mailing list