[dpdk-test-report] |WARNING| pw27764 [PATCH v2] net/failsafe: safer subdev iterator
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Aug 25 12:26:43 CEST 2017
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27764
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 's' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (s = fs_find_next((dev), 0, state, &i); \
+ s != NULL; \
+ s = fs_find_next((dev), i + 1, state, &i))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (s = fs_find_next((dev), 0, state, &i); \
+ s != NULL; \
+ s = fs_find_next((dev), i + 1, state, &i))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'i' may be better as '(i)' to avoid precedence issues
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (s = fs_find_next((dev), 0, state, &i); \
+ s != NULL; \
+ s = fs_find_next((dev), i + 1, state, &i))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (s = fs_find_next((dev), 0, state, &i); \
+ s != NULL; \
+ s = fs_find_next((dev), i + 1, state, &i))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (s = fs_find_next((dev), 0, state, &i); \
+ s != NULL; \
+ s = fs_find_next((dev), i + 1, state, &i))
total: 0 errors, 0 warnings, 5 checks, 48 lines checked
More information about the test-report
mailing list