[dpdk-test-report] |WARNING| pw27926 [PATCH 06/13] pci: avoid inlining functions

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Aug 25 12:30:41 CEST 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27926

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#142: FILE: lib/librte_pci/rte_pci.c:57:
+#define GET_PCIADDR_FIELD(in, fd, lim, dlm)                     \
+do {                                                            \
+	unsigned long val;                                      \
+	char *end;                                              \
+	errno = 0;                                              \
+	val = strtoul((in), &end, 16);                          \
+	if (errno != 0 || end[0] != (dlm) || val > (lim))       \
+		return -EINVAL;                                 \
+	(fd) = (typeof (fd))val;                                \
+	(in) = end + 1;                                         \
+} while(0)

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#150: FILE: lib/librte_pci/rte_pci.c:65:
+	(fd) = (typeof (fd))val;                                \

ERROR:SPACING: space required before the open parenthesis '('
#152: FILE: lib/librte_pci/rte_pci.c:67:
+} while(0)

total: 1 errors, 2 warnings, 183 lines checked


More information about the test-report mailing list