[dpdk-test-report] |WARNING| pw31878 [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Dec 1 18:18:32 CET 2017

Previous message: [dpdk-test-report] |SUCCESS| pw31869 [PATCH] examples/eventdev_pipeline: add Rx adapter support
Next message: [dpdk-test-report] |FAILURE| pw31878 [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start Re: [PATCH] [PATCH v2] net/virtio: fix an incorrect behavior> of device stop/start> > Hi Tiwei > > I'm doing some regression tests with v17.11-rc4. I ran> into a hitch with testpmd running into a guest VM. It happens> that no packet gets forwarded by testpmd.> The issue seems to appear after this patch was upstreamed.> > I saw there's a way to make it work ie by avoiding to> increment the last consumed descriptor:> > --- a/drivers/net/virtio/virtqueue.c> +++ b/drivers/net/virtio/virtqueue.c> @@ -80 7 +80 7 @@ virtqueue_flush(struct virtqueue *vq)> rte_pktmbuf_free(dxp->cookie); > dxp->cookie = NULL; > }> - vq->vq_used_cons_idx++; > + //vq->vq_used_cons_idx++; > vq_ring_free_chain(vq desc_idx); > > Not quite sure if this change make any sense to you?> > Some details below.> > The issue appears only if the traffic generator is already> sending packets before I launch testpmd in the guest.> > In my testbench I have Open-vSwitch (OvS-DPDK) which launches> a VM with 2 vhostuserclient ports (vhu0 and vhu1) each with> a single queue.> My OvS has 2 physical ports: dpdk0 and dpdk1.> dpdk0 forwards packets back and forth from/to the generator> to/from vhu0.> Similarly dpdk1 forwards packets back and forth from/to the generator> to/from vhu1.> > In OvS there are 2 different PMD threads serving the 2> vhostuserclient ports.> > While the traffic generator is already sending packets in the> guest VM I launch> ./testpmd -c 0x3 -n 4 --socket-mem 512 -- --burst=64 -i --> txqflags=0xf00 --disable-hw-vlan> > The issue is that I see no packet received on the traffic generator> and in fact testpmd shows> > ---------------------- Forward statistics for port 0 ------------------> ----> RX-packets: 0 RX-dropped: 0 RX-total: 0> TX-packets: 0 TX-dropped: 0 TX-total: 0> ----------------------------------------------------------------------> ------> > ---------------------- Forward statistics for port 1 ----------------> ------> RX-packets: 0 RX-dropped: 0 RX-total: 0> TX-packets: 0 TX-dropped: 0 TX-total: 0> ----------------------------------------------------------------------> ------> > +++++++++++++++ Accumulated forward statistics for all> ports+++++++++++++++> RX-packets: 0 RX-dropped: 0 RX-total: 0> TX-packets: 0 TX-dropped: 0 TX-total: 0> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++> ++++> > Please let me know if I missed something or if you need> more info on my testbench.> > > Thanks > Antonio> > > -----Original Message-----> >
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/31878

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#21: 
I could replicate the same issue by using testpmd + a VM (= Virtual Machine).

ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#52: 
commit d8227497ec5c3de75fe378e09fc9673ae097fa73

ERROR:CODE_INDENT: code indent should use tabs where possible
#298: FILE: drivers/net/virtio/virtqueue.c:83:
+               //vq->vq_used_cons_idx++;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 3 errors, 1 warnings, 0 checks, 8 lines checked

More information about the test-report mailing list