[dpdk-test-report] |WARNING| pw32025 [PATCH RFC v1 6/9] app/testpmd: add pktgen forwarding engine

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32025

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#48: FILE: app/test-pmd/cmdline.c:15597:
+extern cmdline_parse_inst_t cmd_pktgen_cmd;

WARNING:SPACING: missing space after struct definition
#153: FILE: app/test-pmd/pktgen.c:87:
+struct pktgen_task_stats{

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#157: FILE: app/test-pmd/pktgen.c:91:
+^Iuint64_t start; ^I/* start tsc */$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#169: FILE: app/test-pmd/pktgen.c:103:
+^Iuint8_t txrx:1; ^I/* txrx type task */$

ERROR:INITIALISED_STATIC: do not initialise statics to 0
#176: FILE: app/test-pmd/pktgen.c:110:
+static int pktgen_busy = 0;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#179: FILE: app/test-pmd/pktgen.c:113:
+pg_task_template_get(struct pktgen_task* task, uint32_t idx)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#207: FILE: app/test-pmd/pktgen.c:141:
+pg_dump_mbuf_header(struct rte_mbuf *mbuf, struct fwd_stream* fs, int is_rx) {

ERROR:SPACING: space required before the open brace '{'
#227: FILE: app/test-pmd/pktgen.c:161:
+	else if (mbuf->ol_flags){

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#234: FILE: app/test-pmd/pktgen.c:168:
+pg_debug(struct rte_mbuf *mbuf, uint8_t level, struct fwd_stream* fs, int is_rx)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#252: FILE: app/test-pmd/pktgen.c:186:
+pg_mbuf_field_expect(struct fwd_stream* fs, struct pktgen_task *task,

ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#263: FILE: app/test-pmd/pktgen.c:197:
+	} fields [] = {

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#264: FILE: app/test-pmd/pktgen.c:198:
+^I^I{"port", ^IOFF(port), ^I^I0, UINT16_MAX},$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#265: FILE: app/test-pmd/pktgen.c:199:
+^I^I{"ptype",^IOFF(packet_type), ^I0, UINT32_MAX},$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#266: FILE: app/test-pmd/pktgen.c:200:
+^I^I{"rss", ^IOFF(hash.rss),^I^I0, UINT32_MAX},$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#267: FILE: app/test-pmd/pktgen.c:201:
+^I^I{"fdir", ^IOFF(hash.fdir.hi),^I0, UINT32_MAX},$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#269: FILE: app/test-pmd/pktgen.c:203:
+^I^I{"ol_flags",^IOFF(ol_flags), ^I^I0, UINT64_MAX &$

ERROR:PRINTF_0XDECIMAL: Prefixing 0x with decimal output is defective
#278: FILE: app/test-pmd/pktgen.c:212:
+			printf("Failed: queue expect: 0x%lu received:0x%hu
",

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#305: FILE: app/test-pmd/pktgen.c:239:
+pg_mbuf_expect(struct fwd_stream* fs, struct pktgen_task *task,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#353: FILE: app/test-pmd/pktgen.c:287:
+pg_tx_burst(struct fwd_stream* fs, int mode,

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#366: FILE: app/test-pmd/pktgen.c:300:
+	if (unlikely(nb_tx < nb_to_tx) && fs->retry_enabled)
+	{

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#369: FILE: app/test-pmd/pktgen.c:303:
+		while (nb_tx < nb_to_tx && retry++ < burst_tx_retry_num)
+		{

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#377: FILE: app/test-pmd/pktgen.c:311:
+	if (unlikely(nb_tx < nb_to_tx))
+	{

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#390: FILE: app/test-pmd/pktgen.c:324:
+		struct pktgen_task *task, struct fwd_stream* fs)

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#444: FILE: app/test-pmd/pktgen.c:378:
+pg_tx(struct fwd_stream* fs, struct pktgen_task *task,

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#459: FILE: app/test-pmd/pktgen.c:393:
+	} else
+			nb_to_tx = nb_pkt_per_burst;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#477: FILE: app/test-pmd/pktgen.c:411:
+pg_rx(struct fwd_stream* fs, struct pktgen_task *task, uint64_t start_tsc)

WARNING:LONG_LINE: line over 90 characters
#506: FILE: app/test-pmd/pktgen.c:440:
+				r = pg_mbuf_expect(fs, task, pkts_burst[i], task->stats.count + i);

ERROR:SPACING: spaces required around that '==' (ctx:VxV)
#522: FILE: app/test-pmd/pktgen.c:456:
+		else if (tx_task && tx_task->stats.active==PKTGEN_ROUND_END) {
 		                                         ^

WARNING:STATIC_CONST_CHAR_ARRAY: char * array declaration might be better as static const
#536: FILE: app/test-pmd/pktgen.c:470:
+	const char *names[] = {

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#548: FILE: app/test-pmd/pktgen.c:482:
+pg_rx_idle(struct fwd_stream* fs)

total: 18 errors, 12 warnings, 641 lines checked