[dpdk-test-report] |WARNING| pw32425 [PATCH RFC 10/23] eal: populate hugepage counts from socket-specific sysfs path

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Dec 19 12:06:24 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32425

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#49: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:103:
+static uint32_t
+get_num_hugepages_on_node(const char *subdir, unsigned socket) {

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#50: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:104:
+get_num_hugepages_on_node(const char *subdir, unsigned socket) {

WARNING:MISORDERED_TYPE: type 'long unsigned' should be specified in [[un]signed] [short|int|long|long long] order
#53: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:107:
+	long unsigned num_pages = 0;

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#78: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:132:
+	 * anyway ... */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#93: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:317:
+	unsigned i, total_pages, num_sizes = 0;

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#106: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:373:
+		 * in one socket and sorting them later */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#111: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:378:
+				unsigned num_pages =

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#118: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:385:
+		 * back to old way */

WARNING:BRACES: braces {} are not necessary for single statement blocks
#119: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:386:
+		if (total_pages == 0) {
+			hpi->num_pages[0] = get_num_hugepages(dirent->d_name);
+		}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#132: FILE: lib/librte_eal/linuxapp/eal/eal_hugepage_info.c:414:
+		unsigned j, num_pages = 0;

total: 1 errors, 9 warnings, 105 lines checked


More information about the test-report mailing list