[dpdk-test-report] |WARNING| pw32559 [PATCH v1 net/tap] add logic to assign speed from user

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/32559

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <edataCmd>
#57: FILE: drivers/net/tap/rte_eth_tap.c:1239:
+	struct ethtool_cmd edataCmd = {0};

CHECK:CAMELCASE: Avoid CamelCase: <edataLink>
#59: FILE: drivers/net/tap/rte_eth_tap.c:1241:
+	struct ethtool_link_settings edataLink = {0};

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pmd == NULL'
#62: FILE: drivers/net/tap/rte_eth_tap.c:1244:
+	if ((pmd == NULL) || (iface_name == NULL) ||
+		(speed == ETH_SPEED_NUM_NONE))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'iface_name == NULL'
#62: FILE: drivers/net/tap/rte_eth_tap.c:1244:
+	if ((pmd == NULL) || (iface_name == NULL) ||
+		(speed == ETH_SPEED_NUM_NONE))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed == ETH_SPEED_NUM_NONE'
#62: FILE: drivers/net/tap/rte_eth_tap.c:1244:
+	if ((pmd == NULL) || (iface_name == NULL) ||
+		(speed == ETH_SPEED_NUM_NONE))

CHECK:SPACING: spaces required around that '?' (ctx:VxV)
#69: FILE: drivers/net/tap/rte_eth_tap.c:1251:
+		(mode == REMOTE_ONLY)?"REMOTE":"LOCAL",
 		                     ^

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#69: FILE: drivers/net/tap/rte_eth_tap.c:1251:
+		(mode == REMOTE_ONLY)?"REMOTE":"LOCAL",
 		                              ^

CHECK:SPACING: spaces required around that '?' (ctx:VxV)
#91: FILE: drivers/net/tap/rte_eth_tap.c:1273:
+			(mode == REMOTE_ONLY)?"REMOTE":"LOCAL",
 			                     ^

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#91: FILE: drivers/net/tap/rte_eth_tap.c:1273:
+			(mode == REMOTE_ONLY)?"REMOTE":"LOCAL",
 			                              ^

CHECK:SPACING: spaces required around that '?' (ctx:VxV)
#103: FILE: drivers/net/tap/rte_eth_tap.c:1285:
+		(mode == REMOTE_ONLY)?REMOTE_ONLY:LOCAL_ONLY);
 		                     ^

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#103: FILE: drivers/net/tap/rte_eth_tap.c:1285:
+		(mode == REMOTE_ONLY)?REMOTE_ONLY:LOCAL_ONLY);
 		                                 ^

CHECK:SPACING: spaces required around that '?' (ctx:VxV)
#113: FILE: drivers/net/tap/rte_eth_tap.c:1295:
+		(mode == REMOTE_ONLY)?REMOTE_ONLY:LOCAL_ONLY);
 		                     ^

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#113: FILE: drivers/net/tap/rte_eth_tap.c:1295:
+		(mode == REMOTE_ONLY)?REMOTE_ONLY:LOCAL_ONLY);
 		                                 ^

CHECK:SPACING: spaces required around that '?' (ctx:VxV)
#120: FILE: drivers/net/tap/rte_eth_tap.c:1302:
+		speed, (mode == REMOTE_ONLY)?"REMOTE":"LOCAL", iface_name);
 		                            ^

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#120: FILE: drivers/net/tap/rte_eth_tap.c:1302:
+		speed, (mode == REMOTE_ONLY)?"REMOTE":"LOCAL", iface_name);
 		                                     ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pmd == NULL'
#136: FILE: drivers/net/tap/rte_eth_tap.c:1318:
+	if ((pmd == NULL) || (iface_name == NULL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'iface_name == NULL'
#136: FILE: drivers/net/tap/rte_eth_tap.c:1318:
+	if ((pmd == NULL) || (iface_name == NULL))

WARNING:TYPO_SPELLING: 'Retrive' may be misspelled - perhaps 'Retrieve'?
#140: FILE: drivers/net/tap/rte_eth_tap.c:1322:
+		"Retrive speed for %s iface_name %s.
",

CHECK:SPACING: spaces required around that '?' (ctx:VxV)
#141: FILE: drivers/net/tap/rte_eth_tap.c:1323:
+		(mode == REMOTE_ONLY)?"REMOTE":"LOCAL", iface_name);
 		                     ^

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#141: FILE: drivers/net/tap/rte_eth_tap.c:1323:
+		(mode == REMOTE_ONLY)?"REMOTE":"LOCAL", iface_name);
 		                              ^

CHECK:SPACING: spaces required around that '?' (ctx:VxV)
#149: FILE: drivers/net/tap/rte_eth_tap.c:1331:
+		(mode == REMOTE_ONLY)?REMOTE_ONLY:LOCAL_ONLY);
 		                     ^

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#149: FILE: drivers/net/tap/rte_eth_tap.c:1331:
+		(mode == REMOTE_ONLY)?REMOTE_ONLY:LOCAL_ONLY);
 		                                 ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0'
#151: FILE: drivers/net/tap/rte_eth_tap.c:1333:
+	if ((err == 0) && (edataLink.speed))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'edataLink.speed'
#151: FILE: drivers/net/tap/rte_eth_tap.c:1333:
+	if ((err == 0) && (edataLink.speed))

CHECK:SPACING: spaces required around that '?' (ctx:VxV)
#160: FILE: drivers/net/tap/rte_eth_tap.c:1342:
+		(mode == REMOTE_ONLY)?REMOTE_ONLY:LOCAL_ONLY);
 		                     ^

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#160: FILE: drivers/net/tap/rte_eth_tap.c:1342:
+		(mode == REMOTE_ONLY)?REMOTE_ONLY:LOCAL_ONLY);
 		                                 ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0'
#161: FILE: drivers/net/tap/rte_eth_tap.c:1343:
+	if ((err == 0) && (edataCmd.speed))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'edataCmd.speed'
#161: FILE: drivers/net/tap/rte_eth_tap.c:1343:
+	if ((err == 0) && (edataCmd.speed))

WARNING:TYPO_SPELLING: 'retrive' may be misspelled - perhaps 'retrieve'?
#165: FILE: drivers/net/tap/rte_eth_tap.c:1347:
+		"Failed to retrive speed for %s iface_name %s.
",

CHECK:SPACING: spaces required around that '?' (ctx:VxV)
#166: FILE: drivers/net/tap/rte_eth_tap.c:1348:
+		(mode == REMOTE_ONLY)?"REMOTE":"LOCAL", iface_name);
 		                     ^

CHECK:SPACING: spaces required around that ':' (ctx:VxV)
#166: FILE: drivers/net/tap/rte_eth_tap.c:1348:
+		(mode == REMOTE_ONLY)?"REMOTE":"LOCAL", iface_name);
 		                              ^

CHECK:CAMELCASE: Avoid CamelCase: <remoteSpeed>
#174: FILE: drivers/net/tap/rte_eth_tap.c:1356:
+	int err = 0, remoteSpeed = 0, localSpeed = 0;

CHECK:CAMELCASE: Avoid CamelCase: <localSpeed>
#174: FILE: drivers/net/tap/rte_eth_tap.c:1356:
+	int err = 0, remoteSpeed = 0, localSpeed = 0;

CHECK:SPACING: No space is necessary after a cast
#186: FILE: drivers/net/tap/rte_eth_tap.c:1368:
+	if (localSpeed != (int) pmd_link.link_speed) {

CHECK:SPACING: No space is necessary after a cast
#193: FILE: drivers/net/tap/rte_eth_tap.c:1375:
+	pmd_link.link_speed = (unsigned int) localSpeed;

CHECK:SPACING: No space is necessary after a cast
#204: FILE: drivers/net/tap/rte_eth_tap.c:1386:
+		remoteSpeed = (unsigned int) err;

CHECK:SPACING: No space is necessary after a cast
#206: FILE: drivers/net/tap/rte_eth_tap.c:1388:
+		if ((unsigned int) remoteSpeed != pmd_link.link_speed) {

CHECK:SPACING: No space is necessary after a cast
#212: FILE: drivers/net/tap/rte_eth_tap.c:1394:
+			remoteSpeed = (int) pmd_link.link_speed;

total: 0 errors, 2 warnings, 36 checks, 221 lines checked