[dpdk-test-report] |WARNING| pw20624 [PATCH v7 01/17] lib: rename legacy distributor lib files

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Feb 21 11:17:29 CET 2017


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20624

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#923: FILE: lib/librte_distributor/rte_distributor_v20.c:51:
+ * original pointer value with proper sign extension into the top bits. */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#956: FILE: lib/librte_distributor/rte_distributor_v20.c:84:
+	unsigned start;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#957: FILE: lib/librte_distributor/rte_distributor_v20.c:85:
+	unsigned count;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#962: FILE: lib/librte_distributor/rte_distributor_v20.c:90:
+	unsigned start;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#963: FILE: lib/librte_distributor/rte_distributor_v20.c:91:
+	unsigned count;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#971: FILE: lib/librte_distributor/rte_distributor_v20.c:99:
+	unsigned num_workers;                 /**< Number of workers polling */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#999: FILE: lib/librte_distributor/rte_distributor_v20.c:127:
+		unsigned worker_id, struct rte_mbuf *oldpkt)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1011: FILE: lib/librte_distributor/rte_distributor_v20.c:139:
+		unsigned worker_id)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1024: FILE: lib/librte_distributor/rte_distributor_v20.c:152:
+		unsigned worker_id, struct rte_mbuf *oldpkt)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1035: FILE: lib/librte_distributor/rte_distributor_v20.c:163:
+		unsigned worker_id, struct rte_mbuf *oldpkt)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int *' to bare use of 'unsigned *'
#1069: FILE: lib/librte_distributor/rte_distributor_v20.c:197:
+		unsigned *ret_start, unsigned *ret_count)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int *' to bare use of 'unsigned *'
#1069: FILE: lib/librte_distributor/rte_distributor_v20.c:197:
+		unsigned *ret_start, unsigned *ret_count)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1079: FILE: lib/librte_distributor/rte_distributor_v20.c:207:
+handle_worker_shutdown(struct rte_distributor *d, unsigned wkr)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1096: FILE: lib/librte_distributor/rte_distributor_v20.c:224:
+		unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1100: FILE: lib/librte_distributor/rte_distributor_v20.c:228:
+			unsigned idx = (bl->start + i) &

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1121: FILE: lib/librte_distributor/rte_distributor_v20.c:249:
+	unsigned wkr;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1122: FILE: lib/librte_distributor/rte_distributor_v20.c:250:
+	unsigned flushed = 0;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1123: FILE: lib/librte_distributor/rte_distributor_v20.c:251:
+	unsigned ret_start = d->returns.start,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1159: FILE: lib/librte_distributor/rte_distributor_v20.c:287:
+		struct rte_mbuf **mbufs, unsigned num_mbufs)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1161: FILE: lib/librte_distributor/rte_distributor_v20.c:289:
+	unsigned next_idx = 0;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1162: FILE: lib/librte_distributor/rte_distributor_v20.c:290:
+	unsigned wkr = 0;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1166: FILE: lib/librte_distributor/rte_distributor_v20.c:294:
+	unsigned ret_start = d->returns.start,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1194: FILE: lib/librte_distributor/rte_distributor_v20.c:322:
+			unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1210: FILE: lib/librte_distributor/rte_distributor_v20.c:338:
+				unsigned worker = __builtin_ctzl(match);

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1243: FILE: lib/librte_distributor/rte_distributor_v20.c:371:
+	 * if they are ready */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1263: FILE: lib/librte_distributor/rte_distributor_v20.c:391:
+		struct rte_mbuf **mbufs, unsigned max_mbufs)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1266: FILE: lib/librte_distributor/rte_distributor_v20.c:394:
+	unsigned retval = (max_mbufs < returns->count) ?

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1268: FILE: lib/librte_distributor/rte_distributor_v20.c:396:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1271: FILE: lib/librte_distributor/rte_distributor_v20.c:399:
+		unsigned idx = (returns->start + i) & RTE_DISTRIB_RETURNS_MASK;

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1281: FILE: lib/librte_distributor/rte_distributor_v20.c:409:
+ * being workered on or queued up in a backlog. */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1285: FILE: lib/librte_distributor/rte_distributor_v20.c:413:
+	unsigned wkr, total_outstanding;

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1296: FILE: lib/librte_distributor/rte_distributor_v20.c:424:
+ * queued up. */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1300: FILE: lib/librte_distributor/rte_distributor_v20.c:428:
+	const unsigned flushed = total_outstanding(d);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1321: FILE: lib/librte_distributor/rte_distributor_v20.c:449:
+		unsigned socket_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1322: FILE: lib/librte_distributor/rte_distributor_v20.c:450:
+		unsigned num_workers)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1436: FILE: lib/librte_distributor/rte_distributor_v20.h:71:
+rte_distributor_create(const char *name, unsigned socket_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1437: FILE: lib/librte_distributor/rte_distributor_v20.h:72:
+		unsigned num_workers);

WARNING:TYPO_SPELLING: 'procesed' may be misspelled - perhaps 'processed'?
#1453: FILE: lib/librte_distributor/rte_distributor_v20.h:88:
+ * same flow id, or tag, in the mbuf will be procesed at the same time.

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1472: FILE: lib/librte_distributor/rte_distributor_v20.h:107:
+		struct rte_mbuf **mbufs, unsigned num_mbufs);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1490: FILE: lib/librte_distributor/rte_distributor_v20.h:125:
+		struct rte_mbuf **mbufs, unsigned max_mbufs);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1546: FILE: lib/librte_distributor/rte_distributor_v20.h:181:
+		unsigned worker_id, struct rte_mbuf *oldpkt);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1561: FILE: lib/librte_distributor/rte_distributor_v20.h:196:
+rte_distributor_return_pkt(struct rte_distributor *d, unsigned worker_id,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1586: FILE: lib/librte_distributor/rte_distributor_v20.h:221:
+		unsigned worker_id, struct rte_mbuf *oldpkt);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1606: FILE: lib/librte_distributor/rte_distributor_v20.h:241:
+		unsigned worker_id);

total: 0 errors, 44 warnings, 770 lines checked


More information about the test-report mailing list